- User Since
- Aug 31 2018, 7:16 PM (141 w, 3 d)
Apr 13 2021
rebase + remove conflicted files + add new typos
Feb 17 2021
Feb 15 2021
Feb 14 2021
Feb 13 2021
Just bumping for exposure
How to proceed...please advise? Shall I rebase ?
Feb 6 2021
Feb 5 2021
Feb 4 2021
Should I rebase? Also I have a separate patch just for source (API) changes. Didn't think it was prudent to add in to this one as it would delay it. Shall I submit a separate patch now?
Feb 2 2021
Mar 12 2020
Sep 15 2019
Aug 1 2019
Hmm.. maybe I should of submit this as a diff instead?
Jul 16 2019
All whitespaces removed.
Squashed patch file so there aren't any whitespace fixes polluting the diff review
Jul 12 2019
Removed whitespace fixes that crept in to previous commit
Jul 11 2019
@Brecht Van Lommel (brecht) i rebased the patch locally. I can break it up in to 2 smaller patches, if you want.
Should I rebase ?
Oct 22 2018
@Brecht Van Lommel (brecht) hi, just checking on this. Anything you need me to do before it gets committed ?
Oct 5 2018
Any news on this being merged soon ?
Sep 28 2018
@Brecht Van Lommel (brecht) sorry, I know you asked me to add all the patches in to one. But I had an issue and I thought it would just be less complicated to separate them (because they all have been git format-patch'd from separate directories). I know it means extra work for you. I apologize for the lameness
I'm still not used to using phabricator, so I apologize. So a couple if issues:
- I rebased the diff over blender2.8 branch again
- I added some leftover commits (unfortnately none of them were from the addons because...
- my git client is a GUI and there is a bug that wasn't showing me the commits I made in the addons because it was in a submodule. So I'm going to make a patch from within the submodules for the next commit.
Sorry for the confusion
@Brecht Van Lommel (brecht) is there any issue with fixing typos for ./release/scripts/addons ?
Sep 25 2018
@Brecht Van Lommel (brecht) thanks for the reply. Oh, should I then make patches against master from now on?
Sep 24 2018
Hi @Brecht Van Lommel (brecht) it looks like the patch wasn't committed in its entirety. Can you supply the reason and what files didn't make it in ? (just so I know in the future not to resubmit them again)
Sep 22 2018
Sep 17 2018
This is a follow-up patch to D3668
Sep 2 2018
I will keep this diff small for now.. there are some source typos that I found that may break the API so I will submit them separately. If someone could review and merge that would be great.
I found more typos, should I add them to this or just submit a new diff once this one is reviewed and merged ?