Page MenuHome

Manuel Castilla (manzanilla)
User

Projects (9)

User Details

User Since
May 28 2020, 12:43 AM (114 w, 5 d)

Recent Activity

Mar 13 2022

Robert Windefjord (Robonnet) awarded T88150: Full Frame Compositor a Love token.
Mar 13 2022, 10:48 PM · BF Blender, Compositing

Feb 13 2022

Habib Gahbiche (zazizizou) awarded D11113: Compositor: Full-frame base system a Love token.
Feb 13 2022, 6:44 PM · Compositing

Jan 26 2022

Antoine (pedrohoho) awarded T81650: New compositor system proposal a Love token.
Jan 26 2022, 11:57 AM · VFX & Video, Compositing

Dec 25 2021

Silas Opel (Schamph) awarded T81650: New compositor system proposal a The World Burns token.
Dec 25 2021, 4:22 PM · VFX & Video, Compositing

Nov 26 2021

Manuel Castilla (manzanilla) accepted D13369: Fix T93310: Crash due to broken image paths..

Yes as you said I think NodeOperationOutput::determine_canvas and NodeOperation::determine_canvas should ensure r_area is set to 0 by default before using it.

Nov 26 2021, 12:48 AM

Nov 25 2021

Manuel Castilla (manzanilla) created P2618 (An Untitled Masterwork).
Nov 25 2021, 11:49 PM

Nov 20 2021

Aditia A. Pratama (aditiapratama) awarded D12750: Compositor: Support backdrop offset for the Viewer node a Like token.
Nov 20 2021, 1:01 AM · Compositing

Nov 6 2021

Evan Wilson (EAW) awarded rBecb8a574c752: Cleanup: remove unused includes in Compositor a 100 token.
Nov 6 2021, 5:25 AM

Oct 29 2021

Manuel Castilla (manzanilla) added inline comments to D11179: Exclude 'Render Result' and 'Viewer' images where not supported T73182.
Oct 29 2021, 2:25 AM
Manuel Castilla (manzanilla) updated the diff for D11179: Exclude 'Render Result' and 'Viewer' images where not supported T73182.
  • Merge branch 'master' into arcpatch-D11179
  • Rename *_image_poll functions to *_image_id_poll
Oct 29 2021, 2:16 AM
Manuel Castilla (manzanilla) updated the diff for D12750: Compositor: Support backdrop offset for the Viewer node.
  • Merge branch 'master' into cmp-viewer-offset2
  • Specify viewer image offsets are in pixel space
Oct 29 2021, 1:56 AM · Compositing
Manuel Castilla (manzanilla) requested changes to D12481: Compositing Convert color space node.
  • Please update the patch with the last updates done in D12520 for the Color Space node (see my comment there).
  • We may name it "Color Space Convert" and move it to the "Converter" UI group. Fits better.
  • UI field texts could be shorten to -> "From" and "To". With "Color Space Convert" as node name it should be enough.
  • Is there a reason you need to use ColorManagedColorspaceSetting struct instead of string properties in NodeColorSpace? I'm not sure it's needed, using strings for just the color space name would simplify the code.
  • Will comment further once the patch is updated.
Oct 29 2021, 12:58 AM
Manuel Castilla (manzanilla) requested changes to D12520: [COMPOSITOR] OCIO color spaces conversion node + 1D_3D_LUT node.

Thanks for working on this, I think these nodes can be very useful.
There has been style changes in compositor (mostly naming convention), I've updated the diff to reflect the changes because it's my fault, sorry for the hassle.
Please continue from this diff:

Oct 29 2021, 12:50 AM

Oct 23 2021

Alaska (Alaska) awarded rBdd505a7ebba2: Fix T92400: Denoise node Prefilter output is always "Fast" a Like token.
Oct 23 2021, 11:35 PM
Manuel Castilla (manzanilla) added a comment to T65648: Recent halo fix appears to bug out with glare node and NLM denoising.

This can only be reproduced in 2.93 and previous versions, as NLM Denoiser seems to be removed in 3.0 -> https://code.blender.org/2021/04/cycles-x/

Oct 23 2021, 11:27 PM · Render & Cycles, BF Blender
Manuel Castilla (manzanilla) renamed T65648: Recent halo fix appears to bug out with glare node and NLM denoising from Recent halo fix appears to bug out with glare node. to Recent halo fix appears to bug out with glare node and NLM denoising.
Oct 23 2021, 10:59 PM · Render & Cycles, BF Blender
Manuel Castilla (manzanilla) edited projects for T65648: Recent halo fix appears to bug out with glare node and NLM denoising, added: Render & Cycles; removed VFX & Video, Compositing.
Oct 23 2021, 10:59 PM · Render & Cycles, BF Blender
Manuel Castilla (manzanilla) merged T77314: Glare node bug when using NLM denoising into T65648: Recent halo fix appears to bug out with glare node and NLM denoising.
Oct 23 2021, 10:58 PM · Render & Cycles, BF Blender
Manuel Castilla (manzanilla) merged task T77314: Glare node bug when using NLM denoising into T65648: Recent halo fix appears to bug out with glare node and NLM denoising.
Oct 23 2021, 10:58 PM · Render & Cycles, BF Blender
Manuel Castilla (manzanilla) closed T92400: Possible regression: Blender 3.0.0: Cycles: Compositor: Denoise node as Resolved by committing rBdd505a7ebba2: Fix T92400: Denoise node Prefilter output is always "Fast".
Oct 23 2021, 10:10 PM · Compositing, BF Blender
Manuel Castilla (manzanilla) committed rBa3d0b50d7503: Cleanup: use underscore suffix for private data members (authored by Manuel Castilla (manzanilla)).
Cleanup: use underscore suffix for private data members
Oct 23 2021, 10:10 PM
Manuel Castilla (manzanilla) committed rB8c21667f3ca7: Cleanup: remove unused function (authored by Manuel Castilla (manzanilla)).
Cleanup: remove unused function
Oct 23 2021, 10:10 PM
Manuel Castilla (manzanilla) committed rBdd505a7ebba2: Fix T92400: Denoise node Prefilter output is always "Fast" (authored by Manuel Castilla (manzanilla)).
Fix T92400: Denoise node Prefilter output is always "Fast"
Oct 23 2021, 10:10 PM
Manuel Castilla (manzanilla) closed T86271: Blender crashing when working in Compositor - for example deleting Cryptomatte nodes as Resolved.

Cannot be reproduced in 2.93 or current master. I think this was fixed in rBcbf033c05519ffa977693a5f6845b476017af08b

Oct 23 2021, 10:00 PM · VFX & Video, Compositing, BF Blender
Manuel Castilla (manzanilla) closed T43180: Values in depth channel saved incorrectly on .blend file re-open as Resolved.

Seems fixed. It cannot be reproduced in newer versions.

Oct 23 2021, 9:38 PM · VFX & Video, Compositing, BF Blender

Oct 19 2021

Manuel Castilla (manzanilla) accepted D12919: Compositor: Combine and Separate XYZ.

Looks good to me. I think it can be useful too. Even if it can be done with separate/combine RGBA, users might not be aware of it and with this it has the proper socket fields.

Oct 19 2021, 1:48 PM · BF Blender (3.1)

Oct 17 2021

Manuel Castilla (manzanilla) updated the diff for D11179: Exclude 'Render Result' and 'Viewer' images where not supported T73182.
  • Merge branch 'master' into arcpatch-D11179
  • Do plain checks using ptr->data
  • Unselect viewer images when switching to UV Editor
  • Add versioning code
Oct 17 2021, 11:23 PM

Oct 15 2021

Manuel Castilla (manzanilla) committed rBL62721: Tests: update for Compositor after Sun Beams node fix.
Tests: update for Compositor after Sun Beams node fix
Oct 15 2021, 11:23 PM
Manuel Castilla (manzanilla) closed T72583: Sun Beams Node artifacts as Resolved by committing rB5b9a911c4b3c: Fix T72583: Sun Beams node artifacts.
Oct 15 2021, 11:20 PM · VFX & Video, Compositing, BF Blender
Manuel Castilla (manzanilla) committed rB9b1b1d9269ed: Cleanup: remove unused functions (authored by Manuel Castilla (manzanilla)).
Cleanup: remove unused functions
Oct 15 2021, 11:20 PM
Manuel Castilla (manzanilla) committed rB5b9a911c4b3c: Fix T72583: Sun Beams node artifacts (authored by Manuel Castilla (manzanilla)).
Fix T72583: Sun Beams node artifacts
Oct 15 2021, 11:20 PM

Oct 14 2021

Manuel Castilla (manzanilla) updated the diff for D12786: Fix T90830: Crop node cropping is one pixel short.
  • Merge branch 'master' into cmp-fix-crop
Oct 14 2021, 9:45 PM · Compositing
Manuel Castilla (manzanilla) updated the diff for D12750: Compositor: Support backdrop offset for the Viewer node.
  • Cleanup: fix comment
Oct 14 2021, 9:19 PM · Compositing
Manuel Castilla (manzanilla) updated the diff for D12750: Compositor: Support backdrop offset for the Viewer node.
  • Merge branch 'master' into cmp-viewer-offset2
Oct 14 2021, 9:04 PM · Compositing
Manuel Castilla (manzanilla) committed rBL62720: Tests: update for Compositor after Box Mask node fix.
Tests: update for Compositor after Box Mask node fix
Oct 14 2021, 12:48 AM

Oct 13 2021

Manuel Castilla (manzanilla) closed T90799: Compositor Box Mask node doesn't fullfill screen area as Resolved by committing rB8278ad3dfb32: Fix T90799: Box/Ellipse Mask node masking is off-centered.
Oct 13 2021, 11:47 PM · Compositing, VFX & Video, BF Blender
Manuel Castilla (manzanilla) committed rBa3610c451aa1: Fix Compositor stack use after scope (authored by Manuel Castilla (manzanilla)).
Fix Compositor stack use after scope
Oct 13 2021, 11:46 PM
Manuel Castilla (manzanilla) committed rB8278ad3dfb32: Fix T90799: Box/Ellipse Mask node masking is off-centered (authored by Manuel Castilla (manzanilla)).
Fix T90799: Box/Ellipse Mask node masking is off-centered
Oct 13 2021, 11:46 PM
Manuel Castilla (manzanilla) committed rBf609b05b11ce: Cleanup: use `_` suffix for non-public data members in Compositor (authored by Manuel Castilla (manzanilla)).
Cleanup: use `_` suffix for non-public data members in Compositor
Oct 13 2021, 11:46 PM
Manuel Castilla (manzanilla) committed rB1c42d4930a24: Cleanup: convert camelCase naming to snake_case in Compositor (authored by Manuel Castilla (manzanilla)).
Cleanup: convert camelCase naming to snake_case in Compositor
Oct 13 2021, 11:46 PM
Manuel Castilla (manzanilla) committed rBa2ee3c3a9f01: Cleanup: replace members `m_` prefix by `_` suffix in Compositor (authored by Manuel Castilla (manzanilla)).
Cleanup: replace members `m_` prefix by `_` suffix in Compositor
Oct 13 2021, 11:46 PM
Manuel Castilla (manzanilla) committed rBea79efef70da: Cleanup: remove `this->` for `m_` prefixed members in Compositor (authored by Manuel Castilla (manzanilla)).
Cleanup: remove `this->` for `m_` prefixed members in Compositor
Oct 13 2021, 11:46 PM
Manuel Castilla (manzanilla) committed rBecb8a574c752: Cleanup: remove unused includes in Compositor (authored by Manuel Castilla (manzanilla)).
Cleanup: remove unused includes in Compositor
Oct 13 2021, 11:46 PM

Oct 8 2021

kursad k (kursadk) awarded D12786: Fix T90830: Crop node cropping is one pixel short a Love token.
Oct 8 2021, 6:36 AM · Compositing
Manuel Castilla (manzanilla) updated the summary of D12786: Fix T90830: Crop node cropping is one pixel short.
Oct 8 2021, 2:21 AM · Compositing
Manuel Castilla (manzanilla) added a revision to T90830: compositor crop node is generating 1 pixel too many on both x and y.: D12786: Fix T90830: Crop node cropping is one pixel short.
Oct 8 2021, 2:20 AM · Compositing, VFX & Video, BF Blender
Manuel Castilla (manzanilla) added a task to D12786: Fix T90830: Crop node cropping is one pixel short: T90830: compositor crop node is generating 1 pixel too many on both x and y..
Oct 8 2021, 2:20 AM · Compositing
Manuel Castilla (manzanilla) added a reviewer for D12786: Fix T90830: Crop node cropping is one pixel short: Jeroen Bakker (jbakker).
Oct 8 2021, 2:19 AM · Compositing
Manuel Castilla (manzanilla) requested review of D12786: Fix T90830: Crop node cropping is one pixel short.
Oct 8 2021, 2:18 AM · Compositing

Oct 6 2021

Manuel Castilla (manzanilla) updated the diff for D12750: Compositor: Support backdrop offset for the Viewer node.
  • Ensure gizmos are updated after compositing (fixes the issue)
  • Remove unneeded whitespace
  • Take into account viewer offset in Crop, Sun Beams and Corner Pin gizmos
Oct 6 2021, 12:01 AM · Compositing

Oct 4 2021

Manuel Castilla (manzanilla) added a comment to D12750: Compositor: Support backdrop offset for the Viewer node.

@Jeroen Bakker (jbakker) I've tried to implement this setting the offset in the viewer node but a lot image/gizmo update issues come up, mainly due to the thread node tree has to merged back to the original tree, so setting the offset has some delay.

Oct 4 2021, 9:43 PM · Compositing
Manuel Castilla (manzanilla) updated the summary of D12750: Compositor: Support backdrop offset for the Viewer node.
Oct 4 2021, 9:25 PM · Compositing
Manuel Castilla (manzanilla) requested review of D12750: Compositor: Support backdrop offset for the Viewer node.
Oct 4 2021, 9:23 PM · Compositing

Oct 1 2021

Manuel Castilla (manzanilla) committed rB66fe1c79f3ce: Compositor: Fix Composite node using alpha when "Use Alpha" is off (authored by Manuel Castilla (manzanilla)).
Compositor: Fix Composite node using alpha when "Use Alpha" is off
Oct 1 2021, 12:11 AM
Manuel Castilla (manzanilla) committed rBf3274bfa70f0: Compositor: Fix Dilate/Erode node crash with Step option (authored by Manuel Castilla (manzanilla)).
Compositor: Fix Dilate/Erode node crash with Step option
Oct 1 2021, 12:11 AM
Manuel Castilla (manzanilla) committed rBe2df5c8a56c0: Compositor: Fix Flip node not flipping translation on Full Frame (authored by Manuel Castilla (manzanilla)).
Compositor: Fix Flip node not flipping translation on Full Frame
Oct 1 2021, 12:11 AM
Manuel Castilla (manzanilla) committed rB4569d9c0c3b0: Compositor: Fix Movie Distortion node rendering an empty image (authored by Manuel Castilla (manzanilla)).
Compositor: Fix Movie Distortion node rendering an empty image
Oct 1 2021, 12:11 AM

Sep 30 2021

Matteo Scopel (scopelma) awarded T88150: Full Frame Compositor a Love token.
Sep 30 2021, 8:28 PM · BF Blender, Compositing

Sep 29 2021

Manuel Castilla (manzanilla) abandoned D12232: [WIP] Compositor: Full frame Glare node.

Commit: rB283d76a70dba

Sep 29 2021, 5:53 AM
Manuel Castilla (manzanilla) added a comment to D12466: Compositor: Add support for canvas compositing.

Committed on agreement with the reviewer.

Sep 29 2021, 5:49 AM · Compositing
Manuel Castilla (manzanilla) added a comment to D12465: Compositor: Replace resolution concept by canvas.

Committed on agreement with the reviewer.

Sep 29 2021, 5:48 AM · Compositing

Sep 28 2021

Manuel Castilla (manzanilla) committed rBf84fb12f5d72: Compositor: Add support for canvas compositing (authored by Manuel Castilla (manzanilla)).
Compositor: Add support for canvas compositing
Sep 28 2021, 10:02 PM
Manuel Castilla (manzanilla) committed rB283d76a70dba: Compositor: Full frame Glare node (authored by Manuel Castilla (manzanilla)).
Compositor: Full frame Glare node
Sep 28 2021, 10:02 PM
Manuel Castilla (manzanilla) closed D12466: Compositor: Add support for canvas compositing.
Sep 28 2021, 10:02 PM · Compositing
Manuel Castilla (manzanilla) committed rB0830211c9529: Cleanup: Remove XRange and YRange in Compositor (authored by Manuel Castilla (manzanilla)).
Cleanup: Remove XRange and YRange in Compositor
Sep 28 2021, 10:02 PM
Manuel Castilla (manzanilla) committed rB76377f0176b9: Compositor: Replace resolution concept by canvas (authored by Manuel Castilla (manzanilla)).
Compositor: Replace resolution concept by canvas
Sep 28 2021, 10:02 PM
Manuel Castilla (manzanilla) closed D12465: Compositor: Replace resolution concept by canvas.
Sep 28 2021, 10:02 PM · Compositing
Manuel Castilla (manzanilla) added a comment to D12366: Cleanup: convert compositor nodes to c++.

I ran the tests on windows and nothing failed. Still better to check this on buildbot before committing.

Sep 28 2021, 6:22 PM
Manuel Castilla (manzanilla) updated the summary of D12466: Compositor: Add support for canvas compositing.
Sep 28 2021, 4:13 PM · Compositing
Manuel Castilla (manzanilla) accepted D12366: Cleanup: convert compositor nodes to c++.
Sep 28 2021, 1:32 PM
Manuel Castilla (manzanilla) added a comment to D12466: Compositor: Add support for canvas compositing.

The cropping issues are due to the scale canvas limitation (scene output resolution * 1.5). We've agreed to look for alternatives to this on bcon2.
@Evan Wilson (EAW) Thank you for the feedback, I've reproduced the third case and was a problem with the texture node. It should be fixed now.
If there is still differences, can you share the file please?

Sep 28 2021, 1:05 PM · Compositing
Manuel Castilla (manzanilla) updated the diff for D12466: Compositor: Add support for canvas compositing.
  • Fix previews cropping inputs
  • Fix texture node having different canvas in full frame
Sep 28 2021, 12:58 PM · Compositing

Sep 27 2021

Paul Larson (GeorgiaPacific) awarded D12466: Compositor: Add support for canvas compositing a Like token.
Sep 27 2021, 5:37 PM · Compositing

Sep 25 2021

Manuel Castilla (manzanilla) updated the task description for T88150: Full Frame Compositor.
Sep 25 2021, 11:13 PM · BF Blender, Compositing
Manuel Castilla (manzanilla) updated the summary of D12466: Compositor: Add support for canvas compositing.
Sep 25 2021, 11:08 PM · Compositing
Manuel Castilla (manzanilla) added a comment to D12466: Compositor: Add support for canvas compositing.

Or should D12465 be first applied?

It's ok just applying this patch, the other is the base of this.

Sep 25 2021, 10:54 PM · Compositing
Manuel Castilla (manzanilla) updated the diff for D12466: Compositor: Add support for canvas compositing.
  • Scale from resolution center to match tiled implementation
  • Use scale, rotate and translate operations in Transform node
  • Use scale, rotate and translate operations in Stabilize2D node
  • Do not clear display buffer on cancelling
  • Use intptr_t for offsets to avoid overflows when scaling up
  • Increase max scale canvas size to allow some translation in output canvas without cropping
  • Limit viewer translation padding
  • Cleanup: unused variables
Sep 25 2021, 10:40 PM · Compositing
Gilberto Rodrigues (gilberto_rodrigues) awarded D12466: Compositor: Add support for canvas compositing a Burninate token.
Sep 25 2021, 4:06 AM · Compositing

Sep 23 2021

Lloyd (digim0nk) awarded T88150: Full Frame Compositor a Love token.
Sep 23 2021, 8:14 AM · BF Blender, Compositing

Sep 22 2021

Andrea Monzini (Andrea_Monzini) awarded rB276eebb27474: Compositor: Add OIDN prefiltering option to Denoise node a Love token.
Sep 22 2021, 5:57 PM
Manuel Castilla (manzanilla) closed D12286: Compositor: Add more render tests.

Committed: rBL62687

Sep 22 2021, 2:33 PM · Compositing

Sep 21 2021

Manuel Castilla (manzanilla) updated the diff for D12466: Compositor: Add support for canvas compositing.
  • Minimize display buffer updates on cancelling
Sep 21 2021, 4:27 PM · Compositing

Sep 20 2021

Emilien Colombier (Peine_Perdue) awarded T88150: Full Frame Compositor a The World Burns token.
Sep 20 2021, 3:51 PM · BF Blender, Compositing
YAFU (YAFU) awarded rB276eebb27474: Compositor: Add OIDN prefiltering option to Denoise node a Love token.
Sep 20 2021, 2:42 AM
Alaska (Alaska) awarded rB276eebb27474: Compositor: Add OIDN prefiltering option to Denoise node a Love token.
Sep 20 2021, 1:19 AM

Sep 19 2021

Manuel Castilla (manzanilla) closed D12342: Compositor: Add OIDN prefiltering option to Denoise node.
Sep 19 2021, 9:33 PM · Compositing
Manuel Castilla (manzanilla) committed rB276eebb27474: Compositor: Add OIDN prefiltering option to Denoise node (authored by Manuel Castilla (manzanilla)).
Compositor: Add OIDN prefiltering option to Denoise node
Sep 19 2021, 9:33 PM
Manuel Castilla (manzanilla) committed rBf256bfb3e26c: Compositor: Fix crash exporting buffers on debug (authored by Manuel Castilla (manzanilla)).
Compositor: Fix crash exporting buffers on debug
Sep 19 2021, 9:33 PM
Manuel Castilla (manzanilla) committed rB942c471ce969: Compositor: Fix Alpha Over node ignoring emissive colors (authored by Manuel Castilla (manzanilla)).
Compositor: Fix Alpha Over node ignoring emissive colors
Sep 19 2021, 9:33 PM

Sep 17 2021

Helge Maus (pixeltrain) awarded T88150: Full Frame Compositor a Love token.
Sep 17 2021, 2:24 PM · BF Blender, Compositing

Sep 15 2021

Manuel Castilla (manzanilla) added a comment to D12466: Compositor: Add support for canvas compositing.

When attaching a viewer node to a node it should show it in canvas space. Eg. image -> translate 100 in x -> viewer should show the image translated 100px.

Sep 15 2021, 2:23 AM · Compositing
Manuel Castilla (manzanilla) updated the diff for D12466: Compositor: Add support for canvas compositing.
  • Use float2 for render size
  • Show translation in viewer node within an unlimited canvas
Sep 15 2021, 2:11 AM · Compositing

Sep 14 2021

Alaska (Alaska) awarded D12466: Compositor: Add support for canvas compositing a Love token.
Sep 14 2021, 3:40 AM · Compositing
Evan Wilson (EAW) awarded D12466: Compositor: Add support for canvas compositing a Love token.
Sep 14 2021, 3:14 AM · Compositing
Manuel Castilla (manzanilla) updated the diff for D12466: Compositor: Add support for canvas compositing.
  • Fix last diff submitted from wrong branch
Sep 14 2021, 2:48 AM · Compositing
Manuel Castilla (manzanilla) added a comment to D12466: Compositor: Add support for canvas compositing.

Need to confirm "translate + rotate" and lens distortion node are ok now, before doing it for all the nodes.
Apart from the nodes you said, would need to add only: Plane Track Deform, Vector Blur and Stabilize 2D?

Sep 14 2021, 2:24 AM · Compositing
Manuel Castilla (manzanilla) updated the diff for D12466: Compositor: Add support for canvas compositing.

rebase

Sep 14 2021, 2:10 AM · Compositing
Manuel Castilla (manzanilla) updated the diff for D12466: Compositor: Add support for canvas compositing.
  • Use resolution center as rotation center (without canvas offset)
  • Make lens distortion work in screen space
Sep 14 2021, 2:00 AM · Compositing

Sep 12 2021

Manuel Castilla (manzanilla) updated the summary of D12465: Compositor: Replace resolution concept by canvas.
Sep 12 2021, 8:34 PM · Compositing
Manuel Castilla (manzanilla) updated the summary of D12466: Compositor: Add support for canvas compositing.
Sep 12 2021, 8:32 PM · Compositing