Page MenuHome

Manuel Castilla (manzanilla)
User

Projects (7)

User Details

User Since
May 28 2020, 12:43 AM (55 w, 1 d)

Recent Activity

Today

Andres Stephens (Draise) awarded D11594: Compositor: Full frame Value node a Like token.
Fri, Jun 18, 4:11 AM · Compositing
Andres Stephens (Draise) awarded D11593: Compositor: Full frame RGB node a Like token.
Fri, Jun 18, 4:11 AM · Compositing

Yesterday

Manuel Castilla (manzanilla) updated the task description for T88150: Full Frame Compositor.
Thu, Jun 17, 10:43 PM · BF Blender, Compositing
Manuel Castilla (manzanilla) added a reviewer for D11638: Compositor: Full frame ID Mask node: Jeroen Bakker (jbakker).
Thu, Jun 17, 10:28 PM · Compositing
Manuel Castilla (manzanilla) requested review of D11638: Compositor: Full frame ID Mask node.
Thu, Jun 17, 10:28 PM · Compositing
Manuel Castilla (manzanilla) added a reviewer for D11635: Compositor: Full frame Ellipse Mask node: Jeroen Bakker (jbakker).
Thu, Jun 17, 8:50 PM · Compositing
Manuel Castilla (manzanilla) requested review of D11635: Compositor: Full frame Ellipse Mask node.
Thu, Jun 17, 8:50 PM · Compositing
Manuel Castilla (manzanilla) added a reviewer for D11634: Compositor: Full frame Bilateral Blur node: Jeroen Bakker (jbakker).
Thu, Jun 17, 8:43 PM · Compositing
Manuel Castilla (manzanilla) requested review of D11634: Compositor: Full frame Bilateral Blur node.
Thu, Jun 17, 8:42 PM · Compositing

Wed, Jun 16

Manuel Castilla (manzanilla) added a reviewer for D11627: Compositor: Full frame Box Mask node: Jeroen Bakker (jbakker).
Wed, Jun 16, 11:42 PM · Compositing
Manuel Castilla (manzanilla) requested review of D11627: Compositor: Full frame Box Mask node.
Wed, Jun 16, 11:41 PM · Compositing
Manuel Castilla (manzanilla) updated the diff for D11559: Compositor: Full frame Image node.
  • Merge branch 'master' into cmp-node-image
Wed, Jun 16, 4:54 PM · Compositing
Manuel Castilla (manzanilla) committed rB88aa056d1ac5: Fix: Image node alpha socket converted to operations twice (authored by Manuel Castilla (manzanilla)).
Fix: Image node alpha socket converted to operations twice
Wed, Jun 16, 2:33 PM
Manuel Castilla (manzanilla) closed D11566: Fix: Image node alpha socket converted to operations twice.
Wed, Jun 16, 2:33 PM · Compositing
Manuel Castilla (manzanilla) committed rBb66600b9f339: Compositor: Full frame Value node (authored by Manuel Castilla (manzanilla)).
Compositor: Full frame Value node
Wed, Jun 16, 2:33 PM
Manuel Castilla (manzanilla) closed D11594: Compositor: Full frame Value node.
Wed, Jun 16, 2:33 PM · Compositing
Manuel Castilla (manzanilla) committed rBb406b6717f97: Compositor: Full frame RGB node (authored by Manuel Castilla (manzanilla)).
Compositor: Full frame RGB node
Wed, Jun 16, 2:33 PM
Manuel Castilla (manzanilla) closed D11593: Compositor: Full frame RGB node.
Wed, Jun 16, 2:33 PM · Compositing
Manuel Castilla (manzanilla) updated the diff for D11559: Compositor: Full frame Image node.
  • Move utility methods to MemoryBuffer
  • Rename rect to area
  • Rename is_buffer_data_owned_ to owns_data_
Wed, Jun 16, 12:09 AM · Compositing

Mon, Jun 14

Robert Windefjord (Robonnet) awarded T81650: New compositor system proposal a Love token.
Mon, Jun 14, 3:32 PM · VFX & Video, Compositing

Sun, Jun 13

Manuel Castilla (manzanilla) retitled D11559: Compositor: Full frame Image node from Compositor: Full frame image node to Compositor: Full frame Image node.
Sun, Jun 13, 11:14 AM · Compositing
Manuel Castilla (manzanilla) retitled D11593: Compositor: Full frame RGB node from Compositor: Full frame color node to Compositor: Full frame RGB node.
Sun, Jun 13, 11:14 AM · Compositing
Manuel Castilla (manzanilla) added a reviewer for D11594: Compositor: Full frame Value node: Jeroen Bakker (jbakker).
Sun, Jun 13, 11:13 AM · Compositing
Manuel Castilla (manzanilla) requested review of D11594: Compositor: Full frame Value node.
Sun, Jun 13, 11:12 AM · Compositing
Manuel Castilla (manzanilla) added a reviewer for D11593: Compositor: Full frame RGB node: Jeroen Bakker (jbakker).
Sun, Jun 13, 10:48 AM · Compositing
Manuel Castilla (manzanilla) updated the summary of D11559: Compositor: Full frame Image node.
Sun, Jun 13, 10:47 AM · Compositing
Manuel Castilla (manzanilla) requested review of D11593: Compositor: Full frame RGB node.
Sun, Jun 13, 10:45 AM · Compositing

Sat, Jun 12

Manuel Castilla (manzanilla) retitled D11559: Compositor: Full frame Image node from [WIP]Compositor: Full frame image node to Compositor: Full frame image node.
Sat, Jun 12, 8:00 PM · Compositing
Manuel Castilla (manzanilla) updated the diff for D11559: Compositor: Full frame Image node.
  • Add missing consts
  • Merge branch 'master' into cmp-node-image
Sat, Jun 12, 7:58 PM · Compositing

Thu, Jun 10

Manuel Castilla (manzanilla) added a reviewer for D11566: Fix: Image node alpha socket converted to operations twice: Jeroen Bakker (jbakker).
Thu, Jun 10, 1:49 PM · Compositing
Manuel Castilla (manzanilla) requested review of D11566: Fix: Image node alpha socket converted to operations twice.
Thu, Jun 10, 1:48 PM · Compositing

Wed, Jun 9

Manuel Castilla (manzanilla) requested review of D11559: Compositor: Full frame Image node.
Wed, Jun 9, 11:42 PM · Compositing
Manuel Castilla (manzanilla) committed rBb18a214ecba6: Fix: Compositor test desintegrate failing on arm64 (authored by Manuel Castilla (manzanilla)).
Fix: Compositor test desintegrate failing on arm64
Wed, Jun 9, 11:30 AM
Manuel Castilla (manzanilla) closed D11546: Fix: Compositor test desintegrate failing on arm64.
Wed, Jun 9, 11:30 AM · Compositing
Manuel Castilla (manzanilla) closed D11515: Compositor: Refactor recursive methods to iterative.
Wed, Jun 9, 11:30 AM · Compositing
Manuel Castilla (manzanilla) committed rBd7c812f15bef: Compositor: Refactor recursive methods to iterative (authored by Manuel Castilla (manzanilla)).
Compositor: Refactor recursive methods to iterative
Wed, Jun 9, 11:30 AM
Manuel Castilla (manzanilla) updated the summary of D11546: Fix: Compositor test desintegrate failing on arm64.
Wed, Jun 9, 9:56 AM · Compositing
Manuel Castilla (manzanilla) requested review of D11546: Fix: Compositor test desintegrate failing on arm64.
Wed, Jun 9, 9:54 AM · Compositing

Tue, Jun 8

Lopo Isaac (lopoIsaac) awarded rB9adfd278f748: Compositor: Full-frame base system a Love token.
Tue, Jun 8, 2:43 PM

Sat, Jun 5

Manuel Castilla (manzanilla) updated the summary of D11515: Compositor: Refactor recursive methods to iterative.
Sat, Jun 5, 7:13 PM · Compositing
Manuel Castilla (manzanilla) requested review of D11515: Compositor: Refactor recursive methods to iterative.
Sat, Jun 5, 7:10 PM · Compositing

Fri, Jun 4

Lopo Isaac (lopoIsaac) awarded T88150: Full Frame Compositor a Love token.
Fri, Jun 4, 1:41 PM · BF Blender, Compositing

Thu, Jun 3

Manuel Castilla (manzanilla) updated the diff for D11490: Compositor: Constant folding.
  • Cleanup: Unneeded block
Thu, Jun 3, 11:57 PM
Manuel Castilla (manzanilla) updated the summary of D11490: Compositor: Constant folding.
Thu, Jun 3, 11:40 PM
Manuel Castilla (manzanilla) requested review of D11490: Compositor: Constant folding.
Thu, Jun 3, 11:29 PM

Wed, Jun 2

Daniel Salazar (zanqdo) awarded rB9adfd278f748: Compositor: Full-frame base system a Love token.
Wed, Jun 2, 3:03 AM

Tue, Jun 1

Manuel Castilla (manzanilla) updated the task description for T88150: Full Frame Compositor.
Tue, Jun 1, 10:33 PM · BF Blender, Compositing
Manuel Castilla (manzanilla) updated the diff for D11295: [WIP] Compositor: WorkScheduler tests.
  • Merge branch 'master' into cmp-scheduler-tests
  • Cleanups
  • Fix missing member after merge
  • Fix: Must specify package type to run custom functions
  • Fix: Works may not be executed, wait by time
  • Add more works than cpu threads so there may be some waiting
Tue, Jun 1, 10:16 PM · Compositing
Manuel Castilla (manzanilla) closed D11113: Compositor: Full-frame base system.
Tue, Jun 1, 10:57 AM · Compositing
Manuel Castilla (manzanilla) committed rB9adfd278f748: Compositor: Full-frame base system (authored by Manuel Castilla (manzanilla)).
Compositor: Full-frame base system
Tue, Jun 1, 10:57 AM
Manuel Castilla (manzanilla) updated the diff for D11113: Compositor: Full-frame base system.
  • Fix macos compiler warning: side effects on typeid
Tue, Jun 1, 10:23 AM · Compositing

Mon, May 31

Manuel Castilla (manzanilla) added a comment to T88484: Compositor: adding viewer node with volume object causes crash in DebugInfo::graphviz.

What type of exception does it throw?
Can't reproduce it on windows or linux, seems to happen only on macos. I don't have one.
Can you try this patch please?

Mon, May 31, 10:00 PM · EEVEE & Viewport, Compositing, BF Blender
Manuel Castilla (manzanilla) added a comment to D11113: Compositor: Full-frame base system.

The crash has been fixed with D11381, merged from master. Operations should never have 0 resolution.

Mon, May 31, 1:21 PM · Compositing
Manuel Castilla (manzanilla) updated the diff for D11113: Compositor: Full-frame base system.
  • Merge branch 'master' into cmp-full-frame
  • Fix areas of interest outside operation bounds
Mon, May 31, 1:16 PM · Compositing
Manuel Castilla (manzanilla) committed rBe9f2f17e8518: Fix (unreported): TextureOperation inputs have no resolution (authored by Manuel Castilla (manzanilla)).
Fix (unreported): TextureOperation inputs have no resolution
Mon, May 31, 12:32 PM
Manuel Castilla (manzanilla) closed D11381: Fix (unreported): TextureOperation inputs have no resolution.
Mon, May 31, 12:32 PM · Compositing

Tue, May 25

Manuel Castilla (manzanilla) updated the summary of D11381: Fix (unreported): TextureOperation inputs have no resolution.
Tue, May 25, 3:09 PM · Compositing
Manuel Castilla (manzanilla) updated the diff for D11381: Fix (unreported): TextureOperation inputs have no resolution.
  • Force preferred resolution as TextureOperation resolution
Tue, May 25, 3:07 PM · Compositing
Manuel Castilla (manzanilla) updated the summary of D11381: Fix (unreported): TextureOperation inputs have no resolution.
Tue, May 25, 2:18 PM · Compositing
Manuel Castilla (manzanilla) added a reviewer for D11381: Fix (unreported): TextureOperation inputs have no resolution: Jeroen Bakker (jbakker).
Tue, May 25, 2:15 PM · Compositing
Manuel Castilla (manzanilla) requested review of D11381: Fix (unreported): TextureOperation inputs have no resolution.
Tue, May 25, 2:14 PM · Compositing

Mon, May 24

Manuel Castilla (manzanilla) committed rB1318cb26fe07: Cleanup: Refactor PlaneTrack and PlaneDistort operations (authored by Manuel Castilla (manzanilla)).
Cleanup: Refactor PlaneTrack and PlaneDistort operations
Mon, May 24, 3:16 PM
Manuel Castilla (manzanilla) closed D11273: Cleanup: Refactor PlaneTrack and PlaneDistort operations.
Mon, May 24, 3:16 PM · Compositing

Sun, May 23

Evan Wilson (EAW) awarded D11113: Compositor: Full-frame base system a Love token.
Sun, May 23, 7:20 PM · Compositing

Sat, May 22

Fran Marz (franMarz) awarded D11113: Compositor: Full-frame base system a Love token.
Sat, May 22, 4:46 PM · Compositing
Manuel Castilla (manzanilla) updated the diff for D11113: Compositor: Full-frame base system.
  • Merge branch 'master' into cmp-full-frame
  • Add get_area_of_interest overloading and pass input_op
Sat, May 22, 4:13 PM · Compositing

Thu, May 20

Manuel Castilla (manzanilla) planned changes to D11312: Fix (unreported): Cryptomatte legacy node memory leak.

This is not a proper solution. File in bug report T86271 crashes when closing blender.
That file loads 2 legacy cryptomatte nodes with same address for their matte_id string. Once one is freed when freeing the other will crash.
The memory leak happens too with that file in current master. Don't know how loading/saving file code works but node_copy_cryptomatte certainly duplicates matte_id pointer value, so this may happen with files being saved with duplicated legacy matte nodes in old files.

Thu, May 20, 11:29 PM
Manuel Castilla (manzanilla) added a comment to D11113: Compositor: Full-frame base system.

I've create a glossary at https://wiki.blender.org/wiki/Source/Compositor
Will be adding more, specially terms that may not be clear.
Term "render" in SharedOperationsBuffer was certainly confusing. I've changed it to "area" and use the term in more places as it's related to get_input_area_of_interest.

Thu, May 20, 6:26 PM · Compositing
Manuel Castilla (manzanilla) updated the diff for D11113: Compositor: Full-frame base system.
  • Move execute_work mutex and condition to class scope
  • Improve get_area_of_interest doc comments and signature
  • Improve SharedOperationBuffers methods naming and add doc comments
  • Improve comments and naming
Thu, May 20, 6:13 PM · Compositing

May 19 2021

Manuel Castilla (manzanilla) requested review of D11312: Fix (unreported): Cryptomatte legacy node memory leak.
May 19 2021, 6:21 PM
Manuel Castilla (manzanilla) added a comment to D11113: Compositor: Full-frame base system.

I've tested the use of parallel_for_each from BLI_task.hh as alternative and performance went from ~0.55s to ~1.90s, to use a thread/task pool as WorkScheduler does seems a must.
About WorkScheduler::finish issue, it's queue model only waits for works queue getting empty and not last work threads to finish. Tiled implementation may have been relying on this behaviour for a long time, I'm not sure if it was intended on initial implementation.
I have in mind all you've recommended, as this patch is already quite big, I'd prefer we do it in smaller patches after this one.

May 19 2021, 8:21 AM · Compositing
Manuel Castilla (manzanilla) added inline comments to D11113: Compositor: Full-frame base system.
May 19 2021, 12:21 AM · Compositing
Manuel Castilla (manzanilla) updated the diff for D11113: Compositor: Full-frame base system.
  • Add TODO to implement MemoryBuffer get_size()
  • Use mutex lock instead of atomics
  • Add TODO to remove execute_work workaround
  • Add TODO for get_area_of_interest parameter overloading
  • Add TODO to improve is_render_registered
May 19 2021, 12:04 AM · Compositing

May 18 2021

Manuel Castilla (manzanilla) retitled D11295: [WIP] Compositor: WorkScheduler tests from Compositor: WorkScheduler tests to [WIP] Compositor: WorkScheduler tests.
May 18 2021, 10:49 PM · Compositing
Manuel Castilla (manzanilla) requested review of D11295: [WIP] Compositor: WorkScheduler tests.
May 18 2021, 10:48 PM · Compositing
Manuel Castilla (manzanilla) added inline comments to D11113: Compositor: Full-frame base system.
May 18 2021, 12:14 AM · Compositing

May 17 2021

Manuel Castilla (manzanilla) created P2121 (An Untitled Masterwork).
May 17 2021, 11:43 PM
Manuel Castilla (manzanilla) updated the diff for D11113: Compositor: Full-frame base system.
  • Fix multi line comment open tag
  • Rename new class data members from m_* to *_
  • Rename OutputStore to SharedOperationBuffers
  • Use num_* naming instead of n_*
  • Cast strange type values instead of normal ones.
  • Move is_breaked to base class
  • Rename get_input_area_of_interest to get_area_of_interest
  • Rename multi_update_memory_buffer to update_memory_buffer_partial
  • Rename public getInputOperation to get_input_operation
  • Move non NodeOperation responsabilities to FullFrameExecutionModel
  • Move assert before assignment
  • Rename WorkPackage functions to *_fn
  • Fix eNodeTreeExecutionMode typedef
May 17 2021, 11:32 PM · Compositing

May 16 2021

Manuel Castilla (manzanilla) updated the diff for D11113: Compositor: Full-frame base system.
  • Fix incorrect output border calculation
May 16 2021, 7:28 PM · Compositing
Manuel Castilla (manzanilla) added a reviewer for D11273: Cleanup: Refactor PlaneTrack and PlaneDistort operations: Compositing.
May 16 2021, 12:47 PM · Compositing
Manuel Castilla (manzanilla) requested review of D11273: Cleanup: Refactor PlaneTrack and PlaneDistort operations.
May 16 2021, 12:46 PM · Compositing

May 15 2021

Silas Opel (Schamph) awarded D11113: Compositor: Full-frame base system a Love token.
May 15 2021, 3:01 PM · Compositing
Manuel Castilla (manzanilla) updated the diff for D11113: Compositor: Full-frame base system.
  • Use getInputOperation instead of socket links
  • Use WorkScheduler::finish() for better performance
May 15 2021, 2:59 PM · Compositing
Manuel Castilla (manzanilla) updated the summary of D11113: Compositor: Full-frame base system.
May 15 2021, 2:58 PM · Compositing

May 14 2021

Manuel Castilla (manzanilla) updated the diff for D11113: Compositor: Full-frame base system.
  • Comments fixes
May 14 2021, 9:56 PM · Compositing
Manuel Castilla (manzanilla) added a comment to D11113: Compositor: Full-frame base system.

Seems it is still in development as not all comments have been addressed?

May 14 2021, 6:15 PM · Compositing
Manuel Castilla (manzanilla) added inline comments to D11113: Compositor: Full-frame base system.
May 14 2021, 6:10 PM · Compositing
Manuel Castilla (manzanilla) updated the diff for D11113: Compositor: Full-frame base system.
  • Fix comment formatting
  • Merge branch 'master' into cmp-full-frame
May 14 2021, 5:29 PM · Compositing
Manuel Castilla (manzanilla) updated the diff for D11113: Compositor: Full-frame base system.
  • Rename var to has_outputs
  • Rename execution_model to execution_mode
  • User prefs option only enable panel option now
  • Add a TODO to check operation is constant
  • Create ExecutionModel classes to reduce complexity
  • Use pthread_signals and atomic counter
May 14 2021, 4:54 PM · Compositing
Habib Gahbiche (zazizizou) awarded T88150: Full Frame Compositor a Like token.
May 14 2021, 11:45 AM · BF Blender, Compositing
Manuel Castilla (manzanilla) updated the diff for D11113: Compositor: Full-frame base system.
  • Fix comments didn't conform style convention.
  • Add missing copyright notice
  • Use work package type for more readable code
  • Add panel UI option for execution model
  • Use WorkScheduler for getting number of cpu threads
  • Use MIN2 and BLI_rcti_clamp
  • Improve execute_work code readability
  • Refactor render methods into NodeOperation
May 14 2021, 12:52 AM · Compositing

May 11 2021

Manuel Castilla (manzanilla) updated the summary of D11113: Compositor: Full-frame base system.
May 11 2021, 2:19 PM · Compositing
Manuel Castilla (manzanilla) retitled D11113: Compositor: Full-frame base system from [WIP] Compositor: Full-frame base system to Compositor: Full-frame base system.
May 11 2021, 2:16 PM · Compositing
Manuel Castilla (manzanilla) updated the diff for D11113: Compositor: Full-frame base system.
  • Add phabricator task to UI option
  • Fix string format compiler warning
May 11 2021, 2:13 PM · Compositing
Manuel Castilla (manzanilla) added a comment to D11113: Compositor: Full-frame base system.

Added benchmarks to summary

May 11 2021, 12:48 PM · Compositing
Manuel Castilla (manzanilla) updated the summary of D11113: Compositor: Full-frame base system.
May 11 2021, 12:46 PM · Compositing
Manuel Castilla (manzanilla) updated the summary of D11113: Compositor: Full-frame base system.
May 11 2021, 12:31 PM · Compositing

May 10 2021

Manuel Castilla (manzanilla) updated the diff for D11113: Compositor: Full-frame base system.
  • Merge branch 'master' into cmp-full-frame
  • Move rendering logic to ExecutionSystem
  • Take into account single elem buffers
  • Switch back to default ThreadingModel::Queue
May 10 2021, 9:49 PM · Compositing
Manuel Castilla (manzanilla) added a comment to D11090: Compositor: Only read input constants to determine input area.

Would it be similar to cycles nodes "constant folding" idea?
Is this valid approach?:

  • Add a "can_be_constant" operation flag. Maybe false by default to ensure correctness but many operations are constant when all their inputs are, most distort ones may not.
  • Before determining input areas, from inputs search for parts of tree with constant operations, evaluate them by rendering a single pixel and replace with a Set<Color/Vector/Value>Operation.
May 10 2021, 2:57 PM
Manuel Castilla (manzanilla) committed rBf966f6ed55f7: Compositor: Add vars and methods for easier image looping (authored by Manuel Castilla (manzanilla)).
Compositor: Add vars and methods for easier image looping
May 10 2021, 11:18 AM