Mike Erwin (merwin)
Animal

Projects

User Details

User Since
Apr 27 2010, 10:07 PM (369 w, 4 d)

Recent Activity

Fri, May 26

Mike Erwin (merwin) added inline comments to D2678: Gawain refactor.
Fri, May 26, 5:28 PM
Mike Erwin (merwin) committed rB620516965b49: Gawain: move convert_prim_type_to_gl to private API (authored by Mike Erwin (merwin)).
Gawain: move convert_prim_type_to_gl to private API
Fri, May 26, 5:24 PM
Mike Erwin (merwin) added inline comments to D2678: Gawain refactor.
Fri, May 26, 4:53 PM
Mike Erwin (merwin) added inline comments to D2678: Gawain refactor.
Fri, May 26, 4:20 PM
Mike Erwin (merwin) added inline comments to D2678: Gawain refactor.
Fri, May 26, 4:02 PM
Mike Erwin (merwin) added a comment to T51635: Gawain hardcoded limit of 16 attributes leads to crashes.

Gawain's limit matches common hardware limits, that's why it's 16. This applies to active attributes in the shader. I talked with @Clément Foucault (fclem) before about aliases — these don't belong in VertexFormat, and the limit should not apply to them. VertexBuffer or Batch is a better place to track aliases... still need to figure out the details!

Fri, May 26, 3:45 PM · BF Blender: 2.8

Tue, May 23

Mike Erwin (merwin) added a comment to rB340e4394d43e: Use custom shader for dot particles.

Please explain the difference between the new shader and GPU_SHADER_3D_POINT_UNIFORM_SIZE_UNIFORM_COLOR_OUTLINE_AA. Is it something that the rest of Blender (outside the 3D view) might want to use?

Tue, May 23, 5:54 PM

Mon, May 22

Mike Erwin (merwin) committed rB6cc293a6d97a: Gawain: replace switch with lookup table (authored by Mike Erwin (merwin)).
Gawain: replace switch with lookup table
Mon, May 22, 10:45 PM
Mike Erwin (merwin) added a comment to T51576: Blender crash when change to edit mode with Intel GPU.

More results from Intel HD 520 + Windows 10.

Mon, May 22, 9:44 PM · BF Blender: 2.8
Mike Erwin (merwin) triaged T51576: Blender crash when change to edit mode with Intel GPU as "Confirmed" priority.

Crashes inside Intel graphics driver while linking one of our shaders. This one!

Mon, May 22, 3:26 AM · BF Blender: 2.8
Mike Erwin (merwin) committed rB054eb9422ca5: Gawain: use integer math to convert int16 to int10 (authored by Mike Erwin (merwin)).
Gawain: use integer math to convert int16 to int10
Mon, May 22, 12:27 AM
Mike Erwin (merwin) committed rB23035cf46fb4: Gawain: remove GLenum from IndexType API (authored by Mike Erwin (merwin)).
Gawain: remove GLenum from IndexType API
Mon, May 22, 12:27 AM
Mike Erwin (merwin) committed rBea31c55b08e0: Gawain: cleanup code formatting (authored by Mike Erwin (merwin)).
Gawain: cleanup code formatting
Mon, May 22, 12:27 AM
Mike Erwin (merwin) committed rB90a1d491800c: Gawain: drop support for APPLE_vertex_array_object (authored by Mike Erwin (merwin)).
Gawain: drop support for APPLE_vertex_array_object
Mon, May 22, 12:27 AM
Mike Erwin (merwin) committed rB3f6f02e43364: Gawain: drop support for APPLE_flush_buffer_range (authored by Mike Erwin (merwin)).
Gawain: drop support for APPLE_flush_buffer_range
Mon, May 22, 12:27 AM
Mike Erwin (merwin) committed rB68d8618538e6: Gawain: promote 10_10_10 to first-class vertex format (authored by Mike Erwin (merwin)).
Gawain: promote 10_10_10 to first-class vertex format
Mon, May 22, 12:27 AM

Sun, May 21

Mike Erwin (merwin) added inline comments to rB07dd208209ce: Cleanup: warnings.
Sun, May 21, 8:06 PM
Mike Erwin (merwin) closed T49450: replace OpenGL legacy matrix stacks as "Resolved".
Sun, May 21, 4:20 PM · OpenGL / Gfx, BF Blender: 2.8
Mike Erwin (merwin) closed T49450: replace OpenGL legacy matrix stacks, a subtask of T49165: OpenGL Refactor: Main Task, as "Resolved".
Sun, May 21, 4:20 PM · OpenGL / Gfx, BF Blender: 2.8
Mike Erwin (merwin) claimed T51576: Blender crash when change to edit mode with Intel GPU.

I have some Windows + Intel systems here for testing.

Sun, May 21, 3:36 PM · BF Blender: 2.8

Fri, May 19

Mike Erwin (merwin) committed rB996bf6573025: Clay/Eevee: fix more crash when entering edit mode (authored by Mike Erwin (merwin)).
Clay/Eevee: fix more crash when entering edit mode
Fri, May 19, 10:13 PM
Mike Erwin (merwin) committed rB8d7b98bfd396: OpenGL: cleanup material shader GLSL (authored by Mike Erwin (merwin)).
OpenGL: cleanup material shader GLSL
Fri, May 19, 8:21 PM
Mike Erwin (merwin) committed rB941e739d7035: Clay/Eevee: fix crash when entering edit mode (authored by Mike Erwin (merwin)).
Clay/Eevee: fix crash when entering edit mode
Fri, May 19, 8:21 PM
Mike Erwin (merwin) committed rBa1c558e19f6f: OpenGL: cleanup edit overlay shaders (authored by Mike Erwin (merwin)).
OpenGL: cleanup edit overlay shaders
Fri, May 19, 8:21 PM
Mike Erwin (merwin) committed rB8561a2dda746: OpenGL: remove BIT_OPERATIONS check from GLSL (authored by Mike Erwin (merwin)).
OpenGL: remove BIT_OPERATIONS check from GLSL
Fri, May 19, 6:37 PM
Mike Erwin (merwin) awarded rB8adec78ca574: Cleanup: remove GLSL version checks a Piece of Eight token.
Fri, May 19, 5:21 PM
Mike Erwin (merwin) committed rBef3c2554575c: fix typo in interlace shader (authored by Mike Erwin (merwin)).
fix typo in interlace shader
Fri, May 19, 5:11 PM
Mike Erwin (merwin) committed rB648f2a61ada5: OpenGL: convert old texture2D calls in built-in shaders (authored by Mike Erwin (merwin)).
OpenGL: convert old texture2D calls in built-in shaders
Fri, May 19, 5:11 PM
Mike Erwin (merwin) committed rBfa47437426b8: OpenGL: clean up smoke & fire shaders (authored by Mike Erwin (merwin)).
OpenGL: clean up smoke & fire shaders
Fri, May 19, 5:10 PM
Mike Erwin (merwin) committed rBf6ffe12ddb44: OpenGL: convert old texture2D calls in FX shaders (authored by Mike Erwin (merwin)).
OpenGL: convert old texture2D calls in FX shaders
Fri, May 19, 5:10 PM
Mike Erwin (merwin) committed rB4c5e9d7c0df0: OpenGL: convert old texture2D calls in material GLSL (authored by Mike Erwin (merwin)).
OpenGL: convert old texture2D calls in material GLSL
Fri, May 19, 5:10 PM
Mike Erwin (merwin) added a comment to D2678: Gawain refactor.

General comments.

Fri, May 19, 8:18 AM
Mike Erwin (merwin) committed rB77f8d631b1f6: OpenSubdiv: insert TODO notes for OpenGL (authored by Mike Erwin (merwin)).
OpenSubdiv: insert TODO notes for OpenGL
Fri, May 19, 12:32 AM
Mike Erwin (merwin) committed rBe03e977385c9: OpenGL: call glProgramUniform only if version >= 4.1 (authored by Mike Erwin (merwin)).
OpenGL: call glProgramUniform only if version >= 4.1
Fri, May 19, 12:32 AM
Mike Erwin (merwin) committed rB2e56e1415a0d: OpenGL: remove EXT_geometry_shader4 from OpenSubdiv (authored by Mike Erwin (merwin)).
OpenGL: remove EXT_geometry_shader4 from OpenSubdiv
Fri, May 19, 12:32 AM
Mike Erwin (merwin) committed rBff8673399ecb: OpenSubdiv: remove legacy support & display queries (authored by Mike Erwin (merwin)).
OpenSubdiv: remove legacy support & display queries
Fri, May 19, 12:31 AM
Mike Erwin (merwin) committed rB51278bab5ded: remove GPU_legacy_support query (authored by Mike Erwin (merwin)).
remove GPU_legacy_support query
Fri, May 19, 12:31 AM
Mike Erwin (merwin) committed rB414c1c0e77e9: OpenGL: remove -noglsl option & GPU_extensions_disable (authored by Mike Erwin (merwin)).
OpenGL: remove -noglsl option & GPU_extensions_disable
Fri, May 19, 12:31 AM
Mike Erwin (merwin) committed rB7823957455fb: remove GPU_geometry_shader_support, instanced_drawing_support queries (authored by Mike Erwin (merwin)).
remove GPU_geometry_shader_support, instanced_drawing_support queries
Fri, May 19, 12:31 AM
Mike Erwin (merwin) committed rB5ed0944ce638: GPU: cleanup GLSL version and standard extensions (authored by Mike Erwin (merwin)).
GPU: cleanup GLSL version and standard extensions
Fri, May 19, 12:31 AM
Mike Erwin (merwin) committed rB8cb3c7bdecd8: remove GPU_display_list_support query (authored by Mike Erwin (merwin)).
remove GPU_display_list_support query
Fri, May 19, 12:31 AM

Thu, May 18

Mike Erwin (merwin) added a comment to rB740f33d8a20e: Remove "Modern Viewport".

Why remove modern and keep legacy? The other way makes more sense to me.

Thu, May 18, 9:28 PM
Mike Erwin (merwin) added a comment to T50856: Blender is not responding after minimizing.

I'm testing Blender 2.78c on an AMD A10-7850, not seeing any issues. Tried different window draw methods, region overlap, nothing yet breaks it.

Thu, May 18, 1:33 AM · BF Blender, OpenGL / Gfx

Mon, May 15

Mike Erwin (merwin) committed rB87bbeb283778: Gawain: further cleanup to VertexBuffer_prime (authored by Mike Erwin (merwin)).
Gawain: further cleanup to VertexBuffer_prime
Mon, May 15, 7:10 PM
Mike Erwin (merwin) committed rB4f7c738a38b2: Gawain: revert recent VRAM usage metric (authored by Mike Erwin (merwin)).
Gawain: revert recent VRAM usage metric
Mon, May 15, 7:10 PM
Mike Erwin (merwin) committed rB30d325c9e61f: Gawain: cleanup VRAM usage metric (authored by Mike Erwin (merwin)).
Gawain: cleanup VRAM usage metric
Mon, May 15, 7:10 PM
Mike Erwin (merwin) added a reverting commit for rB1ff97bbfff78: Gawain: Better metric for VRAM usage.: rB4f7c738a38b2: Gawain: revert recent VRAM usage metric.
Mon, May 15, 7:10 PM
Mike Erwin (merwin) added a reverting commit for rB7a18ee62eb4d: Gawain: Fix memory manager.: rB4f7c738a38b2: Gawain: revert recent VRAM usage metric.
Mon, May 15, 7:10 PM

Sat, May 13

Mike Erwin (merwin) committed rB6deaab207c25: remove old PBVH VertexBufferFormat struct (authored by Mike Erwin (merwin)).
remove old PBVH VertexBufferFormat struct
Sat, May 13, 5:40 AM
Mike Erwin (merwin) committed rB41c4c3f8fdd6: remove unused #includes (authored by Mike Erwin (merwin)).
remove unused #includes
Sat, May 13, 5:40 AM
Mike Erwin (merwin) added a comment to D2670: Crappy Persistent mapping based gawain.

Good to see you @Antony Riakiotakis (psy-fi)! Thanks for digging into this & verifying that it does help.

Sat, May 13, 3:37 AM · BF Blender: 2.8
Mike Erwin (merwin) added a comment to T51478: Lagging with Blender 2.78 on Mac OS Sierra.

Also try "OpenGL Occlusion Queries" in User Prefs | System | Selection.

Sat, May 13, 3:09 AM · BF Blender
Mike Erwin (merwin) added a comment to T51478: Lagging with Blender 2.78 on Mac OS Sierra.

It might be related to a change we made in 2.77 — always use VBOs to draw objects. @Small Sébastien (Conique2001) your graphics card has plenty of VRAM so should be able to handle large poly counts. So hmmm....

Sat, May 13, 3:07 AM · BF Blender

Fri, May 12

Mike Erwin (merwin) added a comment to rBf1242ea93b1c: Fix bug in copying VertexFormat.

Thanks for the fix, I can't believe this hasn't caused problems before!

Fri, May 12, 12:45 AM
Mike Erwin (merwin) awarded rBf1242ea93b1c: Fix bug in copying VertexFormat a Doubloon token.
Fri, May 12, 12:39 AM
Mike Erwin (merwin) closed T49012: update OpenGL requirements for Blender 2.8 as "Resolved".

As of c8ab7d46566c4a65c6176cd2ebe27778512f7fef we use OpenGL 3.3 core profile on all platforms. We still have some implementation and cleanup work ahead, but this milestone is effectively done.

Fri, May 12, 12:37 AM · BF Blender: 2.8, OpenGL / Gfx
Mike Erwin (merwin) closed T49012: update OpenGL requirements for Blender 2.8, a subtask of T49165: OpenGL Refactor: Main Task, as "Resolved".
Fri, May 12, 12:37 AM · OpenGL / Gfx, BF Blender: 2.8

Fri, May 5

Mike Erwin (merwin) added a comment to T51219: Gawain API general consistency RFC.

Bigger picture, I prefer function names mostly as they are. That's why I chose them! Some of the P453 changes are better though, so we can pick & choose.

Fri, May 5, 7:40 PM · BF Blender: 2.8
Mike Erwin (merwin) added a comment to T51219: Gawain API general consistency RFC.

Some notes on specifics, so we can use P453 as a base for discussion.

Fri, May 5, 5:48 PM · BF Blender: 2.8
Mike Erwin (merwin) added a comment to P453 gawain_refactor.py (see: T51219).

Some notes on specifics, so we can use this as a base for discussion.

Fri, May 5, 5:45 PM
Mike Erwin (merwin) closed T51152: Blender won't start after updating Nvidia drivers as "Resolved".

Fixed by unknown NVIDIA magic.

Fri, May 5, 1:46 AM · BF Blender: Unconfirmed, OpenGL / Gfx
Mike Erwin (merwin) added a comment to T51152: Blender won't start after updating Nvidia drivers.

Just tested Blender 2.78c on latest Windows 10 (64-bit) and Geforce GTX 1050.

Fri, May 5, 12:41 AM · BF Blender: Unconfirmed, OpenGL / Gfx

Mon, May 1

Mike Erwin (merwin) updated subscribers of T51206: Wire line-width in draw manager ignores UI scale..

Edit mode edge drawing uses a different technique though. It can be updated to respect UI scale. Similar for round points with outlines.

Mon, May 1, 7:31 PM · BF Blender: 2.8, OpenGL / Gfx
Mike Erwin (merwin) added a comment to T51206: Wire line-width in draw manager ignores UI scale..

I've gotten mixed results with wide lines on core profile.

Mon, May 1, 7:27 PM · BF Blender: 2.8, OpenGL / Gfx
Mike Erwin (merwin) added a comment to T51370: Object Mode: Empty Image Draw Option.

For reference, here's the commit from the current (non draw manager) viewport.

Mon, May 1, 7:21 PM · BF Blender: 2.8, OpenGL / Gfx
Mike Erwin (merwin) updated subscribers of T51375: Port CDDM to core profile.

Whaaaat? I thought we were removing all of this soon. How long until the depsgraph gives us post-modifier results?

Mon, May 1, 7:17 PM · BF Blender: 2.8, OpenGL / Gfx
Mike Erwin (merwin) added a comment to T51346: Object Info node not working in material view .

Yes I'll take a look tomorrow, try to figure it out.

Mon, May 1, 3:24 AM · BF Blender

Apr 27 2017

Mike Erwin (merwin) committed rBe4d856e31b27: OpenGL: manage legacy state only when WITH_LEGACY_OPENGL=ON (authored by Mike Erwin (merwin)).
OpenGL: manage legacy state only when WITH_LEGACY_OPENGL=ON
Apr 27 2017, 8:35 PM
Mike Erwin (merwin) committed rB079e0b5943f3: OpenGL: don't set texture LoD bias via glTexEnvf (authored by Mike Erwin (merwin)).
OpenGL: don't set texture LoD bias via glTexEnvf
Apr 27 2017, 8:35 PM
Mike Erwin (merwin) committed rB0d5c5a8438ba: OpenGL: early exit from functions that don't mix with core profile (authored by Mike Erwin (merwin)).
OpenGL: early exit from functions that don't mix with core profile
Apr 27 2017, 8:35 PM
Mike Erwin (merwin) committed rB99fde39f4905: OpenGL: fix color logic op (authored by Mike Erwin (merwin)).
OpenGL: fix color logic op
Apr 27 2017, 8:20 PM
Mike Erwin (merwin) committed rB75fac519c053: Gawain: safely orphan immediate mode's VBO (authored by Mike Erwin (merwin)).
Gawain: safely orphan immediate mode's VBO
Apr 27 2017, 5:47 PM
Mike Erwin (merwin) committed rB741ed16d13b3: OpenGL: don't glGet(GL_RED_BITS) in core profile (authored by Mike Erwin (merwin)).
OpenGL: don't glGet(GL_RED_BITS) in core profile
Apr 27 2017, 5:47 PM
Mike Erwin (merwin) committed rBbfaf7a3eb15e: OpenGL: stop enabling GL_TEXTURE (authored by Mike Erwin (merwin)).
OpenGL: stop enabling GL_TEXTURE
Apr 27 2017, 5:29 PM
Mike Erwin (merwin) committed rBa49708a69181: OpenGL: stop using GL_NORMALIZE (authored by Mike Erwin (merwin)).
OpenGL: stop using GL_NORMALIZE
Apr 27 2017, 5:29 PM
Mike Erwin (merwin) committed rB34c808287e17: Gawain: fix pointer arithmetic warning (authored by Mike Erwin (merwin)).
Gawain: fix pointer arithmetic warning
Apr 27 2017, 4:02 PM
Mike Erwin (merwin) committed rB9a193a28c4fc: fix Clay compatibility comment (authored by Mike Erwin (merwin)).
fix Clay compatibility comment
Apr 27 2017, 3:32 PM
Mike Erwin (merwin) committed rB5c7b8cfffa5d: OpenGL: remove GL_MAP1_VERTEX_3 (authored by Mike Erwin (merwin)).
OpenGL: remove GL_MAP1_VERTEX_3
Apr 27 2017, 3:32 PM
Mike Erwin (merwin) committed rB1dbb41f19517: OpenGL: restore all 8 lights (authored by Mike Erwin (merwin)).
OpenGL: restore all 8 lights
Apr 27 2017, 3:32 PM
Mike Erwin (merwin) committed rB6f0cf4a80403: support OpenGL 3.0 on Linux only when WITH_LEGACY_OPENGL=ON (authored by Mike Erwin (merwin)).
support OpenGL 3.0 on Linux only when WITH_LEGACY_OPENGL=ON
Apr 27 2017, 3:32 PM

Apr 25 2017

Mike Erwin (merwin) edited the description of T51164: Deprecated OpenGL Migration, the home stretch!.
Apr 25 2017, 4:38 AM · BF Blender: 2.8
Mike Erwin (merwin) committed rB75a759ea5e9a: OpenGL: better context creation on Windows (authored by Mike Erwin (merwin)).
OpenGL: better context creation on Windows
Apr 25 2017, 4:32 AM
Mike Erwin (merwin) committed rB9c87bb124a57: group WITH_LEGACY_OPENGL with the other GL options (authored by Mike Erwin (merwin)).
group WITH_LEGACY_OPENGL with the other GL options
Apr 25 2017, 4:32 AM

Apr 24 2017

Mike Erwin (merwin) edited the description of T51164: Deprecated OpenGL Migration, the home stretch!.
Apr 24 2017, 4:13 AM · BF Blender: 2.8
Mike Erwin (merwin) added a comment to T51301: Remove MinGW support.

+1 for removing it

Apr 24 2017, 4:11 AM · Platform: Windows, BF Blender
Mike Erwin (merwin) awarded T51301: Remove MinGW support a Like token.
Apr 24 2017, 3:53 AM · Platform: Windows, BF Blender

Apr 23 2017

Mike Erwin (merwin) added a comment to T51164: Deprecated OpenGL Migration, the home stretch!.

@Mike Erwin (merwin) about the runtime problem with OSX. I had to update the extern glew to 2.0. Blender has a build option to use either the system glew or Blender's. So make sure you use Blender's glew for your tests!

Apr 23 2017, 4:59 PM · BF Blender: 2.8
Mike Erwin (merwin) edited the description of T51164: Deprecated OpenGL Migration, the home stretch!.
Apr 23 2017, 4:55 PM · BF Blender: 2.8

Apr 22 2017

Mike Erwin (merwin) added a comment to rBL61849: Attempted fix for macOS 10.9 libraries missing _getentropy symbol error..

Confirmed working on 10.9.5 (latest update). I tried both a version I built on 10.12 and the latest nightly build from blender.org.

Apr 22 2017, 7:52 PM
Mike Erwin (merwin) added a comment to T51152: Blender won't start after updating Nvidia drivers.

FYI @Gal (Gal) and @Christian Moravec (BeautyOfTechnology) I just ordered some NVIDIA cards so will be able to debug (and hopefully fix) this in a few days.

Apr 22 2017, 7:24 PM · BF Blender: Unconfirmed, OpenGL / Gfx
Mike Erwin (merwin) committed rB9fe9cf826107: fix omission from previous commit (authored by Mike Erwin (merwin)).
fix omission from previous commit
Apr 22 2017, 6:59 AM
Mike Erwin (merwin) committed rBef640ecf1004: OpenGL: remove use of GLEW MX (authored by Mike Erwin (merwin)).
OpenGL: remove use of GLEW MX
Apr 22 2017, 6:38 AM
Mike Erwin (merwin) added a comment to rB28ed66552bbb: Fix debug checks were enabled for release builds only.

Thanks, I got this reversed in b0351bd3bdaa16f7dec75fe90bcd66569564608a

Apr 22 2017, 5:55 AM
Mike Erwin (merwin) awarded rB28ed66552bbb: Fix debug checks were enabled for release builds only a Piece of Eight token.
Apr 22 2017, 5:54 AM

Apr 21 2017

Mike Erwin (merwin) committed rB1beed61b761d: OpenGL/GHOST: don't request accum buffer on Mac (authored by Mike Erwin (merwin)).
OpenGL/GHOST: don't request accum buffer on Mac
Apr 21 2017, 10:11 PM
Mike Erwin (merwin) committed rB12261aa047f4: fix unitizialized use warning (authored by Mike Erwin (merwin)).
fix unitizialized use warning
Apr 21 2017, 10:11 PM
Mike Erwin (merwin) committed rBdcda9b41365e: Eevee/OpenGL: fix shader for core profile (authored by Mike Erwin (merwin)).
Eevee/OpenGL: fix shader for core profile
Apr 21 2017, 10:11 PM
Mike Erwin (merwin) added a comment to rB8e0c57a812e8: Gawain: fix immediate mode drawing exceeding IMM_BUFFER_SIZE.

There are multiple ways to orphan a buffer resource, and this code picks 1 of 3 ways based on which OpenGL version we're running.

Apr 21 2017, 8:53 PM

Apr 20 2017

Mike Erwin (merwin) edited the description of T51164: Deprecated OpenGL Migration, the home stretch!.
Apr 20 2017, 7:21 PM · BF Blender: 2.8
Mike Erwin (merwin) claimed T51251: Odd Graphic in 2.80 User Preferences > System.

Awesome! It's the spheres from the Solid OpenGL Lights section. Should be easy to fix.

Apr 20 2017, 2:13 AM · BF Blender: 2.8, BF Blender