Mike Erwin (merwin)
Animal

Projects

User Since
Apr 27 2010, 10:07 PM (355 w, 6 d)

Recent Activity

Yesterday

Mike Erwin (merwin) added a comment to D2521: Initial rework of BKE's mesh_render to support BMesh directly..

Much appreciated! I'll review closer later today.

Mon, Feb 20, 10:23 AM
Mike Erwin (merwin) added a comment to T50158: Blender does not work above 1920x1080.

Can Blender run on Intel HD Graphic 5500? I plan to learn Blender now but very confuse about which notebook should I buy?

Mon, Feb 20, 6:20 AM · OpenGL / Gfx, Platform: Windows, BF Blender

Sun, Feb 19

Mike Erwin (merwin) committed rB9f839a2ff52e: OpenGL: fix MVP matrix order (authored by Mike Erwin (merwin)).
OpenGL: fix MVP matrix order
Sun, Feb 19, 1:54 AM

Sat, Feb 18

Mike Erwin (merwin) committed rBfae895125efe: fix OpenGL line count in VSE backdrop (authored by Mike Erwin (merwin)).
fix OpenGL line count in VSE backdrop
Sat, Feb 18, 9:40 PM

Fri, Feb 17

Mike Erwin (merwin) committed rB39e212eb05bd: OpenGL: further mask_draw tweaks (authored by Mike Erwin (merwin)).
OpenGL: further mask_draw tweaks
Fri, Feb 17, 9:48 PM
Mike Erwin (merwin) closed D2371: Converted mask_draw.c to new immediate mode.
Fri, Feb 17, 9:36 AM
Mike Erwin (merwin) accepted D2371: Converted mask_draw.c to new immediate mode.

Committed to blender2.8 with some modifications:

  • used imm mode instead of creating VAO & VBO (vertex count is rather small)
  • took your x/y scale observation & ran with it
Fri, Feb 17, 9:36 AM
Mike Erwin (merwin) committed rB84141f27a668: OpenGL: mask_draw uses new imm mode (authored by Mike Erwin (merwin)).
OpenGL: mask_draw uses new imm mode
Fri, Feb 17, 9:27 AM
Mike Erwin (merwin) accepted D2512: Add diagonal stripe shader (GPU_SHADER_2D_DIAG_STRIPES).
Fri, Feb 17, 2:12 AM · Restricted Project

Thu, Feb 16

Mike Erwin (merwin) added a task to rBdbe23c545649: OpenGL immediate mode: sequencer_draw.c: T49043: replace OpenGL immediate mode in Blender 2.8.
Thu, Feb 16, 9:19 PM
Mike Erwin (merwin) added a commit to T49043: replace OpenGL immediate mode in Blender 2.8: rBdbe23c545649: OpenGL immediate mode: sequencer_draw.c.
Thu, Feb 16, 9:19 PM · Restricted Project, OpenGL / Gfx
Mike Erwin (merwin) awarded rBdbe23c545649: OpenGL immediate mode: sequencer_draw.c a Manufacturing Defect? token.
Thu, Feb 16, 9:18 PM
Mike Erwin (merwin) added a comment to rBbf83f097ad7e: Immediate Mode: sculpt_uv.c.

This duplicates D2497. Yes sometimes it's easier to just do this ourselves, but it's more respectful of volunteers' time & effort to get their patches in.

Thu, Feb 16, 8:46 PM

Tue, Feb 14

Mike Erwin (merwin) added a comment to D2371: Converted mask_draw.c to new immediate mode.

Testing this now...

Tue, Feb 14, 7:10 PM
Mike Erwin (merwin) added a comment to rB6906a884eea2: Immediate Mode: make triangles smooth again.

I've got a good idea for this & ui_draw_anti_roundbox. Just need to translate my notes from graph paper to GLSL!

Tue, Feb 14, 4:08 PM
Mike Erwin (merwin) added a comment to rB31a21135cf72: Immediate Mode: area.c and UI_draw_icon_tri, ui_draw_anti_tria.

Drawing multiple times with jitter is a trick to get AA. Now that we have real shaders we should do this right. Don't focus on how to get jittering (obsolete technique) to work in the new API.

Tue, Feb 14, 4:01 PM

Sun, Feb 12

Mike Erwin (merwin) added a comment to D1193: BGE: Fix T29882: Add anti-aliasing filtering for fonts.

@Porteries Tristan (panzergame) Nothing like this is planned for the 2.8 3D viewport or 2D UI. We always draw screen-aligned text at a known size/scale.

Sun, Feb 12, 4:21 PM · Game Engine
Mike Erwin (merwin) added a comment to rB09bfc378895f: OpenGL: convert NLA editor to new imm mode.

@Joshua Leung (aligorith) ok, but explain why so it can be fixed.

Sun, Feb 12, 12:11 PM
Mike Erwin (merwin) committed rBb104057d001d: OpenGL: enable program point size for keyframes (authored by Mike Erwin (merwin)).
OpenGL: enable program point size for keyframes
Sun, Feb 12, 7:56 AM
Mike Erwin (merwin) committed rB09bfc378895f: OpenGL: convert NLA editor to new imm mode (authored by Mike Erwin (merwin)).
OpenGL: convert NLA editor to new imm mode
Sun, Feb 12, 7:37 AM

Sat, Feb 11

Mike Erwin (merwin) committed rBe008ca13f138: OpenGL: updated clip_utils.c to new immediate mode (authored by Mike Erwin (merwin)).
OpenGL: updated clip_utils.c to new immediate mode
Sat, Feb 11, 7:00 AM
Mike Erwin (merwin) closed D2391: OpenGL: updated clip_utils.c to new immediate mode.

Committed to blender2.8

Sat, Feb 11, 7:00 AM · Restricted Project
Mike Erwin (merwin) accepted D2391: OpenGL: updated clip_utils.c to new immediate mode.

Works fine now! See final commit for some small changes I made.

Sat, Feb 11, 6:42 AM · Restricted Project
Mike Erwin (merwin) abandoned D2373: OpenGL: updated keyframes_draw.c to new immediate mode.

This work made it into blender2.8 as part of a larger keyframe drawing overhaul. Thanks!

Sat, Feb 11, 6:34 AM · Restricted Project
Mike Erwin (merwin) committed rBbbc31e89292d: OpenGL: draw keyframe markers as point sprites (authored by Mike Erwin (merwin)).
OpenGL: draw keyframe markers as point sprites
Sat, Feb 11, 6:29 AM
Mike Erwin (merwin) committed rB768e4e991cc6: fix warning (authored by Mike Erwin (merwin)).
fix warning
Sat, Feb 11, 6:29 AM
Mike Erwin (merwin) committed rBa161d45cfb6d: add builtin GPU_SHADER_KEYFRAME_DIAMOND (authored by Mike Erwin (merwin)).
add builtin GPU_SHADER_KEYFRAME_DIAMOND
Sat, Feb 11, 6:29 AM
Mike Erwin (merwin) committed rBf7b1b87ba953: Gawain: minor cleanup (authored by Mike Erwin (merwin)).
Gawain: minor cleanup
Sat, Feb 11, 6:29 AM

Thu, Feb 9

Mike Erwin (merwin) closed D2438: Updates the tree element to use retained mode.

Pushed to blender2.8. Thanks!

Thu, Feb 9, 12:38 AM · Restricted Project
Mike Erwin (merwin) committed rBf2ea319316f8: OpenGL: outliner_draw_tree_element uses new imm mode (authored by Chaitanya (cyrax)).
OpenGL: outliner_draw_tree_element uses new imm mode
Thu, Feb 9, 12:38 AM
Mike Erwin (merwin) committed rB6444ba263529: added UI_GetThemeColorShade4ubv function (authored by Chaitanya (cyrax)).
added UI_GetThemeColorShade4ubv function
Thu, Feb 9, 12:38 AM
Mike Erwin (merwin) accepted D2438: Updates the tree element to use retained mode.
Thu, Feb 9, 12:30 AM · Restricted Project

Wed, Feb 8

Mike Erwin (merwin) added inline comments to D2438: Updates the tree element to use retained mode.
Wed, Feb 8, 9:13 PM · Restricted Project
Mike Erwin (merwin) closed D2437: Updating outliner_draw_hierarchy_lines to use retained mode.

Looks good, pushed to blender2.8

Wed, Feb 8, 9:06 PM · Restricted Project
Mike Erwin (merwin) committed rBb08483defa4a: Update outliner_draw_hierarchy_lines to use new imm mode (authored by Chaitanya (cyrax)).
Update outliner_draw_hierarchy_lines to use new imm mode
Wed, Feb 8, 9:04 PM
Mike Erwin (merwin) accepted D2437: Updating outliner_draw_hierarchy_lines to use retained mode.
Wed, Feb 8, 8:58 PM · Restricted Project
Mike Erwin (merwin) added inline comments to D2497: blender2.8: New immediate mode for sculpt_uv.c.
Wed, Feb 8, 8:51 PM · Restricted Project
Mike Erwin (merwin) closed D2433: Updates to outliner_draw_highlights_recursive under the blender2.8 branch.

It worked! Pushed to blender2.8

Wed, Feb 8, 8:40 PM · Restricted Project
Mike Erwin (merwin) committed rB525937cc397e: OpenGL: outliner_draw_highlights uses new imm mode (authored by Chaitanya (cyrax)).
OpenGL: outliner_draw_highlights uses new imm mode
Wed, Feb 8, 8:39 PM
Mike Erwin (merwin) added a task to rBa39a459a1ecb: OpenGL immediate mode: interface_draw.c (cont): T49043: replace OpenGL immediate mode in Blender 2.8.
Wed, Feb 8, 7:59 AM
Mike Erwin (merwin) added a commit to T49043: replace OpenGL immediate mode in Blender 2.8: rBa39a459a1ecb: OpenGL immediate mode: interface_draw.c (cont).
Wed, Feb 8, 7:59 AM · Restricted Project, OpenGL / Gfx
Mike Erwin (merwin) added inline comments to rBa39a459a1ecb: OpenGL immediate mode: interface_draw.c (cont).
Wed, Feb 8, 7:59 AM
Mike Erwin (merwin) committed rB2e36bebc7743: cleanup from recent commits (authored by Mike Erwin (merwin)).
cleanup from recent commits
Wed, Feb 8, 7:44 AM

Tue, Feb 7

Mike Erwin (merwin) committed rB5f47439cfd18: fix clang warning (authored by Mike Erwin (merwin)).
fix clang warning
Tue, Feb 7, 8:49 PM
Mike Erwin (merwin) updated subscribers of D2433: Updates to outliner_draw_highlights_recursive under the blender2.8 branch.

@Chaitanya (cyrax) do you use "arc diff" to submit these?

Tue, Feb 7, 8:46 PM · Restricted Project
Mike Erwin (merwin) added a comment to D2433: Updates to outliner_draw_highlights_recursive under the blender2.8 branch.

@Chaitanya (cyrax), I'm trying to commit this to blender2.8 under your name.

Tue, Feb 7, 7:16 PM · Restricted Project
Mike Erwin (merwin) accepted D2433: Updates to outliner_draw_highlights_recursive under the blender2.8 branch.
Tue, Feb 7, 6:48 PM · Restricted Project
Mike Erwin (merwin) added a task to D2438: Updates the tree element to use retained mode: T49043: replace OpenGL immediate mode in Blender 2.8.
Tue, Feb 7, 5:45 PM · Restricted Project
Mike Erwin (merwin) added a revision to T49043: replace OpenGL immediate mode in Blender 2.8: D2438: Updates the tree element to use retained mode.
Tue, Feb 7, 5:45 PM · Restricted Project, OpenGL / Gfx
Mike Erwin (merwin) added a revision to T49043: replace OpenGL immediate mode in Blender 2.8: D2437: Updating outliner_draw_hierarchy_lines to use retained mode.
Tue, Feb 7, 5:42 PM · Restricted Project, OpenGL / Gfx
Mike Erwin (merwin) added a task to D2437: Updating outliner_draw_hierarchy_lines to use retained mode: T49043: replace OpenGL immediate mode in Blender 2.8.
Tue, Feb 7, 5:42 PM · Restricted Project
Mike Erwin (merwin) added a task to D2433: Updates to outliner_draw_highlights_recursive under the blender2.8 branch: T49043: replace OpenGL immediate mode in Blender 2.8.
Tue, Feb 7, 5:42 PM · Restricted Project
Mike Erwin (merwin) added a revision to T49043: replace OpenGL immediate mode in Blender 2.8: D2433: Updates to outliner_draw_highlights_recursive under the blender2.8 branch.
Tue, Feb 7, 5:42 PM · Restricted Project, OpenGL / Gfx
Mike Erwin (merwin) committed rB97fa285ae1b9: OpenGL: add gpuMatrixUpdate_legacy function (authored by Mike Erwin (merwin)).
OpenGL: add gpuMatrixUpdate_legacy function
Tue, Feb 7, 5:25 AM
Mike Erwin (merwin) committed rB6c95e97e64fa: OpenGL: convert clip_dopesheet_draw to new imm mode (authored by Mike Erwin (merwin)).
OpenGL: convert clip_dopesheet_draw to new imm mode
Tue, Feb 7, 5:25 AM
Mike Erwin (merwin) committed rBd23c57b84cbb: fix unused var warnings (authored by Mike Erwin (merwin)).
fix unused var warnings
Tue, Feb 7, 5:25 AM

Mon, Feb 6

Mike Erwin (merwin) added a comment to T50531: Blender closes when reduced to icon, Windows 10.

@Dario (Joysurrender) please attach system-info.txt (from Blender's Help menu).

Mon, Feb 6, 12:00 AM · BF Blender

Sun, Feb 5

Mike Erwin (merwin) committed rBc3e2faaad540: BLF: simplify API for default font (authored by Mike Erwin (merwin)).
BLF: simplify API for default font
Sun, Feb 5, 7:17 AM
Mike Erwin (merwin) committed rB5ad5bb235bf8: fix most UI text color (authored by Mike Erwin (merwin)).
fix most UI text color
Sun, Feb 5, 7:17 AM
Mike Erwin (merwin) committed rB590838201120: add BLF_default function (authored by Mike Erwin (merwin)).
add BLF_default function
Sun, Feb 5, 7:17 AM
Mike Erwin (merwin) added a comment to T50493: GLSL Shading with Textured shading caused UI freezing.

Why are you running software GL? Your hardware is definitely capable of running Blender.

Sun, Feb 5, 1:43 AM · OpenGL / Gfx, BF Blender
Mike Erwin (merwin) committed rB627566cb9ac7: OpenGL: use GL4 on Linux when available (authored by Mike Erwin (merwin)).
OpenGL: use GL4 on Linux when available
Sun, Feb 5, 1:38 AM

Sat, Feb 4

Mike Erwin (merwin) added a comment to T50493: GLSL Shading with Textured shading caused UI freezing.

@Bohdan (bvk888) this happens even with default cube & no textures/materials, correct?

Sat, Feb 4, 7:29 AM · OpenGL / Gfx, BF Blender

Fri, Feb 3

Mike Erwin (merwin) added a comment to T50583: graphic glitches on MacBook Pro 2016.

@Fabien Maroy (FabStudio) please update the Broken and Worked fields in description. Are you seeing this problem on latest version 2.78a?

Fri, Feb 3, 12:02 AM · OpenGL / Gfx, BF Blender

Thu, Feb 2

Mike Erwin (merwin) added a comment to T50121: downsampling artifacts on hard edges of a proceduraly mapped texture..

I see the same artifacts on Intel graphics. Will look into it.

Thu, Feb 2, 6:43 AM · OpenGL / Gfx, BF Blender
Mike Erwin (merwin) closed D2486: Converted clip_dopesheet_draw.c to new immediate mode. (Part of T49043).

Minor inconvenience! committed to blender2.8

Thu, Feb 2, 6:00 AM · Restricted Project
Mike Erwin (merwin) accepted D2486: Converted clip_dopesheet_draw.c to new immediate mode. (Part of T49043).
Thu, Feb 2, 4:39 AM · Restricted Project
Mike Erwin (merwin) committed rB8e05a5bf8c37: fix build: BLF Theme color (authored by Mike Erwin (merwin)).
fix build: BLF Theme color
Thu, Feb 2, 1:01 AM

Wed, Feb 1

Mike Erwin (merwin) committed rB4935e2449b2c: BLF can use Theme colors (authored by Mike Erwin (merwin)).
BLF can use Theme colors
Wed, Feb 1, 10:44 PM
Mike Erwin (merwin) committed rB7493a2b3c090: set default color for BLF fonts (authored by Mike Erwin (merwin)).
set default color for BLF fonts
Wed, Feb 1, 10:22 PM
Mike Erwin (merwin) committed rBba551014f8fc: add BLF_color functions (authored by Mike Erwin (merwin)).
add BLF_color functions
Wed, Feb 1, 10:22 PM
Mike Erwin (merwin) added a comment to D2486: Converted clip_dopesheet_draw.c to new immediate mode. (Part of T49043).

"arc patch D2486" fails for me. Somehow your earlier commit is not included, but I see its effects here...
Do you have commit rights? If so you can push these changes.
If not, either figure out how to fix in Phabricator/Arcanist or attach the final clip_dopesheet_draw.c here.

Wed, Feb 1, 8:41 PM · Restricted Project
Mike Erwin (merwin) committed rBbe72d7a9f503: OpenGL: use new matrix API for Loop Cut (authored by Mike Erwin (merwin)).
OpenGL: use new matrix API for Loop Cut
Wed, Feb 1, 12:22 AM
Mike Erwin (merwin) committed rBadb422e5005b: OpenGL: fix MultMatrix order (authored by Mike Erwin (merwin)).
OpenGL: fix MultMatrix order
Wed, Feb 1, 12:22 AM

Tue, Jan 31

Mike Erwin (merwin) requested changes to D2486: Converted clip_dopesheet_draw.c to new immediate mode. (Part of T49043).

Looks good for the most part! One change needed for BLF compatibility.

Tue, Jan 31, 10:29 AM · Restricted Project
Mike Erwin (merwin) added inline comments to D2485: blender 2.8: OpenGL immediate mode: view3d_ruler.c.
Tue, Jan 31, 10:17 AM · Restricted Project
Mike Erwin (merwin) added a comment to D2485: blender 2.8: OpenGL immediate mode: view3d_ruler.c.

You're right about glColor being used by BLF. I've got BLF_color implemented, will commit soon!

Tue, Jan 31, 10:14 AM · Restricted Project
Mike Erwin (merwin) added a comment to D2484: blender 2.8: OpenGL immediate mode: drawanimviz.c.

Looks good so far, expecting your planned changes to be good also.

Tue, Jan 31, 10:05 AM · Restricted Project
Mike Erwin (merwin) added a comment to D2482: blender 2.8: OpenGL immediate mode: transform_generics.c.

@Luca Rood (LucaRood) just remember to "arc land --onto blender2.8"

Tue, Jan 31, 9:56 AM · Restricted Project
Mike Erwin (merwin) accepted D2482: blender 2.8: OpenGL immediate mode: transform_generics.c.

@Luca Rood (LucaRood) You can land accepted revisions since you have commit access.

Tue, Jan 31, 9:55 AM · Restricted Project
Mike Erwin (merwin) added inline comments to D2481: blender 2.8: OpenGL immediate mode: editmesh_knife.c.
Tue, Jan 31, 9:43 AM · Restricted Project
Mike Erwin (merwin) closed D2480: blender 2.8: OpenGL immediate mode: editmesh_loopcut.c.

Landed in blender2.8

Tue, Jan 31, 9:14 AM · Restricted Project
Mike Erwin (merwin) committed rB85174329d9f5: blender 2.8: OpenGL immediate mode: editmesh_loopcut.c (authored by Mike Erwin (merwin)).
blender 2.8: OpenGL immediate mode: editmesh_loopcut.c
Tue, Jan 31, 9:08 AM
Mike Erwin (merwin) committed rBb997914f8074: OpenGL: remove NPOT texture rescaling logic (authored by Mike Erwin (merwin)).
OpenGL: remove NPOT texture rescaling logic
Tue, Jan 31, 8:55 AM

Sun, Jan 29

Mike Erwin (merwin) added inline comments to D2371: Converted mask_draw.c to new immediate mode.
Sun, Jan 29, 5:08 PM
Mike Erwin (merwin) added a comment to D2486: Converted clip_dopesheet_draw.c to new immediate mode. (Part of T49043).

Looks good! I can test it tomorrow.

Sun, Jan 29, 4:49 PM · Restricted Project

Sat, Jan 28

Mike Erwin (merwin) accepted D2480: blender 2.8: OpenGL immediate mode: editmesh_loopcut.c.
Sat, Jan 28, 2:51 PM · Restricted Project

Wed, Jan 25

Mike Erwin (merwin) awarded rB99cfad6a0157: Convert MBC_ API to Mesh (instead of derived mesh) and move it to mesh_render a Doubloon token.
Wed, Jan 25, 4:22 PM

Tue, Jan 24

Mike Erwin (merwin) added inline comments to D2476: Convert MBC_ API to Mesh (instead of derived mesh) and move it to mesh_render.
Tue, Jan 24, 5:08 PM
Mike Erwin (merwin) added a comment to D2476: Convert MBC_ API to Mesh (instead of derived mesh) and move it to mesh_render.

Looks good! Thanks for going ahead with this.

Tue, Jan 24, 4:53 PM

Mon, Jan 23

Mike Erwin (merwin) added a comment to D2457: UPBGE.

Right, C++11 and C99 are finally available on all the platforms/compilers we target. I use C++11 in other projects and am a big fan.

Mon, Jan 23, 10:55 PM
Mike Erwin (merwin) added a comment to T50408: Port EXCEPTION_ACCESS_VIOLATION fix to 2.76b.

For the 2nd message, go to UserPrefs > System > Window Draw Method and choose another method.

Mon, Jan 23, 5:27 PM · BF Blender
Mike Erwin (merwin) added a comment to T50408: Port EXCEPTION_ACCESS_VIOLATION fix to 2.76b.

Cool! I'm guessing there is an image containing all icons which exceeds the reported texture size limit of 512x512. But that is just a guess.

Mon, Jan 23, 12:12 PM · BF Blender

Jan 21 2017

Mike Erwin (merwin) added a comment to T50408: Port EXCEPTION_ACCESS_VIOLATION fix to 2.76b.

From those reports it seems you have no Intel driver running. Grab it here:
https://downloadcenter.intel.com/product/81503/Intel-HD-Graphics-for-Previous-Generation-Intel-Processors

Jan 21 2017, 8:35 PM · BF Blender

Jan 20 2017

Mike Erwin (merwin) added a comment to T50408: Port EXCEPTION_ACCESS_VIOLATION fix to 2.76b.

I wrote a simple OpenGL info program. @anatoly techtonik (techtonik) please run this and attach OpenGLinfo.txt it generates. That will give us more info about your system & help us decide what to do.

Jan 20 2017, 10:23 PM · BF Blender
Mike Erwin (merwin) added a comment to rB8aa8165e85d4: OpenGL: convert legacy calls in transform.c.

@Darwin Yip (darwin) I think immVertex2s will be useful in the future, so let's keep it! Did not use it here because switching between 2f and 2s was tricky to get right. Would like to replace these arrows with a high-quality bitmap one day.

Jan 20 2017, 5:22 AM
Mike Erwin (merwin) added a comment to D2469: clip_draw.c immediate coding.

Formatting looks a little weird. Use tabs and make sure indentation matches surrounding code.

Jan 20 2017, 3:42 AM

Jan 19 2017

Mike Erwin (merwin) added a comment to D2373: OpenGL: updated keyframes_draw.c to new immediate mode.

@Dalai Felinto (dfelinto),@Antonio Vazquez (antoniov) No, it's not ready. I'm investigating ways to do this right.

Jan 19 2017, 9:12 AM · Restricted Project
Mike Erwin (merwin) closed D2359: Blender 2.8: OpenGL immediate mode: transform.
Jan 19 2017, 6:58 AM · Restricted Project
Mike Erwin (merwin) accepted D2359: Blender 2.8: OpenGL immediate mode: transform.

Put pieces of this into blender2.8. Thanks!

Jan 19 2017, 6:57 AM · Restricted Project