Mike Erwin (merwin)
User

Projects

User Since
Apr 27 2010, 10:07 PM (326 w, 1 d)

Recent Activity

Sat, Jul 23

Mike Erwin (merwin) committed rBbd11d917c19a: fix atan2f input conditional (authored by Mike Erwin (merwin)).
fix atan2f input conditional
Sat, Jul 23, 3:02 AM

Fri, Jul 22

Mike Erwin (merwin) committed rBa7e742f9c4ab: use bool consistently, fix redundant conditional (authored by Mike Erwin (merwin)).
use bool consistently, fix redundant conditional
Fri, Jul 22, 8:19 AM
Mike Erwin (merwin) committed rB2b77b1ce465a: remove double-checked conditions (authored by Mike Erwin (merwin)).
remove double-checked conditions
Fri, Jul 22, 8:19 AM
Mike Erwin (merwin) added a comment to T48917: PVS-Studio team is about to produce a technical breakthrough, but for now let's recheck Blender .

Reusing i for inner & outer loops had already been fixed in BM_face_exists_overlap_subset.

Fri, Jul 22, 1:03 AM · BF Blender
Mike Erwin (merwin) committed rB08e1bba10c17: fix confusing operator precedence (authored by Mike Erwin (merwin)).
fix confusing operator precedence
Fri, Jul 22, 12:53 AM
Mike Erwin (merwin) committed rB9ff8d4a95786: fix enum type / values mismatch (authored by Mike Erwin (merwin)).
fix enum type / values mismatch
Fri, Jul 22, 12:53 AM
Mike Erwin (merwin) committed rB7c99b7110e89: fix null pointer dereferences (authored by Mike Erwin (merwin)).
fix null pointer dereferences
Fri, Jul 22, 12:16 AM
Mike Erwin (merwin) committed rB23f1b2073f4a: fix comparison of identicals (authored by Mike Erwin (merwin)).
fix comparison of identicals
Fri, Jul 22, 12:16 AM

Thu, Jul 21

Mike Erwin (merwin) committed rB6ebce7e9480c: fix typo in condition (authored by Mike Erwin (merwin)).
fix typo in condition
Thu, Jul 21, 9:54 PM
Mike Erwin (merwin) added a comment to T48917: PVS-Studio team is about to produce a technical breakthrough, but for now let's recheck Blender .
if(m_cols!=m_cols)  m_scaledMatrix.resize(rows,cols);

Has already been fixed upstream in Eigen.
http://eigen.tuxfamily.org/bz/show_bug.cgi?id=1134

Thu, Jul 21, 9:53 PM · BF Blender
Mike Erwin (merwin) committed rB9279bee58302: remove repeated codec-supports-alpha check (authored by Mike Erwin (merwin)).
remove repeated codec-supports-alpha check
Thu, Jul 21, 7:51 PM
Mike Erwin (merwin) added a comment to T48917: PVS-Studio team is about to produce a technical breakthrough, but for now let's recheck Blender .

While not a "bug" we do appreciate the writeup. I'll go through the suspicious fragments and fix if needed.

Thu, Jul 21, 5:44 PM · BF Blender

Fri, Jul 8

Mike Erwin (merwin) committed rBL61689: fixed filenames of OpenEXR debug libs.
fixed filenames of OpenEXR debug libs
Fri, Jul 8, 5:26 AM
Mike Erwin (merwin) committed rBfa1abf564e9d: update "bound" flag of GPU strand shaders (authored by Mike Erwin (merwin)).
update "bound" flag of GPU strand shaders
Fri, Jul 8, 3:04 AM
Mike Erwin (merwin) committed rBf037fdfa5306: initialize variables before use (authored by Mike Erwin (merwin)).
initialize variables before use
Fri, Jul 8, 1:51 AM

Mon, Jul 4

Mike Erwin (merwin) added a comment to T48772: 3D View shading issue dependent on Normal map channel.

Broken in the official 2.77 (no letter) release, so it was before that.

Mon, Jul 4, 7:17 PM · BF Blender
Mike Erwin (merwin) added a comment to T48772: 3D View shading issue dependent on Normal map channel.

Confirmed broken on nVidia + Mac.
Works fine on Intel + Mac same system.

Mon, Jul 4, 7:06 PM · BF Blender
Mike Erwin (merwin) added a comment to T48772: 3D View shading issue dependent on Normal map channel.

Yes my Mac is the previous year's model, with Intel HD 4000 + NV 750M. Will check it out.

Mon, Jul 4, 6:58 PM · BF Blender

Fri, Jul 1

Mike Erwin (merwin) raised a concern with rB0a026033ae46: BMesh: make toolflags optional.

Breaks build on Mac / clang.

Fri, Jul 1, 6:55 PM

Jun 27 2016

Mike Erwin (merwin) added a comment to T38384: Layer Manager.

I don't understand the unification of Layers (for grouping objects) with Render Layers. To me they seem like totally separate topics.

Jun 27 2016, 4:51 AM · BF Blender, User Interface
Mike Erwin (merwin) added a comment to T38384: Layer Manager.

Viewport as Render Engine
At least with the way current render engine API works, it's not a good fit for the viewport. Having two render engines (e.g. Viewport and Cycles) active at the same time does not fit the current design either. It would be good to have a realtime render engine as a choice in the render engine menu, so that e.g. F12 renders that way. But the viewport still needs to operate outside of that too.

Jun 27 2016, 4:47 AM · BF Blender, User Interface

Jun 11 2016

Mike Erwin (merwin) claimed T48625: Blender cannot interpret Right Click for Wacom Tablet.

Sure, I'm familiar with this code & have some Wacom gear at home.

Jun 11 2016, 8:42 PM · Platform: Mac OS X, BF Blender

May 29 2016

Mike Erwin (merwin) added a comment to T47630: Blender always crash Mac Book 2007, 2GB, Mac OS X 10.7.5.

Hey @Chau (BlenderNavi) I'm looking at this again. You are not forgotten!

May 29 2016, 8:05 AM · BF Blender

May 27 2016

Mike Erwin (merwin) committed rBbd678f179b3e: ndof: detect SpaceMouse Enterprise (authored by Mike Erwin (merwin)).
ndof: detect SpaceMouse Enterprise
May 27 2016, 9:49 PM
Mike Erwin (merwin) committed rB1e32951477ec: OpenGL: use EXT version of FBOs (authored by Mike Erwin (merwin)).
OpenGL: use EXT version of FBOs
May 27 2016, 6:20 AM

May 24 2016

Mike Erwin (merwin) committed rB886349fd9828: ndof: build system cleanup (authored by Mike Erwin (merwin)).
ndof: build system cleanup
May 24 2016, 7:57 AM
Mike Erwin (merwin) committed rB84e083953798: ndof: enable Linux support by default, unless libs missing (authored by Mike Erwin (merwin)).
ndof: enable Linux support by default, unless libs missing
May 24 2016, 6:36 AM
Mike Erwin (merwin) updated subscribers of D2014: Cycles: Support bump mapping in GLSL viewport.
May 24 2016, 6:27 AM
Mike Erwin (merwin) awarded D2014: Cycles: Support bump mapping in GLSL viewport a Mountain of Wealth token.
May 24 2016, 6:27 AM

May 22 2016

Mike Erwin (merwin) committed rB9bf09200d29f: ndof: simplify Mac build (authored by Mike Erwin (merwin)).
ndof: simplify Mac build
May 22 2016, 12:30 AM

Apr 27 2016

Mike Erwin (merwin) added a comment to D1958: Flat shading for basic shader.

I don't know if there is a drawback in practice. We are generally CPU bound, and doing this in the fragment shader might end up being faster in some cases due to simpler CPU side code, even if it's more work for the GPU? It also lets us use indexed buffers more easily, which has performance benefits too.

Apr 27 2016, 9:36 PM
Mike Erwin (merwin) added a comment to D1958: Flat shading for basic shader.

Did you receive the email thread titled "[Bf-viewport] OpenGL refactoring tasks"? From 11 Dec 2015. We discussed flat shading with the dFdx approach. I still think it's a bad approach but some parts of this patch are good improvements.

Apr 27 2016, 4:07 PM

Apr 22 2016

Mike Erwin (merwin) edited the description of T48238: Viewport Project: Wireframes for Blender 2.8.
Apr 22 2016, 4:27 PM · BF Blender
Mike Erwin (merwin) added a comment to T48238: Viewport Project: Wireframes for Blender 2.8.

To clarify the scope of this design task:

Apr 22 2016, 4:24 PM · BF Blender

Apr 7 2016

Mike Erwin (merwin) accepted D1880: Wide lines + line stipple deprecated API replacement.

Looks good! I wanted to test it on Mac before giving the OK but have been busy. Go ahead and commit then we'll clean up any rough edges later.

Apr 7 2016, 10:48 PM
Mike Erwin (merwin) claimed T47630: Blender always crash Mac Book 2007, 2GB, Mac OS X 10.7.5.

I'll dig into the problem and provide test builds to @Chau (BlenderNavi) if needed.

Apr 7 2016, 7:45 PM · BF Blender

Mar 28 2016

Mike Erwin (merwin) added a comment to D1880: Wide lines + line stipple deprecated API replacement.

Going forward, code like this should target the Blender 2.8 release. That's when we'll have GLSL 1.5 and guaranteed geometry shader support. Blender 2.7x will stay at OpenGL 2.1 + extensions.

Mar 28 2016, 5:24 PM

Mar 3 2016

Mike Erwin (merwin) updated subscribers of T47639: OpenGL render with smoke and fire incorrect when using transparency .

@Kévin Dietrich (kevindietrich) This is your area, right?

Mar 3 2016, 7:41 PM · BF Blender: Regressions, BF Blender
Mike Erwin (merwin) updated subscribers of T47639: OpenGL render with smoke and fire incorrect when using transparency .
Mar 3 2016, 7:38 PM · BF Blender: Regressions, BF Blender

Mar 1 2016

Mike Erwin (merwin) added a comment to D1828: Add an option to draw volume that represent camera frustum in the viewport.

The GL state usage looks good to me. It's more important to set the items you mentioned to their default values. Restoring their previous values with glGet is a performance killer! And not needed most of the time.

Mar 1 2016, 10:32 PM · BF Blender
Mike Erwin (merwin) added a comment to T47630: Blender always crash Mac Book 2007, 2GB, Mac OS X 10.7.5.

Intel GMA950 is an OpenGL 1.4 part, but MacOS has a software fallback for whatever the GPU can't handle. That means OpenGL 2.1 is always supported and available but you're running in software.

Mar 1 2016, 4:24 PM · BF Blender

Feb 27 2016

Mike Erwin (merwin) claimed T47592: Wireframe on custom shape of bones.
Feb 27 2016, 12:16 AM · BF Blender

Feb 26 2016

Mike Erwin (merwin) added a comment to T47586: Nurbs Edit Handle thickness regression.

Feel free to assign line thickness bugs to me as well. Clean up my own mess :|

Feb 26 2016, 5:40 PM · BF Blender
Mike Erwin (merwin) updated subscribers of T47586: Nurbs Edit Handle thickness regression.
Feb 26 2016, 5:37 PM · BF Blender

Feb 19 2016

Mike Erwin (merwin) updated subscribers of T47454: The line thickness of curve, paths, nurbs, etc. is wrong.
Feb 19 2016, 1:25 AM · BF Blender

Feb 11 2016

Mike Erwin (merwin) added a comment to D1786: Mirror influence of environment texture in Blender viewport.

This looks great!

Feb 11 2016, 11:09 PM

Feb 5 2016

Mike Erwin (merwin) added a comment to T47331: 3D view Display - bug with AO.

Are you sure about the 0.2 samples? Mine only allows 1, 2, 3 and so on.

Feb 5 2016, 5:21 PM · OpenGL / Gfx, BF Blender

Feb 2 2016

Mike Erwin (merwin) added a comment to T47281: Blender crashes randomly on freshly installed windows 10 (OpenGL).

Viktor already installed the latest driver, so it's not a problem of being out-of-date.

Feb 2 2016, 6:14 PM · BF Blender

Jan 30 2016

Mike Erwin (merwin) added a comment to T47281: Blender crashes randomly on freshly installed windows 10 (OpenGL).

This doesn't point to anything specific... I'll stick an nVidia card (Quadro K600) in my Windows test machine and try to reproduce.

Jan 30 2016, 7:06 PM · BF Blender

Jan 29 2016

Mike Erwin (merwin) added a comment to D1753: Some tests to modernize the UI OpenGL interface..

I redid some of this code recently and am glad to see @Kévin Dietrich (kevindietrich) take it even further.

Jan 29 2016, 11:11 PM

Jan 28 2016

Mike Erwin (merwin) committed rB30086eafe521: OpenGL: optimize ED_screen_draw (authored by Mike Erwin (merwin)).
OpenGL: optimize ED_screen_draw
Jan 28 2016, 8:52 AM
Mike Erwin (merwin) committed rBf91fe78af514: cleanup: spelling, comments, alignment (authored by Mike Erwin (merwin)).
cleanup: spelling, comments, alignment
Jan 28 2016, 7:37 AM
Mike Erwin (merwin) committed rBa1d7f67d81bd: cleanup: spelling / typos (authored by Mike Erwin (merwin)).
cleanup: spelling / typos
Jan 28 2016, 6:31 AM
Mike Erwin (merwin) added inline comments to D1120: Normal Map node support for GLSL mode and the internal render (multiple tangents support).
Jan 28 2016, 6:29 AM

Jan 27 2016

Mike Erwin (merwin) committed rB499bde810598: NDOF: enable 3D mouse support on Mac by default (authored by Mike Erwin (merwin)).
NDOF: enable 3D mouse support on Mac by default
Jan 27 2016, 3:10 AM
Mike Erwin (merwin) accepted D1414: World textures displaying for viewport in BI..
Jan 27 2016, 2:42 AM · BF Blender: Next, OpenGL / Gfx, Rendering
Mike Erwin (merwin) awarded rBa48a66fb19e7: A few urgent glLineWidth fixes for anim editors a Piece of Eight token.
Jan 27 2016, 12:52 AM

Jan 26 2016

Mike Erwin (merwin) added inline comments to D1414: World textures displaying for viewport in BI..
Jan 26 2016, 6:54 AM · BF Blender: Next, OpenGL / Gfx, Rendering

Jan 23 2016

Mike Erwin (merwin) committed rB705e6d76fbbf: OpenGL: tiny state-change fix (authored by Mike Erwin (merwin)).
OpenGL: tiny state-change fix
Jan 23 2016, 8:30 AM
Mike Erwin (merwin) committed rB275abd14a096: OpenGL: combine multiple GL_LINES into fewer draw calls (authored by Mike Erwin (merwin)).
OpenGL: combine multiple GL_LINES into fewer draw calls
Jan 23 2016, 8:30 AM
Mike Erwin (merwin) committed rBe25ba162c0b6: OpenGL: call glLineWidth less often (authored by Mike Erwin (merwin)).
OpenGL: call glLineWidth less often
Jan 23 2016, 7:04 AM

Jan 22 2016

Mike Erwin (merwin) added a comment to T47221: Sculpt error: hide border.

Cool, I was unaware of this feature. The release notes mention it only works in solid shading mode. It also affects edit mode -- hidden parts remain hidden.

Jan 22 2016, 9:30 PM · Sculpting and Painting, BF Blender
Mike Erwin (merwin) added a comment to T46866: OpenSubdiv meshes ignore the clipping rectangle set with Alt-B.

Sure I'll take this one. I think it's important to have zero performance impact when clipping is off (vast majority of usage).

Jan 22 2016, 9:09 PM · BF Blender
Mike Erwin (merwin) committed rB8c596e08e7b7: OpenGL: remove unneeded state changes (authored by Mike Erwin (merwin)).
OpenGL: remove unneeded state changes
Jan 22 2016, 8:53 AM
Mike Erwin (merwin) committed rBf2fdec3ab7e7: OpenGL: remove glGet with unused result (authored by Mike Erwin (merwin)).
OpenGL: remove glGet with unused result
Jan 22 2016, 8:53 AM
Mike Erwin (merwin) committed rB66d9efe76562: OpenGL: draw box outlines with lines, not rectangles (authored by Mike Erwin (merwin)).
OpenGL: draw box outlines with lines, not rectangles
Jan 22 2016, 8:53 AM
Mike Erwin (merwin) committed rB1d88773b1f2e: OpenGL: cleanup (authored by Mike Erwin (merwin)).
OpenGL: cleanup
Jan 22 2016, 8:53 AM
Mike Erwin (merwin) committed rB24f05bb9177a: OpenGL: remove extra vertex in arrowhead (authored by Mike Erwin (merwin)).
OpenGL: remove extra vertex in arrowhead
Jan 22 2016, 8:53 AM
Mike Erwin (merwin) committed rB4c6836401e97: OpenGL: pull glBegin/End out of loops (authored by Mike Erwin (merwin)).
OpenGL: pull glBegin/End out of loops
Jan 22 2016, 8:53 AM
Mike Erwin (merwin) committed rB8e35657beb59: OpenGL: fewer state changes for wireframe PBVH (authored by Mike Erwin (merwin)).
OpenGL: fewer state changes for wireframe PBVH
Jan 22 2016, 3:08 AM

Jan 18 2016

Mike Erwin (merwin) committed rBd48c328b725d: OpenGL: remove ARB_fragment_program comment (authored by Mike Erwin (merwin)).
OpenGL: remove ARB_fragment_program comment
Jan 18 2016, 5:30 AM

Jan 16 2016

Mike Erwin (merwin) committed rBddc75d7e8a04: OpenGL: remove redundant state change (authored by Mike Erwin (merwin)).
OpenGL: remove redundant state change
Jan 16 2016, 8:20 AM
Mike Erwin (merwin) committed rB384a16bfbc80: cleanup: C99 (authored by Mike Erwin (merwin)).
cleanup: C99
Jan 16 2016, 8:20 AM
Mike Erwin (merwin) committed rBa29e2c379e6a: OpenGL: simplify some UI draw calls (authored by Mike Erwin (merwin)).
OpenGL: simplify some UI draw calls
Jan 16 2016, 7:20 AM
Mike Erwin (merwin) committed rBf4cd7ca9c63c: OpenGL: pull glBegin/End out of loop (authored by Mike Erwin (merwin)).
OpenGL: pull glBegin/End out of loop
Jan 16 2016, 7:20 AM
Mike Erwin (merwin) committed rB2d71d13ea2cb: OpenGL: fixes related to GL_POINTS (authored by Mike Erwin (merwin)).
OpenGL: fixes related to GL_POINTS
Jan 16 2016, 5:52 AM
Mike Erwin (merwin) raised a concern with rB70e16b3c99d3: Fix T47181: Blender OSL script node crash (OSL 1.6.9).

Could not build on Mac after pulling the latest changes. Error points to here! Disabled CYCLES_OSL and am back in business.

Jan 16 2016, 5:46 AM

Jan 15 2016

Mike Erwin (merwin) added a comment to T46962: Empty-Image does not work on iMac Mid 2011 wit Mac OS X 10.11.2.

Disabling alpha test when U.glalphaclip == 0 is another approach. Visually it's the same as discarding alpha 0 pixels. I'll do some experiments & see what works well.

Jan 15 2016, 1:52 AM · OpenGL / Gfx, BF Blender

Jan 10 2016

Mike Erwin (merwin) added a comment to T47128: All images lose color and open in solid white..

Hrm. It just happened that one time for me. Image displaying fine now.

Jan 10 2016, 4:44 AM · Platform: Mac OS X, BF Blender

Jan 9 2016

Mike Erwin (merwin) added a comment to T47128: All images lose color and open in solid white..

@Willem Odendaal (dexon) Did you see the problem on official 2.76b or a custom build?

Jan 9 2016, 7:54 PM · Platform: Mac OS X, BF Blender
Mike Erwin (merwin) claimed T47128: All images lose color and open in solid white..

Yep, I'm seeing this on my Mac (geforce GT 650M).
Images appear white in trunk/master.
Appear normal in 2.76b on same machine.

Jan 9 2016, 7:46 PM · Platform: Mac OS X, BF Blender

Jan 7 2016

Mike Erwin (merwin) committed rB2643b57f9789: OpenGL: remove obsolete version check (authored by Mike Erwin (merwin)).
OpenGL: remove obsolete version check
Jan 7 2016, 11:41 PM
Mike Erwin (merwin) added a comment to D1707: OpenGL: remove some hacks/workarounds.

I was only able to track the GL_POINTS hack to January 2008. Wow... exactly 8 years ago!

Jan 7 2016, 10:49 PM
Mike Erwin (merwin) committed rB0e695f671af0: cleanup: C99 (authored by Mike Erwin (merwin)).
cleanup: C99
Jan 7 2016, 10:39 PM
Mike Erwin (merwin) committed rB1aff22b81d7c: OpenGL: use best available mipmap gen function (authored by Mike Erwin (merwin)).
OpenGL: use best available mipmap gen function
Jan 7 2016, 10:39 PM
Mike Erwin (merwin) committed rBf01f74d5dd26: cleanup: C99 (authored by Mike Erwin (merwin)).
cleanup: C99
Jan 7 2016, 10:39 PM
Mike Erwin (merwin) committed rB0df1bdc26832: OpenGL: fix max texture anisotropy check (authored by Mike Erwin (merwin)).
OpenGL: fix max texture anisotropy check
Jan 7 2016, 10:39 PM
Mike Erwin (merwin) committed rB290b0a97ba6b: cleanup: OpenGL comment (authored by Mike Erwin (merwin)).
cleanup: OpenGL comment
Jan 7 2016, 10:39 PM
Mike Erwin (merwin) committed rB77641c28ef80: OpenGL: remove some hacks/workarounds (authored by Mike Erwin (merwin)).
OpenGL: remove some hacks/workarounds
Jan 7 2016, 10:39 PM
Mike Erwin (merwin) committed rBe20b30a1d857: OpenGL: remove glPointSize hack (authored by Mike Erwin (merwin)).
OpenGL: remove glPointSize hack
Jan 7 2016, 10:39 PM
Mike Erwin (merwin) closed D1707: OpenGL: remove some hacks/workarounds by committing rB77641c28ef80: OpenGL: remove some hacks/workarounds.
Jan 7 2016, 10:38 PM
Mike Erwin (merwin) updated subscribers of D1707: OpenGL: remove some hacks/workarounds.
Jan 7 2016, 3:57 PM

Jan 6 2016

Mike Erwin (merwin) added a comment to T47128: All images lose color and open in solid white..

FYI -- I made small changes to image drawing code recently, after 2.76b was released.

Jan 6 2016, 9:26 PM · Platform: Mac OS X, BF Blender

Jan 5 2016

Mike Erwin (merwin) committed rB0a9935cb285b: OpenGL: various small optimizations (authored by Mike Erwin (merwin)).
OpenGL: various small optimizations
Jan 5 2016, 7:36 AM

Jan 4 2016

Mike Erwin (merwin) created D1707: OpenGL: remove some hacks/workarounds.
Jan 4 2016, 11:15 AM
Mike Erwin (merwin) committed rB1eb5e0b6608b: minor cleanup (authored by Mike Erwin (merwin)).
minor cleanup
Jan 4 2016, 7:46 AM
Mike Erwin (merwin) committed rBd2b4f9c627e6: OpenGL: image drawing tweaks (authored by Mike Erwin (merwin)).
OpenGL: image drawing tweaks
Jan 4 2016, 7:46 AM
Mike Erwin (merwin) committed rBed2daace76c0: minor cleanup: typos (authored by Mike Erwin (merwin)).
minor cleanup: typos
Jan 4 2016, 7:28 AM
Mike Erwin (merwin) committed rB2e8a8403079e: OpenGL: GPU_legacy_support workaround for nVidia (authored by Mike Erwin (merwin)).
OpenGL: GPU_legacy_support workaround for nVidia
Jan 4 2016, 7:28 AM

Dec 27 2015

Mike Erwin (merwin) added a comment to T46962: Empty-Image does not work on iMac Mid 2011 wit Mac OS X 10.11.2.

Also try exactly 1.0 since that disables the OpenGL alpha test.

Dec 27 2015, 4:18 AM · OpenGL / Gfx, BF Blender