Mike Erwin (merwin)
Animal

Projects

User Details

User Since
Apr 27 2010, 10:07 PM (390 w, 3 d)

Recent Activity

Sat, Sep 23

Mike Erwin (merwin) awarded T52807: Proposal: Remove macos quicktime exporter a Doubloon token.
Sat, Sep 23, 12:59 AM · Platform: Mac OS X, BF Blender: 2.8

Aug 30 2017

Mike Erwin (merwin) added inline comments to rB480def9c5587: Fix T52591: OpenColorIO not working correct with OpenGL core profile on macOS..
Aug 30 2017, 8:08 PM
Mike Erwin (merwin) awarded rB480def9c5587: Fix T52591: OpenColorIO not working correct with OpenGL core profile on macOS. a Doubloon token.
Aug 30 2017, 8:07 PM
Mike Erwin (merwin) committed rB17f26e181feb: OCIO: use modern GLSL texture functions (authored by Mike Erwin (merwin)).
OCIO: use modern GLSL texture functions
Aug 30 2017, 7:34 PM

Jun 28 2017

Mike Erwin (merwin) added a comment to T51921: Gawain assert with heavy mesh when selecting vertices on edit mode.

Confirmed here as well. It's failing during selection, not the drawing we see on screen.

Jun 28 2017, 2:06 PM · BF Blender: 2.8

Jun 26 2017

Mike Erwin (merwin) added a comment to T51467: Eevee: Shader recompilation issue.

I too think making uniforms for all parameters is the way to go, when editing or animating a material. Constant value nodes can be compiled for faster preview/playback when a material is not being edited. This is one area we can do better than the Unreal editor.

Jun 26 2017, 2:38 AM · BF Blender: 2.8

Jun 20 2017

Mike Erwin (merwin) added a comment to T51721: Blender 2.80 won't open..

@Mike Erwin (merwin) poke, can we give this somewhat of a priority? currently blender 2.8 will only start on windows with cards with ogl 4.5 , seems a little steep.....

Jun 20 2017, 6:24 AM · BF Blender: 2.8

Jun 18 2017

Mike Erwin (merwin) added a comment to T51644: Crash upon Startup.

Thanks @Joshua Leung (aligorith), that debug dump has some useful info.

Jun 18 2017, 3:26 PM · BF Blender: 2.8

Jun 17 2017

Mike Erwin (merwin) added a comment to T51635: Gawain hardcoded limit of 16 attributes leads to crashes.

I'm working on this now! Should have a better solution in a few days.

Jun 17 2017, 9:43 PM · BF Blender: 2.8

Jun 15 2017

Mike Erwin (merwin) triaged T51813: Grid is opaque and different scale on macOS as Confirmed priority.

Exact same issue on Mac + NVIDIA.

Jun 15 2017, 6:11 PM · BF Blender: 2.8

Jun 8 2017

Mike Erwin (merwin) added a comment to T50935: gawain presents problems when particle.

It should be fixed already, feel free to close as resolved after confirming.

Jun 8 2017, 4:34 PM · BF Blender: 2.8
Mike Erwin (merwin) added a comment to T51736: Drawing issues when running in multiple windows.

FYI our new immediate mode handles this by recreating its internal VAO every time we start drawing to a different window (each window has its own GL context). Much simpler there because imm has only one VAO total, not one per batch, potentially thousands.

Jun 8 2017, 2:22 PM · BF Blender: 2.8
Mike Erwin (merwin) added a comment to T51736: Drawing issues when running in multiple windows.

How about a more radical approach? Have one drawing context that all the windows use. The GPU already draws in sequence whether we have one context or many. The one drawing context has all VAOs so we don't have to manage anything ourselves. Adding yet another manager isn't the only solution.

Jun 8 2017, 2:14 PM · BF Blender: 2.8

Jun 7 2017

Dalai Felinto (dfelinto) awarded rBbfa5efeebecb: Fix MSVC compile (T51740) a Like token.
Jun 7 2017, 11:13 PM
Mike Erwin (merwin) closed T51740: gawain doesn't build with MSVC as Resolved.
Jun 7 2017, 10:31 PM · BF Blender: 2.8
Mike Erwin (merwin) added a comment to T51740: gawain doesn't build with MSVC.

I agree with @LazyDodo (LazyDodo) about removing "inline". Simplest solution & I've found static private functions to be as effective as inline. If we ever need public inline functions we can define this in gawain/common.h

Jun 7 2017, 10:31 PM · BF Blender: 2.8
Mike Erwin (merwin) committed rBbfa5efeebecb: Fix MSVC compile (T51740) (authored by Mike Erwin (merwin)).
Fix MSVC compile (T51740)
Jun 7 2017, 10:29 PM
Mike Erwin (merwin) committed rBbb3e669d06ec: Gawain: faster lookup shader attribs by name (authored by Mike Erwin (merwin)).
Gawain: faster lookup shader attribs by name
Jun 7 2017, 10:29 PM
Mike Erwin (merwin) committed rB179bb9774080: Gawain: stricter lookup of builtin uniforms (authored by Mike Erwin (merwin)).
Gawain: stricter lookup of builtin uniforms
Jun 7 2017, 10:29 PM
Mike Erwin (merwin) committed rBa5242d08fbe4: cleanup floating point literals (authored by Mike Erwin (merwin)).
cleanup floating point literals
Jun 7 2017, 10:29 PM

Jun 5 2017

Mike Erwin (merwin) added a comment to T51721: Blender 2.80 won't open..

The Geforce 8000 series are the oldest GPUs from NVIDIA that support OpenGL 3.3. I recently got an 8600 for compatibility testing. Windows 10 did not recognize it but I can try Windows 7 (otherwise the card might just be bad).

Jun 5 2017, 11:19 PM · BF Blender: 2.8

Jun 1 2017

Mike Erwin (merwin) added a comment to T50126: Modeling (mode edit) and stack overflow into the driver NVIDIA.

Is it possible that Windows 10 imposes its graphics driver instead of that of NVIDIA?

Jun 1 2017, 12:09 AM · OpenGL / Gfx

May 31 2017

Mike Erwin (merwin) added a comment to D2697: Gawain: Optimize shader uniform access.

Excellent work @Sergey Sharybin (sergey)!

May 31 2017, 8:05 PM

May 30 2017

Mike Erwin (merwin) added a comment to T51576: Blender crash when change to edit mode with Intel GPU.

Thanks @Wo!262 (wo262) for the quick response! Hopefully Intel really fixed this between 4624 and 4627 and we just have to wait for the newer version to roll out.

May 30 2017, 11:42 PM · OpenGL / Gfx
Mike Erwin (merwin) added a comment to T51644: Crash upon Startup.

I'll try to reproduce this issue on a debug build which should tell us more information. I only have a few NVIDIA cards though, none of the ones reported here...

May 30 2017, 11:35 PM · BF Blender: 2.8
Mike Erwin (merwin) added a comment to T51576: Blender crash when change to edit mode with Intel GPU.

@Wo!262 (wo262) what driver version? I would think HD 520 and 530 would have the same driver available.

May 30 2017, 11:25 PM · OpenGL / Gfx

May 29 2017

Mike Erwin (merwin) committed rB6757ca8b40bc: NDOF: clean up after MinGW removal (authored by Mike Erwin (merwin)).
NDOF: clean up after MinGW removal
May 29 2017, 8:06 PM
Mike Erwin (merwin) committed rB1fa216487d69: Gawain: update comments to match latest API (authored by Mike Erwin (merwin)).
Gawain: update comments to match latest API
May 29 2017, 7:42 PM

May 26 2017

Mike Erwin (merwin) added inline comments to D2678: Gawain refactor.
May 26 2017, 5:28 PM
Mike Erwin (merwin) committed rB620516965b49: Gawain: move convert_prim_type_to_gl to private API (authored by Mike Erwin (merwin)).
Gawain: move convert_prim_type_to_gl to private API
May 26 2017, 5:24 PM
Mike Erwin (merwin) added inline comments to D2678: Gawain refactor.
May 26 2017, 4:53 PM
Mike Erwin (merwin) added inline comments to D2678: Gawain refactor.
May 26 2017, 4:20 PM
Mike Erwin (merwin) added inline comments to D2678: Gawain refactor.
May 26 2017, 4:02 PM
Mike Erwin (merwin) added a comment to T51635: Gawain hardcoded limit of 16 attributes leads to crashes.

Gawain's limit matches common hardware limits, that's why it's 16. This applies to active attributes in the shader. I talked with @Clément Foucault (fclem) before about aliases — these don't belong in VertexFormat, and the limit should not apply to them. VertexBuffer or Batch is a better place to track aliases... still need to figure out the details!

May 26 2017, 3:45 PM · BF Blender: 2.8

May 23 2017

Mike Erwin (merwin) added a comment to rB340e4394d43e: Use custom shader for dot particles.

Please explain the difference between the new shader and GPU_SHADER_3D_POINT_UNIFORM_SIZE_UNIFORM_COLOR_OUTLINE_AA. Is it something that the rest of Blender (outside the 3D view) might want to use?

May 23 2017, 5:54 PM

May 22 2017

Mike Erwin (merwin) committed rB6cc293a6d97a: Gawain: replace switch with lookup table (authored by Mike Erwin (merwin)).
Gawain: replace switch with lookup table
May 22 2017, 10:45 PM
Mike Erwin (merwin) added a comment to T51576: Blender crash when change to edit mode with Intel GPU.

More results from Intel HD 520 + Windows 10.

May 22 2017, 9:44 PM · OpenGL / Gfx
Mike Erwin (merwin) triaged T51576: Blender crash when change to edit mode with Intel GPU as Confirmed priority.

Crashes inside Intel graphics driver while linking one of our shaders. This one!

May 22 2017, 3:26 AM · OpenGL / Gfx
Mike Erwin (merwin) committed rB054eb9422ca5: Gawain: use integer math to convert int16 to int10 (authored by Mike Erwin (merwin)).
Gawain: use integer math to convert int16 to int10
May 22 2017, 12:27 AM
Mike Erwin (merwin) committed rB23035cf46fb4: Gawain: remove GLenum from IndexType API (authored by Mike Erwin (merwin)).
Gawain: remove GLenum from IndexType API
May 22 2017, 12:27 AM
Mike Erwin (merwin) committed rBea31c55b08e0: Gawain: cleanup code formatting (authored by Mike Erwin (merwin)).
Gawain: cleanup code formatting
May 22 2017, 12:27 AM
Mike Erwin (merwin) committed rB90a1d491800c: Gawain: drop support for APPLE_vertex_array_object (authored by Mike Erwin (merwin)).
Gawain: drop support for APPLE_vertex_array_object
May 22 2017, 12:27 AM
Mike Erwin (merwin) committed rB3f6f02e43364: Gawain: drop support for APPLE_flush_buffer_range (authored by Mike Erwin (merwin)).
Gawain: drop support for APPLE_flush_buffer_range
May 22 2017, 12:27 AM
Mike Erwin (merwin) committed rB68d8618538e6: Gawain: promote 10_10_10 to first-class vertex format (authored by Mike Erwin (merwin)).
Gawain: promote 10_10_10 to first-class vertex format
May 22 2017, 12:27 AM

May 21 2017

Mike Erwin (merwin) added inline comments to rB07dd208209ce: Cleanup: warnings.
May 21 2017, 8:06 PM
Mike Erwin (merwin) closed T49450: replace OpenGL legacy matrix stacks as Resolved.
May 21 2017, 4:20 PM · OpenGL / Gfx, BF Blender: 2.8
Mike Erwin (merwin) closed T49450: replace OpenGL legacy matrix stacks, a subtask of T49165: OpenGL Refactor: Main Task, as Resolved.
May 21 2017, 4:20 PM · OpenGL / Gfx, BF Blender: 2.8
Mike Erwin (merwin) claimed T51576: Blender crash when change to edit mode with Intel GPU.

I have some Windows + Intel systems here for testing.

May 21 2017, 3:36 PM · OpenGL / Gfx

May 19 2017

Mike Erwin (merwin) committed rB996bf6573025: Clay/Eevee: fix more crash when entering edit mode (authored by Mike Erwin (merwin)).
Clay/Eevee: fix more crash when entering edit mode
May 19 2017, 10:13 PM
Mike Erwin (merwin) committed rB8d7b98bfd396: OpenGL: cleanup material shader GLSL (authored by Mike Erwin (merwin)).
OpenGL: cleanup material shader GLSL
May 19 2017, 8:21 PM
Mike Erwin (merwin) committed rB941e739d7035: Clay/Eevee: fix crash when entering edit mode (authored by Mike Erwin (merwin)).
Clay/Eevee: fix crash when entering edit mode
May 19 2017, 8:21 PM
Mike Erwin (merwin) committed rBa1c558e19f6f: OpenGL: cleanup edit overlay shaders (authored by Mike Erwin (merwin)).
OpenGL: cleanup edit overlay shaders
May 19 2017, 8:21 PM
Mike Erwin (merwin) committed rB8561a2dda746: OpenGL: remove BIT_OPERATIONS check from GLSL (authored by Mike Erwin (merwin)).
OpenGL: remove BIT_OPERATIONS check from GLSL
May 19 2017, 6:37 PM
Mike Erwin (merwin) awarded rB8adec78ca574: Cleanup: remove GLSL version checks a Piece of Eight token.
May 19 2017, 5:21 PM
Mike Erwin (merwin) committed rBef3c2554575c: fix typo in interlace shader (authored by Mike Erwin (merwin)).
fix typo in interlace shader
May 19 2017, 5:11 PM
Mike Erwin (merwin) committed rB648f2a61ada5: OpenGL: convert old texture2D calls in built-in shaders (authored by Mike Erwin (merwin)).
OpenGL: convert old texture2D calls in built-in shaders
May 19 2017, 5:11 PM
Mike Erwin (merwin) committed rBfa47437426b8: OpenGL: clean up smoke & fire shaders (authored by Mike Erwin (merwin)).
OpenGL: clean up smoke & fire shaders
May 19 2017, 5:10 PM
Mike Erwin (merwin) committed rBf6ffe12ddb44: OpenGL: convert old texture2D calls in FX shaders (authored by Mike Erwin (merwin)).
OpenGL: convert old texture2D calls in FX shaders
May 19 2017, 5:10 PM
Mike Erwin (merwin) committed rB4c5e9d7c0df0: OpenGL: convert old texture2D calls in material GLSL (authored by Mike Erwin (merwin)).
OpenGL: convert old texture2D calls in material GLSL
May 19 2017, 5:10 PM
Mike Erwin (merwin) added a comment to D2678: Gawain refactor.

General comments.

May 19 2017, 8:18 AM
Mike Erwin (merwin) committed rB77f8d631b1f6: OpenSubdiv: insert TODO notes for OpenGL (authored by Mike Erwin (merwin)).
OpenSubdiv: insert TODO notes for OpenGL
May 19 2017, 12:32 AM
Mike Erwin (merwin) committed rBe03e977385c9: OpenGL: call glProgramUniform only if version >= 4.1 (authored by Mike Erwin (merwin)).
OpenGL: call glProgramUniform only if version >= 4.1
May 19 2017, 12:32 AM
Mike Erwin (merwin) committed rB2e56e1415a0d: OpenGL: remove EXT_geometry_shader4 from OpenSubdiv (authored by Mike Erwin (merwin)).
OpenGL: remove EXT_geometry_shader4 from OpenSubdiv
May 19 2017, 12:32 AM
Mike Erwin (merwin) committed rBff8673399ecb: OpenSubdiv: remove legacy support & display queries (authored by Mike Erwin (merwin)).
OpenSubdiv: remove legacy support & display queries
May 19 2017, 12:31 AM
Mike Erwin (merwin) committed rB51278bab5ded: remove GPU_legacy_support query (authored by Mike Erwin (merwin)).
remove GPU_legacy_support query
May 19 2017, 12:31 AM
Mike Erwin (merwin) committed rB414c1c0e77e9: OpenGL: remove -noglsl option & GPU_extensions_disable (authored by Mike Erwin (merwin)).
OpenGL: remove -noglsl option & GPU_extensions_disable
May 19 2017, 12:31 AM
Mike Erwin (merwin) committed rB7823957455fb: remove GPU_geometry_shader_support, instanced_drawing_support queries (authored by Mike Erwin (merwin)).
remove GPU_geometry_shader_support, instanced_drawing_support queries
May 19 2017, 12:31 AM
Mike Erwin (merwin) committed rB5ed0944ce638: GPU: cleanup GLSL version and standard extensions (authored by Mike Erwin (merwin)).
GPU: cleanup GLSL version and standard extensions
May 19 2017, 12:31 AM
Mike Erwin (merwin) committed rB8cb3c7bdecd8: remove GPU_display_list_support query (authored by Mike Erwin (merwin)).
remove GPU_display_list_support query
May 19 2017, 12:31 AM

May 18 2017

Mike Erwin (merwin) added a comment to rB740f33d8a20e: Remove "Modern Viewport".

Why remove modern and keep legacy? The other way makes more sense to me.

May 18 2017, 9:28 PM
Mike Erwin (merwin) added a comment to T50856: Blender is not responding after minimizing [AMD].

I'm testing Blender 2.78c on an AMD A10-7850, not seeing any issues. Tried different window draw methods, region overlap, nothing yet breaks it.

May 18 2017, 1:33 AM · Platform: Windows, BF Blender, OpenGL / Gfx

May 15 2017

Mike Erwin (merwin) committed rB87bbeb283778: Gawain: further cleanup to VertexBuffer_prime (authored by Mike Erwin (merwin)).
Gawain: further cleanup to VertexBuffer_prime
May 15 2017, 7:10 PM
Mike Erwin (merwin) committed rB4f7c738a38b2: Gawain: revert recent VRAM usage metric (authored by Mike Erwin (merwin)).
Gawain: revert recent VRAM usage metric
May 15 2017, 7:10 PM
Mike Erwin (merwin) committed rB30d325c9e61f: Gawain: cleanup VRAM usage metric (authored by Mike Erwin (merwin)).
Gawain: cleanup VRAM usage metric
May 15 2017, 7:10 PM
Mike Erwin (merwin) added a reverting commit for rB1ff97bbfff78: Gawain: Better metric for VRAM usage.: rB4f7c738a38b2: Gawain: revert recent VRAM usage metric.
May 15 2017, 7:10 PM
Mike Erwin (merwin) added a reverting commit for rB7a18ee62eb4d: Gawain: Fix memory manager.: rB4f7c738a38b2: Gawain: revert recent VRAM usage metric.
May 15 2017, 7:10 PM

May 13 2017

Mike Erwin (merwin) committed rB6deaab207c25: remove old PBVH VertexBufferFormat struct (authored by Mike Erwin (merwin)).
remove old PBVH VertexBufferFormat struct
May 13 2017, 5:40 AM
Mike Erwin (merwin) committed rB41c4c3f8fdd6: remove unused #includes (authored by Mike Erwin (merwin)).
remove unused #includes
May 13 2017, 5:40 AM
Mike Erwin (merwin) added a comment to D2670: Crappy Persistent mapping based gawain.

Good to see you @Antony Riakiotakis (psy-fi)! Thanks for digging into this & verifying that it does help.

May 13 2017, 3:37 AM · BF Blender: 2.8
Mike Erwin (merwin) added a comment to T51478: Lagging with Blender 2.78 on Mac OS Sierra.

Also try "OpenGL Occlusion Queries" in User Prefs | System | Selection.

May 13 2017, 3:09 AM · BF Blender
Mike Erwin (merwin) added a comment to T51478: Lagging with Blender 2.78 on Mac OS Sierra.

It might be related to a change we made in 2.77 — always use VBOs to draw objects. @Small Sébastien (Conique2001) your graphics card has plenty of VRAM so should be able to handle large poly counts. So hmmm....

May 13 2017, 3:07 AM · BF Blender

May 12 2017

Mike Erwin (merwin) added a comment to rBf1242ea93b1c: Fix bug in copying VertexFormat.

Thanks for the fix, I can't believe this hasn't caused problems before!

May 12 2017, 12:45 AM
Mike Erwin (merwin) awarded rBf1242ea93b1c: Fix bug in copying VertexFormat a Doubloon token.
May 12 2017, 12:39 AM
Mike Erwin (merwin) closed T49012: update OpenGL requirements for Blender 2.8 as Resolved.

As of c8ab7d46566c4a65c6176cd2ebe27778512f7fef we use OpenGL 3.3 core profile on all platforms. We still have some implementation and cleanup work ahead, but this milestone is effectively done.

May 12 2017, 12:37 AM · BF Blender: 2.8, OpenGL / Gfx
Mike Erwin (merwin) closed T49012: update OpenGL requirements for Blender 2.8, a subtask of T49165: OpenGL Refactor: Main Task, as Resolved.
May 12 2017, 12:37 AM · OpenGL / Gfx, BF Blender: 2.8

May 5 2017

Mike Erwin (merwin) added a comment to T51219: Gawain API general consistency RFC.

Bigger picture, I prefer function names mostly as they are. That's why I chose them! Some of the P453 changes are better though, so we can pick & choose.

May 5 2017, 7:40 PM · BF Blender: 2.8
Mike Erwin (merwin) added a comment to T51219: Gawain API general consistency RFC.

Some notes on specifics, so we can use P453 as a base for discussion.

May 5 2017, 5:48 PM · BF Blender: 2.8
Mike Erwin (merwin) added a comment to P453 gawain_refactor.py (see: T51219).

Some notes on specifics, so we can use this as a base for discussion.

May 5 2017, 5:45 PM
Mike Erwin (merwin) closed T51152: Blender won't start after updating Nvidia drivers as Resolved.

Fixed by unknown NVIDIA magic.

May 5 2017, 1:46 AM · BF Blender: Unconfirmed, OpenGL / Gfx
Mike Erwin (merwin) added a comment to T51152: Blender won't start after updating Nvidia drivers.

Just tested Blender 2.78c on latest Windows 10 (64-bit) and Geforce GTX 1050.

May 5 2017, 12:41 AM · BF Blender: Unconfirmed, OpenGL / Gfx

May 1 2017

Mike Erwin (merwin) updated subscribers of T51206: Wire line-width in draw manager ignores UI scale..

Edit mode edge drawing uses a different technique though. It can be updated to respect UI scale. Similar for round points with outlines.

May 1 2017, 7:31 PM · BF Blender: 2.8, OpenGL / Gfx
Mike Erwin (merwin) added a comment to T51206: Wire line-width in draw manager ignores UI scale..

I've gotten mixed results with wide lines on core profile.

May 1 2017, 7:27 PM · BF Blender: 2.8, OpenGL / Gfx
Mike Erwin (merwin) added a comment to T51370: Object Mode: Empty Image Draw Option.

For reference, here's the commit from the current (non draw manager) viewport.

May 1 2017, 7:21 PM · BF Blender: 2.8, OpenGL / Gfx
Mike Erwin (merwin) updated subscribers of T51375: Port CDDM to core profile.

Whaaaat? I thought we were removing all of this soon. How long until the depsgraph gives us post-modifier results?

May 1 2017, 7:17 PM · BF Blender: 2.8, OpenGL / Gfx
Mike Erwin (merwin) added a comment to T51346: Object Info node not working in material view .

Yes I'll take a look tomorrow, try to figure it out.

May 1 2017, 3:24 AM · BF Blender

Apr 27 2017

Mike Erwin (merwin) committed rBe4d856e31b27: OpenGL: manage legacy state only when WITH_LEGACY_OPENGL=ON (authored by Mike Erwin (merwin)).
OpenGL: manage legacy state only when WITH_LEGACY_OPENGL=ON
Apr 27 2017, 8:35 PM
Mike Erwin (merwin) committed rB079e0b5943f3: OpenGL: don't set texture LoD bias via glTexEnvf (authored by Mike Erwin (merwin)).
OpenGL: don't set texture LoD bias via glTexEnvf
Apr 27 2017, 8:35 PM
Mike Erwin (merwin) committed rB0d5c5a8438ba: OpenGL: early exit from functions that don't mix with core profile (authored by Mike Erwin (merwin)).
OpenGL: early exit from functions that don't mix with core profile
Apr 27 2017, 8:35 PM
Mike Erwin (merwin) committed rB99fde39f4905: OpenGL: fix color logic op (authored by Mike Erwin (merwin)).
OpenGL: fix color logic op
Apr 27 2017, 8:20 PM
Mike Erwin (merwin) committed rB75fac519c053: Gawain: safely orphan immediate mode's VBO (authored by Mike Erwin (merwin)).
Gawain: safely orphan immediate mode's VBO
Apr 27 2017, 5:47 PM