Page MenuHome

Nils Thuerey (n_t)
User

Projects

User Details

User Since
Jun 27 2005, 10:16 AM (741 w, 6 d)

Recent Activity

Tue, Sep 3

Nils Thuerey (n_t) added a comment to T59995: Mantaflow Review.

@Sebastián Barschkis (sebbas) - neat! I've tested the version in the last days. It compiles and runs nicely on my mac. I think this version is ready to be merged, as far as I can see.

Tue, Sep 3, 6:41 PM · Physics, BF Blender

May 12 2019

Nils Thuerey (n_t) added a comment to D3850: Mantaflow [Part 1]: Added preprocessed Mantaflow source files.

@Sebastián Barschkis (sebbas) yes, good idea - we're using TBB with mantaflow for a long time now, and it works very nicely. We also saw performance gains in the past, less than 50%, but gains nonetheless. So I don't see a reason not to focus on TBB. That way we could also get rid of the somewhat redundant code for OpenMP.

May 12 2019, 2:50 PM

May 5 2019

Nils Thuerey (n_t) added a comment to T59995: Mantaflow Review.

@Bastien Montagne (mont29) thanks for the detailed comments! We'll have to more carefully look at the points you mentioned. Good idea to make the naming scheme consistent, to properly indicate the parts of the new solver. I'd suggest using "manta" there to distinguish it from the old smoke and liquid version.

May 5 2019, 3:44 PM · Physics, BF Blender

May 2 2019

Nils Thuerey (n_t) added a comment to T59995: Mantaflow Review.

@Brecht Van Lommel (brecht), @Bastien Montagne (mont29) - okay, very good!

May 2 2019, 1:56 PM · Physics, BF Blender

Apr 26 2019

Nils Thuerey (n_t) added a comment to T59995: Mantaflow Review.

I have another question here for the experienced blender devs (@Brecht Van Lommel (brecht) @Sam Van Hulle (sam_vh) @Martin Felke (scorpion81) @Jacques Lucke (JacquesLucke) and maybe others?): what would be the best next steps for an official 'approval' of the mantaflow diffs? I saw the 2.8 timeline, and I guess it would be ideal to verify that the patch is in a good enough state some time soon. Then it could be merged into the main branch as soon as possible after 2.8 is released in July, such that it can be included for the 2.81 release.

Apr 26 2019, 12:41 PM · Physics, BF Blender

Apr 23 2019

Nils Thuerey (n_t) added a comment to T59995: Mantaflow Review.

@Brecht Van Lommel (brecht) Okay, yes - the GIL seems to be unproblematic so far. It could make the UI somewhat unresponsive when baking large sims, though. The new node system notes look interesting. I think for mantaflow it would neat to go for the "everything-nodes" direction, where a node graph would define the data flow of the simulation. This could then use a python back-end, or directly hook into the mantaflow functions (the functions that are exposes to python are the crucial ones that ideally would also be available as nodes). It's definitely a good point to keep in mind.

Apr 23 2019, 1:53 PM · Physics, BF Blender

Apr 18 2019

Nils Thuerey (n_t) added a comment to T59995: Mantaflow Review.

@Brecht Van Lommel (brecht) Good question, to add to sebbas comments, there are a few reasons for the python bindings: a first mundane one is that that's how the mantaflow solver worked originally, and it would have been a lot more work to switch to C/C++ bindings. Also, the performance impact is negligible, as mantaflow provides all the solver building blocks via python, but each of the steps is quite expensive. So there are no low-level operations in python (e.g. access to grid cells), but just a small number of calls to high level functions that typically make several passes over the full grid.

Apr 18 2019, 4:19 PM · Physics, BF Blender

Apr 17 2019

Nils Thuerey (n_t) added a comment to T59995: Mantaflow Review.

@Sebastián Barschkis (sebbas) - I noticed the exported python scene has a few lines at the top for OS/multi-processing checks that don't seem to be used or necessary. (from "withMP ... up to VARIABLES", ca. lines 8 to 18). Those could be removed, right?

Apr 17 2019, 9:46 AM · Physics, BF Blender

Apr 8 2019

Nils Thuerey (n_t) added a comment to T59995: Mantaflow Review.

Hi everyone, great to see the manta integration being re-revived! @Sebastián Barschkis (sebbas) thanks for the large patch collection. I just checked out and tried the revised diff "from scratch". Works nicely on my MAC. The sims also run through without problem (I tested based on the quick-smoke and quick-liquid setups). So I think this patch looks good, overall. There are some obvious next steps, like removing the old liquid/smoke modifiers, and cleaning up the code, but I think this would be better to address once the manta code is integrated.

Apr 8 2019, 10:09 AM · Physics, BF Blender