Hristo Gueorguiev (nirved)
User

Projects

User Details

User Since
Oct 2 2016, 4:45 PM (25 w, 14 h)

Recent Activity

Fri, Mar 24

Hristo Gueorguiev (nirved) added a comment to T50985: Rendering volume scatter with GPU OpenCL comes to an halt after a few seconds.

Cause is unsafe compiler options. Changing it to a safe one does performance penalty 1%.

1diff --git a/intern/cycles/device/opencl/opencl_base.cpp b/intern/cycles/device/opencl/opencl_base.cpp
2index 0328dfe..c3a499d 100644
3--- a/intern/cycles/device/opencl/opencl_base.cpp
4+++ b/intern/cycles/device/opencl/opencl_base.cpp
5@@ -612,7 +612,7 @@ void OpenCLDeviceBase::shader(DeviceTask& task)
6
7​ string OpenCLDeviceBase::kernel_build_options(const string *debug_src)
8​ {
9- string build_options = "-cl-fast-relaxed-math ";
10+ string build_options = "-cl-no-signed-zeros -cl-mad-enable ";
11
12​ if(platform_name == "NVIDIA CUDA") {
13​ build_options += "-D__KERNEL_OPENCL_NVIDIA__ "

Fri, Mar 24, 9:31 PM · BF Blender
Hristo Gueorguiev (nirved) created P457 Fix for T50985.
Fri, Mar 24, 9:28 PM

Thu, Mar 23

Hristo Gueorguiev (nirved) abandoned D2314: Cycles: OpenCL split kernel SSS.

Already in master rB57e26627c4.

Thu, Mar 23, 12:13 PM
Hristo Gueorguiev (nirved) abandoned D2310: Cycles: OpenCL split kernel volume.

Subsurface scattering works ok when using a single program - all kernels in one file.

Not sure why this would be, do you have an explanation or a fix?

This was due to a combination of division by zero and unsafe OpenCL optimization options.

Thu, Mar 23, 12:12 PM

Mon, Mar 13

Hristo Gueorguiev (nirved) committed rBf169ff8b8861: Fix T50925: Add AO approximation to split kernel (authored by Hristo Gueorguiev (nirved)).
Fix T50925: Add AO approximation to split kernel
Mon, Mar 13, 11:16 AM
Hristo Gueorguiev (nirved) closed T50925: AO bounce simplification diffences between GPU and CPU as "Resolved" by committing rBf169ff8b8861: Fix T50925: Add AO approximation to split kernel.
Mon, Mar 13, 11:16 AM · BF Blender

Fri, Mar 10

Hristo Gueorguiev (nirved) added 1 commit(s) for D2310: Cycles: OpenCL split kernel volume: rB57e26627c485: Cycles: SSS and Volume rendering in split kernel.
Fri, Mar 10, 2:46 PM
Hristo Gueorguiev (nirved) added an edge to rB57e26627c485: Cycles: SSS and Volume rendering in split kernel: D2310: Cycles: OpenCL split kernel volume.
Fri, Mar 10, 2:46 PM

Thu, Mar 9

Hristo Gueorguiev (nirved) added a comment to T50888: Master Broken, Cuda kernel compat errors compile, OpenCL GPU just sits there on one tile never rendering anything..

@James W E Bird (3dLuver) Please also share the git hash (first 8 letters) of the master which you use.

Thu, Mar 9, 6:26 PM · BF Blender

Wed, Mar 8

Hristo Gueorguiev (nirved) committed rB0c70c2eb5123: Cycles: add single program debug option for split kernel (authored by Hristo Gueorguiev (nirved)).
Cycles: add single program debug option for split kernel
Wed, Mar 8, 6:12 PM
Hristo Gueorguiev (nirved) committed rBa4f8766265bf: Cycles: split kernel_shadow_blocked to AO & DL parts (authored by Hristo Gueorguiev (nirved)).
Cycles: split kernel_shadow_blocked to AO & DL parts
Wed, Mar 8, 6:12 PM
Hristo Gueorguiev (nirved) committed rB2e42f8e73f9a: Cycles: Speedup transparent shadows in split kernel (authored by Hristo Gueorguiev (nirved)).
Cycles: Speedup transparent shadows in split kernel
Wed, Mar 8, 6:12 PM
Hristo Gueorguiev (nirved) committed rBc33ab5fe6b7c: Cycles: SSS and Volume rendering in split kernel (authored by Hristo Gueorguiev (nirved)).
Cycles: SSS and Volume rendering in split kernel
Wed, Mar 8, 6:12 PM

Feb 3 2017

Hristo Gueorguiev (nirved) added a comment to D2310: Cycles: OpenCL split kernel volume.

@Mai Lavelle (maiself)
Volume scattering doesn't work due to NO_TRANSPARENT_SHADOWS.
Subsurface scattering works ok when using a single program - all kernels in one file.

Feb 3 2017, 3:24 PM

Dec 10 2016

Hristo Gueorguiev (nirved) updated the diff for D2314: Cycles: OpenCL split kernel SSS.

Update against latest master.

Dec 10 2016, 10:31 PM
Hristo Gueorguiev (nirved) updated the diff for D2310: Cycles: OpenCL split kernel volume.

Update against latest master.

Dec 10 2016, 10:26 PM

Nov 14 2016

Hristo Gueorguiev (nirved) added a comment to D2348: Cycles: Refactor split kernel and implement for CPU.

Changing the behavior of atomic_inc is misleading, both CUDA & OpenCL return the old value. Further, using atomic_inc_uint32 and atomic_add_uint32 produces less readable code, since we have to subtract what was just added. Maybe there should be indication in atomic_ops.h, i.e. atomic_add_and_get_uint32.

Nov 14 2016, 3:02 PM

Nov 10 2016

Hristo Gueorguiev (nirved) updated the diff for D2314: Cycles: OpenCL split kernel SSS.

The patch had wrong newline characters.

Nov 10 2016, 9:59 PM
Hristo Gueorguiev (nirved) updated the diff for D2310: Cycles: OpenCL split kernel volume.

The patch had wrong newline characters.

Nov 10 2016, 9:58 PM
Hristo Gueorguiev (nirved) updated the diff for D2314: Cycles: OpenCL split kernel SSS.

Update against latest master. Fixed queue bug. Fixed indentation.

Nov 10 2016, 2:18 AM

Nov 8 2016

Hristo Gueorguiev (nirved) updated the diff for D2310: Cycles: OpenCL split kernel volume.

Fixed missing ccl_fetch.

Nov 8 2016, 10:45 PM
Hristo Gueorguiev (nirved) updated the diff for D2310: Cycles: OpenCL split kernel volume.

Updated to work with current master.

Nov 8 2016, 10:18 PM

Oct 27 2016

Hristo Gueorguiev (nirved) removed a dependency for D2310: Cycles: OpenCL split kernel volume: D2299: Cycles: OpenCL 3d textures.
Oct 27 2016, 12:31 AM
Hristo Gueorguiev (nirved) removed a dependent revision for D2299: Cycles: OpenCL 3d textures: D2310: Cycles: OpenCL split kernel volume.
Oct 27 2016, 12:31 AM

Oct 25 2016

Hristo Gueorguiev (nirved) updated the diff for D2314: Cycles: OpenCL split kernel SSS.

Fixed more indentation.

Oct 25 2016, 3:31 PM
Hristo Gueorguiev (nirved) updated the diff for D2314: Cycles: OpenCL split kernel SSS.

Fixed queuing and indentation. SOA is not supported.

Oct 25 2016, 3:05 PM

Oct 24 2016

Hristo Gueorguiev (nirved) added a comment to D2246: Cycles: Remove all structure-of-array features.

In kernel_shadow_blocked.h must use SD_THREAD instead of ray_index .

Oct 24 2016, 1:12 PM

Oct 23 2016

Hristo Gueorguiev (nirved) updated the diff for D2310: Cycles: OpenCL split kernel volume.

Fixed indentation, a typo, removed shadow_blocked_addrspace.

Oct 23 2016, 6:44 PM
Hristo Gueorguiev (nirved) added a comment to D2310: Cycles: OpenCL split kernel volume.
Oct 23 2016, 6:27 PM
Aaron Carlisle (Blendify) awarded rB8905c5c87495: Cycles: OpenCL 3d textures support. a Like token.
Oct 23 2016, 12:53 AM

Oct 21 2016

Hristo Gueorguiev (nirved) updated the diff for D2299: Cycles: OpenCL 3d textures.

Switched back to uint4. Also fixed a bug - missing offset.

Oct 21 2016, 8:32 PM

Oct 20 2016

Hristo Gueorguiev (nirved) updated the diff for D2314: Cycles: OpenCL split kernel SSS.

More missing ccl_global.

Oct 20 2016, 3:26 PM
Hristo Gueorguiev (nirved) updated the diff for D2314: Cycles: OpenCL split kernel SSS.

Added missing ccl_global definitions.

Oct 20 2016, 3:07 PM
Hristo Gueorguiev (nirved) added a dependent revision for D2310: Cycles: OpenCL split kernel volume: D2314: Cycles: OpenCL split kernel SSS.
Oct 20 2016, 12:13 PM
Hristo Gueorguiev (nirved) added a dependency for D2314: Cycles: OpenCL split kernel SSS: D2310: Cycles: OpenCL split kernel volume.
Oct 20 2016, 12:13 PM
Hristo Gueorguiev (nirved) retitled D2314: Cycles: OpenCL split kernel SSS from to Cycles: OpenCL split kernel SSS.
Oct 20 2016, 12:12 PM
Hristo Gueorguiev (nirved) added a dependent revision for D2299: Cycles: OpenCL 3d textures: D2310: Cycles: OpenCL split kernel volume.
Oct 20 2016, 12:09 PM
Hristo Gueorguiev (nirved) added a dependency for D2310: Cycles: OpenCL split kernel volume: D2299: Cycles: OpenCL 3d textures.
Oct 20 2016, 12:09 PM
Hristo Gueorguiev (nirved) updated the diff for D2310: Cycles: OpenCL split kernel volume.

Minor changes: added missing rays state in queue_enqueue.

Oct 20 2016, 12:08 PM

Oct 18 2016

Hristo Gueorguiev (nirved) added a comment to D2310: Cycles: OpenCL split kernel volume.

Currently it's buggy (default cube with quick smoke+fire at frame 30):

Oct 18 2016, 9:48 PM
Hristo Gueorguiev (nirved) retitled D2310: Cycles: OpenCL split kernel volume from to Cycles: OpenCL split kernel volume.
Oct 18 2016, 9:47 PM
Hristo Gueorguiev (nirved) updated the diff for D2299: Cycles: OpenCL 3d textures.

Fixed kernel_image_3d_interp calls for OpenCL.

Oct 18 2016, 7:28 PM

Oct 14 2016

Hristo Gueorguiev (nirved) added a comment to D2299: Cycles: OpenCL 3d textures.

Tested only Split kernel, Mega should work, kernel_image_opencl.h is included. There might be problems with CUDA though.

Oct 14 2016, 2:31 PM
Hristo Gueorguiev (nirved) retitled D2299: Cycles: OpenCL 3d textures from to Cycles: OpenCL 3d textures.
Oct 14 2016, 1:36 PM