Page MenuHome

Janusch Patas (patjan)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 1 2020, 8:56 PM (32 w, 5 d)

Recent Activity

Thu, May 13

Janusch Patas (patjan) added a comment to D9678: Bevel on curves does not create distorted geometry anymore.

Is this feature still relevant? The inital commit is almost 6 months old and little drive towards acceptance. So, if there are plan to integrate it, I like to update the patch. Otherwise it would be best to abandon it.

Thu, May 13, 12:47 AM · Unknown Object (Project), Modeling, Good First Issue

Wed, May 12

Andy Cuccaro (AndyCuccaro) awarded D9678: Bevel on curves does not create distorted geometry anymore a Love token.
Wed, May 12, 4:46 AM · Unknown Object (Project), Modeling, Good First Issue

Thu, Apr 22

Roman (roman13) awarded D9678: Bevel on curves does not create distorted geometry anymore a Burninate token.
Thu, Apr 22, 11:19 AM · Unknown Object (Project), Modeling, Good First Issue

Mar 17 2021

Janusch Patas (patjan) added a comment to D9678: Bevel on curves does not create distorted geometry anymore.

@Germano Cavalcante (mano-wii): Thanks. I have substituted the function as suggested.
@Hans Goudey (HooglyBoogly): Radius factor applies now to every bevel piece.

Mar 17 2021, 11:24 PM · Unknown Object (Project), Modeling, Good First Issue
Janusch Patas (patjan) updated the diff for D9678: Bevel on curves does not create distorted geometry anymore.
radius_factor applied to every bevelpiece
Mar 17 2021, 11:22 PM · Unknown Object (Project), Modeling, Good First Issue

Mar 15 2021

Janusch Patas (patjan) added a comment to D9678: Bevel on curves does not create distorted geometry anymore.

@Hans Goudey (HooglyBoogly): I still don't know what you mean by radius. There is a check box called radius but I can't see an effect when check marked even not on master.
Or do you mean the depth slider (which says "Radius of the bevel geometry" when hoovering over it and which seems to work just fine")?

Mar 15 2021, 11:29 PM · Unknown Object (Project), Modeling, Good First Issue
Janusch Patas (patjan) updated the diff for D9678: Bevel on curves does not create distorted geometry anymore.
Reviewer remarks implemented.
Mar 15 2021, 11:24 PM · Unknown Object (Project), Modeling, Good First Issue

Mar 8 2021

Janusch Patas (patjan) added a comment to D9678: Bevel on curves does not create distorted geometry anymore.

Hmm, right now I am not sure what your expectations are. The radius seems useless to me or I am just not able to trigger it.

Mar 8 2021, 10:27 PM · Unknown Object (Project), Modeling, Good First Issue

Mar 6 2021

Juan Manuel Lynch (Lynchon) awarded D9678: Bevel on curves does not create distorted geometry anymore a Burninate token.
Mar 6 2021, 10:14 AM · Unknown Object (Project), Modeling, Good First Issue

Feb 9 2021

Janusch Patas (patjan) added a comment to D9678: Bevel on curves does not create distorted geometry anymore.

@Hans Goudey (HooglyBoogly) : Thx. I know but this is the consequence of the approach. Future improvements might by rounded corners or similar geometric improvements.

Feb 9 2021, 9:02 PM · Unknown Object (Project), Modeling, Good First Issue

Feb 1 2021

Janusch Patas (patjan) added a comment to D9678: Bevel on curves does not create distorted geometry anymore.

Hey @Roman (roman13), it might be the easiest way when you build blender yourself? Here https://wiki.blender.org/wiki/Tools/CodeReview you can find information how to apply the patch and here https://wiki.blender.org/wiki/Building_Blender how to build blender.
Unfortunately, I have no idea if and when this patch is going to be merge into master.

Feb 1 2021, 9:10 PM · Unknown Object (Project), Modeling, Good First Issue

Jan 11 2021

Janusch Patas (patjan) added a comment to D9934: Fix T83122: NURBS Extruding multiple points only moves existing points.

@Sergey Sharybin (sergey) : Thank you for your review. I tested it once again and I don't think the code is redundant. You won't be able to extrude a surface. You will one extrude if you select a single point. This behaves then like a regular curve. Please see my comment.

Jan 11 2021, 10:27 PM · Modeling
Janusch Patas (patjan) retitled D9934: Fix T83122: NURBS Extruding multiple points only moves existing points from Fix NURBS Extruding multiple points only moves existing points to Fix T83122: NURBS Extruding multiple points only moves existing points.
Jan 11 2021, 10:05 PM · Modeling
Janusch Patas (patjan) added a comment to D9937: Fix NURBS Repeat for Extrude doesn't repeat extrusion..

I reassigned the key mapping to select a row to "alt + mouse selection button". It has now a similar behavior to MESH_OT_loop_select. However, the edge selection feature is not implemented yet. That's what I will do next. You are right. This should be more or less straight forward.

Jan 11 2021, 12:16 AM · User Interface, Modeling
Janusch Patas (patjan) updated the diff for D9937: Fix NURBS Repeat for Extrude doesn't repeat extrusion..

reassigned keymapping

Jan 11 2021, 12:10 AM · User Interface, Modeling

Jan 8 2021

Janusch Patas (patjan) retitled D9334: Fix T82000: Viewport animation render chrashes when collapsing viewport from Bugfix for T82000 Viewport animation render chrashes when collapsing viewport to Fix T82000: Viewport animation render chrashes when collapsing viewport.
Jan 8 2021, 10:22 PM · User Interface, EEVEE & Viewport

Jan 7 2021

Janusch Patas (patjan) added a comment to D9937: Fix NURBS Repeat for Extrude doesn't repeat extrusion..

Sound like an great exercise. Any pointers to useful code I can take a peak?

Jan 7 2021, 10:17 PM · User Interface, Modeling

Jan 6 2021

Vitalii Vlasov (Fracture128) awarded D9678: Bevel on curves does not create distorted geometry anymore a Like token.
Jan 6 2021, 9:26 AM · Unknown Object (Project), Modeling, Good First Issue
Gilberto Rodrigues (gilberto_rodrigues) awarded D9678: Bevel on curves does not create distorted geometry anymore a Love token.
Jan 6 2021, 12:31 AM · Unknown Object (Project), Modeling, Good First Issue

Jan 3 2021

Janusch Patas (patjan) added inline comments to D9334: Fix T82000: Viewport animation render chrashes when collapsing viewport.
Jan 3 2021, 10:06 PM · User Interface, EEVEE & Viewport
Janusch Patas (patjan) updated the diff for D9334: Fix T82000: Viewport animation render chrashes when collapsing viewport.
Correction of overriding shading prop. 
wm has to be checked for NULL pointer.
Jan 3 2021, 10:01 PM · User Interface, EEVEE & Viewport
Janusch Patas (patjan) added a comment to D9678: Bevel on curves does not create distorted geometry anymore.

@Hans Goudey (HooglyBoogly) I tried to be more clear what the code is doing and tried to implement your suggested improvements. To me it is not at all annoying, it is a great learning experience. Thank your for your great help and reviews. I hope I was able to do better now.

Jan 3 2021, 12:20 AM · Unknown Object (Project), Modeling, Good First Issue
Janusch Patas (patjan) updated the diff for D9678: Bevel on curves does not create distorted geometry anymore.
Reviewer remarks implemented:
Jan 3 2021, 12:10 AM · Unknown Object (Project), Modeling, Good First Issue

Dec 28 2020

Janusch Patas (patjan) added inline comments to D9678: Bevel on curves does not create distorted geometry anymore.
Dec 28 2020, 9:45 PM · Unknown Object (Project), Modeling, Good First Issue
Janusch Patas (patjan) updated the diff for D9678: Bevel on curves does not create distorted geometry anymore.
Implement Germano Cavalcante's review.
Dec 28 2020, 9:41 PM · Unknown Object (Project), Modeling, Good First Issue
Wilsimar (wilBr) awarded D9678: Bevel on curves does not create distorted geometry anymore a Love token.
Dec 28 2020, 4:13 PM · Unknown Object (Project), Modeling, Good First Issue
Kyron de Haas (kryp) awarded D9678: Bevel on curves does not create distorted geometry anymore a Party Time token.
Dec 28 2020, 3:50 PM · Unknown Object (Project), Modeling, Good First Issue
Janusch Patas (patjan) added a comment to T83123: NURBS: Repeat for Extrude doesn't repeat extrusion, selects all points.

Btw, I just checked the manual https://docs.blender.org/manual/en/latest/modeling/surfaces/selecting.html#select-control-point-row which documents the hotkey "shift + r" as assigned to another command. Since I suggested a patch, now I am quite unsure if there is a usability conflict.

Dec 28 2020, 12:25 PM · Modeling, BF Blender

Dec 27 2020

Janusch Patas (patjan) updated the diff for D9678: Bevel on curves does not create distorted geometry anymore.

I went once more over the code and was able to simplify it further.

Dec 27 2020, 10:54 PM · Unknown Object (Project), Modeling, Good First Issue
Janusch Patas (patjan) claimed T83123: NURBS: Repeat for Extrude doesn't repeat extrusion, selects all points.
Dec 27 2020, 1:47 PM · Modeling, BF Blender
Janusch Patas (patjan) updated the summary of D9937: Fix NURBS Repeat for Extrude doesn't repeat extrusion..
Dec 27 2020, 1:47 PM · User Interface, Modeling
Janusch Patas (patjan) added a revision to T83123: NURBS: Repeat for Extrude doesn't repeat extrusion, selects all points: D9937: Fix NURBS Repeat for Extrude doesn't repeat extrusion..
Dec 27 2020, 1:39 PM · Modeling, BF Blender
Janusch Patas (patjan) requested review of D9937: Fix NURBS Repeat for Extrude doesn't repeat extrusion..
Dec 27 2020, 1:39 PM · User Interface, Modeling
Janusch Patas (patjan) claimed T83122: NURBS: Extruding multiple points only moves existing points.

I have provided an Bugfix. I don't know, if the behavior described here was former intended design. If not, it is fixed now.
It can be found in D9934.

Dec 27 2020, 12:42 AM · Modeling, BF Blender
Janusch Patas (patjan) updated the summary of D9934: Fix T83122: NURBS Extruding multiple points only moves existing points.
Dec 27 2020, 12:39 AM · Modeling
Janusch Patas (patjan) requested review of D9934: Fix T83122: NURBS Extruding multiple points only moves existing points.
Dec 27 2020, 12:37 AM · Modeling
Janusch Patas (patjan) updated the diff for D9931: Fix: Knife tool renders future points incorrectly once again..
Correction: Wrong Differential
Dec 27 2020, 12:30 AM · Modeling
Janusch Patas (patjan) updated the diff for D9931: Fix: Knife tool renders future points incorrectly once again..
Dec 27 2020, 12:22 AM · Modeling

Dec 25 2020

Janusch Patas (patjan) claimed T83391: Knife tool renders future points incorrectly once again.

I have updated the patch in D9931. Maybe, it helps to resolve this issue.

Dec 25 2020, 2:13 PM · Modeling, User Interface, BF Blender
Janusch Patas (patjan) updated the summary of D9931: Fix: Knife tool renders future points incorrectly once again..
Dec 25 2020, 2:09 PM · Modeling
Janusch Patas (patjan) requested review of D9931: Fix: Knife tool renders future points incorrectly once again..
Dec 25 2020, 2:06 PM · Modeling
Janusch Patas (patjan) added a comment to T83391: Knife tool renders future points incorrectly once again.

Initially, I provided a small patch in D9509 that fixes T83831 and does not produce the bug described in this task. I just applied it again and tested it successfully. However, it was abandoned and I don't understand exactly why. In D9509 you can find a short discussion where I made a concern about zeroing the coordinates. Maybe, I was not completely wrong.

Dec 25 2020, 2:00 PM · Modeling, User Interface, BF Blender
Janusch Patas (patjan) updated the diff for D9678: Bevel on curves does not create distorted geometry anymore.

UI checkbox for angle based radius included. Please see the screenshot

Dec 25 2020, 12:41 AM · Unknown Object (Project), Modeling, Good First Issue

Dec 23 2020

Janusch Patas (patjan) added a comment to D9678: Bevel on curves does not create distorted geometry anymore.

Good to see someone working on it :)

Nice, thx. It is quite challenging for a good first issue.

Dec 23 2020, 10:41 PM · Unknown Object (Project), Modeling, Good First Issue
Janusch Patas (patjan) updated the diff for D9678: Bevel on curves does not create distorted geometry anymore.

Incorporated review from Hans Goudey

Dec 23 2020, 10:30 PM · Unknown Object (Project), Modeling, Good First Issue

Dec 22 2020

Janusch Patas (patjan) added a comment to T80979: Bevel on curves created distorted geometry.

The blend file I have upload is take from T83207.

Dec 22 2020, 5:35 PM · Unknown Object (Project), Good First Issue, Modeling, BF Blender
Janusch Patas (patjan) added a comment to T80979: Bevel on curves created distorted geometry.

I have updated my fix D9678 which should no more produce distortions in the bevel. I have tested it with many files and could not identify any issue. It even fixes the issues with the distortion in the attached file (I am not sure in which issue I found this file)



It would be nice if someone could test it and provide any feedback.

Dec 22 2020, 5:32 PM · Unknown Object (Project), Good First Issue, Modeling, BF Blender
Janusch Patas (patjan) updated the diff for D9678: Bevel on curves does not create distorted geometry anymore.
  • Thorough fix of bevel distortion
Dec 22 2020, 5:25 PM · Unknown Object (Project), Modeling, Good First Issue

Dec 14 2020

Janusch Patas (patjan) added inline comments to D9334: Fix T82000: Viewport animation render chrashes when collapsing viewport.
Dec 14 2020, 10:28 PM · User Interface, EEVEE & Viewport

Dec 13 2020

Raimund Klink (Raimund58) awarded T65585: Knife Tool fail if camera is too close to the object and mouse away from object a Love token.
Dec 13 2020, 9:57 PM · Modeling, BF Blender

Dec 7 2020

Janusch Patas (patjan) updated the diff for D9678: Bevel on curves does not create distorted geometry anymore.

Fixes bevel distortion in xy plane.
I gave it some work, but did not manage to fix it when there is beveling in the z direction.
I tried to handle everything with an angle based approach. Right now, I do not know what exactly causes the problems in z direction.

Dec 7 2020, 9:15 PM · Unknown Object (Project), Modeling, Good First Issue

Dec 1 2020

Janusch Patas (patjan) added a comment to D9678: Bevel on curves does not create distorted geometry anymore.

Thank you Jesse Y for pointing out this problem. I have checked why the case you have provided gets degenerated. This patch needs some more work.

Dec 1 2020, 11:56 PM · Unknown Object (Project), Modeling, Good First Issue
Roman (roman13) awarded D9678: Bevel on curves does not create distorted geometry anymore a Love token.
Dec 1 2020, 11:25 AM · Unknown Object (Project), Modeling, Good First Issue
Janusch Patas (patjan) claimed T80979: Bevel on curves created distorted geometry.

A solution is proposed in D9678

Dec 1 2020, 12:08 AM · Unknown Object (Project), Good First Issue, Modeling, BF Blender
Janusch Patas (patjan) retitled D9678: Bevel on curves does not create distorted geometry anymore from This patch adresses the issue described in T80979. Prior to this patch, bevel on curves could create distorted geometry as the same profile was applyed to each segment. This patch adresses the issue by taking into account the angle of the... to Bevel on curves does not create distorted geometry anymore.
Dec 1 2020, 12:06 AM · Unknown Object (Project), Modeling, Good First Issue
Janusch Patas (patjan) added a revision to T80979: Bevel on curves created distorted geometry: D9678: Bevel on curves does not create distorted geometry anymore.
Dec 1 2020, 12:04 AM · Unknown Object (Project), Good First Issue, Modeling, BF Blender
Janusch Patas (patjan) requested review of D9678: Bevel on curves does not create distorted geometry anymore.
Dec 1 2020, 12:03 AM · Unknown Object (Project), Modeling, Good First Issue

Nov 14 2020

Janusch Patas (patjan) added a watcher for Sculpt, Paint & Texture: Janusch Patas (patjan).
Nov 14 2020, 12:53 PM

Nov 10 2020

Janusch Patas (patjan) added a comment to D9509: Fix-T65585: Knife Tool fail if camera is too close to the object and mouse away from object.

Hi Campbell,
probably not. Your fix should be simpler although it either does not investigate the root cause why the mouse coordinates are set to zero.

Nov 10 2020, 8:50 AM · Modeling

Nov 9 2020

Janusch Patas (patjan) added a reviewer for D9509: Fix-T65585: Knife Tool fail if camera is too close to the object and mouse away from object: Modeling.
Nov 9 2020, 12:19 AM · Modeling

Nov 8 2020

Janusch Patas (patjan) updated the summary of D9509: Fix-T65585: Knife Tool fail if camera is too close to the object and mouse away from object.
Nov 8 2020, 11:46 PM · Modeling
Janusch Patas (patjan) claimed T65585: Knife Tool fail if camera is too close to the object and mouse away from object.

I have crafted a fix for this issue. It can be found in D9509

Nov 8 2020, 11:40 PM · Modeling, BF Blender
Janusch Patas (patjan) requested review of D9509: Fix-T65585: Knife Tool fail if camera is too close to the object and mouse away from object.
Nov 8 2020, 11:37 PM · Modeling

Nov 4 2020

Janusch Patas (patjan) updated the diff for D9345: Bugfix T81951 - Add Cube new tool surface snaping not working.
  • SnapObjectContext allocated memory delete code included.
Nov 4 2020, 12:06 AM · Modeling

Nov 3 2020

Janusch Patas (patjan) added a comment to D9334: Fix T82000: Viewport animation render chrashes when collapsing viewport.

Julian, I have tried to incorporate your review to the best of my current knowledge. I hope that I was able to improve the patch.
Merci,
Janusch

Nov 3 2020, 11:29 PM · User Interface, EEVEE & Viewport
Janusch Patas (patjan) updated the diff for D9334: Fix T82000: Viewport animation render chrashes when collapsing viewport.
  • Revision of bugfix
  • BKE_spacedata_copy included.
Nov 3 2020, 11:25 PM · User Interface, EEVEE & Viewport
Janusch Patas (patjan) added a comment to D9345: Bugfix T81951 - Add Cube new tool surface snaping not working.

Thank you Germano. I gonna correct this tonight after work.

Nov 3 2020, 3:40 PM · Modeling

Oct 27 2020

Janusch Patas (patjan) updated the diff for D9334: Fix T82000: Viewport animation render chrashes when collapsing viewport.
  • Revision of Bugfix

Created copies of ARegion and View3D, because this memory is getting freed if viewport is collapsed.

Oct 27 2020, 11:00 AM · User Interface, EEVEE & Viewport

Oct 26 2020

Janusch Patas (patjan) added a comment to D9334: Fix T82000: Viewport animation render chrashes when collapsing viewport.

Thx Brecht, I will resubmit a revision tonight.

Oct 26 2020, 3:18 PM · User Interface, EEVEE & Viewport

Oct 25 2020

Janusch Patas (patjan) updated the summary of D9345: Bugfix T81951 - Add Cube new tool surface snaping not working.
Oct 25 2020, 11:56 PM · Modeling
Janusch Patas (patjan) updated the diff for D9345: Bugfix T81951 - Add Cube new tool surface snaping not working.

Comment added

Oct 25 2020, 11:53 PM · Modeling
Janusch Patas (patjan) requested review of D9345: Bugfix T81951 - Add Cube new tool surface snaping not working.
Oct 25 2020, 11:49 PM · Modeling
Janusch Patas (patjan) added a revision to T81951: Add Cube new tool surface snaping not working: D9345: Bugfix T81951 - Add Cube new tool surface snaping not working.
Oct 25 2020, 11:49 PM · Modeling, BF Blender
Janusch Patas (patjan) claimed T81951: Add Cube new tool surface snaping not working.

I think I found the problem and already prepared a fix. I will link the differential here.

Oct 25 2020, 11:42 PM · Modeling, BF Blender

Oct 24 2020

Janusch Patas (patjan) added reviewers for D9334: Fix T82000: Viewport animation render chrashes when collapsing viewport: User Interface, Good First Issue, EEVEE & Viewport.
Oct 24 2020, 2:00 PM · User Interface, EEVEE & Viewport
Janusch Patas (patjan) updated the summary of D9334: Fix T82000: Viewport animation render chrashes when collapsing viewport.
Oct 24 2020, 1:59 PM · User Interface, EEVEE & Viewport
Janusch Patas (patjan) added a comment to D9334: Fix T82000: Viewport animation render chrashes when collapsing viewport.

I am not sure if this is the best possible solution. I mean it's also kind of a design decision what should happen after another viewport is merged in the one, that triggered the animation rendering? Maybe my solution is okay?

Oct 24 2020, 1:58 PM · User Interface, EEVEE & Viewport
Janusch Patas (patjan) updated the summary of D9334: Fix T82000: Viewport animation render chrashes when collapsing viewport.
Oct 24 2020, 1:55 PM · User Interface, EEVEE & Viewport
Janusch Patas (patjan) claimed T82000: Viewport animation render crashes when collapsing the viewport..

You can find my suggested fix here: https://developer.blender.org/D9334

Oct 24 2020, 1:50 PM · Good First Issue, EEVEE & Viewport, User Interface, BF Blender
Janusch Patas (patjan) requested review of D9334: Fix T82000: Viewport animation render chrashes when collapsing viewport.
Oct 24 2020, 1:48 PM · User Interface, EEVEE & Viewport

Oct 19 2020

Janusch Patas (patjan) claimed T80165: separate by loose parts breaks custom normals.


That's what I get. I am at the most current commit: aa244a7a68d
I would like to try to resolve this one.

Oct 19 2020, 10:36 PM · Modeling, BF Blender
Janusch Patas (patjan) added a comment to T81484: Weight/Vertex paint with mirror and viewport clipping does not update stroke on original side.

Can't reproduce the issue anymore that I have described. Nice :)

Oct 19 2020, 10:10 PM · Modeling, Sculpt, Paint & Texture, BF Blender
Janusch Patas (patjan) added a comment to T81484: Weight/Vertex paint with mirror and viewport clipping does not update stroke on original side.

@Philipp Oeser (lichtwerk): No problem, I was aware of it that's why I asked. I try to get familiar with the code base as as side project by helping fixing bugs. Anyway, I will go for another bug then. I dont know why the clipping did not work in my case. Unfortunately I can't test it right now because I am at work. I will take another look at it tonight.

Oct 19 2020, 1:24 PM · Modeling, Sculpt, Paint & Texture, BF Blender

Oct 18 2020

Janusch Patas (patjan) added a comment to T81484: Weight/Vertex paint with mirror and viewport clipping does not update stroke on original side.

Hey Philipp, I have looked a bit into this one. What I know so far, the bug seems to be unrelated to the mirroring as described. If you simply clip the upper half of the plane in the given file and start painting without mirroring, it already is buggy. You can't cross the y axis.


If you don't mind, I would like to work and help you with this one.

Oct 18 2020, 11:52 PM · Modeling, Sculpt, Paint & Texture, BF Blender

Oct 15 2020

Janusch Patas (patjan) retitled D9217: Bugfix T80768: Subdivision Surface modifier uses viewport subdivision settings when rendering in edit mode from Bugfix T-80768: Subdivision Surface modifier uses viewport subdivision settings when rendering in edit mode to Bugfix T80768: Subdivision Surface modifier uses viewport subdivision settings when rendering in edit mode.
Oct 15 2020, 12:10 AM
Janusch Patas (patjan) requested review of D9217: Bugfix T80768: Subdivision Surface modifier uses viewport subdivision settings when rendering in edit mode.
Oct 15 2020, 12:08 AM

Oct 13 2020

Janusch Patas (patjan) added a revision to T81288: 'Delimit' in 'Select Linked' works unexpectedly when editing multiple objects: D9188: Bugfix T81288 - Delimit in selected linked works unexpectedly when editing multiple objectsx.
Oct 13 2020, 12:27 AM · BF Blender (2.90), Modeling
Janusch Patas (patjan) updated the summary of D9188: Bugfix T81288 - Delimit in selected linked works unexpectedly when editing multiple objectsx.
Oct 13 2020, 12:26 AM
Janusch Patas (patjan) requested review of D9188: Bugfix T81288 - Delimit in selected linked works unexpectedly when editing multiple objectsx.
Oct 13 2020, 12:22 AM

Oct 11 2020

Janusch Patas (patjan) added a watcher for Good First Issue: Janusch Patas (patjan).
Oct 11 2020, 10:36 PM
Janusch Patas (patjan) added a watcher for Modeling: Janusch Patas (patjan).
Oct 11 2020, 10:04 PM