Page MenuHome

Phil Stopford (philstopford)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 12 2018, 4:20 PM (171 w, 1 d)

Recent Activity

Jun 7 2021

Phil Stopford (philstopford) added a comment to D7182: Ocean modifier : expose eigenvectors for use as maps.

This was written with the intent that it would work with the upcoming particle system overhaul. That work was postponed so the spray vector maps aren’t immediately usable within blender for driving particles.
The idea is that each channel of RGB drives velocity in XYZ. These velocity representations come directly from the Jacobian inputs to the foam. I left the option for complementary in the spray because it was not immediately clear what would work best with the particle system when it arrived.

Jun 7 2021, 5:44 AM

Oct 21 2020

Robert Windefjord (Robonnet) awarded D8470: Ocean modifier : allow spray maps to be baked a Love token.
Oct 21 2020, 11:12 AM

Oct 20 2020

Phil Stopford (philstopford) added a comment to rB3d78e98d52d3: Ocean Modifier: allow spray maps to be baked.

No worries - it's all good. :)

Oct 20 2020, 10:42 PM

Sep 28 2020

Peter Söderberg (pipur) awarded rBS6ce709dceb8d: Ocean: add new spectra modes to the ocean modifier a Love token.
Sep 28 2020, 5:41 PM

Sep 22 2020

Phil Stopford (philstopford) added a comment to D8470: Ocean modifier : allow spray maps to be baked.

@Hans Goudey (HooglyBoogly) : I'm not sure how to do that without polluting the cache and/or result in order to track the spray usage (and even foam usage). It looked messy, so I opted to simply go-with-the-flow. This also makes it less awkward for reloading the baked data - I just get what's there and map it in identically to the foam. It's quite a naive approach, but seemed less problematic.

Sep 22 2020, 6:17 PM

Sep 10 2020

Phil Stopford (philstopford) added a comment to D8470: Ocean modifier : allow spray maps to be baked.

@Hans Goudey (HooglyBoogly) : Just nudging this in case it can fit for 2.91. If not, no worries.

Sep 10 2020, 5:59 PM

Sep 7 2020

Phil Stopford (philstopford) added a comment to T80547: Linked copy of a scene : changing values (e.g. scene camera) does not update values in linked copy..

Fundamentally, what I'd like to do is to link the camera and render properties between scene copies. I'd hoped the 'linked copy' did this; hadn't realized it was collections-only at the time. There doesn't seem to be a way to set up drivers to tie scene camera, etc. together across scenes, though.

Sep 7 2020, 8:56 PM · BF Blender
Phil Stopford (philstopford) updated the task description for T80547: Linked copy of a scene : changing values (e.g. scene camera) does not update values in linked copy..
Sep 7 2020, 4:14 AM · BF Blender
Phil Stopford (philstopford) created T80547: Linked copy of a scene : changing values (e.g. scene camera) does not update values in linked copy..
Sep 7 2020, 4:11 AM · BF Blender

Aug 21 2020

Julien Leménicier (mistajuliax) awarded D8470: Ocean modifier : allow spray maps to be baked a Love token.
Aug 21 2020, 10:14 AM

Aug 19 2020

Phil Stopford (philstopford) added a comment to D8470: Ocean modifier : allow spray maps to be baked.

@Hans Goudey (HooglyBoogly) : Not sure about timelines. When might this land?

Aug 19 2020, 3:14 PM

Aug 16 2020

Kenzie (kenziemac130) awarded D8470: Ocean modifier : allow spray maps to be baked a Love token.
Aug 16 2020, 10:57 PM
Phil Stopford (philstopford) awarded D8577: Cloth: New collision algorithm a Mountain of Wealth token.
Aug 16 2020, 6:00 AM

Aug 14 2020

Phil Stopford (philstopford) added a comment to D8470: Ocean modifier : allow spray maps to be baked.

I can't really speak to the utility of the feature, but considering it's basically the same as the foam maps I'd say it's close to there. Two things:

  1. Even though the existing code uses short for the do_spray variables, I think this should probably use bool since it's new code.
Aug 14 2020, 7:51 PM
Phil Stopford (philstopford) added a comment to D8470: Ocean modifier : allow spray maps to be baked.

@Hans Goudey (HooglyBoogly) : Just curious whether you think this is fully baked (ha!) or not as a patch.

Aug 14 2020, 5:40 PM

Aug 5 2020

Phil Stopford (philstopford) requested review of D8470: Ocean modifier : allow spray maps to be baked.
Aug 5 2020, 2:46 AM

Aug 3 2020

Phil Stopford (philstopford) added a comment to rBa44299ccd117: Ocean Modifier: Add viewport resolution.

@Hans Goudey (HooglyBoogly) : I rebuilt from scratch and it worked then. Stale parts of the build, I guess.

Aug 3 2020, 11:12 PM
Phil Stopford (philstopford) added a comment to rBa44299ccd117: Ocean Modifier: Add viewport resolution.

@Hans Goudey (HooglyBoogly) : Your fix didn't seem to resolve it for me here.

Aug 3 2020, 10:24 PM
Phil Stopford (philstopford) added a comment to rBa44299ccd117: Ocean Modifier: Add viewport resolution.

From poking around, it looks like it's the copyData code that is breaking things. I originally thought the use of viewport_resolution would be fine, but it looks like the render pipeline doesn't cause a re-evaluation and re-set of the resolution. I don't have the flag to capture the situation elsewhere, so it drops through the cracks.

Aug 3 2020, 9:35 PM
Phil Stopford (philstopford) added a comment to rB17b89f6dacba: Ocean modifier: Expose eigenvectors for use as map.

Hmm. Indeed caching looks like it needs additional work to implement. Not sure how beneficial that might be, though. As little thought as I gave to caching, I'd anticpated people caching the particles rather than the maps responsible for them. I haven't really made any use of the caching in the ocean modifier; some idea of how prevalent this workflow is and whether caching of spray maps would be useful would be welcome.

Aug 3 2020, 8:10 PM
Phil Stopford (philstopford) added a comment to rB17b89f6dacba: Ocean modifier: Expose eigenvectors for use as map.

@ronan ducluzeau (zeauro) : Per the original differential, 'Assuming the particle system was capable, for example, the eigenvectors could be used to drive spray emission velocities.' It's also not exactly related to the displacement or foam intensity - this is more about an implied surface velocity (of two or more waves coming together, resulting in spray). I used the same approach as foam to offer compatible workflow with foam/displacement exports until such time as the new particle system matures.

Aug 3 2020, 6:38 PM
Phil Stopford (philstopford) updated the diff for D8336: Adding display resolution to ocean modifier.

Hopefully this is what was asked for. Changed the property names and removed the overrides for the UI.

Aug 3 2020, 3:27 PM
Phil Stopford (philstopford) added a comment to D8336: Adding display resolution to ocean modifier.

@Hans Goudey (HooglyBoogly) : would you be able to find time to commit this soon? :)

Aug 3 2020, 5:59 AM

Jul 27 2020

Phil Stopford (philstopford) added a comment to D8336: Adding display resolution to ocean modifier.

@Brecht Van Lommel (brecht) : when would this be merged for 2.91? I know 2.90 is the focus - this isn't intended to hassle, just curious.

Jul 27 2020, 6:10 PM

Jul 22 2020

Phil Stopford (philstopford) added a comment to D8336: Adding display resolution to ocean modifier.

Just curious - missed the cutoff for 2.90 or still a chance?

Jul 22 2020, 7:43 PM

Jul 20 2020

Phil Stopford (philstopford) added a comment to D8336: Adding display resolution to ocean modifier.

I couldn't reproduce the crash. I wonder if it might have been arising from the misplaced versioning code. If it still happens with this patch, could you supply the blend file?

Jul 20 2020, 9:54 PM
Phil Stopford (philstopford) updated the diff for D8336: Adding display resolution to ocean modifier.

'make format'

Jul 20 2020, 9:49 PM
Phil Stopford (philstopford) updated the diff for D8336: Adding display resolution to ocean modifier.

Moved versioning code into the correct place (possibly this caused the crash Hans reported).
Fixed up the without-ocean-modifier function to take the additional resolution parameter.
Fixing up the UI entries (hopefully, although I find this part of blender's code to be rather confusing)

Jul 20 2020, 9:41 PM
Phil Stopford (philstopford) added a comment to D8336: Adding display resolution to ocean modifier.

@Hans Goudey (HooglyBoogly) : anything left for me to fix up here?

Jul 20 2020, 6:06 PM

Jul 19 2020

Phil Stopford (philstopford) updated the summary of D8336: Adding display resolution to ocean modifier.
Jul 19 2020, 6:21 PM

Jul 18 2020

Phil Stopford (philstopford) updated the diff for D8336: Adding display resolution to ocean modifier.

Tooltip and label updates

Jul 18 2020, 7:25 PM
Phil Stopford (philstopford) added a comment to D8336: Adding display resolution to ocean modifier.

No crash here with a file saved from blender 2.83.

Jul 18 2020, 7:25 PM
Phil Stopford (philstopford) retitled D8336: Adding display resolution to ocean modifier from WIP: Adding display resolution to ocean modifier to Adding display resolution to ocean modifier.
Jul 18 2020, 4:20 PM
Phil Stopford (philstopford) added a comment to D8336: Adding display resolution to ocean modifier.

Here's the rename and grouping work for the UI. Padding also removed. Hopefully this ticks all the boxes.

Jul 18 2020, 3:50 PM
Phil Stopford (philstopford) updated the diff for D8336: Adding display resolution to ocean modifier.

Renaming per earlier feedback, remove useless padding

Jul 18 2020, 3:49 PM
Phil Stopford (philstopford) added a comment to D8336: Adding display resolution to ocean modifier.

@Hans Goudey (HooglyBoogly) : does this look cleaner to you?

Jul 18 2020, 5:00 AM
Phil Stopford (philstopford) updated the diff for D8336: Adding display resolution to ocean modifier.

Finding a way to handle older scenes. Still WIP, pending renames (at the very least)

Jul 18 2020, 5:00 AM
Phil Stopford (philstopford) added a comment to D8336: Adding display resolution to ocean modifier.

An ugly workaround would be (in BKE_ocean_init_from_modifier)

Jul 18 2020, 12:05 AM

Jul 17 2020

Phil Stopford (philstopford) added a comment to D8336: Adding display resolution to ocean modifier.

I can of course abuse the versioning system to set ocean_resolution on-load; I'm just not clear yet on the code flow that means the doOcean is not called to set this as I would have expected.

Jul 17 2020, 11:46 PM
Phil Stopford (philstopford) updated the diff for D8336: Adding display resolution to ocean modifier.

Versioning

Jul 17 2020, 11:30 PM
Phil Stopford (philstopford) added a comment to D8336: Adding display resolution to ocean modifier.

The terms we usually use are "Viewport" and "Render" resolution, I would be consistent here.

For getting old files to work, check in the versioning_290.c. I've already done some versioning there for the ocean modifier there for 2.90.

Something like this should work:

if (!DNA_struct_elem_find(fd->filesdna, "OceanModifierData", "int", "viewport_resolution")) {
  for (Object *object = bmain->objects.first; object != NULL; object = object->id.next) {
    LISTBASE_FOREACH (ModifierData *, md, &object->modifiers) {
      if (md->type == eModifierType_Ocean) {
        OceanModifierData *omd = (OceanModifierData *)md;
        omd->viewport_resolution *= omd->resolution;
      }
    }
  }
}
Jul 17 2020, 11:29 PM
Phil Stopford (philstopford) updated the summary of D8336: Adding display resolution to ocean modifier.
Jul 17 2020, 9:03 PM
Phil Stopford (philstopford) requested review of D8336: Adding display resolution to ocean modifier.
Jul 17 2020, 9:01 PM

Jul 1 2020

Phil Stopford (philstopford) updated the diff for D7182: Ocean modifier : expose eigenvectors for use as maps.

Change from gen_spray to use_spray per feedback

Jul 1 2020, 10:27 PM
Phil Stopford (philstopford) added a comment to D7182: Ocean modifier : expose eigenvectors for use as maps.

@Brecht Van Lommel (brecht) : I was using gen because this really generates the map rather than 'uses' it; I find 'use_foam' misleading in that sense. I can change it for consistency, but the modifier never really uses these properties; they are used elsewhere (the modifier generates the data)

Jul 1 2020, 9:40 PM
Phil Stopford (philstopford) added a comment to D7182: Ocean modifier : expose eigenvectors for use as maps.

@Hans Goudey (HooglyBoogly) : is there anything pending? I think your comments are already addressed, unless I missed something. Hoping to move this forward through review. :)

Jul 1 2020, 8:42 PM

Jun 26 2020

Phil Stopford (philstopford) added a comment to D7182: Ocean modifier : expose eigenvectors for use as maps.

Just following up again - not sure there's anything pending here for me to change.

Jun 26 2020, 4:23 PM

Jun 24 2020

Phil Stopford (philstopford) added a comment to D7182: Ocean modifier : expose eigenvectors for use as maps.

The layer data names should already be consistent. I opted for 'generate' rather than 'use' for the spray, as the spray map is generated. It's not actually 'used' by the modifier, so I always felt 'use foam' was wrong - you have to use it somewhere else.

Jun 24 2020, 5:19 AM
Phil Stopford (philstopford) added a comment to D7182: Ocean modifier : expose eigenvectors for use as maps.

Hans, what do you think? Is this OK from your perspective?

Jun 24 2020, 4:52 AM

Jun 19 2020

Phil Stopford (philstopford) updated the diff for D7182: Ocean modifier : expose eigenvectors for use as maps.

Continuing feedback

Jun 19 2020, 5:28 PM
Phil Stopford (philstopford) updated the diff for D7182: Ocean modifier : expose eigenvectors for use as maps.

Responding to feedback. The uninitialized warnings are meaningless - the variables are defined at outer level for scope, but only used in the conditional blocks where they have been initialized. Not sure how this ought to be handled.

Jun 19 2020, 4:00 PM

Jun 5 2020

Phil Stopford (philstopford) added a comment to D7182: Ocean modifier : expose eigenvectors for use as maps.

Jun 5 2020, 10:06 PM
Phil Stopford (philstopford) updated the diff for D7182: Ocean modifier : expose eigenvectors for use as maps.

Last attempt went wrong somewhere. Here's an updated diff responding to the modifier UI changes.

Jun 5 2020, 10:05 PM
Phil Stopford (philstopford) updated the diff for D7182: Ocean modifier : expose eigenvectors for use as maps.

Reworked to respond to recent modifier UI code changes.

Jun 5 2020, 9:32 PM

Jun 2 2020

Phil Stopford (philstopford) awarded D7896: New Sky Texture a Party Time token.
Jun 2 2020, 3:34 PM · Cycles

Apr 23 2020

Phil Stopford (philstopford) added a comment to D7182: Ocean modifier : expose eigenvectors for use as maps.

Gentle nudge for review :)

Apr 23 2020, 10:09 PM

Apr 15 2020

Phil Stopford (philstopford) added a comment to D7182: Ocean modifier : expose eigenvectors for use as maps.

Is master in a position where this could be merged? :)

Apr 15 2020, 10:01 PM

Apr 1 2020

Phil Stopford (philstopford) added a comment to D7182: Ocean modifier : expose eigenvectors for use as maps.

Just wondering if the proposal and differential make sense now and could be signed off

Apr 1 2020, 4:52 PM

Mar 26 2020

Phil Stopford (philstopford) updated the diff for D7182: Ocean modifier : expose eigenvectors for use as maps.

Simplifying UI per feedback.

Mar 26 2020, 5:07 PM
Phil Stopford (philstopford) added a comment to D7182: Ocean modifier : expose eigenvectors for use as maps.

So how about this:

Mar 26 2020, 5:05 PM

Mar 23 2020

Phil Stopford (philstopford) added a comment to D7182: Ocean modifier : expose eigenvectors for use as maps.

Just wondered whether any of those suggested labels might be appropriate.

Mar 23 2020, 11:21 PM

Mar 19 2020

Phil Stopford (philstopford) added a comment to D7182: Ocean modifier : expose eigenvectors for use as maps.

Apologies for the confusion; I was thinking at the individual X->R, Y->G, Z->B level, not as the whole 'vector' - too close to the tree to see the forest. I've tweaked the description to better describe things. I'm very open to whatever label is appropriate and clear. I can live with curvature, but there is an aspect of rate of change to this as well so it might need to be indicated that this is also a rate of change / velocity.

Mar 19 2020, 10:22 PM
Phil Stopford (philstopford) retitled D7182: Ocean modifier : expose eigenvectors for use as maps from Ocean modifier : expose eigenvalue maps for use to Ocean modifier : expose eigenvectors for use as maps.
Mar 19 2020, 10:07 PM
Phil Stopford (philstopford) added a comment to D7182: Ocean modifier : expose eigenvectors for use as maps.

Here's an overview video showing why the terminology is open to debate. The eigenvalues come from the mathematical representation and the minus and plus are essentially complementary. I can't really think of a good general name for this, though, in terms of what it represents. It could be labelled, I guess, as spray veolocity, but there's no spray as such without a particle system, so I am uncertain. The underlying equation is a combination of wave folding and collision.

Mar 19 2020, 8:48 PM
Phil Stopford (philstopford) updated the diff for D7182: Ocean modifier : expose eigenvectors for use as maps.

Python indentation reverted prior to diff being generated. Fixed.

Mar 19 2020, 7:01 PM
Phil Stopford (philstopford) updated the summary of D7182: Ocean modifier : expose eigenvectors for use as maps.
Mar 19 2020, 6:20 PM
Phil Stopford (philstopford) created D7182: Ocean modifier : expose eigenvectors for use as maps.
Mar 19 2020, 6:17 PM

Mar 17 2020

Phil Stopford (philstopford) closed T74851: Material definitions cause blender 2.83 to crash on load as Archived.

The debug suggests an addon is responsible. I'll close this as invalid given the debug output; thanks for the pointer to that - I wasn't aware of its existence.

Mar 17 2020, 5:27 PM · BF Blender
Phil Stopford (philstopford) created T74851: Material definitions cause blender 2.83 to crash on load.
Mar 17 2020, 3:34 PM · BF Blender

Mar 12 2020

Daniel Ulrich (dulrich) awarded rB6ce709dceb8d: Ocean: add new spectra modes to the ocean modifier a Love token.
Mar 12 2020, 8:23 AM
Phil Stopford (philstopford) added a comment to D6889: Adding new spectra to the ocean modifier.

Could this land for 2.83 or will it come later?

Mar 12 2020, 2:15 AM

Mar 9 2020

Jonathan Lampel (jonathanl) awarded D6889: Adding new spectra to the ocean modifier a Love token.
Mar 9 2020, 6:32 PM
Phil Stopford (philstopford) added a comment to D6889: Adding new spectra to the ocean modifier.

Any remaining concerns?

Mar 9 2020, 3:44 PM

Mar 5 2020

Phil Stopford (philstopford) updated the diff for D6889: Adding new spectra to the ocean modifier.

Changed names and descriptions per feedback.
Moved common JONSWAP code (shared between the JONSWAP and TMA choices) into a static float function 'jonswap'. The difference between the two is thus more apparent in code.
Simplified the calculation of the damping across all of the models.

Mar 5 2020, 9:15 PM
Phil Stopford (philstopford) requested review of D6889: Adding new spectra to the ocean modifier.

Request review again based on the comment regarding names/descriptions. I tend to think the existing approach is more user friendly compared to tooltips.

Mar 5 2020, 7:21 PM
Phil Stopford (philstopford) added inline comments to D6889: Adding new spectra to the ocean modifier.
Mar 5 2020, 2:20 PM
Phil Stopford (philstopford) added inline comments to D6889: Adding new spectra to the ocean modifier.
Mar 5 2020, 1:22 AM
Phil Stopford (philstopford) updated the diff for D6889: Adding new spectra to the ocean modifier.

Enum typedef removed
Changed enum names to separate whole words with '_'
Moved static up in source file, removed from header.
Added license information to new header file.
Added guard to new header file.
Added doc block to header file.
Added full-stops to new comments per feedback.

Mar 5 2020, 1:20 AM

Mar 4 2020

Phil Stopford (philstopford) added a comment to D6889: Adding new spectra to the ocean modifier.

Is there anything pending that I overlooked in the requested changes?

Mar 4 2020, 7:32 PM

Mar 3 2020

Phil Stopford (philstopford) added a comment to T55044: Duplicating a node with a driver loses the driver.

@Joshua Leung (aligorith) : I ran into this again recently with 2.82/2.83 code. Is this something that might be discussed, to see whether the animation data could/should be retained for the copy?

Mar 3 2020, 5:53 AM · BF Blender

Mar 2 2020

Phil Stopford (philstopford) updated the diff for D6889: Adding new spectra to the ocean modifier.

Adjusted names of functions per feedback.
Abbreviated Apache license.
Moved struct to a dedicated header file.

Mar 2 2020, 7:12 PM
Phil Stopford (philstopford) added inline comments to D6889: Adding new spectra to the ocean modifier.
Mar 2 2020, 3:21 PM

Mar 1 2020

Phil Stopford (philstopford) added inline comments to D6889: Adding new spectra to the ocean modifier.
Mar 1 2020, 9:47 PM
Phil Stopford (philstopford) updated the diff for D6889: Adding new spectra to the ocean modifier.

Moved apache licensed code to ocean_spectrum.c
Changed names to suggested values.
Hopefully fixed comments to use required convention.
Added some more comments to better explain 'fetch' for the JONSWAP model.
Made UI spectrum show guidance about the spectrum itself.
Removed obsolete 'surface_tension' float.

Mar 1 2020, 9:43 PM
Way awarded D6889: Adding new spectra to the ocean modifier a Pterodactyl token.
Mar 1 2020, 1:28 PM
Everton Schneider (eversimo) awarded D6889: Adding new spectra to the ocean modifier a Love token.
Mar 1 2020, 6:28 AM

Feb 29 2020

Daniel Ulrich (dulrich) awarded D6889: Adding new spectra to the ocean modifier a Love token.
Feb 29 2020, 9:52 PM
Phil Stopford (philstopford) updated the summary of D6889: Adding new spectra to the ocean modifier.
Feb 29 2020, 3:47 PM

Feb 28 2020

Kenzie (kenziemac130) awarded D6871: Ocean modifier RNG/spectrum improvements a Like token.
Feb 28 2020, 3:18 AM

Feb 25 2020

Fran Marz (franMarz) awarded D6889: Adding new spectra to the ocean modifier a Love token.
Feb 25 2020, 4:35 PM

Feb 22 2020

Christoph Werner (Taros) awarded D6871: Ocean modifier RNG/spectrum improvements a Love token.
Feb 22 2020, 1:58 PM

Feb 21 2020

Mark Sutton (MrMargaretScratcher) awarded D6871: Ocean modifier RNG/spectrum improvements a Love token.
Feb 21 2020, 2:45 PM
Dylan Neill (dylanneill) awarded D6871: Ocean modifier RNG/spectrum improvements a Love token.
Feb 21 2020, 4:01 AM

Feb 19 2020

Phil Stopford (philstopford) updated the diff for D6871: Ocean modifier RNG/spectrum improvements.

Addressing nitpick for spacing, using make format to check

Feb 19 2020, 10:56 PM
Kenn Nyström (Frozen_Death_Knight) awarded D6871: Ocean modifier RNG/spectrum improvements a Party Time token.
Feb 19 2020, 10:38 PM
xrg (xrg) awarded D6871: Ocean modifier RNG/spectrum improvements a Like token.
Feb 19 2020, 9:04 PM
Way awarded D6871: Ocean modifier RNG/spectrum improvements a Like token.
Feb 19 2020, 8:24 PM
Phil Stopford (philstopford) created D6889: Adding new spectra to the ocean modifier.
Feb 19 2020, 4:10 PM
Phil Stopford (philstopford) added a comment to D6871: Ocean modifier RNG/spectrum improvements.

Changed to use blender's hash function (I went looking, but somehow missed it originally). RNG approach changed per guidance.

Feb 19 2020, 2:16 PM
Phil Stopford (philstopford) updated the diff for D6871: Ocean modifier RNG/spectrum improvements.

Using blender's hash function with parameter scaling. Changed RNG approach to change seed of existing RNG rather than initialize a new RNG each time.

Feb 19 2020, 2:12 PM