Page MenuHome

Phil Stopford (philstopford)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 12 2018, 4:20 PM (110 w, 3 d)

Recent Activity

Apr 23 2020

Phil Stopford (philstopford) added a comment to D7182: Ocean modifier : expose eigenvectors for use as maps.

Gentle nudge for review :)

Apr 23 2020, 10:09 PM

Apr 15 2020

Phil Stopford (philstopford) added a comment to D7182: Ocean modifier : expose eigenvectors for use as maps.

Is master in a position where this could be merged? :)

Apr 15 2020, 10:01 PM

Apr 1 2020

Phil Stopford (philstopford) added a comment to D7182: Ocean modifier : expose eigenvectors for use as maps.

Just wondering if the proposal and differential make sense now and could be signed off

Apr 1 2020, 4:52 PM

Mar 26 2020

Phil Stopford (philstopford) updated the diff for D7182: Ocean modifier : expose eigenvectors for use as maps.

Simplifying UI per feedback.

Mar 26 2020, 5:07 PM
Phil Stopford (philstopford) added a comment to D7182: Ocean modifier : expose eigenvectors for use as maps.

So how about this:

Mar 26 2020, 5:05 PM

Mar 23 2020

Phil Stopford (philstopford) added a comment to D7182: Ocean modifier : expose eigenvectors for use as maps.

Just wondered whether any of those suggested labels might be appropriate.

Mar 23 2020, 11:21 PM

Mar 19 2020

Phil Stopford (philstopford) added a comment to D7182: Ocean modifier : expose eigenvectors for use as maps.

Apologies for the confusion; I was thinking at the individual X->R, Y->G, Z->B level, not as the whole 'vector' - too close to the tree to see the forest. I've tweaked the description to better describe things. I'm very open to whatever label is appropriate and clear. I can live with curvature, but there is an aspect of rate of change to this as well so it might need to be indicated that this is also a rate of change / velocity.

Mar 19 2020, 10:22 PM
Phil Stopford (philstopford) retitled D7182: Ocean modifier : expose eigenvectors for use as maps from Ocean modifier : expose eigenvalue maps for use to Ocean modifier : expose eigenvectors for use as maps.
Mar 19 2020, 10:07 PM
Phil Stopford (philstopford) added a comment to D7182: Ocean modifier : expose eigenvectors for use as maps.

Here's an overview video showing why the terminology is open to debate. The eigenvalues come from the mathematical representation and the minus and plus are essentially complementary. I can't really think of a good general name for this, though, in terms of what it represents. It could be labelled, I guess, as spray veolocity, but there's no spray as such without a particle system, so I am uncertain. The underlying equation is a combination of wave folding and collision.

Mar 19 2020, 8:48 PM
Phil Stopford (philstopford) updated the diff for D7182: Ocean modifier : expose eigenvectors for use as maps.

Python indentation reverted prior to diff being generated. Fixed.

Mar 19 2020, 7:01 PM
Phil Stopford (philstopford) updated the summary of D7182: Ocean modifier : expose eigenvectors for use as maps.
Mar 19 2020, 6:20 PM
Phil Stopford (philstopford) created D7182: Ocean modifier : expose eigenvectors for use as maps.
Mar 19 2020, 6:17 PM

Mar 17 2020

Phil Stopford (philstopford) closed T74851: Material definitions cause blender 2.83 to crash on load as Invalid.

The debug suggests an addon is responsible. I'll close this as invalid given the debug output; thanks for the pointer to that - I wasn't aware of its existence.

Mar 17 2020, 5:27 PM · BF Blender
Phil Stopford (philstopford) created T74851: Material definitions cause blender 2.83 to crash on load.
Mar 17 2020, 3:34 PM · BF Blender

Mar 12 2020

Daniel Ulrich (dulrich) awarded rB6ce709dceb8d: Ocean: add new spectra modes to the ocean modifier a Love token.
Mar 12 2020, 8:23 AM
Phil Stopford (philstopford) added a comment to D6889: Adding new spectra to the ocean modifier.

Could this land for 2.83 or will it come later?

Mar 12 2020, 2:15 AM

Mar 9 2020

Jonathan Lampel (jonathanl) awarded D6889: Adding new spectra to the ocean modifier a Love token.
Mar 9 2020, 6:32 PM
Phil Stopford (philstopford) added a comment to D6889: Adding new spectra to the ocean modifier.

Any remaining concerns?

Mar 9 2020, 3:44 PM

Mar 5 2020

Phil Stopford (philstopford) updated the diff for D6889: Adding new spectra to the ocean modifier.

Changed names and descriptions per feedback.
Moved common JONSWAP code (shared between the JONSWAP and TMA choices) into a static float function 'jonswap'. The difference between the two is thus more apparent in code.
Simplified the calculation of the damping across all of the models.

Mar 5 2020, 9:15 PM
Phil Stopford (philstopford) requested review of D6889: Adding new spectra to the ocean modifier.

Request review again based on the comment regarding names/descriptions. I tend to think the existing approach is more user friendly compared to tooltips.

Mar 5 2020, 7:21 PM
Phil Stopford (philstopford) added inline comments to D6889: Adding new spectra to the ocean modifier.
Mar 5 2020, 2:20 PM
Phil Stopford (philstopford) added inline comments to D6889: Adding new spectra to the ocean modifier.
Mar 5 2020, 1:22 AM
Phil Stopford (philstopford) updated the diff for D6889: Adding new spectra to the ocean modifier.

Enum typedef removed
Changed enum names to separate whole words with '_'
Moved static up in source file, removed from header.
Added license information to new header file.
Added guard to new header file.
Added doc block to header file.
Added full-stops to new comments per feedback.

Mar 5 2020, 1:20 AM

Mar 4 2020

Phil Stopford (philstopford) added a comment to D6889: Adding new spectra to the ocean modifier.

Is there anything pending that I overlooked in the requested changes?

Mar 4 2020, 7:32 PM

Mar 3 2020

Phil Stopford (philstopford) added a comment to T55044: Duplicating a node with a driver loses the driver.

@Joshua Leung (aligorith) : I ran into this again recently with 2.82/2.83 code. Is this something that might be discussed, to see whether the animation data could/should be retained for the copy?

Mar 3 2020, 5:53 AM · BF Blender

Mar 2 2020

Phil Stopford (philstopford) updated the diff for D6889: Adding new spectra to the ocean modifier.

Adjusted names of functions per feedback.
Abbreviated Apache license.
Moved struct to a dedicated header file.

Mar 2 2020, 7:12 PM
Phil Stopford (philstopford) added inline comments to D6889: Adding new spectra to the ocean modifier.
Mar 2 2020, 3:21 PM

Mar 1 2020

Phil Stopford (philstopford) added inline comments to D6889: Adding new spectra to the ocean modifier.
Mar 1 2020, 9:47 PM
Phil Stopford (philstopford) updated the diff for D6889: Adding new spectra to the ocean modifier.

Moved apache licensed code to ocean_spectrum.c
Changed names to suggested values.
Hopefully fixed comments to use required convention.
Added some more comments to better explain 'fetch' for the JONSWAP model.
Made UI spectrum show guidance about the spectrum itself.
Removed obsolete 'surface_tension' float.

Mar 1 2020, 9:43 PM
Way awarded D6889: Adding new spectra to the ocean modifier a Pterodactyl token.
Mar 1 2020, 1:28 PM
Everton Schneider (eversimo) awarded D6889: Adding new spectra to the ocean modifier a Love token.
Mar 1 2020, 6:28 AM

Feb 29 2020

Daniel Ulrich (dulrich) awarded D6889: Adding new spectra to the ocean modifier a Love token.
Feb 29 2020, 9:52 PM
Phil Stopford (philstopford) updated the summary of D6889: Adding new spectra to the ocean modifier.
Feb 29 2020, 3:47 PM

Feb 28 2020

Alex Strand (astrand130) awarded D6871: Ocean modifier RNG/spectrum improvements a Like token.
Feb 28 2020, 3:18 AM

Feb 25 2020

Fran Marz (franMarz) awarded D6889: Adding new spectra to the ocean modifier a Love token.
Feb 25 2020, 4:35 PM

Feb 22 2020

Christoph Werner (Taros) awarded D6871: Ocean modifier RNG/spectrum improvements a Love token.
Feb 22 2020, 1:58 PM

Feb 21 2020

Mark Sutton (MrMargaretScratcher) awarded D6871: Ocean modifier RNG/spectrum improvements a Love token.
Feb 21 2020, 2:45 PM
Dylan Neill (dylanneill) awarded D6871: Ocean modifier RNG/spectrum improvements a Love token.
Feb 21 2020, 4:01 AM

Feb 19 2020

Phil Stopford (philstopford) updated the diff for D6871: Ocean modifier RNG/spectrum improvements.

Addressing nitpick for spacing, using make format to check

Feb 19 2020, 10:56 PM
Kenn Nyström (Frozen_Death_Knight) awarded D6871: Ocean modifier RNG/spectrum improvements a Party Time token.
Feb 19 2020, 10:38 PM
xrg (xrg) awarded D6871: Ocean modifier RNG/spectrum improvements a Like token.
Feb 19 2020, 9:04 PM
Way awarded D6871: Ocean modifier RNG/spectrum improvements a Like token.
Feb 19 2020, 8:24 PM
Phil Stopford (philstopford) created D6889: Adding new spectra to the ocean modifier.
Feb 19 2020, 4:10 PM
Phil Stopford (philstopford) added a comment to D6871: Ocean modifier RNG/spectrum improvements.

Changed to use blender's hash function (I went looking, but somehow missed it originally). RNG approach changed per guidance.

Feb 19 2020, 2:16 PM
Phil Stopford (philstopford) updated the diff for D6871: Ocean modifier RNG/spectrum improvements.

Using blender's hash function with parameter scaling. Changed RNG approach to change seed of existing RNG rather than initialize a new RNG each time.

Feb 19 2020, 2:12 PM
Fran Marz (franMarz) awarded D6871: Ocean modifier RNG/spectrum improvements a Love token.
Feb 19 2020, 5:11 AM

Feb 18 2020

noki paike (amonpaike) awarded D6871: Ocean modifier RNG/spectrum improvements a Love token.
Feb 18 2020, 5:43 AM

Feb 17 2020

Phil Stopford (philstopford) updated the diff for D6871: Ocean modifier RNG/spectrum improvements.

Used macro, changed comments to fit style guide.

Feb 17 2020, 9:59 PM
Aaron Carlisle (Blendify) awarded D6871: Ocean modifier RNG/spectrum improvements a Love token.
Feb 17 2020, 9:43 PM
Hans Goudey (HooglyBoogly) awarded D6871: Ocean modifier RNG/spectrum improvements a Love token.
Feb 17 2020, 9:06 PM
Phil Stopford (philstopford) added reviewers for D6871: Ocean modifier RNG/spectrum improvements: Campbell Barton (campbellbarton), Howard Trickey (howardt).
Feb 17 2020, 8:12 PM
Jonathan Lampel (jonathanl) awarded D6871: Ocean modifier RNG/spectrum improvements a Love token.
Feb 17 2020, 7:41 PM
Phil Stopford (philstopford) created D6871: Ocean modifier RNG/spectrum improvements.
Feb 17 2020, 5:33 PM

Jan 21 2020

Phil Stopford (philstopford) added a comment to T67126: Blender start up screen scene crashes during render "CUDA error: Illegal address in cuCtxSynchronize(), line 1605".

Looks OK here with the buildbot 2.82 on Windows from Jan 20. It does seem to need more memory than is available on most GPUs (~ 8 GB or so) so the performance is hurt, but the tool no longer crashes or throws an error.

Jan 21 2020, 4:14 PM · Cycles, BF Blender

Oct 2 2019

Phil Stopford (philstopford) awarded T68917: Texture cache and mipmaps a Mountain of Wealth token.
Oct 2 2019, 3:56 AM · Cycles, BF Blender
Phil Stopford (philstopford) awarded D3509: Add support for tiled images and the UDIM naming scheme a Mountain of Wealth token.
Oct 2 2019, 3:54 AM · BF Blender (2.82)

Jul 25 2019

Phil Stopford (philstopford) added a comment to T67594: Loading a scene file from 2.79 that isn't set to use Cycles or Eevee falls back to Eevee and can yield a crash for larger scenes.

i tried to give you a trick to mitigate eevee's fallback for large scene

disable the LoadUI option when opening the file

it work?

Jul 25 2019, 12:55 AM · BF Blender
Phil Stopford (philstopford) added a comment to T67594: Loading a scene file from 2.79 that isn't set to use Cycles or Eevee falls back to Eevee and can yield a crash for larger scenes.

That overlooks the issue of Eevee crashing, though, which is my primary concern here and why I reported the issue. Silently crashing without any guidance to help the user seems like a bad thing. There's zero reason for the user to try 'load UI' when faced with a crash like this. Could the Eevee crash be caught and Workbench invoked as a basic level 'try not to die' mode?

Jul 25 2019, 12:47 AM · BF Blender
Phil Stopford (philstopford) added a comment to T67594: Loading a scene file from 2.79 that isn't set to use Cycles or Eevee falls back to Eevee and can yield a crash for larger scenes.

@dark999 (dark999) : the test scene attached is small and focussed purely on illustrating the fallback to Eevee rather than Cycles. You won't see any errors from it (or at least should not do). For my larger scenes that were built in 2.79 (often with side-by-side configuration for Cycles and V-ray), loading those set for V-ray will fall back to Eevee in 2.80 rather than Cycles, and Eevee can't handle the amount of data (it seems).

Jul 25 2019, 12:22 AM · BF Blender

Jul 24 2019

Phil Stopford (philstopford) added a comment to T67594: Loading a scene file from 2.79 that isn't set to use Cycles or Eevee falls back to Eevee and can yield a crash for larger scenes.

No idea - screenshot attached, in case useful. This is during the load; shortly after this, blender just exits silently to desktop

Jul 24 2019, 6:44 PM · BF Blender
Phil Stopford (philstopford) added a comment to T67594: Loading a scene file from 2.79 that isn't set to use Cycles or Eevee falls back to Eevee and can yield a crash for larger scenes.

I do, but the scene is too large to make a practical reproduction case for the bug tracker. I had complaints for 'too large to be useful' before, so don't want to make that mistake again. The UI is blocked as Eevee is attempting to compile shaders, and I have no way to abort either that process or to change the renderer. The viewport is configured to whatever the fallback is in this case; I'm not actively requesting a render or a render preview in the viewport, and as the UI is blocked, it's impossible to change anyway.

Jul 24 2019, 6:29 PM · BF Blender
Phil Stopford (philstopford) added a comment to T67594: Loading a scene file from 2.79 that isn't set to use Cycles or Eevee falls back to Eevee and can yield a crash for larger scenes.

The issue with Eevee, from the point of view of large scenes, is that it might simply fail due to the scene complexity, and it's unfortunate that its failure crashes the whole of blender. Falling back to something that isn't intimately tied with the GPU (where resources might well be constrained) seems like a safer strategy.

Jul 24 2019, 6:08 PM · BF Blender
Phil Stopford (philstopford) added a comment to T67594: Loading a scene file from 2.79 that isn't set to use Cycles or Eevee falls back to Eevee and can yield a crash for larger scenes.

Jul 24 2019, 4:36 PM · BF Blender
Phil Stopford (philstopford) created T67594: Loading a scene file from 2.79 that isn't set to use Cycles or Eevee falls back to Eevee and can yield a crash for larger scenes.
Jul 24 2019, 4:36 PM · BF Blender

Jul 17 2019

Phil Stopford (philstopford) created T67126: Blender start up screen scene crashes during render "CUDA error: Illegal address in cuCtxSynchronize(), line 1605".
Jul 17 2019, 3:11 PM · Cycles, BF Blender

Sep 14 2018

Phil Stopford (philstopford) added a comment to T56804: OSL bug? (interior shader).

OK. So here's a simpler example, which demonstrates the same problem. The only difference is, again, the negation of the values from the transform("object", P) call. This fixes the texture projection (for the most part). I think this is as simple as it can get.

Sep 14 2018, 6:34 PM · Tracker Curfew, BF Blender
Phil Stopford (philstopford) created T56804: OSL bug? (interior shader).
Sep 14 2018, 5:30 PM · Tracker Curfew, BF Blender

Aug 6 2018

Phil Stopford (philstopford) added a comment to T56247: Blender crashes with attached tiled EXR loaded (generated from attached PNG).

OK. I didn't realize that the time saving was that significant beyond throwing a sphere in; I'll bear that in mind for future reports and apologize for the aggravation caused.

Aug 6 2018, 4:41 PM · BF Blender
Phil Stopford (philstopford) added a comment to T56247: Blender crashes with attached tiled EXR loaded (generated from attached PNG).

Again, I cannot save a blend file because blender instantly crashes when loading the EXR. I get that you're frustrated and consider me to be a contributor to your situation, but I'm genuinely not trying to piss you off here - blender crashes on loading the image. There is no window of opportunity to save a blend file.

Aug 6 2018, 3:03 PM · BF Blender
Phil Stopford (philstopford) raised the priority of T56247: Blender crashes with attached tiled EXR loaded (generated from attached PNG) from 30 to 90.

I'm not sure what the objection is. Providing a blend file is not helpful here - the crash happens loading the EXR image in. I've supplied PNG and the resulting EXR file so that the crash can be better understood (PNG is not crashing, EXR is). Steps are provided. Release information and OS/graphics card information is provided.

Aug 6 2018, 2:13 PM · BF Blender

Aug 5 2018

Phil Stopford (philstopford) added a comment to T56247: Blender crashes with attached tiled EXR loaded (generated from attached PNG).

Aug 5 2018, 11:27 PM · BF Blender
Phil Stopford (philstopford) created T56247: Blender crashes with attached tiled EXR loaded (generated from attached PNG).
Aug 5 2018, 10:52 PM · BF Blender

Jul 6 2018

Phil Stopford (philstopford) updated the task description for T55786: Blender allows node data to be pasted into some input fields - seems wrong.
Jul 6 2018, 3:57 AM · BF Blender
Phil Stopford (philstopford) created T55786: Blender allows node data to be pasted into some input fields - seems wrong.
Jul 6 2018, 3:56 AM · BF Blender

Jun 25 2018

Phil Stopford (philstopford) added a comment to T55610: Renaming a UV map breaks references in UV map nodes.

Indeed. I'm just offering additional background to help any decision from Brecht at this point :)

Jun 25 2018, 2:24 PM · BF Blender
Phil Stopford (philstopford) added a comment to T55610: Renaming a UV map breaks references in UV map nodes.

For additional background, I ran into this following Brecht's advice on devtalk about how to workaround the UV map per object limitation; I went through renaming the UV maps on each object (prior to joining the meshes together) and all of the surfacing broke (since I'd made an explicit reference to each UV map in the surfacing). It was a fair bit of work to fix this up, so it felt like a bug (lack of notification or something)

Jun 25 2018, 1:59 PM · BF Blender
Phil Stopford (philstopford) created T55610: Renaming a UV map breaks references in UV map nodes.
Jun 25 2018, 2:46 AM · BF Blender

Jun 21 2018

Phil Stopford (philstopford) created T55577: Multi-selection : adding multiple objects to a group through 'Add to group'.
Jun 21 2018, 4:39 PM · BF Blender
Phil Stopford (philstopford) added a comment to T55034: Setting duplication group for multiple selected items only affects one item.

Ah, that works. There's a different issue (multi-selection of objects, and 'add to group'). I'll file a separate ticket for this - I guess it's not related to this specific case.

Jun 21 2018, 4:03 PM · BF Blender
Phil Stopford (philstopford) added a comment to T55034: Setting duplication group for multiple selected items only affects one item.

Is this supposed to be resolved in the 2.79 code? I'm still seeing this behavior in the current nightly builds, so wanted to check

Jun 21 2018, 12:02 AM · BF Blender

Jun 20 2018

Phil Stopford (philstopford) created T55561: Dupligroup on particles lies down for change of sizefrom 1.0 to 0.1 and back to 1.0.
Jun 20 2018, 9:30 PM · Physics, BF Blender

Jun 18 2018

Phil Stopford (philstopford) changed the status of T55510: Blender 2.79 daily builds crash when saving a scene with a linked group (from another blend) from Unknown Status to Resolved.

Indeed the build from today seems to be fine.

Jun 18 2018, 3:52 PM · BF Blender

Jun 16 2018

Phil Stopford (philstopford) created T55510: Blender 2.79 daily builds crash when saving a scene with a linked group (from another blend).
Jun 16 2018, 7:23 PM · BF Blender

May 13 2018

Phil Stopford (philstopford) created T55044: Duplicating a node with a driver loses the driver.
May 13 2018, 1:03 AM · BF Blender

May 11 2018

Phil Stopford (philstopford) updated the task description for T55034: Setting duplication group for multiple selected items only affects one item.
May 11 2018, 11:46 PM · BF Blender
Phil Stopford (philstopford) created T55034: Setting duplication group for multiple selected items only affects one item.
May 11 2018, 11:46 PM · BF Blender

Apr 18 2018

Phil Stopford (philstopford) added a comment to T54704: FBX import from modo : blen_read_material assertion failure.

It's reporting as 2.79.3 in the header, so I thought this was 2.79b; I'll ask them why their labeling is misleading. Apologies for the noise.

Apr 18 2018, 1:27 PM · Import/Export, Add-ons

Apr 17 2018

Phil Stopford (philstopford) created T54704: FBX import from modo : blen_read_material assertion failure.
Apr 17 2018, 8:12 PM · Import/Export, Add-ons

Apr 12 2018

Phil Stopford (philstopford) created T54586: FBX importer script lacks try/except handling (integer overflow for read-in values).
Apr 12 2018, 8:48 PM · Import/Export, Add-ons