In D6543#194432, @Wayne Dixon (waylow) wrote:

Thanks for checking it out @Damien Picard (pioverfour)
I'm glad I didn't break it.

Are you the one who commits this to master?

In D6543#194298, @Wayne Dixon (waylow) wrote:

What's the best way for you to do that?
Should I make a patch? (I've never done that before)

Hi,
at the time I made that commit (rBA0f5738d9022c), the add-on didn’t select any transparency whatsoever, as seen in T67239. I just made the commit because the task had been sitting for a while, but the default wasn’t an opinionated choice from me; if a better one can be chosen, that’s good.
But I suspect there may be many usages for this add-on, so choosing a default may not be very easy, and I don’t know the implications of each setting well enough to help here, sorry.

• Rename focus_bone to focus_subtarget
• Use Brecht’s code for Cycles
• Expose the property in Cycles’ UI
  • Side note: the focus_object property does not display the same name in Cycles’ (Focus Object) and Eevee’s UIs (Focus on Object). I named the subtarget property accordingly (Focus Bone, Focus on Bone), but perhaps they should be unified.
• Update source/blender/editors/armature/armature_naming.c and source/blender/depsgraph/intern/builder/deg_builder_relations.cc
  • I don’t properly understand the depsgraph’s logic so I may have got it wrong:
  • the code in deg_builder_relations.cc doesn’t appear to have any effect
  • in armature_naming.c I call DEG_id_tag_update() on the camera data, which isn’t done elsewhere in this file.

In D7012#169725, @Ankit (ankitm) wrote:

you didn't specify any reviewers here?

Ha ha right, but you are still the author! All right, pushing this with commit rBAf4cf9b00db36. Thanks.

@Wayne Dixon (waylow) @Brendon Murphy (meta-androcto) If that’s all right with you I’ll push this new rig to master.

Remove camera sensor width from drivers: this caused delays in the drivers. Also gets rid of two dependency cycles.

Error with previous diff.

• Expose the DOF focus object property in the 2D rig UI, since the Add Empty operator is irrelevant here
• Add @Flavio Perez (flav) as original author of the 2D Camera rig

There is a dependency cycle (unparent chest from ORG-spine.006). This is “not considered a bug” (cf. T69101, T71838, T66814…)

Based on @Jacques Lucke (JacquesLucke)’s answer, this crash actually seems to happen when any error popup is displayed.
For instance:

• Open User Preferences
• In main window, open a text editor and execute some invalid Python code
• Switch to the preferences window without moving the mouse (e.g. Alt + Tab)
• Open…
  • Don’t Save
• Crash

In T73487#861721, @Jacques Lucke (JacquesLucke) wrote:

By "immediatly afterwards" you mean while the error popup is still open? Then yes, I can reproduce it, otherwise not.

Yes, that seems to be the case. Updating description.

In D6543#157089, @Wayne Dixon (waylow) wrote:

git apply -R patch

to revert the changes of the patch.
I'm learning things!

Well, so am I! It makes sense that it exists, but I wouldn’t have thought.

In D6543#156867, @Wayne Dixon (waylow) wrote:

-I've noticed that when you add a rig, the camera doesn't automatically become the active camera for the scene.

Although it’s not Blender’s default behaviour, it makes sense for a camera add-on aimed at creating primary shooting cameras. I’ll do that.

• use object_utils so that objects are added to the Collection collection, as default
• root widget case
• fix root widget size
• set camera as active
• create rig at cursor
• add my name to authors

In D6543#154854, @Wayne Dixon (waylow) wrote:

Ok I think I got the patch applied.
I use git so thanks for that tip ;)

Fix error with MCH name.

Rename aim mechanism to Aim_shape_rotation-MCH

In D6543#154392, @Wayne Dixon (waylow) wrote:

I don't know how to easily download your diff and apply it at my end.
But I think I need to install arc, is that right?

In D6543#154202, @Damien Picard (pioverfour) wrote:

I renamed the camera object from Dolly_camera and Crane_camera to just Camera, because the distinction didn’t seem useful and to simplify the code slightly. Do you agree with that?

I meant to say that I’d like to do that.

Rename Crane_arm and Crane_height back.

In D6543#154194, @Wayne Dixon (waylow) wrote:

I haven't had a proper look at your code yet (I'm hoping to get a chance this Sunday)

Hi, no problem, take your time!

Cleanup: unused variables, indentation, line length, variable names.

• Add back focus lens, focus distance and aperture properties and drivers.
• Add icon for the Add Marker operator
• Increment version

In D6543#153709, @Wayne Dixon (waylow) wrote:

Great, this is exactly what I hoped would happen, someone would fix my errors and help me improve haha.

I like free software :)

D6424 fixed an openGL bug on macos.

Fixed by rBA95e98889aba9.

Fixed by rBA95e98889aba9, after D6424. Thanks!

Hi, thanks! This indeed fixes the bug.

Thanks! No problem at all as far as I can tell. :)

Hi, thanks, but I don’t have commit rights for the manual repo. Who should I ask? the documentation page about contributing doesn’t tell.

Fix typo
Update to reflect recent changes

I proceeded with removing the world maps (rBACab0c257), and replacing presets (rBAC6eb516c).
I also did various fixes and cleanups (rBACb7aae31, rBACbd4f0a0, rBACc74a4e7, rBACb52e776) and fixes to match the online calculator upon which this add-on is based (rBACe79295c, rBACe8696b0).

This bug was introduced by rBA3423174b37a0.
@Alexander Gavrilov (angavrilov) It seems that a 2.81a release is planned, should the fix be backported before then? @Nathan Letwory (jesterking) said “If we do we may wait some extra days to see if any other pressing issue is found”, but I don’t know if this qualifies as a pressing issue.

Hi @Rombout Versluijs (rombout),
thanks for the report but this is completely unrelated to Animall, especially to the Blender 2.80 update. Please open a new bug report.

In D5675#139419, @Ivan Cappiello (icappiello) wrote:

i believe that exposing the need of using a prefix or suffix is better support for the user than answer to all fake bug reports related to a wrong usage of the add-on. If you let people understand what the add-on should work like, they usually learn how to do it. Rigify has suffered for long time of undocumented feature and obscure feature options in the ui.

In D5675#139410, @Ivan Cappiello (icappiello) wrote:

what about a naming section with "suffix" checkbox, a text field and an append/prepend option?

In D5675#139396, @Ivan Cappiello (icappiello) wrote:

i am more concerned about the naming issue:

Since the source rig is by default named metarig, when it generates use to default rig as name. Most people uses it like that.
If you do not append _rig at the end, when making a proxy it will became very difficult to get what you are looking for.
So, yes, it could be removed, but then you have to explain the users they have to put something there to find it later on.
i think this is not good so, in my opinion, _rig should stay.

This was merged in ca85dbc76c57.

Hi @Sergey Sharybin (sergey), thank you.
UVs appear fixed, but I’m not sure about the vertex colors. In the test file below, one vertex of the mesh labeled V-Cols is supposed to go from blue to white on playback.
The one labeled V-groups has one vertex shift to the right with a Displace modifier.
The lattice Points are also animated.

Some fixes for the HDRI point selector, implemented geographic coordinates parser field using a GPL module by Maximilian Högner, to allow users to paste coordinates from an online map.

All right, I’ll give it a rest for the time being, the map can be reimplemented later. The current code for it won’t work at all since it relies on the Display manager class, which I removed. But it was broken for a long time anyway, I had to use Blender 2.75 to see how it behaved.

Fix mirror ball environment formula

I opened a diff at D5825, and restored mirrorball projections for HDRI sun selections.

That’s fine with me. Some points which certainly need discussion are:

• The reimplementation of the HDR and world map modes, which were in my opinion overly complex in the previous version, but maybe they fit others’ use cases. The shader part can definitely be simplified using the new gpu and gpu_extras modules, but I’m not sure about the UI.
  • For the HDR sun selection, I don’t think the user needs to display it permanently, since the purpose is to choose a precise point on the texture and then sync it, so a one-time operation fits better.
  • For the world map, I’m not sure overlaying it on the 3D View or properties panel is right. Maybe displaying it inside an image editor would be better, but I’m not sure yet.

Rebase against @Alexander Gavrilov (angavrilov)’s generation refactor.

@Alexander Gavrilov (angavrilov) Yes, I thought so. I’ll update it as soon as possible.

Committed in rBA0f5738d9022c.