Page MenuHome

Miguel Pozo (pragma37)
Developer

Projects (8)

User Details

User Since
Apr 26 2018, 9:16 PM (240 w, 1 d)

Recent Activity

Wed, Nov 30

Miguel Pozo (pragma37) updated the task description for T101619: Workbench rewrite.
Wed, Nov 30, 6:11 PM · EEVEE & Viewport
Miguel Pozo (pragma37) added a comment to rB6c4c09b2dfa3: Fix T102519: GPU Subdivision : selected vertices not visible in paint mode.

It looks like MeshRenderData::hide_vert and MeshRenderData::select_vert are missing in 3.3.

Wed, Nov 30, 1:04 PM

Tue, Nov 29

Miguel Pozo (pragma37) committed rBcb7e36cfa588: Merge branch 'blender-v3.4-release' (authored by Miguel Pozo (pragma37)).
Merge branch 'blender-v3.4-release'
Tue, Nov 29, 9:06 PM
Miguel Pozo (pragma37) closed T102519: GPU subdivision: vertex paintmask: vertices (or their selection status) not visible in weightpaint/vertexpaint as Resolved by committing rB6c4c09b2dfa3: Fix T102519: GPU Subdivision : selected vertices not visible in paint mode.
Tue, Nov 29, 9:06 PM · Sculpt, Paint & Texture, EEVEE & Viewport, BF Blender
Miguel Pozo (pragma37) committed rB6c4c09b2dfa3: Fix T102519: GPU Subdivision : selected vertices not visible in paint mode (authored by Miguel Pozo (pragma37)).
Fix T102519: GPU Subdivision : selected vertices not visible in paint mode
Tue, Nov 29, 9:05 PM
Miguel Pozo (pragma37) closed D16594: Fix T102519: GPU Subdivision : selected vertices not visible in paint mode.
Tue, Nov 29, 9:05 PM
Miguel Pozo (pragma37) added a comment to T102795: Regression: Stereoscopy checkbox turns the VSE preview black.

Oops! Too late. I didn't notice the commit.

Tue, Nov 29, 5:19 PM · EEVEE & Viewport, BF Blender, Video Sequencer
Miguel Pozo (pragma37) updated subscribers of T102795: Regression: Stereoscopy checkbox turns the VSE preview black.

I've looked into this one and the issue is caused because wm_draw_region_stereo_set is only called when stereo is in use, so multiview_eye is left as STEREO_RIGHT_ID after disabling stereo rendering.

Tue, Nov 29, 5:17 PM · EEVEE & Viewport, BF Blender, Video Sequencer
Miguel Pozo (pragma37) updated the diff for D16594: Fix T102519: GPU Subdivision : selected vertices not visible in paint mode.
  • Replace GPU_COMP_I8 with GPU_COM_I32
Tue, Nov 29, 3:29 PM

Mon, Nov 28

Miguel Pozo (pragma37) updated the diff for D16594: Fix T102519: GPU Subdivision : selected vertices not visible in paint mode.
  • ensure the buffer can hold the entire int
  • ensure flag_format is only initialized once
  • Remap flag to to signed char range
  • Remove poly_hidden (causes visible verts to get hidden)
Mon, Nov 28, 5:56 PM
Miguel Pozo (pragma37) added a comment to rBa84c92fc73d3: Fix T98989: Performance regression when using multiple bump nodes.

You can safely set that line back to ENUM_OPERATORS(eGPUNodeTag, GPU_NODE_TAG_FUNCTION) for 3.3.
I think I should have made that change in a separate (preceding) commit.

Mon, Nov 28, 3:12 PM

Sun, Nov 27

Miguel Pozo (pragma37) closed T102777: Regression: GPU Subdivision: Geometry artifacts with subdivision surface as Resolved.

I accidentally swapped two enums in D16420.
Should be fixed now.

Sun, Nov 27, 2:48 PM · EEVEE & Viewport, Modifiers, BF Blender
Miguel Pozo (pragma37) committed rBea384fc09612: Merge branch 'blender-v3.4-release' (authored by Miguel Pozo (pragma37)).
Merge branch 'blender-v3.4-release'
Sun, Nov 27, 2:41 PM
Miguel Pozo (pragma37) closed T102773: Regression: Scrambled assigned materials with Subdivision modifier levels as Resolved by committing rB41733a9c08ee: Fix T102773 & T102777: Regressions in GPU Subdivision.
Sun, Nov 27, 2:41 PM · EEVEE & Viewport, Modifiers, BF Blender
Miguel Pozo (pragma37) committed rB6cd441fdacd2: Draw: GPU Subdivision: Add missing case in get_shader_code (authored by Miguel Pozo (pragma37)).
Draw: GPU Subdivision: Add missing case in get_shader_code
Sun, Nov 27, 2:41 PM
Miguel Pozo (pragma37) committed rB41733a9c08ee: Fix T102773 & T102777: Regressions in GPU Subdivision (authored by Miguel Pozo (pragma37)).
Fix T102773 & T102777: Regressions in GPU Subdivision
Sun, Nov 27, 2:41 PM

Fri, Nov 25

Miguel Pozo (pragma37) updated subscribers of T99629: Wrong tangent space when using GPU subdivisions.

The issue is that the GPU subdivision code just interpolates the base mesh tangents instead of actually computing them after the subdivision.
Since flat-shaded quads have the same tangent in all of their corners, the interpolation effectively does nothing.

Fri, Nov 25, 5:33 PM · EEVEE & Viewport, BF Blender
Miguel Pozo (pragma37) updated the summary of D16594: Fix T102519: GPU Subdivision : selected vertices not visible in paint mode.
Fri, Nov 25, 3:39 PM
Miguel Pozo (pragma37) added a comment to D16594: Fix T102519: GPU Subdivision : selected vertices not visible in paint mode.

These callbacks (iter_subdiv_bm and iter_subdiv_mesh) are generally used either to prepare coarse data for GPU processing, or to generate subdivided data which cannot be done on the GPU. The semantic depends on which data we have to prepare. In this case it will be the first case (prepare coarse data).

Fri, Nov 25, 3:37 PM
Miguel Pozo (pragma37) updated the task description for T100749: Blender LTS: Maintenance Task 3.3.
Fri, Nov 25, 12:58 PM · BF Blender (3.3)
Miguel Pozo (pragma37) committed rB6422f75088aa: Merge branch 'blender-v3.4-release' (authored by Miguel Pozo (pragma37)).
Merge branch 'blender-v3.4-release'
Fri, Nov 25, 12:44 PM
Miguel Pozo (pragma37) committed rBb918c079daf5: Fix T101402: EEVEE: Wrong Volume transforms (authored by Miguel Pozo (pragma37)).
Fix T101402: EEVEE: Wrong Volume transforms
Fri, Nov 25, 12:44 PM
Miguel Pozo (pragma37) closed T101402: Regression: when the scene has multiple volumes, some of them get wrong transformation in Eevee's render as Resolved by committing rBb918c079daf5: Fix T101402: EEVEE: Wrong Volume transforms.
Fri, Nov 25, 12:44 PM · EEVEE & Viewport, BF Blender
Miguel Pozo (pragma37) closed D16607: Fix T101402: EEVEE: Wrong Volume transforms.
Fri, Nov 25, 12:44 PM

Thu, Nov 24

Miguel Pozo (pragma37) added a revision to T101402: Regression: when the scene has multiple volumes, some of them get wrong transformation in Eevee's render: D16607: Fix T101402: EEVEE: Wrong Volume transforms.
Thu, Nov 24, 8:11 PM · EEVEE & Viewport, BF Blender
Miguel Pozo (pragma37) added a task to D16607: Fix T101402: EEVEE: Wrong Volume transforms: T101402: Regression: when the scene has multiple volumes, some of them get wrong transformation in Eevee's render.
Thu, Nov 24, 8:10 PM
Miguel Pozo (pragma37) requested review of D16607: Fix T101402: EEVEE: Wrong Volume transforms.
Thu, Nov 24, 8:09 PM
Miguel Pozo (pragma37) claimed T101402: Regression: when the scene has multiple volumes, some of them get wrong transformation in Eevee's render.
Thu, Nov 24, 8:02 PM · EEVEE & Viewport, BF Blender
Miguel Pozo (pragma37) added inline comments to D16594: Fix T102519: GPU Subdivision : selected vertices not visible in paint mode.
Thu, Nov 24, 4:21 PM
Miguel Pozo (pragma37) updated the diff for D16594: Fix T102519: GPU Subdivision : selected vertices not visible in paint mode.
  • Remove comment
Thu, Nov 24, 4:20 PM
Miguel Pozo (pragma37) added a comment to D16594: Fix T102519: GPU Subdivision : selected vertices not visible in paint mode.

If the selection state may be changed in paint mode then it should be moved to somewhere more dynamic (like for edit mode flags). As a rule of thumb, the subdivision code should follow what the non subdivision code is doing (I am not sure where it is done for the non-subdivision case).

Thu, Nov 24, 4:17 PM
Miguel Pozo (pragma37) added a comment to rB17e562311f9f: Draw: Use 32-bit floats for custom color attributes.

This was implemented as part of D16420 but it was split into its own commit.
The Color option explicitly mentions it's a 32-bit floating point property on the UI, so a 16-bit float unit didn't provide the expected behavior in the shader.
If bandwidth/performance is an issue, the user still has the Byte Color option, and Vertex Colors are Byte Color by default.
The Byte Color option should be 8 bits instead of 16, but it's currently not possible to do so since colors vbos are assumed to be in linear space and the conversion would introduce a loss of precision.

Thu, Nov 24, 3:47 PM
Miguel Pozo (pragma37) committed rB1b7b996e160c: Merge branch 'blender-v3.4-release' (authored by Miguel Pozo (pragma37)).
Merge branch 'blender-v3.4-release'
Thu, Nov 24, 1:37 PM
Miguel Pozo (pragma37) committed rB17e562311f9f: Draw: Use 32-bit floats for custom color attributes (authored by Miguel Pozo (pragma37)).
Draw: Use 32-bit floats for custom color attributes
Thu, Nov 24, 1:37 PM
Miguel Pozo (pragma37) committed rB2a53e0f4376d: FIX T102076: Add support for int attributes to draw manager. (authored by Miguel Pozo (pragma37)).
FIX T102076: Add support for int attributes to draw manager.
Thu, Nov 24, 1:37 PM
Miguel Pozo (pragma37) closed T102076: Material can't read integer properties as Resolved by committing rB2a53e0f4376d: FIX T102076: Add support for int attributes to draw manager..
Thu, Nov 24, 1:36 PM · EEVEE & Viewport, BF Blender
Miguel Pozo (pragma37) closed D16420: FIX T102076: Add support for int attributes to draw manager..
Thu, Nov 24, 1:36 PM · EEVEE & Viewport
Miguel Pozo (pragma37) updated the diff for D16420: FIX T102076: Add support for int attributes to draw manager..
  • remove fetch_mode from parameters
  • clean-up
Thu, Nov 24, 1:15 PM · EEVEE & Viewport
Jacob Merrill (blueprintrandom) awarded D16420: FIX T102076: Add support for int attributes to draw manager. a Love token.
Thu, Nov 24, 4:09 AM · EEVEE & Viewport

Wed, Nov 23

silex (silex) awarded T101619: Workbench rewrite a Love token.
Wed, Nov 23, 10:05 PM · EEVEE & Viewport
Miguel Pozo (pragma37) added a comment to T102519: GPU subdivision: vertex paintmask: vertices (or their selection status) not visible in weightpaint/vertexpaint.

This was marked as a regression, and as working in Blender 3.0.1,
but AFAIK GPU subdivision was implemented in 3.1 and this has never worked.

Wed, Nov 23, 5:33 PM · Sculpt, Paint & Texture, EEVEE & Viewport, BF Blender
Miguel Pozo (pragma37) updated the task description for T102519: GPU subdivision: vertex paintmask: vertices (or their selection status) not visible in weightpaint/vertexpaint.
Wed, Nov 23, 5:31 PM · Sculpt, Paint & Texture, EEVEE & Viewport, BF Blender
Miguel Pozo (pragma37) renamed T102519: GPU subdivision: vertex paintmask: vertices (or their selection status) not visible in weightpaint/vertexpaint from Regression: GPU subdivision: vertex paintmask: vertices (or their selection status) not visible in weightpaint/vertexpaint to GPU subdivision: vertex paintmask: vertices (or their selection status) not visible in weightpaint/vertexpaint.
Wed, Nov 23, 5:30 PM · Sculpt, Paint & Texture, EEVEE & Viewport, BF Blender
Miguel Pozo (pragma37) added a revision to T102519: GPU subdivision: vertex paintmask: vertices (or their selection status) not visible in weightpaint/vertexpaint: D16594: Fix T102519: GPU Subdivision : selected vertices not visible in paint mode.
Wed, Nov 23, 5:25 PM · Sculpt, Paint & Texture, EEVEE & Viewport, BF Blender
Miguel Pozo (pragma37) added a task to D16594: Fix T102519: GPU Subdivision : selected vertices not visible in paint mode: T102519: GPU subdivision: vertex paintmask: vertices (or their selection status) not visible in weightpaint/vertexpaint.
Wed, Nov 23, 5:24 PM
Miguel Pozo (pragma37) requested review of D16594: Fix T102519: GPU Subdivision : selected vertices not visible in paint mode.
Wed, Nov 23, 5:22 PM
Miguel Pozo (pragma37) claimed T102519: GPU subdivision: vertex paintmask: vertices (or their selection status) not visible in weightpaint/vertexpaint.
Wed, Nov 23, 4:03 PM · Sculpt, Paint & Texture, EEVEE & Viewport, BF Blender

Tue, Nov 22

Miguel Pozo (pragma37) committed rB51f56e71cbf2: Merge branch 'blender-v3.4-release' (authored by Miguel Pozo (pragma37)).
Merge branch 'blender-v3.4-release'
Tue, Nov 22, 1:42 PM
Miguel Pozo (pragma37) closed T100904: SSS effect disappears when Mix Shader Node includes Shader To RGB Node as Resolved by committing rB6d7a067a83bb: Fix T100904: Shader Nodes: Optimize-out inactive mix branches.
Tue, Nov 22, 1:41 PM · EEVEE & Viewport, BF Blender
Miguel Pozo (pragma37) committed rB6d7a067a83bb: Fix T100904: Shader Nodes: Optimize-out inactive mix branches (authored by Miguel Pozo (pragma37)).
Fix T100904: Shader Nodes: Optimize-out inactive mix branches
Tue, Nov 22, 1:41 PM
Miguel Pozo (pragma37) closed D16533: Fix T100904: Shader Nodes: Optimize-out inactive mix branches.
Tue, Nov 22, 1:41 PM
Miguel Pozo (pragma37) updated the diff for D16533: Fix T100904: Shader Nodes: Optimize-out inactive mix branches.

Update warning comment

Tue, Nov 22, 1:40 PM
Miguel Pozo (pragma37) added inline comments to D16420: FIX T102076: Add support for int attributes to draw manager..
Tue, Nov 22, 1:36 PM · EEVEE & Viewport

Mon, Nov 21

Miguel Pozo (pragma37) added a reviewer for D16533: Fix T100904: Shader Nodes: Optimize-out inactive mix branches: Jeroen Bakker (jbakker).
Mon, Nov 21, 11:52 AM

Fri, Nov 18

Miguel Pozo (pragma37) updated the diff for D16420: FIX T102076: Add support for int attributes to draw manager..
  • Use floats for CD_PROP_COLOR
  • de-duplicate extract_attr code
Fri, Nov 18, 6:24 PM · EEVEE & Viewport
Miguel Pozo (pragma37) updated the diff for D16420: FIX T102076: Add support for int attributes to draw manager..
  • Add support for custom int attributes
  • Ensure cached shaders match their intended defines
  • Round interpolated int attributes (match CPU behavior)
Fri, Nov 18, 4:13 PM · EEVEE & Viewport
Charlie Jolly (charlie) awarded D16420: FIX T102076: Add support for int attributes to draw manager. a Love token.
Fri, Nov 18, 3:49 PM · EEVEE & Viewport
Miguel Pozo (pragma37) added a reviewer for D16420: FIX T102076: Add support for int attributes to draw manager.: Kévin Dietrich (kevindietrich).
Fri, Nov 18, 3:42 PM · EEVEE & Viewport
Miguel Pozo (pragma37) updated the diff for D16420: FIX T102076: Add support for int attributes to draw manager..
  • Add support for int properties in gpu subdiv
  • Ensure cached shaders match their intended defines
Fri, Nov 18, 3:40 PM · EEVEE & Viewport
Miguel Pozo (pragma37) claimed T102076: Material can't read integer properties.
Fri, Nov 18, 3:36 PM · EEVEE & Viewport, BF Blender
Miguel Pozo (pragma37) commandeered D16420: FIX T102076: Add support for int attributes to draw manager..
Fri, Nov 18, 3:35 PM · EEVEE & Viewport

Thu, Nov 17

Miguel Pozo (pragma37) updated the diff for D16533: Fix T100904: Shader Nodes: Optimize-out inactive mix branches.

Add comments.

Thu, Nov 17, 6:06 PM
Miguel Pozo (pragma37) added a comment to D16533: Fix T100904: Shader Nodes: Optimize-out inactive mix branches.

I think, ideally, this should be something that the nodes themselves should be able to do.
Have something like an optimization pass that removes hidden links, and add some per-node type callback to tell what links can be safely disabled.

Thu, Nov 17, 5:10 PM
Miguel Pozo (pragma37) added a comment to D16420: FIX T102076: Add support for int attributes to draw manager..

Well... this escalated quickly:

Thu, Nov 17, 4:51 PM · EEVEE & Viewport
Miguel Pozo (pragma37) updated the diff for D16533: Fix T100904: Shader Nodes: Optimize-out inactive mix branches.

Updated with the requested changes.
Added support for vector factors.
Hidden socket links are now removed as well.

Thu, Nov 17, 4:08 PM
Miguel Pozo (pragma37) added inline comments to D16533: Fix T100904: Shader Nodes: Optimize-out inactive mix branches.
Thu, Nov 17, 1:49 PM
Miguel Pozo (pragma37) added a revision to T100904: SSS effect disappears when Mix Shader Node includes Shader To RGB Node: D16533: Fix T100904: Shader Nodes: Optimize-out inactive mix branches.
Thu, Nov 17, 1:02 PM · EEVEE & Viewport, BF Blender
Miguel Pozo (pragma37) added a task to D16533: Fix T100904: Shader Nodes: Optimize-out inactive mix branches: T100904: SSS effect disappears when Mix Shader Node includes Shader To RGB Node.
Thu, Nov 17, 1:02 PM
Miguel Pozo (pragma37) claimed T100904: SSS effect disappears when Mix Shader Node includes Shader To RGB Node.
Thu, Nov 17, 1:02 PM · EEVEE & Viewport, BF Blender
Miguel Pozo (pragma37) requested review of D16533: Fix T100904: Shader Nodes: Optimize-out inactive mix branches.
Thu, Nov 17, 1:01 PM

Wed, Nov 16

Miguel Pozo (pragma37) added a comment to D16420: FIX T102076: Add support for int attributes to draw manager..

I got it working, but it needs some cleanup:

Wed, Nov 16, 6:26 PM · EEVEE & Viewport
Miguel Pozo (pragma37) added a comment to D16420: FIX T102076: Add support for int attributes to draw manager..

Yep, it looks like right now only uint16 or float buffers are supported:
https://developer.blender.org/diffusion/B/browse/master/source/blender/draw/intern/draw_cache_impl_subdivision.cc$1504
https://developer.blender.org/diffusion/B/browse/master/source/blender/draw/intern/shaders/common_subdiv_custom_data_interp_comp.glsl

Wed, Nov 16, 5:33 PM · EEVEE & Viewport
Miguel Pozo (pragma37) added a comment to D16420: FIX T102076: Add support for int attributes to draw manager..

Ok, so those wrong int values are actually the right float values stored inside an int buffer.

Wed, Nov 16, 4:49 PM · EEVEE & Viewport
Miguel Pozo (pragma37) added a comment to D16420: FIX T102076: Add support for int attributes to draw manager..

The (wrong) values are the same they were:

Wed, Nov 16, 4:10 PM · EEVEE & Viewport
Miguel Pozo (pragma37) added a comment to D16420: FIX T102076: Add support for int attributes to draw manager..

Now it breaks with GPU Subdivision. :(


Wed, Nov 16, 3:53 PM · EEVEE & Viewport

Tue, Nov 15

Miguel Pozo (pragma37) committed rBb8fd474bb1b0: Merge branch 'blender-v3.4-release' (authored by Miguel Pozo (pragma37)).
Merge branch 'blender-v3.4-release'
Tue, Nov 15, 6:41 PM
Miguel Pozo (pragma37) closed T101965: EEVEE - Lights stops casting shadows w/ sliders as Resolved by committing rB8831c6f05618: Fix T101965: Shadow bounds ignore the light Volume Factor.
Tue, Nov 15, 6:41 PM · EEVEE & Viewport, BF Blender
Miguel Pozo (pragma37) committed rB8831c6f05618: Fix T101965: Shadow bounds ignore the light Volume Factor (authored by Miguel Pozo (pragma37)).
Fix T101965: Shadow bounds ignore the light Volume Factor
Tue, Nov 15, 6:41 PM
Miguel Pozo (pragma37) closed D16513: Fix T101965: Shadow bounds ignore the light Volume Factor.
Tue, Nov 15, 6:41 PM
Miguel Pozo (pragma37) added a revision to T101965: EEVEE - Lights stops casting shadows w/ sliders: D16513: Fix T101965: Shadow bounds ignore the light Volume Factor.
Tue, Nov 15, 4:46 PM · EEVEE & Viewport, BF Blender
Miguel Pozo (pragma37) added a task to D16513: Fix T101965: Shadow bounds ignore the light Volume Factor: T101965: EEVEE - Lights stops casting shadows w/ sliders.
Tue, Nov 15, 4:46 PM
Miguel Pozo (pragma37) claimed T101965: EEVEE - Lights stops casting shadows w/ sliders.
Tue, Nov 15, 4:44 PM · EEVEE & Viewport, BF Blender
Miguel Pozo (pragma37) requested review of D16513: Fix T101965: Shadow bounds ignore the light Volume Factor.
Tue, Nov 15, 4:44 PM
Miguel Pozo (pragma37) merged T101817: EEVEE - Custom camera type has a high DoF by default into T101533: Regression: Stretched image in the viewport when viewed from the lamp object.
Tue, Nov 15, 4:17 PM · EEVEE & Viewport, BF Blender
Miguel Pozo (pragma37) merged task T101817: EEVEE - Custom camera type has a high DoF by default into T101533: Regression: Stretched image in the viewport when viewed from the lamp object.
Tue, Nov 15, 4:17 PM · EEVEE & Viewport, BF Blender
Miguel Pozo (pragma37) added a comment to D16420: FIX T102076: Add support for int attributes to draw manager..

It works with GPU subdivision, though, which I guess follows a different load path.

Tue, Nov 15, 2:04 PM · EEVEE & Viewport
Miguel Pozo (pragma37) added a comment to D16420: FIX T102076: Add support for int attributes to draw manager..

This is not working for me (Windows 10, Nvidia RTX 3060ti).

Tue, Nov 15, 1:57 PM · EEVEE & Viewport
Miguel Pozo (pragma37) committed rB191a3bf2ad0d: Merge branch 'blender-v3.4-release' (authored by Miguel Pozo (pragma37)).
Merge branch 'blender-v3.4-release'
Tue, Nov 15, 1:08 PM
Miguel Pozo (pragma37) committed rBd2728868c01d: GPU: Improve Codegen variable names (authored by Miguel Pozo (pragma37)).
GPU: Improve Codegen variable names
Tue, Nov 15, 1:08 PM
Miguel Pozo (pragma37) closed D16496: GPU: Improve Codegen variable names.
Tue, Nov 15, 1:08 PM
Miguel Pozo (pragma37) closed T101562: 7 mod 7 in Eevee Math Node return an incorrect value as Resolved by committing rB21eeedfc60b5: Fix T101562: GPU: Update fmod to match Cycles/OSL behavior.
Tue, Nov 15, 1:05 PM · EEVEE & Viewport, BF Blender
Miguel Pozo (pragma37) committed rB21eeedfc60b5: Fix T101562: GPU: Update fmod to match Cycles/OSL behavior (authored by Miguel Pozo (pragma37)).
Fix T101562: GPU: Update fmod to match Cycles/OSL behavior
Tue, Nov 15, 1:05 PM
Miguel Pozo (pragma37) closed D16497: Fix T101562: GPU: Update fmod to match Cycles/OSL behavior.
Tue, Nov 15, 1:05 PM

Mon, Nov 14

Miguel Pozo (pragma37) added a comment to T101197: EEVEE: Nishita Sky change Sun Rotation causes shader recompilation.

While the recompilation issue is trivial to fix (just change the sun_rotation from GPU_constant to GPU_variable in node_shader_text_sky.cc),
the real bottleneck is pre-computing the sky texture.

Mon, Nov 14, 6:21 PM · EEVEE & Viewport, BF Blender
Evan Wilson (EAW) awarded D16496: GPU: Improve Codegen variable names a Like token.
Mon, Nov 14, 5:52 PM
Miguel Pozo (pragma37) added a comment to T100420: HDRI reflections don't work properly with normal maps.

Here you can see examples of why this is needed: https://developer.blender.org/rB1c22b551d0c13ad90bdc6145e6fa7db763038523

Mon, Nov 14, 5:32 PM · EEVEE & Viewport, BF Blender
Miguel Pozo (pragma37) closed T97024: FPS dropped significantly when resizing window that also resizing viewport in material preview mode as Archived.

I think it is safe to archive this.

Mon, Nov 14, 4:59 PM · EEVEE & Viewport, BF Blender
Miguel Pozo (pragma37) added a revision to T101562: 7 mod 7 in Eevee Math Node return an incorrect value: D16497: Fix T101562: GPU: Update fmod to match Cycles/OSL behavior.
Mon, Nov 14, 4:16 PM · EEVEE & Viewport, BF Blender
Miguel Pozo (pragma37) added a task to D16497: Fix T101562: GPU: Update fmod to match Cycles/OSL behavior: T101562: 7 mod 7 in Eevee Math Node return an incorrect value.
Mon, Nov 14, 4:15 PM
Miguel Pozo (pragma37) requested review of D16497: Fix T101562: GPU: Update fmod to match Cycles/OSL behavior.
Mon, Nov 14, 4:14 PM