Page MenuHome

Maxim Vasiliev (qmax)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 2 2010, 9:45 PM (520 w, 5 d)

Recent Activity

Apr 6 2020

Germano Cavalcante (mano-wii) awarded rBc544df997ed9: Fix user counting when ungrouping a node group. a Like token.
Apr 6 2020, 4:40 PM

Apr 4 2020

Maxim Vasiliev (qmax) added a reviewer for D7332: Fix user counting when ungrouping: Bastien Montagne (mont29).
Apr 4 2020, 5:02 AM · Data, Assets & I/O
Maxim Vasiliev (qmax) added a revision to T74665: Ungrouping destroys NodeCustomGroups: D7332: Fix user counting when ungrouping.
Apr 4 2020, 5:01 AM · Data, Assets & I/O, Nodes, BF Blender
Maxim Vasiliev (qmax) added a revision to T74682: Ungroup Node Groups doesn't update its user count: D7332: Fix user counting when ungrouping.
Apr 4 2020, 5:01 AM · Nodes, Data, Assets & I/O, BF Blender
Maxim Vasiliev (qmax) added tasks to D7332: Fix user counting when ungrouping: T74665: Ungrouping destroys NodeCustomGroups, T74682: Ungroup Node Groups doesn't update its user count.
Apr 4 2020, 5:01 AM · Data, Assets & I/O
Maxim Vasiliev (qmax) created D7332: Fix user counting when ungrouping.
Apr 4 2020, 4:59 AM · Data, Assets & I/O

Mar 31 2020

Maxim Vasiliev (qmax) added a comment to D6484: Fix broken python nodes API and user counting on ungrouping.

Am not so happy with the direction of that patch in fact... This is adding more special handling all over the codebase, when there has been a constant effort over the past years now to factorize id management code in BKE_lib area...

In short, why are ntree_pycall_copyfunc(new_ntree, src_ntree); calls not simply put at the end of BKE_id_copy_ex() instead of being spread all over copying cases like that?

Mar 31 2020, 6:10 PM · Python API, Nodes & Physics, Data, Assets & I/O, BF Blender, Add-ons (BF-Blender), Nodes

Mar 24 2020

Maxim Vasiliev (qmax) added a comment to D6484: Fix broken python nodes API and user counting on ungrouping.

from a quick look at the code this seems to be going in the good direction, but i cannot apply the patch on current master, can you please update it? Hard to do a review on phab when there is no context available for code ;)

Mar 24 2020, 11:58 AM · Python API, Nodes & Physics, Data, Assets & I/O, BF Blender, Add-ons (BF-Blender), Nodes
Maxim Vasiliev (qmax) updated the diff for D6484: Fix broken python nodes API and user counting on ungrouping.

rebased to 28827b62f7777a51bb4899021b5248486d2a4687

Mar 24 2020, 11:13 AM · Python API, Nodes & Physics, Data, Assets & I/O, BF Blender, Add-ons (BF-Blender), Nodes

Mar 15 2020

Maxim Vasiliev (qmax) added a revision to T74792: Some nodes have ambiguois sockets names: D7152: Fix input sockets names to make them unique and possible to use as keys.
Mar 15 2020, 10:33 PM · Nodes, BF Blender
Maxim Vasiliev (qmax) added a task to D7152: Fix input sockets names to make them unique and possible to use as keys: T74792: Some nodes have ambiguois sockets names.
Mar 15 2020, 10:33 PM
Maxim Vasiliev (qmax) created D7152: Fix input sockets names to make them unique and possible to use as keys.
Mar 15 2020, 10:33 PM
Maxim Vasiliev (qmax) created T74792: Some nodes have ambiguois sockets names.
Mar 15 2020, 10:01 PM · Nodes, BF Blender

Mar 12 2020

Maxim Vasiliev (qmax) added a comment to T74665: Ungrouping destroys NodeCustomGroups.

Apparently, this bug used to be compensated by another bug, adressed in rBe993667a46c2

Mar 12 2020, 8:17 PM · Data, Assets & I/O, Nodes, BF Blender
Maxim Vasiliev (qmax) added a comment to T74665: Ungrouping destroys NodeCustomGroups.

This also affects ordinary nested groups.

Mar 12 2020, 7:42 PM · Data, Assets & I/O, Nodes, BF Blender
Maxim Vasiliev (qmax) added a task to D6484: Fix broken python nodes API and user counting on ungrouping: T74682: Ungroup Node Groups doesn't update its user count.
Mar 12 2020, 7:10 PM · Python API, Nodes & Physics, Data, Assets & I/O, BF Blender, Add-ons (BF-Blender), Nodes
Maxim Vasiliev (qmax) added a revision to T74682: Ungroup Node Groups doesn't update its user count: D6484: Fix broken python nodes API and user counting on ungrouping.
Mar 12 2020, 7:10 PM · Nodes, Data, Assets & I/O, BF Blender
Maxim Vasiliev (qmax) added a comment to T74665: Ungrouping destroys NodeCustomGroups.

This case seems resolved in D6484

Mar 12 2020, 7:09 PM · Data, Assets & I/O, Nodes, BF Blender
Maxim Vasiliev (qmax) added a comment to T74682: Ungroup Node Groups doesn't update its user count.

This case seems resolved in D6484

Mar 12 2020, 7:03 PM · Nodes, Data, Assets & I/O, BF Blender
Maxim Vasiliev (qmax) added a task to D6484: Fix broken python nodes API and user counting on ungrouping: T74665: Ungrouping destroys NodeCustomGroups.
Mar 12 2020, 7:02 PM · Python API, Nodes & Physics, Data, Assets & I/O, BF Blender, Add-ons (BF-Blender), Nodes
Maxim Vasiliev (qmax) added a revision to T74665: Ungrouping destroys NodeCustomGroups: D6484: Fix broken python nodes API and user counting on ungrouping.
Mar 12 2020, 7:02 PM · Data, Assets & I/O, Nodes, BF Blender
Maxim Vasiliev (qmax) updated the diff for D6484: Fix broken python nodes API and user counting on ungrouping.

rebased to current master

Mar 12 2020, 6:54 PM · Python API, Nodes & Physics, Data, Assets & I/O, BF Blender, Add-ons (BF-Blender), Nodes
Maxim Vasiliev (qmax) added a comment to T74682: Ungroup Node Groups doesn't update its user count.

This is related, but it's opposite effect.

Mar 12 2020, 6:08 PM · Nodes, Data, Assets & I/O, BF Blender
Maxim Vasiliev (qmax) updated the task description for T74665: Ungrouping destroys NodeCustomGroups.
Mar 12 2020, 6:03 PM · Data, Assets & I/O, Nodes, BF Blender
Maxim Vasiliev (qmax) added a comment to T74665: Ungrouping destroys NodeCustomGroups.

I didn't understand what you meant in the point 7. "open another group and delete node 'foo' there".
Is there really a need for custom nodes and script execution?

NodeCustomGroup is needed because it contains reference to NodeTree which should be usercounted.

Mar 12 2020, 6:01 PM · Data, Assets & I/O, Nodes, BF Blender

Mar 11 2020

Maxim Vasiliev (qmax) created T74665: Ungrouping destroys NodeCustomGroups.
Mar 11 2020, 8:59 PM · Data, Assets & I/O, Nodes, BF Blender

Feb 29 2020

Maxim Vasiliev (qmax) added a revision to T72579: Copypasting material is broken for `NodeCustomGroup` nodes: D6484: Fix broken python nodes API and user counting on ungrouping.
Feb 29 2020, 6:51 PM · Python API, Data, Assets & I/O, Nodes, BF Blender
Maxim Vasiliev (qmax) added a task to D6484: Fix broken python nodes API and user counting on ungrouping: T72579: Copypasting material is broken for `NodeCustomGroup` nodes.
Feb 29 2020, 6:51 PM · Python API, Nodes & Physics, Data, Assets & I/O, BF Blender, Add-ons (BF-Blender), Nodes
Maxim Vasiliev (qmax) updated the diff for D6484: Fix broken python nodes API and user counting on ungrouping.

Added fix for copypasting materials.

Feb 29 2020, 6:50 PM · Python API, Nodes & Physics, Data, Assets & I/O, BF Blender, Add-ons (BF-Blender), Nodes

Feb 28 2020

Maxim Vasiliev (qmax) added a comment to D6484: Fix broken python nodes API and user counting on ungrouping.

Sorry, commented on wrong review...

Feb 28 2020, 1:51 PM · Python API, Nodes & Physics, Data, Assets & I/O, BF Blender, Add-ons (BF-Blender), Nodes

Feb 17 2020

Maxim Vasiliev (qmax) updated the diff for D6420: Autotests for nodes API of creating/copying/removing CustomNodeGroups.

improved clarity in names, description, code

Feb 17 2020, 2:49 AM · Nodes
Maxim Vasiliev (qmax) updated the diff for D6484: Fix broken python nodes API and user counting on ungrouping.

refactored everything

Feb 17 2020, 2:47 AM · Python API, Nodes & Physics, Data, Assets & I/O, BF Blender, Add-ons (BF-Blender), Nodes

Feb 14 2020

Maxim Vasiliev (qmax) added a comment to T72579: Copypasting material is broken for `NodeCustomGroup` nodes.

I tried to fix it by replacing (approximately) dst_material->nodetree = ntreeCopyTree_ex(src=matcopybuf.nodetree, do_id_user=true) with BKE_id_copy_ex(&matcopybuf, &dst_material, flag)

Feb 14 2020, 2:36 AM · Python API, Data, Assets & I/O, Nodes, BF Blender

Feb 11 2020

Maxim Vasiliev (qmax) added a comment to D6420: Autotests for nodes API of creating/copying/removing CustomNodeGroups.

This looks good to me now. The only issue I see is that this creates one ctest for every node test, which makes the logs quite long when running tests.

Can you bundle all these together in a single ctest somehow? Many of our ctests already do multiple tests under the hood.

Feb 11 2020, 7:15 PM · Nodes
Maxim Vasiliev (qmax) added a comment to D6420: Autotests for nodes API of creating/copying/removing CustomNodeGroups.

Still missing some weird cases.

Feb 11 2020, 2:40 PM · Nodes

Feb 10 2020

Maxim Vasiliev (qmax) added a comment to D6484: Fix broken python nodes API and user counting on ungrouping.

Ok. Quick and dirty fix almost worked, but messed things up. So I abandoned it.

Feb 10 2020, 3:41 PM · Python API, Nodes & Physics, Data, Assets & I/O, BF Blender, Add-ons (BF-Blender), Nodes

Feb 8 2020

Maxim Vasiliev (qmax) updated the diff for D6420: Autotests for nodes API of creating/copying/removing CustomNodeGroups.

increased code clarity

Feb 8 2020, 11:07 PM · Nodes
Maxim Vasiliev (qmax) added inline comments to D6420: Autotests for nodes API of creating/copying/removing CustomNodeGroups.
Feb 8 2020, 2:21 PM · Nodes

Feb 7 2020

Maxim Vasiliev (qmax) updated the diff for D6420: Autotests for nodes API of creating/copying/removing CustomNodeGroups.

Added pointer property asserts.

Feb 7 2020, 4:32 PM · Nodes

Feb 6 2020

Maxim Vasiliev (qmax) updated the diff for D6420: Autotests for nodes API of creating/copying/removing CustomNodeGroups.

Improved clarity.
Added copy/remove tests for Material, Light, World, Scene

Feb 6 2020, 9:50 PM · Nodes

Feb 4 2020

Maxim Vasiliev (qmax) removed a revision from T72579: Copypasting material is broken for `NodeCustomGroup` nodes: D6484: Fix broken python nodes API and user counting on ungrouping.
Feb 4 2020, 5:36 PM · Python API, Data, Assets & I/O, Nodes, BF Blender
Maxim Vasiliev (qmax) removed a task from D6484: Fix broken python nodes API and user counting on ungrouping: T72579: Copypasting material is broken for `NodeCustomGroup` nodes.
Feb 4 2020, 5:36 PM · Python API, Nodes & Physics, Data, Assets & I/O, BF Blender, Add-ons (BF-Blender), Nodes
Maxim Vasiliev (qmax) updated the task description for T71858: Inharitance for `ShaderNodeCustomGroup` is broken.
Feb 4 2020, 5:34 PM · Python API, Nodes, BF Blender

Jan 26 2020

Maxim Vasiliev (qmax) added a comment to D6484: Fix broken python nodes API and user counting on ungrouping.

I also think that the new LIB_ID_COPY_NO_API flag is not needed. Basically, we never want to call that callback when we are not refcounting, so just checking for LIB_ID_CREATE_NO_USER_REFCOUNT (which should always imply LIB_ID_CREATE_NO_MAIN) should be enough here?

Jan 26 2020, 3:21 AM · Python API, Nodes & Physics, Data, Assets & I/O, BF Blender, Add-ons (BF-Blender), Nodes

Jan 14 2020

Maxim Vasiliev (qmax) added a comment to D6484: Fix broken python nodes API and user counting on ungrouping.
Jan 14 2020, 9:15 PM · Python API, Nodes & Physics, Data, Assets & I/O, BF Blender, Add-ons (BF-Blender), Nodes
Maxim Vasiliev (qmax) added a comment to D6484: Fix broken python nodes API and user counting on ungrouping.

So a generic py API callback that can do basically anything is just a no-go here, it’s a full violation of the whole design. Trying to make it work imho is doomed to fail and/or lead to spaghetti code that nobody can follow anymore.

Good thing: move py API callback out of (after the) ID copying code itself.
Bad thing: this call should be completely removed from BKE_node_copy_ex() imho. There is no way we can keep it there and not be bitten by it one way or another.

Jan 14 2020, 4:02 PM · Python API, Nodes & Physics, Data, Assets & I/O, BF Blender, Add-ons (BF-Blender), Nodes
Maxim Vasiliev (qmax) added a comment to D6484: Fix broken python nodes API and user counting on ungrouping.

The patch should be corrected to handle other IDs that contain built-in nodetree, and might contain some NodeCustomGroups

Jan 14 2020, 1:01 PM · Python API, Nodes & Physics, Data, Assets & I/O, BF Blender, Add-ons (BF-Blender), Nodes
Maxim Vasiliev (qmax) added a comment to T72317: Cloning materials with too smart ShaderNodeCustomGroup breaks user counters of both source and target nodes.

Then I'll put retated information here to avoid any non-automated confusion.

Jan 14 2020, 12:41 PM · Python API, Data, Assets & I/O, Nodes, BF Blender
Maxim Vasiliev (qmax) added a comment to T72317: Cloning materials with too smart ShaderNodeCustomGroup breaks user counters of both source and target nodes.

What is the policy, @Dalai Felinto (dfelinto) ?

Jan 14 2020, 11:28 AM · Python API, Data, Assets & I/O, Nodes, BF Blender

Jan 8 2020

André Savik (klutz) awarded rBe993667a46c2: Fix (unreported) critical mistake in Node copying code. a Like token.
Jan 8 2020, 5:20 PM

Dec 31 2019

Maxim Vasiliev (qmax) updated subscribers of T72579: Copypasting material is broken for `NodeCustomGroup` nodes.

I've debugged the case once more.
With patch D6484 applied: it makes MATERIAL_OT_copy operation be called with CREATE_NO_MAIN | COPY_NO_API flag set (do not update counter, do not call api), and MATERIAL_OT_paste operation be called with 0 flag (to update counters, and call api).
Without the patch, both operations are called with flag == 0 and (supposed) to update counters twice. But they don't anyway.

Dec 31 2019, 6:24 AM · Python API, Data, Assets & I/O, Nodes, BF Blender
Maxim Vasiliev (qmax) updated the diff for D6420: Autotests for nodes API of creating/copying/removing CustomNodeGroups.

I'm sorry for flooding in mail. This is the last update in this year.

Dec 31 2019, 4:49 AM · Nodes

Dec 30 2019

Maxim Vasiliev (qmax) added a comment to T72579: Copypasting material is broken for `NodeCustomGroup` nodes.

The node_tree = None doesn't make any sense here, actually. It remains from some code rearrangements. But it shouldn't affect anything. It's a class property for the case when an instance miss it for some reason.

Dec 30 2019, 3:44 PM · Python API, Data, Assets & I/O, Nodes, BF Blender
Maxim Vasiliev (qmax) added a comment to D6484: Fix broken python nodes API and user counting on ungrouping.

I failed to understand logic of BKE_library_foreach_ID_link and id_copy_libmanagement_cb which are used within BKE_id_copy_ex to update counters.
But the point is that it prevents updating counters for nodetrees that belong to materials, so that the updating is postponed until all material data has been copied completely.

Dec 30 2019, 12:10 PM · Python API, Nodes & Physics, Data, Assets & I/O, BF Blender, Add-ons (BF-Blender), Nodes
Maxim Vasiliev (qmax) added a revision to T72579: Copypasting material is broken for `NodeCustomGroup` nodes: D6420: Autotests for nodes API of creating/copying/removing CustomNodeGroups.
Dec 30 2019, 12:09 AM · Python API, Data, Assets & I/O, Nodes, BF Blender
Maxim Vasiliev (qmax) added a revision to T72659: Making 'singleuser' for a group with too smart NodeCustomGroup breaks user counters of both source and target nodes: D6420: Autotests for nodes API of creating/copying/removing CustomNodeGroups.
Dec 30 2019, 12:09 AM · Data, Assets & I/O, Nodes, BF Blender
Maxim Vasiliev (qmax) added tasks to D6420: Autotests for nodes API of creating/copying/removing CustomNodeGroups: T72579: Copypasting material is broken for `NodeCustomGroup` nodes, T72659: Making 'singleuser' for a group with too smart NodeCustomGroup breaks user counters of both source and target nodes.
Dec 30 2019, 12:09 AM · Nodes

Dec 29 2019

Maxim Vasiliev (qmax) updated the diff for D6420: Autotests for nodes API of creating/copying/removing CustomNodeGroups.

Added tests for ID.copy applied to a tree, Nodes.clear and BlendDataNodeTrees.remove

Dec 29 2019, 11:57 PM · Nodes
Maxim Vasiliev (qmax) added a comment to T61655: Python Nodes for Cycles, Eevee, Compositor and Textures.
Dec 29 2019, 10:56 PM · BF Blender
Maxim Vasiliev (qmax) added a comment to T61655: Python Nodes for Cycles, Eevee, Compositor and Textures.
Dec 29 2019, 10:53 PM · BF Blender
Maxim Vasiliev (qmax) added a comment to T72579: Copypasting material is broken for `NodeCustomGroup` nodes.

@Jacques Lucke (JacquesLucke) , I don't understand everything in details, but it seems to me that the property is deinfed as pointer property in build/source/blender/makesrna/intern/rna_nodetree_gen.c:

Dec 29 2019, 9:01 PM · Python API, Data, Assets & I/O, Nodes, BF Blender

Dec 25 2019

Maxim Vasiliev (qmax) added a revision to T72317: Cloning materials with too smart ShaderNodeCustomGroup breaks user counters of both source and target nodes: D6484: Fix broken python nodes API and user counting on ungrouping.
Dec 25 2019, 7:58 PM · Python API, Data, Assets & I/O, Nodes, BF Blender
Maxim Vasiliev (qmax) added a revision to T72579: Copypasting material is broken for `NodeCustomGroup` nodes: D6484: Fix broken python nodes API and user counting on ungrouping.
Dec 25 2019, 7:58 PM · Python API, Data, Assets & I/O, Nodes, BF Blender
Maxim Vasiliev (qmax) added a revision to T72659: Making 'singleuser' for a group with too smart NodeCustomGroup breaks user counters of both source and target nodes: D6484: Fix broken python nodes API and user counting on ungrouping.
Dec 25 2019, 7:58 PM · Data, Assets & I/O, Nodes, BF Blender
Maxim Vasiliev (qmax) added tasks to D6484: Fix broken python nodes API and user counting on ungrouping: T72659: Making 'singleuser' for a group with too smart NodeCustomGroup breaks user counters of both source and target nodes, T72579: Copypasting material is broken for `NodeCustomGroup` nodes, T72317: Cloning materials with too smart ShaderNodeCustomGroup breaks user counters of both source and target nodes.
Dec 25 2019, 7:58 PM · Python API, Nodes & Physics, Data, Assets & I/O, BF Blender, Add-ons (BF-Blender), Nodes
Maxim Vasiliev (qmax) created D6484: Fix broken python nodes API and user counting on ungrouping.
Dec 25 2019, 7:36 PM · Python API, Nodes & Physics, Data, Assets & I/O, BF Blender, Add-ons (BF-Blender), Nodes

Dec 24 2019

Maxim Vasiliev (qmax) updated the diff for D6420: Autotests for nodes API of creating/copying/removing CustomNodeGroups.

Fixed ungrouping test again.
the copy api chould be called and/or user counters incremented.

Dec 24 2019, 9:06 AM · Nodes

Dec 23 2019

Maxim Vasiliev (qmax) created T72659: Making 'singleuser' for a group with too smart NodeCustomGroup breaks user counters of both source and target nodes.
Dec 23 2019, 6:22 PM · Data, Assets & I/O, Nodes, BF Blender

Dec 21 2019

Maxim Vasiliev (qmax) updated the diff for D6420: Autotests for nodes API of creating/copying/removing CustomNodeGroups.

Refactored assertions to check total calls.

Dec 21 2019, 8:07 PM · Nodes

Dec 19 2019

Maxim Vasiliev (qmax) created T72579: Copypasting material is broken for `NodeCustomGroup` nodes.
Dec 19 2019, 5:13 PM · Python API, Data, Assets & I/O, Nodes, BF Blender
Maxim Vasiliev (qmax) updated the diff for D6420: Autotests for nodes API of creating/copying/removing CustomNodeGroups.

Removed excessive nested node checks, sanity checks.

Dec 19 2019, 1:22 PM · Nodes
Maxim Vasiliev (qmax) renamed T72317: Cloning materials with too smart ShaderNodeCustomGroup breaks user counters of both source and target nodes from Copying materials (or single-usering node groups) with custom nodes messes up users counters and may produce bogus orphaned and overused trees to Cloning materials with too smart ShaderNodeCustomGroup breaks user counters of both source and target nodes.
Dec 19 2019, 2:37 AM · Python API, Data, Assets & I/O, Nodes, BF Blender

Dec 18 2019

Maxim Vasiliev (qmax) updated subscribers of D6420: Autotests for nodes API of creating/copying/removing CustomNodeGroups.

@Miguel Porces (cmporces), the node copypasting case that you have mentioned is covered by the tests, and they pass.
Am I doing something wrong?

Dec 18 2019, 8:45 PM · Nodes
Maxim Vasiliev (qmax) updated the diff for D6420: Autotests for nodes API of creating/copying/removing CustomNodeGroups.

Changed checks of calls to copy to fit API logic.

Dec 18 2019, 4:04 PM · Nodes
Maxim Vasiliev (qmax) added a comment to D6420: Autotests for nodes API of creating/copying/removing CustomNodeGroups.

For copypaste scenario assumtion is based on add-on developer's logic: api method copy is called when node is copied and the argument is a real source node being copied.

Dec 18 2019, 4:03 PM · Nodes

Dec 17 2019

Maxim Vasiliev (qmax) updated the diff for D6420: Autotests for nodes API of creating/copying/removing CustomNodeGroups.

Fixed op_material_clone and op_material_copypaste

Dec 17 2019, 10:26 PM · Nodes
Maxim Vasiliev (qmax) added a task to D6420: Autotests for nodes API of creating/copying/removing CustomNodeGroups: T72317: Cloning materials with too smart ShaderNodeCustomGroup breaks user counters of both source and target nodes.
Dec 17 2019, 10:02 PM · Nodes
Maxim Vasiliev (qmax) added a revision to T72317: Cloning materials with too smart ShaderNodeCustomGroup breaks user counters of both source and target nodes: D6420: Autotests for nodes API of creating/copying/removing CustomNodeGroups.
Dec 17 2019, 10:02 PM · Python API, Data, Assets & I/O, Nodes, BF Blender
Maxim Vasiliev (qmax) added projects to T72518: Nodes API and editor operators need to be autotested: Nodes, Python API.
Dec 17 2019, 5:18 PM · Python API, Nodes, BF Blender
Maxim Vasiliev (qmax) edited a custom field on T72518: Nodes API and editor operators need to be autotested.
Dec 17 2019, 5:16 PM · Python API, Nodes, BF Blender
Maxim Vasiliev (qmax) added a task to D6420: Autotests for nodes API of creating/copying/removing CustomNodeGroups: T72518: Nodes API and editor operators need to be autotested.
Dec 17 2019, 5:16 PM · Nodes
Maxim Vasiliev (qmax) added a revision to T72518: Nodes API and editor operators need to be autotested: D6420: Autotests for nodes API of creating/copying/removing CustomNodeGroups.
Dec 17 2019, 5:15 PM · Python API, Nodes, BF Blender
Maxim Vasiliev (qmax) created T72518: Nodes API and editor operators need to be autotested.
Dec 17 2019, 5:14 PM · Python API, Nodes, BF Blender

Dec 16 2019

Maxim Vasiliev (qmax) created D6420: Autotests for nodes API of creating/copying/removing CustomNodeGroups.
Dec 16 2019, 10:49 PM · Nodes

Dec 14 2019

Maxim Vasiliev (qmax) changed the status of T72296: `bpy.types.BlendDataNodeTrees.remove` does not call api function `free` of containing nodes from Unknown Status to Invalid.

Solution: tree.nodes.clear() should be called.
Not quite obvious, but fair enough.

Dec 14 2019, 7:26 PM · Add-ons (BF-Blender), Nodes, BF Blender

Dec 10 2019

Maxim Vasiliev (qmax) added a comment to T72317: Cloning materials with too smart ShaderNodeCustomGroup breaks user counters of both source and target nodes.
Dec 10 2019, 10:48 AM · Python API, Data, Assets & I/O, Nodes, BF Blender
Maxim Vasiliev (qmax) renamed T72317: Cloning materials with too smart ShaderNodeCustomGroup breaks user counters of both source and target nodes from Copying materials with custom nodes messes up users counters and may produce bogus orphaned and overused trees to Copying materials (or single-usering node groups) with custom nodes messes up users counters and may produce bogus orphaned and overused trees.
Dec 10 2019, 9:19 AM · Python API, Data, Assets & I/O, Nodes, BF Blender
Maxim Vasiliev (qmax) added a comment to T72317: Cloning materials with too smart ShaderNodeCustomGroup breaks user counters of both source and target nodes.
Dec 10 2019, 6:36 AM · Python API, Data, Assets & I/O, Nodes, BF Blender
Maxim Vasiliev (qmax) created T72317: Cloning materials with too smart ShaderNodeCustomGroup breaks user counters of both source and target nodes.
Dec 10 2019, 12:33 AM · Python API, Data, Assets & I/O, Nodes, BF Blender

Dec 9 2019

Maxim Vasiliev (qmax) added a project to T72296: `bpy.types.BlendDataNodeTrees.remove` does not call api function `free` of containing nodes: Nodes.
Dec 9 2019, 12:26 PM · Add-ons (BF-Blender), Nodes, BF Blender
Maxim Vasiliev (qmax) created T72296: `bpy.types.BlendDataNodeTrees.remove` does not call api function `free` of containing nodes.
Dec 9 2019, 12:25 PM · Add-ons (BF-Blender), Nodes, BF Blender
Maxim Vasiliev (qmax) changed the status of T71698: Method `Node.free` is not called for nested `ShaderNodeCustomGroup` when parent `ShaderNodeTree` is removed from Unknown Status to Invalid.
Dec 9 2019, 11:51 AM · BF Blender

Dec 8 2019

Maxim Vasiliev (qmax) changed the status of T72150: Cloning material with volatile `ShaderNodeCustomGroup` nodes is broken from Unknown Status to Invalid.
Dec 8 2019, 9:38 AM · Nodes, BF Blender

Dec 5 2019

Maxim Vasiliev (qmax) added a comment to T72150: Cloning material with volatile `ShaderNodeCustomGroup` nodes is broken.

When material is copied, function BKE_node_tree_copy_data, sets flag LIB_ID_CREATE_NO_USER_REFCOUNT for copying nodes.

Dec 5 2019, 7:01 AM · Nodes, BF Blender
Maxim Vasiliev (qmax) renamed T72150: Cloning material with volatile `ShaderNodeCustomGroup` nodes is broken from Cloning material using volatile `ShaderNodeCustomGroup` nodes is broken (as designed) to Cloning material with volatile `ShaderNodeCustomGroup` nodes is broken.
Dec 5 2019, 6:44 AM · Nodes, BF Blender

Dec 3 2019

Maxim Vasiliev (qmax) created T72150: Cloning material with volatile `ShaderNodeCustomGroup` nodes is broken.
Dec 3 2019, 8:35 PM · Nodes, BF Blender

Nov 24 2019

Maxim Vasiliev (qmax) added a comment to T71858: Inharitance for `ShaderNodeCustomGroup` is broken.

The workaround is to register classes in reverse order: first 'baz', and then 'bar'.

Nov 24 2019, 4:33 PM · Python API, Nodes, BF Blender
Maxim Vasiliev (qmax) created T71858: Inharitance for `ShaderNodeCustomGroup` is broken.
Nov 24 2019, 3:41 PM · Python API, Nodes, BF Blender

Nov 20 2019

Maxim Vasiliev (qmax) created T71698: Method `Node.free` is not called for nested `ShaderNodeCustomGroup` when parent `ShaderNodeTree` is removed.
Nov 20 2019, 11:03 AM · BF Blender

Sep 12 2019

Maxim Vasiliev (qmax) added a comment to T69696: Bezier Curve geometry gets distorted by object scaling.

If I do it in object mode with mesh, I can later "apply transform", it resets object scale to 1 and internal parameters (such as skin or edges bevel) will be recalculated. For curves this does not work.

Sep 12 2019, 12:16 AM · BF Blender