Page MenuHome

Edgar Roman Cervantes (redvant)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 23 2021, 11:22 PM (4 w, 4 d)

Recent Activity

Sat, Feb 20

Damian (damian) awarded D10316: Added New String Input Node a Love token.
Sat, Feb 20, 12:00 AM · Geometry Nodes

Fri, Feb 12

Edgar Roman Cervantes (redvant) updated the summary of D10316: Added New String Input Node.
Fri, Feb 12, 5:29 AM · Geometry Nodes
Edgar Roman Cervantes (redvant) added a comment to D10316: Added New String Input Node.

I had some problems because many changes are being made to the geometry nodes code.
I added the changes that @Hans Goudey (HooglyBoogly) asked for.
I took as reference the code used for node_shader_script, so that help me a lot.
I'm still getting familiar to all the parts involved with the nodes so I'm not sure if something is missing, so let me know.

Fri, Feb 12, 5:22 AM · Geometry Nodes
Edgar Roman Cervantes (redvant) updated the diff for D10316: Added New String Input Node.
  • Fix to errors produced when merging the latest master
Fri, Feb 12, 5:07 AM · Geometry Nodes
Edgar Roman Cervantes (redvant) updated the diff for D10316: Added New String Input Node.
  • Added layout callbacks to node_fn_input_string.cc to match with cfa48c84d06c
Fri, Feb 12, 3:05 AM · Geometry Nodes
Edgar Roman Cervantes (redvant) updated the diff for D10316: Added New String Input Node.
  • Custom storage NodeInputString now uses char *
  • Merge remote-tracking branch 'origin/master' into arcpatch-D10316
Fri, Feb 12, 1:30 AM · Geometry Nodes

Mon, Feb 8

Florian Kamenz (TimBrown) awarded D10316: Added New String Input Node a Love token.
Mon, Feb 8, 9:07 AM · Geometry Nodes

Fri, Feb 5

Edgar Roman Cervantes (redvant) updated the diff for D10316: Added New String Input Node.
  • Update to latest master
Fri, Feb 5, 7:04 PM · Geometry Nodes
Some User (someuser) awarded D10316: Added New String Input Node a Love token.
Fri, Feb 5, 12:42 PM · Geometry Nodes
Edgar Roman Cervantes (redvant) added a comment to T84971: Create a string input node.

Here it is!
Let me know of anything that needs a fix or improvement.

Fri, Feb 5, 4:06 AM · Good First Issue, Geometry Nodes
Edgar Roman Cervantes (redvant) updated the summary of D10316: Added New String Input Node.
Fri, Feb 5, 4:02 AM · Geometry Nodes
Edgar Roman Cervantes (redvant) updated the summary of D10316: Added New String Input Node.
Fri, Feb 5, 3:49 AM · Geometry Nodes
Edgar Roman Cervantes (redvant) requested review of D10316: Added New String Input Node.
Fri, Feb 5, 3:44 AM · Geometry Nodes

Thu, Feb 4

Some User (someuser) awarded T84971: Create a string input node a Love token.
Thu, Feb 4, 6:45 PM · Good First Issue, Geometry Nodes
Edgar Roman Cervantes (redvant) claimed T84971: Create a string input node.
Thu, Feb 4, 3:59 AM · Good First Issue, Geometry Nodes
Edgar Roman Cervantes (redvant) added a comment to T84971: Create a string input node.

Ok then.
I'll double check everything and I'll consult the developer intro on Best Practices and all that.
Thanks!

Thu, Feb 4, 1:06 AM · Good First Issue, Geometry Nodes
Edgar Roman Cervantes (redvant) added a comment to T84971: Create a string input node.

Hi guys!! I have it working now.


I wanted to ask you if is OK this new DNA struct to store the string property:

typedef struct NodeInputString {
  char string[1024];
} NodeInputString;

I saw the bNodeSocketValueString use char value[1024] but I think is Deprecated.

Thu, Feb 4, 12:41 AM · Good First Issue, Geometry Nodes

Wed, Feb 3

Edgar Roman Cervantes (redvant) added a comment to T84971: Create a string input node.

I'm on it. Thanks!

Wed, Feb 3, 6:34 AM · Good First Issue, Geometry Nodes
Edgar Roman Cervantes (redvant) added a comment to T84971: Create a string input node.

Great!! I already did some digging and I was wondering if the string node should be a Geometry node or instead a Function node (like the vector node) or a Shading node (like the value node).

Wed, Feb 3, 6:20 AM · Good First Issue, Geometry Nodes
Edgar Roman Cervantes (redvant) added a comment to T84971: Create a string input node.

Hi! Can I work on this?

Wed, Feb 3, 5:12 AM · Good First Issue, Geometry Nodes