Page MenuHome

Robert Guetzkow (rjg)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 11 2017, 11:26 PM (109 w, 6 d)

Recent Activity

Yesterday

Robert Guetzkow (rjg) updated the diff for D4585: Windows move files to recycling bin when deleted in file explorer.
  • Simplified Linux soft delete, now using fork and execvp
  • Added keymap entries back
  • macOS currently commented, because changes necessary to make Objective-C work
  • removed duplicate include for <sys/stat.h>
Mon, May 20, 7:45 PM · Platform: Windows
Robert Guetzkow (rjg) added a comment to D4585: Windows move files to recycling bin when deleted in file explorer.

Since 64acb70e7f0f removes the ability to delete files, is development on this patch still of interest?

Mon, May 20, 4:16 PM · Platform: Windows

Wed, May 15

Robert Guetzkow (rjg) added a comment to T64104: Make Delete in the File Browser use the system Trash.

@Bastien Montagne (mont29) @William Reynish (billreynish) Sorry I've been sick and couldn't work on the patch D4585. This may have to wait some more until I have backlog empty.

Wed, May 15, 3:06 PM · BF Blender, User Interface

Mon, May 6

Robert Guetzkow (rjg) added inline comments to D4585: Windows move files to recycling bin when deleted in file explorer.
Mon, May 6, 7:50 PM · Platform: Windows
William Reynish (billreynish) awarded D4585: Windows move files to recycling bin when deleted in file explorer a Love token.
Mon, May 6, 5:52 PM · Platform: Windows

Sun, May 5

Robert Guetzkow (rjg) added a comment to D4585: Windows move files to recycling bin when deleted in file explorer.

I'm currently quite busy, updates may take a while. Hopefully I can squeeze these in next weekend.

Sun, May 5, 12:53 PM · Platform: Windows

Sun, Apr 28

Robert Guetzkow (rjg) added a comment to T63944: what’s wrong with my blender? contact ASAP.

It's likely just outside the clipping plane. Select the object in the outliner (top right window where the collections are), go to the object tab (the window below that, click on the square icon) and set the location on all coordinates to zero. You may have to adjust the scale as well, if it's very large.

Sun, Apr 28, 11:14 AM · BF Blender

Sat, Apr 27

Robert Guetzkow (rjg) added a comment to T63919: Possible MAYOR bug in Blender-2.80-d966c2f0c2ad-win64 ( downloaded 25-4-2019 ).

What you described sounds unrelated to Blender and more like your computer has been infected with malware.

Sat, Apr 27, 11:31 AM · BF Blender

Fri, Apr 26

Robert Guetzkow (rjg) added a comment to T63853: Unicode paths results in "No such file or directory".

@T.L (T.L) Yes you're right, that's why I wrote that it seems to be a different cause.

Fri, Apr 26, 5:07 PM · BF Blender
Robert Guetzkow (rjg) added a comment to T63853: Unicode paths results in "No such file or directory".

Seems to be a different cause.

Fri, Apr 26, 4:09 PM · BF Blender
Robert Guetzkow (rjg) added a comment to T63853: Unicode paths results in "No such file or directory".

It's quite possible that this isn't a bug in blender, but another case of the strange way Windows handles encoding / code pages. Depending on your locale, it may be that è is not included in your code page, which results in Windows replacing the character with ? when passing the argument to the program. If that is the case, then there is nothing blender can do, because it's not getting the right string. You can check if that's the case by temporarily activating the UTF-8 beta feature described here. If that works properly, it's Windows' fault.

Fri, Apr 26, 3:34 PM · BF Blender

Wed, Apr 24

Robert Guetzkow (rjg) added a comment to D4585: Windows move files to recycling bin when deleted in file explorer.

@Campbell Barton (campbellbarton) I think this patch is done, if we want to limit the supported desktop environments as @Brecht Van Lommel (brecht) suggested.

Wed, Apr 24, 10:42 PM · Platform: Windows

Tue, Apr 23

Robert Guetzkow (rjg) updated the diff for D4585: Windows move files to recycling bin when deleted in file explorer.

Correct error messages

Tue, Apr 23, 1:16 AM · Platform: Windows

Mon, Apr 22

Robert Guetzkow (rjg) updated the diff for D4585: Windows move files to recycling bin when deleted in file explorer.

Replaced malloc with Blender's allocator.

Mon, Apr 22, 11:20 PM · Platform: Windows
Robert Guetzkow (rjg) updated the diff for D4585: Windows move files to recycling bin when deleted in file explorer.

Added missing include for macOS

Mon, Apr 22, 3:36 PM · Platform: Windows
Robert Guetzkow (rjg) updated the diff for D4585: Windows move files to recycling bin when deleted in file explorer.

Fixed wrong debug print function for Linux.

Mon, Apr 22, 1:55 PM · Platform: Windows
Robert Guetzkow (rjg) added a comment to D4585: Windows move files to recycling bin when deleted in file explorer.

I can't test the macOS implementation, perhaps somebody can help with that . I'll test the Linux implementation later this day.

Mon, Apr 22, 12:37 PM · Platform: Windows
Robert Guetzkow (rjg) updated the diff for D4585: Windows move files to recycling bin when deleted in file explorer.

Removed unused argument from Windows delete_soft()

Mon, Apr 22, 12:20 PM · Platform: Windows
Robert Guetzkow (rjg) updated the diff for D4585: Windows move files to recycling bin when deleted in file explorer.

Several small fixes. Sorry for spamming the tracker.

Mon, Apr 22, 12:14 PM · Platform: Windows
Robert Guetzkow (rjg) updated the diff for D4585: Windows move files to recycling bin when deleted in file explorer.
Mon, Apr 22, 12:12 PM · Platform: Windows
Robert Guetzkow (rjg) updated the diff for D4585: Windows move files to recycling bin when deleted in file explorer.
Mon, Apr 22, 12:08 PM · Platform: Windows
Robert Guetzkow (rjg) updated the diff for D4585: Windows move files to recycling bin when deleted in file explorer.
Mon, Apr 22, 12:07 PM · Platform: Windows
Robert Guetzkow (rjg) updated the diff for D4585: Windows move files to recycling bin when deleted in file explorer.

Work in progress implementation of soft delete for Linux and macOS

Mon, Apr 22, 12:05 PM · Platform: Windows
Robert Guetzkow (rjg) added a comment to D4585: Windows move files to recycling bin when deleted in file explorer.

Sure, no problem. I'll implement it today. Do you have any special security policies regarding system() for calling the CLI utilities?

Mon, Apr 22, 9:38 AM · Platform: Windows
Robert Guetzkow (rjg) added a comment to D4585: Windows move files to recycling bin when deleted in file explorer.

@Brecht Van Lommel (brecht) just in case you change your mind: I have implemented the trash specification (currently without directory size cache).

Mon, Apr 22, 12:51 AM · Platform: Windows

Apr 18 2019

Robert Guetzkow (rjg) added a comment to D4585: Windows move files to recycling bin when deleted in file explorer.

That would be an option, although I'd favor a general solution that works on all Linux distributions and desktop environments. @Campbell Barton (campbellbarton) @LazyDodo (LazyDodo) Do you agree with this approach?

Apr 18 2019, 11:47 AM · Platform: Windows
Robert Guetzkow (rjg) added a comment to T63691: [Bug] Focusing on Blender with tablet causes it to stop working (Huion Kamvas Pro 13).

Not sure how relevant this is to the bug report, but I can't reproduce this with my Wacom Intuos.

Apr 18 2019, 11:41 AM · BF Blender
Robert Guetzkow (rjg) added a comment to D4585: Windows move files to recycling bin when deleted in file explorer.

I think the complexity is manageable, but that is your decision. The problem that I see with the Electron approach is finding out what desktop environment we're on (which implies what CLI utility can be used). Does Blender already have an equivalent of libgtkui::GetDesktopName?

Apr 18 2019, 10:18 AM · Platform: Windows
Bataev Artem (shader) awarded D4617: Collapsed nodes don't shrink a Like token.
Apr 18 2019, 8:01 AM

Apr 16 2019

Robert Guetzkow (rjg) added a comment to D4585: Windows move files to recycling bin when deleted in file explorer.

I would like to implement support for $topdir, but in case (1) and (2) fail (see spec) refuse to trash. This means we can simply use rename since we don't move files over across devices. This makes the code simpler and doesn't require reimplementing mv.

Apr 16 2019, 8:53 PM · Platform: Windows
Robert Guetzkow (rjg) updated the diff for D4585: Windows move files to recycling bin when deleted in file explorer.
Apr 16 2019, 1:01 PM · Platform: Windows
Robert Guetzkow (rjg) updated the diff for D4585: Windows move files to recycling bin when deleted in file explorer.

Work in progress.

Apr 16 2019, 12:58 PM · Platform: Windows

Apr 14 2019

Robert Guetzkow (rjg) added a comment to T63603: Blender crashing while rendering scene with linked rigs.

Looks like this might be the same issue as T63582

Apr 14 2019, 11:55 PM · BF Blender
Robert Guetzkow (rjg) added a comment to T63603: Blender crashing while rendering scene with linked rigs.

Can you share a minimal .blend file where this error occurs?

Apr 14 2019, 11:40 PM · BF Blender
Robert Guetzkow (rjg) added a comment to T63561: Blender crashes and exits while rendering complex model.

@AC (AC_3D) this seems to be a different problem than the one described here. You can create a bug report here. Files can be attached by drag-and-drop into the browser window.

Apr 14 2019, 8:07 PM · BF Blender
Robert Guetzkow (rjg) added a comment to T63591: Crash to desktop afer seting anable "show faces" in UV editor.

builder is a nullptr.

Apr 14 2019, 3:22 PM · BF Blender
Robert Guetzkow (rjg) added a comment to T63561: Blender crashes and exits while rendering complex model.

As you've said yourself, you're running out of memory. Your project likely needs more memory than Windows allows you to swap to disk, resulting in a crash. If this is the case then there is nothing to fix, you simply don't have enough memory available to render the scene. If you suspect that the crash isn't caused by OOM, you can go to the installation directory and run blender_debug_log.cmd. This will give you a detailed output about what went wrong.

Apr 14 2019, 11:45 AM · BF Blender

Apr 13 2019

Robert Guetzkow (rjg) added a comment to D4585: Windows move files to recycling bin when deleted in file explorer.

Currently a bit busy, but this isn't forgotten. When I got some time I'll implement the Linux soft delete based on the approach that trash-cli uses.

Apr 13 2019, 4:06 PM · Platform: Windows

Apr 12 2019

Robert Guetzkow (rjg) added a comment to T63540: Experienced crash loading an obj.

Does this happend with the most recent build? If yes, can you provide the .obj or .blend file?

Apr 12 2019, 5:47 PM · Import/Export, Addons
Robert Guetzkow (rjg) awarded D4650: For Discussion - Small Outliner Changes a Like token.
Apr 12 2019, 5:44 PM · User Interface
Robert Guetzkow (rjg) added a comment to T63456: Blender 2.80 not working.

This is likely because you use an old driver for your graphics card which doesn't support OpenGL 3.3 or newer. Install the latest driver and see if that resolves the problem.

Apr 12 2019, 5:25 PM · BF Blender
Robert Guetzkow (rjg) added a comment to T63530: blend file suddenly started crashing immediately after loading attached file in ~90% of my attempts.

It seems v_curr is pointing somewhere it shouldn't.

Apr 12 2019, 1:58 PM · BF Blender

Apr 11 2019

Robert Guetzkow (rjg) added a comment to T63492: CTRL+click on an image in a UV or Image Editor crashes Blender.

col_tot is zero in the division which causes the crash.

>	blender.exe!image_sample_rect_color_ubyte(const ImBuf * ibuf, const rcti * rect, unsigned char * r_col, float * r_col_linear) Zeile 3085	C
 	blender.exe!image_sample_apply(bContext * C, wmOperator * op, const wmEvent * event) Zeile 3161	C
 	blender.exe!image_sample_invoke(bContext * C, wmOperator * op, const wmEvent * event) Zeile 3279	C
 	blender.exe!wm_operator_invoke(bContext * C, wmOperatorType * ot, wmEvent * event, PointerRNA * properties, ReportList * reports, const bool poll_only, bool use_last_properties) Zeile 1343	C
 	blender.exe!wm_handler_operator_call(bContext * C, ListBase * handlers, wmEventHandler * handler_base, wmEvent * event, PointerRNA * properties) Zeile 2144	C
 	blender.exe!wm_handlers_do_intern(bContext * C, wmEvent * event, ListBase * handlers) Zeile 2462	C
 	blender.exe!wm_handlers_do(bContext * C, wmEvent * event, ListBase * handlers) Zeile 2720	C
 	blender.exe!wm_event_do_handlers(bContext * C) Zeile 3141	C
 	blender.exe!WM_main(bContext * C) Zeile 421	C
 	blender.exe!main(int argc, const unsigned char * * UNUSED_argv_c) Zeile 505	C
Apr 11 2019, 11:43 PM · BF Blender
Robert Guetzkow (rjg) closed T63505: Blender crashes when try to select a vertex from this particular file as Resolved.

Looks like this was already fixed in adaa7688ee77

Apr 11 2019, 11:33 PM · BF Blender
Robert Guetzkow (rjg) added a comment to T63505: Blender crashes when try to select a vertex from this particular file.

This was reproducible in a previous version from today, but the current master doesn't crash. GPU_texture_width was dereferencing a nullptr.

Apr 11 2019, 11:32 PM · BF Blender
Robert Guetzkow (rjg) added a comment to T63499: Crashing out of the program when adding torus.

I can't reproduce with the current master. Your blender version seems to be an older build, does that happen with the current 2.8 build as well?

Apr 11 2019, 7:54 PM · BF Blender

Apr 8 2019

Robert Guetzkow (rjg) added a comment to T63345: changing scene and applying modifiers.
Apr 8 2019, 9:01 PM · BF Blender
Robert Guetzkow (rjg) added a comment to T63399: Obj exporter does not respect "Apply Modifiers" settings.

@Sergey Sharybin (sergey) It seems to me that object_for_eval is set to the result of DEG_get_evaluated_object which has the modifiers applied, is used incorrectly in:

Apr 8 2019, 8:51 PM · BF Blender
Robert Guetzkow (rjg) raised the priority of T63399: Obj exporter does not respect "Apply Modifiers" settings from Confirmed, Low to Normal.

The functions rna_Object_to_mesh(), rna_Main_meshes_new_from_object() and BKE_mesh_new_from_object() all get apply_modifiers set to false as it should be. Could it be that this is an error introduced in 46eb5a0b8a4f3a7826b5e5a1a11e114e09037dba @Sergey Sharybin (sergey) ?

Apr 8 2019, 8:42 PM · BF Blender
Robert Guetzkow (rjg) triaged T63399: Obj exporter does not respect "Apply Modifiers" settings as Confirmed, Low priority.

Looks like EXPORT_APPLY_MODIFIERS is set to False when the option is unchecked but to_mesh() or another function applies the modifiers regardless.

Apr 8 2019, 7:49 PM · BF Blender
Robert Guetzkow (rjg) triaged T63398: Search on File Browser doesn't work at all as Needs Information from User priority.

Can't reproduce with the current master as well as previous releases. What exactly happens or doesn't happen? Are you sure that the search pattern doesn't apply to all files in the directory?

Apr 8 2019, 6:52 PM · BF Blender

Apr 5 2019

Robert Guetzkow (rjg) added a comment to D4648: PLY import with vertex color if alpha isn't set.

Patch is D4655. Haven't use arcanist before, will look into it for future patches.

Apr 5 2019, 6:32 PM
Robert Guetzkow (rjg) created D4655: Move reset after incomplete RGB channel warning in ply import.
Apr 5 2019, 6:31 PM
Robert Guetzkow (rjg) added a comment to D4648: PLY import with vertex color if alpha isn't set.

Oh no. I just noticed, that I made a mistake in the reset of colindices. Sorry.

Apr 5 2019, 6:23 PM
Robert Guetzkow (rjg) updated the diff for D4648: PLY import with vertex color if alpha isn't set.
  • Warning when vertex color is ignored because a color channel is there, but not all of the required R, G and B are present
Apr 5 2019, 5:33 PM
Robert Guetzkow (rjg) added inline comments to D4648: PLY import with vertex color if alpha isn't set.
Apr 5 2019, 4:58 PM
Robert Guetzkow (rjg) updated the diff for D4648: PLY import with vertex color if alpha isn't set.

Removed the print. Should there be a message if fewer color channels than RGB are present?

Apr 5 2019, 4:57 PM
Robert Guetzkow (rjg) updated the diff for D4648: PLY import with vertex color if alpha isn't set.
  • Removed redundant check
Apr 5 2019, 4:29 PM
Robert Guetzkow (rjg) updated the diff for D4648: PLY import with vertex color if alpha isn't set.
  • Less list comprehension
Apr 5 2019, 4:25 PM
Robert Guetzkow (rjg) added a comment to D4648: PLY import with vertex color if alpha isn't set.

Sure, no problem. It'll be less DRY, but I guess that's ok.

Apr 5 2019, 2:42 PM
Robert Guetzkow (rjg) added a reviewer for D4648: PLY import with vertex color if alpha isn't set: Brecht Van Lommel (brecht).
Apr 5 2019, 1:33 PM
Robert Guetzkow (rjg) added a comment to T63298: gltf2 import: TypeError: '>=' not supported between instances of 'tuple' and 'int'.

Are sure about this? I haven't had time to test the glTF import, but the actual error from line 135 surely can't be fixed by editing code that happens after it. Also I don't see a nested loop in 149 where i would be shadowed. Can you submit a patch/diff? This is probably easier to discuss.

Apr 5 2019, 11:22 AM · Addons
Robert Guetzkow (rjg) added a comment to T63222: text color change in contents.

This is being worked on, see D4650.

Apr 5 2019, 10:50 AM · Addons

Apr 4 2019

Robert Guetzkow (rjg) claimed T63227: Vertex Colors not imported for PLY files in 2.8.
Apr 4 2019, 10:48 PM · Addons
Robert Guetzkow (rjg) updated subscribers of T63227: Vertex Colors not imported for PLY files in 2.8.

The bug was introduced in 1542092295c9 and @Campbell Barton (campbellbarton) had already noticed it. However there doesn't seem to be any old bug report or patch.

Apr 4 2019, 10:16 PM · Addons
Robert Guetzkow (rjg) created D4648: PLY import with vertex color if alpha isn't set.
Apr 4 2019, 10:14 PM
Robert Guetzkow (rjg) added a revision to T63227: Vertex Colors not imported for PLY files in 2.8: D4648: PLY import with vertex color if alpha isn't set.
Apr 4 2019, 10:14 PM · Addons
Robert Guetzkow (rjg) added a comment to T63227: Vertex Colors not imported for PLY files in 2.8.

I think I found the bug. The current implementation requires an alpha channel for the vertex color otherwise it's ignored.

Apr 4 2019, 8:36 PM · Addons
Robert Guetzkow (rjg) added a comment to T63227: Vertex Colors not imported for PLY files in 2.8.

The code for handling vertex colors is there, but changes from the 2.79b version were introduced in 227fafdfcf4f. I'll have to take a closer look.

Apr 4 2019, 12:42 PM · Addons
Robert Guetzkow (rjg) updated subscribers of T63227: Vertex Colors not imported for PLY files in 2.8.

Looks like some code for the vertex color from the 2.79b release was changed in the port to 2.8. I'm not sure why, but there is a comment saying # XXX, colors dont come in right, needs further investigation. in the 2.79b version, so perhaps this feature didn't quite work as expected.

Apr 4 2019, 11:56 AM · Addons

Apr 3 2019

Robert Guetzkow (rjg) added a comment to T63255: crash while staying in circle select mode and clicking in another editor .

After having a quick look it seems that mesh_circle_select() in view3d_select.c and all functions called by it, don't check if the coordinates are outside the viewport, which ultimately results in GPU_select_buffer_stride_realign() failing an assert.

Apr 3 2019, 8:26 PM · BF Blender
Robert Guetzkow (rjg) added a comment to T63255: crash while staying in circle select mode and clicking in another editor .

I can confirm.

Apr 3 2019, 8:04 PM · BF Blender

Apr 2 2019

Pablo Vazquez (pablovazquez) awarded D4617: Collapsed nodes don't shrink a Love token.
Apr 2 2019, 7:42 PM
Robert Guetzkow (rjg) updated the diff for D4617: Collapsed nodes don't shrink.
  • Proper indentation (now for real ;) )
Apr 2 2019, 3:44 PM
Robert Guetzkow (rjg) added a comment to D4617: Collapsed nodes don't shrink.

Is the value clamping of minwidth of practical relevance, e.g. doing lots of collapses shrinks the node?

Apr 2 2019, 3:40 PM
Robert Guetzkow (rjg) added a comment to D4617: Collapsed nodes don't shrink.

@Jacques Lucke (JacquesLucke) Sorry. For some reason the tab to space conversion was disabled in VS.

Apr 2 2019, 3:18 PM
Robert Guetzkow (rjg) updated the diff for D4617: Collapsed nodes don't shrink.
  • Removed variable and used value directly in max_ff
  • Proper indentation
Apr 2 2019, 2:57 PM
Robert Guetzkow (rjg) assigned T63219: Compilation errors on dna_verify.c to Brecht Van Lommel (brecht).
Apr 2 2019, 2:33 PM · BF Blender
Robert Guetzkow (rjg) created T63219: Compilation errors on dna_verify.c.
Apr 2 2019, 2:33 PM · BF Blender
Robert Guetzkow (rjg) added a comment to T63215: Canceling extrude doesn't undo the extrude, only the distance moved..

This is the same behavior as in 2.79 (pressing escape had the same result). An actual undo reverts the extrude.

Apr 2 2019, 1:35 PM · BF Blender
Robert Guetzkow (rjg) updated subscribers of T63213: Face dots visibility problem.

@Campbell Barton (campbellbarton) you have worked on this before, perhaps you can have a look?

Apr 2 2019, 1:15 PM · BF Blender
Robert Guetzkow (rjg) added a comment to T63213: Face dots visibility problem.

@YAFU (YAFU) you're right in perspective mode this doesn't happen, but in ortho it does. So I correct my previous statement: I can reproduce this issue even when appending to a new project. However I haven't found a way to create an object the has this behavior using the current master build, I do get faces that miss the dot though. Perhaps there is something wrong with the drawing order?

Apr 2 2019, 1:06 PM · BF Blender
Robert Guetzkow (rjg) added a comment to T63213: Face dots visibility problem.

This seems to be a problem with your particular blend-file, because if I append the mesh from your file to a new scene and enabled the face dot in the overlay it works just fine.

Apr 2 2019, 12:53 PM · BF Blender
Robert Guetzkow (rjg) raised the priority of T63213: Face dots visibility problem from Needs Information from User to Normal.
Apr 2 2019, 12:50 PM · BF Blender
Robert Guetzkow (rjg) added a comment to T63213: Face dots visibility problem.

This is odd indeed. You shouldn't see the backside unless you have X-Ray enabled.

Apr 2 2019, 12:49 PM · BF Blender
Robert Guetzkow (rjg) triaged T63213: Face dots visibility problem as Needs Information from User priority.
Apr 2 2019, 12:20 PM · BF Blender
Robert Guetzkow (rjg) added a comment to T63213: Face dots visibility problem.

Could you post the blend file? This looks like overlapping bad geometry to me, which is hard to select because the faces coincide.

Apr 2 2019, 12:19 PM · BF Blender
Robert Guetzkow (rjg) added a comment to T63194: cycles settings disappear .

@Giorgi (Aganattu_Surodzai) given that you've posted two screenshots where you have selected the render tab and not the object tab, could the issue be that you're looking at the wrong tab?

Apr 2 2019, 12:13 PM · BF Blender

Apr 1 2019

Robert Guetzkow (rjg) added a comment to T63194: cycles settings disappear .

Is this the "Ray Visibility" you mean? When does it disappear, can you tell us the exact steps to reproduce?

Apr 1 2019, 8:40 PM · BF Blender
Robert Guetzkow (rjg) added a comment to D4617: Collapsed nodes don't shrink.

I can increase the minimum width for the collapsed state, if you think that it's too short.

Apr 1 2019, 4:34 PM

Mar 30 2019

Robert Guetzkow (rjg) added a comment to T63101: Blender crashes on adding any object to collection duplicated with added scene.

The crash is caused by selbase being a nullptr in layer.c line 348. I'm not sure why it is though.

Mar 30 2019, 6:18 PM · BF Blender
Robert Guetzkow (rjg) updated subscribers of T63121: New version of Blender crashes.

@Clément Foucault (fclem) has already been notified by others about the crashes. The problem is caused by commit dec9c7d87e5b

Mar 30 2019, 6:09 PM · BF Blender
Robert Guetzkow (rjg) added a comment to D4622: Fix for dereferencing nullptr in gp_data_unlink_poll.

For reference this is commited with 4b6a4b5bc25b

Mar 30 2019, 5:44 PM
Robert Guetzkow (rjg) closed D4622: Fix for dereferencing nullptr in gp_data_unlink_poll.
Mar 30 2019, 5:36 PM
Robert Guetzkow (rjg) updated the diff for D4617: Collapsed nodes don't shrink.
  • Resizing results in same size between open and collapsed node, except when the collapsed node needs to be wider due to the rounded caps
  • miniwidth usage is removed
Mar 30 2019, 5:33 PM
Robert Guetzkow (rjg) added a comment to D4617: Collapsed nodes don't shrink.

What is the expected behavior for resizing? I assume it should be possible to resize both in open and collapsed state and the size should remain consistent except for when the open state is too small for the circular arrangement in collapsed state. Then the node in collapsed state may be larger (the minimum width necessary to draw both circular sides without overlap).

Mar 30 2019, 2:03 PM
Robert Guetzkow (rjg) added a task to D4622: Fix for dereferencing nullptr in gp_data_unlink_poll: T63109: Crash when use search bar.
Mar 30 2019, 1:53 PM
Robert Guetzkow (rjg) added a revision to T63109: Crash when use search bar: D4622: Fix for dereferencing nullptr in gp_data_unlink_poll.
Mar 30 2019, 1:53 PM · BF Blender
Robert Guetzkow (rjg) created D4622: Fix for dereferencing nullptr in gp_data_unlink_poll.
Mar 30 2019, 1:52 PM
Robert Guetzkow (rjg) added a comment to T63109: Crash when use search bar.

The problem is actually still in eeefea86cddb. The gpd can be NULL which isn't checked in the code.

Mar 30 2019, 1:44 PM · BF Blender