Page MenuHome

Ha Hyung-jin (robobeg)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 4 2018, 7:57 AM (96 w, 6 d)

Recent Activity

Wed, Nov 6

Ha Hyung-jin (robobeg) added a comment to T71071: Complex scene, one GPU renders successfully, but multiple GPUs fail to render.

Hi robobeg
Yes. Using the the "spring" scene as test again, the same error occures with only the screen driving gpu should render.
So the issue seems not to be the balancing between differently VRAM equipped gpu's, your fix looks okay here.
I now follow your assumption that its another issue.
I can get the scene to render by either reducing the haircount or other simplifications that reduce memory usage.
I think now that the memory used for the attched screens is not taken into account. ( ? )
You might end with the same result as me, is it okay you make a new bugreport out of this find yourself ?
You are the specialist here.
Greetings ... Jens

Wed, Nov 6, 2:04 PM · Cycles, Render & Cycles, BF Blender
Ha Hyung-jin (robobeg) added a comment to T71071: Complex scene, one GPU renders successfully, but multiple GPUs fail to render.

Unfortunately this does not fix the Optix render if one of the gpu's is driving the screen.
I get with 2 exact same RTX 2080 and the spring test scene:

OptiX error OPTIX_ERROR_LAUNCH_FAILURE in optixLaunch(pipelines[PIP_PATH_TRACE], cuda_stream[thread_index], launch_params_ptr, launch_params.data_elements, &sbt_params, wtile.w * wtile.num_samples, wtile.h, 1), line 668

and then only the not screen driving device renders the scene. Cuda seems fine now.
Jens

Wed, Nov 6, 1:45 AM · Cycles, Render & Cycles, BF Blender

Tue, Nov 5

Ha Hyung-jin (robobeg) updated the diff for D6126: Fix T71071: Complex scene, one GPU renders successfully, but multiple GPUs fail to render.

Parentheses are added around ‘&&’ within ‘||’ to make it easier to understand and silence strict compiler warning.

Tue, Nov 5, 7:32 AM · BF Blender, Render & Cycles

Tue, Oct 29

Ha Hyung-jin (robobeg) updated the diff for D6126: Fix T71071: Complex scene, one GPU renders successfully, but multiple GPUs fail to render.

The style of comments is modified.

Tue, Oct 29, 2:32 AM · BF Blender, Render & Cycles

Mon, Oct 28

Ha Hyung-jin (robobeg) added a comment to D6126: Fix T71071: Complex scene, one GPU renders successfully, but multiple GPUs fail to render.

This isn't really a higher level overview of the problem.
Am i right that the issue is that multiple compute devices were using same device pointer, while the code was relying on the fact that it never happens?

Mon, Oct 28, 10:41 PM · BF Blender, Render & Cycles
Ha Hyung-jin (robobeg) added a comment to D6126: Fix T71071: Complex scene, one GPU renders successfully, but multiple GPUs fail to render.

This isn't really a higher level overview of the problem.
Am i right that the issue is that multiple compute devices were using same device pointer, while the code was relying on the fact that it never happens?

Mon, Oct 28, 2:44 PM · BF Blender, Render & Cycles
Ha Hyung-jin (robobeg) added a comment to D6126: Fix T71071: Complex scene, one GPU renders successfully, but multiple GPUs fail to render.

The code related to 'device_memory' does not handle this situation properly.

Can you elaborate a bit more about it (on a higher level) ?

Mon, Oct 28, 1:32 PM · BF Blender, Render & Cycles

Fri, Oct 25

Ha Hyung-jin (robobeg) added projects to T71071: Complex scene, one GPU renders successfully, but multiple GPUs fail to render: Render & Cycles, Cycles.
Fri, Oct 25, 4:21 AM · Cycles, Render & Cycles, BF Blender
Ha Hyung-jin (robobeg) updated the task description for T71071: Complex scene, one GPU renders successfully, but multiple GPUs fail to render.
Fri, Oct 25, 3:48 AM · Cycles, Render & Cycles, BF Blender
Ha Hyung-jin (robobeg) updated the task description for T71071: Complex scene, one GPU renders successfully, but multiple GPUs fail to render.
Fri, Oct 25, 3:47 AM · Cycles, Render & Cycles, BF Blender
Ha Hyung-jin (robobeg) updated the summary of D6126: Fix T71071: Complex scene, one GPU renders successfully, but multiple GPUs fail to render.
Fri, Oct 25, 2:11 AM · BF Blender, Render & Cycles
Ha Hyung-jin (robobeg) updated the diff for D6126: Fix T71071: Complex scene, one GPU renders successfully, but multiple GPUs fail to render.

Tab spacings were modified according to surrounding codes.

Fri, Oct 25, 2:09 AM · BF Blender, Render & Cycles

Thu, Oct 24

Ha Hyung-jin (robobeg) retitled D6126: Fix T71071: Complex scene, one GPU renders successfully, but multiple GPUs fail to render from Fix T71071: Using only one GPU will render successfully, but multiple GPUs fail to render. to Fix T71071: Complex scene, one GPU renders successfully, but multiple GPUs fail to render.
Thu, Oct 24, 2:15 PM · BF Blender, Render & Cycles
Ha Hyung-jin (robobeg) retitled D6126: Fix T71071: Complex scene, one GPU renders successfully, but multiple GPUs fail to render from Bug fix: Using only one GPU will render successfully, but multiple GPUs fails to render. to Fix T71071: Using only one GPU will render successfully, but multiple GPUs fail to render..
Thu, Oct 24, 2:14 PM · BF Blender, Render & Cycles
Ha Hyung-jin (robobeg) created T71071: Complex scene, one GPU renders successfully, but multiple GPUs fail to render.
Thu, Oct 24, 2:13 PM · Cycles, Render & Cycles, BF Blender
Ha Hyung-jin (robobeg) updated the summary of D6126: Fix T71071: Complex scene, one GPU renders successfully, but multiple GPUs fail to render.
Thu, Oct 24, 1:56 PM · BF Blender, Render & Cycles
Ha Hyung-jin (robobeg) updated the summary of D6126: Fix T71071: Complex scene, one GPU renders successfully, but multiple GPUs fail to render.
Thu, Oct 24, 12:42 PM · BF Blender, Render & Cycles
Ha Hyung-jin (robobeg) updated the summary of D6126: Fix T71071: Complex scene, one GPU renders successfully, but multiple GPUs fail to render.
Thu, Oct 24, 9:18 AM · BF Blender, Render & Cycles
Ha Hyung-jin (robobeg) updated the summary of D6126: Fix T71071: Complex scene, one GPU renders successfully, but multiple GPUs fail to render.
Thu, Oct 24, 9:07 AM · BF Blender, Render & Cycles
Ha Hyung-jin (robobeg) created D6126: Fix T71071: Complex scene, one GPU renders successfully, but multiple GPUs fail to render.
Thu, Oct 24, 8:50 AM · BF Blender, Render & Cycles

Jan 31 2018

Ha Hyung-jin (robobeg) added a comment to rB7261d675e6ae: Fix Cycles incorrect principled BSDF mixing with some parameter variatons..

Thanks for a quick fix. In the above patch, I found one initialization was missed:
(svm_closure.h, line 336)
bsdf->T = make_float3(0.0f, 0.0f, 0.0f);
and it is not in function 'bsdf_microfacet_ggx_refraction_setup()', either.

Jan 31 2018, 9:02 AM

Jan 30 2018

Ha Hyung-jin (robobeg) added a comment to rB8825a8e951c1: Squashed commit of the following:.

This patch might result in wrong merges of MicrofacetBsdf closures.

Jan 30 2018, 4:40 AM

Jan 28 2018

Ha Hyung-jin (robobeg) added a comment to rC25f9fc71ce53: Code refactor: move more memory allocation logic into device API..

I found that this patch made 'device_only_memory<T>' over-allocate device memory by a factor of sizeof(T). I think that line 248 of 'device_memory.h' should be revised from

data_size = num*sizeof(T);

to

data_size = num;
Jan 28 2018, 3:34 PM

Jan 27 2018

Ha Hyung-jin (robobeg) added a comment to rB095a01a73a35: Cycles: slightly improve BSDF sample stratification for path tracing..

I made a simple example showing the bug.
An emissive sphere is reflected on a floor with two different principled bsdfs. The left half has 'subsurface: 0.000' while the right half has 'subsurface: 0.300', so the latter is expected to look fuzzier.

Jan 27 2018, 12:09 PM

Jan 26 2018

Ha Hyung-jin (robobeg) added a comment to rBd611cf923358: Fix mixed BSDF + BSSRDF sampling bug in path tracing, after 095a01a73a35..

That's it! Thanks for a quick fix!
Although I cannot test the patch at the moment, I am certain that it will work for the 'path tracing' mode because 'shader_bsdf_pick' and 'shader_bssrdf_pick' now perform sampling closures in the same way with the same 'randu' ( = PRNG_BSDF_U ). ( ... besides numerical issues. How about sharing the code body as a common function? )

Jan 26 2018, 8:06 PM
Ha Hyung-jin (robobeg) added a comment to rB095a01a73a35: Cycles: slightly improve BSDF sample stratification for path tracing..

Yes. I will upload the .blend file after this weekend.

Jan 26 2018, 6:14 PM
Ha Hyung-jin (robobeg) added a comment to rB095a01a73a35: Cycles: slightly improve BSDF sample stratification for path tracing..

I encountered an issue related to this patch. Using blender v2.79 I made a test scene having a floor with rough reflection. However, the floor was rendered like a mirror with the blender executable built with the latest master branch. I found that the phenomenon occurred when a single shader generated multiple BSDF closures along with BSSRDF closures.

Jan 26 2018, 5:27 PM

Jan 17 2018

Ha Hyung-jin (robobeg) added a comment to rBfa3d50af95fd: Cycles: Improve denoising speed on GPUs with small tile sizes.

Oh... I've always taken a snapshot of projects/blender.git at the git://git.blender.org/blender.git but it has given me mixed files.
The master version contains the atomic version of util_math_matrix.h, as you said.
Thanks.

Jan 17 2018, 5:38 PM
Ha Hyung-jin (robobeg) added a comment to T52802: Denoise artifacts with Direct Glossy.

I also encountered this problem and found a remedy.

Jan 17 2018, 5:09 PM · Cycles, BF Blender
Ha Hyung-jin (robobeg) added a comment to rBfa3d50af95fd: Cycles: Improve denoising speed on GPUs with small tile sizes.

I have been working on a rendering project, which heavily relies on the cycles denoising feature. ( Thanks a lot~! )

Jan 17 2018, 1:04 PM