Page MenuHome

Sayak Biswas (sayakAMD)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 11 2021, 11:36 PM (50 w, 4 d)

Recent Activity

Sun, Sep 25

Lloyd (digim0nk) awarded D14360: Cycles: enable HIP binaries on Linux a Dislike token.
Sun, Sep 25, 10:13 AM

Tue, Sep 20

Sayak Biswas (sayakAMD) added a comment to T100891: blender3.3 HIP performance down 30% on Windows.

Okay it seems this commit is causing the performance differential: https://github.com/blender/blender/commit/023eb2ea7c16a00272f83d564145e28aeb9ed2b7
On my W6800, the classroom scene renders in about 59s on a build from this commit. However the previous commit (d567785658349504dc98c693c8c46c30e9a60c44) the scene renders in ~44s. I'm not entirely sure yet which change is exactly causing the issue, maybe the new transform_inverse?

Tue, Sep 20, 12:42 AM · Platform: Windows, Render & Cycles, Cycles, BF Blender

Thu, Sep 8

Nitin Sharma (finalflasher) awarded D15242: Enable Vega GPU/APU for Cycles HIP a Burninate token.
Thu, Sep 8, 11:00 AM

Aug 24 2022

Sayak Biswas (sayakAMD) added a comment to T97591: Cycles HIP error with image textures on Linux and RDNA1.

Update on this issue: there is a fix for this in the driver and it should be available on rocm 5.3.0.

Aug 24 2022, 6:49 PM · Render & Cycles, BF Blender

Aug 17 2022

Sayak Biswas (sayakAMD) added a comment to T100353: Cycles HIP rendered viewport crashes system/GPU on Linux with RDNA2 GPU.

Okay, with 5.19 kernel I am able to kind of reproduce the issue. It doesn't cause a system freeze for me, but both instances of blender freeze.

Aug 17 2022, 2:51 AM · BF Blender
Sayak Biswas (sayakAMD) added a comment to T100353: Cycles HIP rendered viewport crashes system/GPU on Linux with RDNA2 GPU.

I am unable to reproduce this issue on an Ubuntu 20.04.4, it is running kernel 5.15 though. I will upgrade to 5.19.1 via a ppa and see if it repros.

Aug 17 2022, 2:17 AM · BF Blender

Jun 22 2022

Sayak Biswas (sayakAMD) updated the diff for D15242: Enable Vega GPU/APU for Cycles HIP.

Removed "discrete" from description text

Jun 22 2022, 7:07 AM

Jun 20 2022

Sayak Biswas (sayakAMD) updated the summary of D15242: Enable Vega GPU/APU for Cycles HIP.
Jun 20 2022, 1:52 PM
Sayak Biswas (sayakAMD) added a revision to T91571: Cycles HIP device: D15242: Enable Vega GPU/APU for Cycles HIP.
Jun 20 2022, 1:48 PM · Cycles, Render & Cycles
Sayak Biswas (sayakAMD) added a revision to T96740: Enable HIP on older devices: D15242: Enable Vega GPU/APU for Cycles HIP.
Jun 20 2022, 1:48 PM · Cycles, Render & Cycles
Sayak Biswas (sayakAMD) added tasks to D15242: Enable Vega GPU/APU for Cycles HIP: T96740: Enable HIP on older devices, T91571: Cycles HIP device.
Jun 20 2022, 1:48 PM
Sayak Biswas (sayakAMD) requested review of D15242: Enable Vega GPU/APU for Cycles HIP.
Jun 20 2022, 1:47 PM

May 25 2022

Sayak Biswas (sayakAMD) added a comment to T97591: Cycles HIP error with image textures on Linux and RDNA1.

I was able to reproduce this issue with a 5700XT + Ubuntu 20.04 + ROCm 5.1.2 with bmw and classroom scenes. I'm looking into this.

May 25 2022, 2:48 PM · Render & Cycles, BF Blender

May 11 2022

Sayak Biswas (sayakAMD) added a comment to T97997: Crash while rendering image textures on Cycles using the AMD Radeon RX 6600m graphics card.

Of course, np. I was unable to reproduce the issue on a 6800xt. So the api trace from your machine could be helpful. You can add the following to environment variables to the system.

May 11 2022, 6:37 PM · BF Blender
Sayak Biswas (sayakAMD) added a comment to T97997: Crash while rendering image textures on Cycles using the AMD Radeon RX 6600m graphics card.

@Rafael Nieves (Xenevis) Could you set the variable AMD_LOG_LEVEL=3 and run blender? This should print out the API trace from HIP, can you paste that?

May 11 2022, 2:42 PM · BF Blender
Sayak Biswas (sayakAMD) added a comment to T97554: HIP CPU+GPU slower than GPU only.

Yeah that is the one, I suppose we can mark this as a duplicate

May 11 2022, 11:40 AM · Render & Cycles, Cycles, BF Blender
Sayak Biswas (sayakAMD) added a comment to T97554: HIP CPU+GPU slower than GPU only.

There was some work done on load balancing recently from someone in our team to improve this. I'll check if the patch was submitted or not.

May 11 2022, 11:35 AM · Render & Cycles, Cycles, BF Blender

Apr 1 2022

Andrea Monzini (Andrea_Monzini) awarded D14360: Cycles: enable HIP binaries on Linux a Love token.
Apr 1 2022, 1:23 PM

Mar 20 2022

Lloyd (digim0nk) awarded D14360: Cycles: enable HIP binaries on Linux a Love token.
Mar 20 2022, 6:19 PM

Mar 16 2022

Sayak Biswas (sayakAMD) added a revision to T91571: Cycles HIP device: D14360: Cycles: enable HIP binaries on Linux.
Mar 16 2022, 7:15 PM · Cycles, Render & Cycles
Sayak Biswas (sayakAMD) added a task to D14360: Cycles: enable HIP binaries on Linux: T91571: Cycles HIP device.
Mar 16 2022, 7:15 PM
Sayak Biswas (sayakAMD) requested review of D14360: Cycles: enable HIP binaries on Linux.
Mar 16 2022, 7:14 PM

Mar 3 2022

Sayak Biswas (sayakAMD) requested review of D14232: Workaround to fix hang on classroom scene with 22.10 drivers.
Mar 3 2022, 2:41 AM · Cycles

Feb 28 2022

Sayak Biswas (sayakAMD) added a comment to D14198: Fix hipDeviceGetAttribute crash.

Thanks for looking into this, though there are bugfixes to the driver coming.

So that might make these changes obsolete? @Brian Savery (bsavery), @Sayak Biswas (sayakAMD) would know more.

Feb 28 2022, 11:11 PM

Jan 20 2022

Sayak Biswas (sayakAMD) added a comment to T91571: Cycles HIP device.

Is there a branch for 3.2 or is code going to master for now? I have some changes to hipew, I'd like to push

Jan 20 2022, 7:02 PM · Cycles, Render & Cycles

Nov 23 2021

Sayak Biswas (sayakAMD) added a comment to T93109: Cycles HIP device missing driver version check.

Submitted patch checking for file version of amdhip64.dll

Nov 23 2021, 3:20 AM · Cycles, BF Blender
Sayak Biswas (sayakAMD) added a revision to T93109: Cycles HIP device missing driver version check: D13324: Fix T93109: Cycles HIP device missing driver version check.
Nov 23 2021, 3:19 AM · Cycles, BF Blender
Sayak Biswas (sayakAMD) added a task to D13324: Fix T93109: Cycles HIP device missing driver version check: T93109: Cycles HIP device missing driver version check.
Nov 23 2021, 3:19 AM
Sayak Biswas (sayakAMD) requested review of D13324: Fix T93109: Cycles HIP device missing driver version check.
Nov 23 2021, 3:19 AM
Sayak Biswas (sayakAMD) added a comment to T93244: only one GPU rendering with HIP.

Submitted a patch to fix the issue

Nov 23 2021, 12:52 AM · Render & Cycles, BF Blender
Sayak Biswas (sayakAMD) added a revision to T93244: only one GPU rendering with HIP: D13323: Fix T93244: only one gpu rendering with hip.
Nov 23 2021, 12:52 AM · Render & Cycles, BF Blender
Sayak Biswas (sayakAMD) added a task to D13323: Fix T93244: only one gpu rendering with hip: T93244: only one GPU rendering with HIP.
Nov 23 2021, 12:52 AM
Sayak Biswas (sayakAMD) requested review of D13323: Fix T93244: only one gpu rendering with hip.
Nov 23 2021, 12:51 AM

Nov 22 2021

Sayak Biswas (sayakAMD) added a comment to T93244: only one GPU rendering with HIP.

We haven't tested this before. I can confirm that I can reproduce the issue now with two 5700XTs.

Nov 22 2021, 9:01 PM · Render & Cycles, BF Blender
Sayak Biswas (sayakAMD) added a comment to T93109: Cycles HIP device missing driver version check.

We should be able to use it, I am confirming with the driver packaging team. The drawback would be that this dll version info will not the same number as the Radeon Software package version (i.e not 21.40 etc) so we won't be able to provide a more user friendly message other than maybe "Please upgrade driver to 21.40 or later".

Nov 22 2021, 8:06 PM · Cycles, BF Blender

Nov 20 2021

Sayak Biswas (sayakAMD) added a revision to T92984: Cycles HIP crash with smoke volume: D13296: Fix T92984: Cycles HIP crash with smoke volume.
Nov 20 2021, 1:05 AM · Render & Cycles, BF Blender
Sayak Biswas (sayakAMD) added a task to D13296: Fix T92984: Cycles HIP crash with smoke volume: T92984: Cycles HIP crash with smoke volume.
Nov 20 2021, 1:05 AM
Sayak Biswas (sayakAMD) requested review of D13296: Fix T92984: Cycles HIP crash with smoke volume.
Nov 20 2021, 1:05 AM
Sayak Biswas (sayakAMD) added a comment to T92984: Cycles HIP crash with smoke volume.

Okay, cool! Running through the Cycles demos once to make sure nothing else broke. Will submit that patch in a bit.

Nov 20 2021, 12:01 AM · Render & Cycles, BF Blender

Nov 19 2021

Sayak Biswas (sayakAMD) added a comment to T92984: Cycles HIP crash with smoke volume.

Okay, I think I have a fix for the issue with quick smoke{F11829719}. How can I test other volume rendering? Is there a sample scene?

Nov 19 2021, 8:55 PM · Render & Cycles, BF Blender
Sayak Biswas (sayakAMD) added a comment to T93109: Cycles HIP device missing driver version check.

hipRuntimeGetVersion doesn't really provide the correct info. We can get the relevant driver version string from the Windows registry. I will add this to give out an error in case the driver < 21.40.

Nov 19 2021, 6:19 PM · Cycles, BF Blender
Sayak Biswas (sayakAMD) added a comment to T92984: Cycles HIP crash with smoke volume.

I am working on this. Is the quick smoke feature working with NanoVDB enabled? I tried it with the latest from the release branch and it still seems to crash. Debugging the crash, it seems to me like a pointer for the hipArray isn't correctly setup in hipew. I'm looking into this more, will try and update more details by Monday.

Nov 19 2021, 6:04 PM · Render & Cycles, BF Blender

Oct 21 2021

Sayak Biswas (sayakAMD) added a comment to D12958: Patch for precompiled kernel binaries and additional fixes.

I compiled it on my machine and everything seemed to work but when I run the program I keep getting

Error: Invalid value in hipDeviceGetAttribute(&pitch_alignment, hipDeviceAttributeTexturePitchAlignment, hipDevice) (intern/cycles/device/hip/device_impl.cpp:116)

Oct 21 2021, 11:51 PM
Sayak Biswas (sayakAMD) changed the status of T92393: Fix the kernel compilation process for pre-built binaries, a subtask of T91571: Cycles HIP device, from Needs Triage to Confirmed.
Oct 21 2021, 8:14 PM · Cycles, Render & Cycles
Sayak Biswas (sayakAMD) changed the status of T92393: Fix the kernel compilation process for pre-built binaries from Needs Triage to Confirmed.
Oct 21 2021, 8:14 PM · BF Blender (2.90), Cycles, Render & Cycles
Sayak Biswas (sayakAMD) closed T92124: Fix high device memory usage on HIP device, a subtask of T91571: Cycles HIP device, as Resolved.
Oct 21 2021, 8:14 PM · Cycles, Render & Cycles
Sayak Biswas (sayakAMD) closed T92124: Fix high device memory usage on HIP device as Resolved.
Oct 21 2021, 8:14 PM · Cycles, Render & Cycles
Sayak Biswas (sayakAMD) added a revision to T92393: Fix the kernel compilation process for pre-built binaries: D12958: Patch for precompiled kernel binaries and additional fixes.
Oct 21 2021, 8:13 PM · BF Blender (2.90), Cycles, Render & Cycles
Sayak Biswas (sayakAMD) added a task to D12958: Patch for precompiled kernel binaries and additional fixes: T92393: Fix the kernel compilation process for pre-built binaries.
Oct 21 2021, 8:13 PM
Sayak Biswas (sayakAMD) requested review of D12958: Patch for precompiled kernel binaries and additional fixes.
Oct 21 2021, 8:11 PM
Sayak Biswas (sayakAMD) created T92393: Fix the kernel compilation process for pre-built binaries.
Oct 21 2021, 8:07 PM · BF Blender (2.90), Cycles, Render & Cycles

Oct 19 2021

Sayak Biswas (sayakAMD) updated the diff for D12834: HIP device code cleanup and fix for high VRAM usage.

Added a warning in case CYCLES_CONCURRENT_STATES_FACTOR evaluates to 0

Oct 19 2021, 2:52 AM
Sayak Biswas (sayakAMD) updated the diff for D12834: HIP device code cleanup and fix for high VRAM usage.

Updated hipew loader according to changes to API.
Turned on WITH_CYCLES_DEVICE_HIP in top-level CMakeLists

Oct 19 2021, 2:35 AM
Sayak Biswas (sayakAMD) added inline comments to D12834: HIP device code cleanup and fix for high VRAM usage.
Oct 19 2021, 2:10 AM
Sayak Biswas (sayakAMD) added inline comments to D12834: HIP device code cleanup and fix for high VRAM usage.
Oct 19 2021, 1:44 AM

Oct 12 2021

Sayak Biswas (sayakAMD) updated the diff for D12834: HIP device code cleanup and fix for high VRAM usage.

Removed struct intern/cycles/kernel/bvh/bvh_util.h, per review comment.

Oct 12 2021, 6:57 PM
Sayak Biswas (sayakAMD) changed the visibility for D12834: HIP device code cleanup and fix for high VRAM usage.
Oct 12 2021, 6:27 PM
kursad k (kursadk) awarded T92124: Fix high device memory usage on HIP device a Love token.
Oct 12 2021, 2:49 AM · Cycles, Render & Cycles
Sayak Biswas (sayakAMD) updated the summary of D12834: HIP device code cleanup and fix for high VRAM usage.
Oct 12 2021, 1:47 AM
Sayak Biswas (sayakAMD) added a revision to T92124: Fix high device memory usage on HIP device: D12834: HIP device code cleanup and fix for high VRAM usage.
Oct 12 2021, 1:45 AM · Cycles, Render & Cycles
Sayak Biswas (sayakAMD) added a task to D12834: HIP device code cleanup and fix for high VRAM usage: T92124: Fix high device memory usage on HIP device.
Oct 12 2021, 1:45 AM
Sayak Biswas (sayakAMD) requested review of D12834: HIP device code cleanup and fix for high VRAM usage.
Oct 12 2021, 1:44 AM
Sayak Biswas (sayakAMD) updated the task description for T92124: Fix high device memory usage on HIP device.
Oct 12 2021, 1:37 AM · Cycles, Render & Cycles
Sayak Biswas (sayakAMD) created T92124: Fix high device memory usage on HIP device.
Oct 12 2021, 1:34 AM · Cycles, Render & Cycles