Interesting. This doesnt even work in 2.79! :D Never noticed it though.

ok, thanks.
Btw: even easier workaround: Duplicate the node, make single user. :)

Oops, I am sorry, I didn't test with the latest build. This is apparently already fixed!

Confirmed, though it is not just Detect Features. Also adding a new Marker results in an empty Adjust Last Operation panel.

I would like to come back to this issue.
@Sergey Sharybin (sergey) told me a while ago that this is indeed a bug, and for the upcoming VFX course this should be fixed.

Is there any chance this can get fixed before final 2.80? Would make the VFX course at the Institute a bit more pleasant ;)

Seems to be similar to this issue: https://developer.blender.org/D4638#115765
What do you think, @Jeroen Bakker (jbakker)?

Just a note: As already mentioned to @Brendon Murphy (meta-androcto) in blender.chat, the issues in clip editor pie where afaics not the ones in space_clip.py, but in the former pie_menus_official addon. I don't think that is even needed anymore, and at least the clip editor pies in that addon can be removed, since we have those in space_clip.py already.

You can press Shift+M in 3D Viewport and Outliner as well to link one or more objects to a collection instead of moving it to a collection. Unless I am misunderstanding your problem, and you mean something else.

Yep, I can confirm that, though this never worked. It totally sucks, but it's not a bug, more a limitation.
I hope this can get fixed once the masking tools are brought to the new tool system. Hopefully in 2.81! :)

Yes, that would have been it.

Ah, I understand.
So it looks like as if you would have tracked this shot with some kind of script, which was adding keyframes for the marker weight on each frame. These are the keyframes that appear in the timeline, and there doesn't seem to be a way to filter those.
Any idea what to do about that, @Sergey Sharybin (sergey)?

Yes, upload did work.
I think I know what happened, though.
You probably clicked on "Constraint to F-Curve" in the Camera's Camera-Solver Constraint. That will convert the track into single keyframes. You don't need to do that, though. Just add the Camera-Solver to the camera, and it will move according to the camera solution. Did that help?

Yeah, confirmed. This did work in 2.79.

Confirmed. Also, we probably need to adjust the keymap.

I can't reproduce that. Please send a file that shows those keyframes. You don't need to send the footage, blendfile is enough.

I agree that this looks like a bug, or at least it's not the logical behavior.
I would expect Holdout to "override" Indirect Only.
With Indirect Only you see only the indirect influence of the object.
With Holdout you see the indirect influence of the object to the scene, but also it cuts a hole in the render, so to speak.
So funtionality wise Indirect Only is included in Holdout. So if both are activated, I think it should be rendered as holdout.

I don't have commit rights ;) So if you want, please commit.

Sounds similar to T64438...

@Brecht Van Lommel (brecht) @Sergey Sharybin (sergey) Thanks so much for helping out with this. It also works great! :)
I am just not so sure about line 1191. When using the 27x keymap and rightclicking on a curve point it goes directly into transform mode. This feels a bit odd, since it should just select the point. If I want to drag a curve point with RMB I can simply rightclick and drag.

This is rather new though. Pretty sure it didn't confirm until 1 or 2 days ago.

@Sergey Sharybin (sergey) is there anything I can do to help here?

I have removed the extra class and added a poll.
While doing the poll function I figured it would make sense to make the context menu aware of if there is a mask or not, so you can create an empty new mask or add a new mask with primitive shape from the context menu.

@Jeroen Bakker (jbakker) DOF in Cycles over background images doesn't work at all:

@Jeroen Bakker (jbakker) Holdout in combination with transparent film doesn't seem to work. When scene as Film Transparent enabled and I create a viewlayer that is set to holdout, the Cycles viewport rendering shows the transparent area created by the holdout as grey world background, but not the Background images. You can try this file:

@Sergey Sharybin (sergey) hehe, no other pending changes at the moment, so you can apply. Thanks! :)

I noticed that the "Adjust Last Operation" checkbox was missing from the Clip Editor's View menu, so I added that.

I have fixed some inconsistent icons and elimated some whitespace.

In D5075#115569, @Sergey Sharybin (sergey) wrote:

In D5070#115605, @Sergey Sharybin (sergey) wrote:

Well, somehow the closest functionality seems to be nodes, somehow. At least that is another big area where we allow selection, dragging, select-and-drag.
Shall we stick to the same rules for masking?

@Sergey Sharybin (sergey) What do you think of the issue @Brecht Van Lommel (brecht) mentioned?

I know, it's a bit weird, but when select is set to select_mouse (LMB by default), there is a conflict with the tweak functionality, so when you try to slide a single mask point, you slide the entire mask.
We had 2 different select modes in 2.79 as well: left-clicking would do a select + move when dragggin, right-clicking would select as well, and, if mouse dragged, would start a transform as well. However, only with RMB you could also extend the selection by holding shift.

Yep, that works. Thanks a lot, @Sergey Sharybin (sergey) :)

I would say Fake User is different than normal user. The UI doesn’t even use the F anymore, so to non-old-farts or developers it would not be obvious why enabling the shield icon (formerly know as F) would add a user. So, clicking the shield icon should not raise number.

I think part of the problem is, that there is not really a second user, because the Scene doesn’t really “use” it. The thing is that in this case as well as in the case of Node Groups there is no obvious way to create a second user to begin with. So I would rather not make the user count hidden at all.

Correct. I would expect that at least it would be possible to generate another unique datablock copy of a clip via the fake user. A more direct way to do it would be nice though, not only in clip but everywhere in Blender. Node Group has a similar problem, where there is no not clunky way to create a copy.

It does not crash here. I noticed though that your render engine is set to Eevee. Does it also crash when you set it to Cycles?

Filmic has been part of Blender for a long time ;)

I would say it was changed by accident. The thing is, it works okay if you create a New File and choose VFX. Then the pivot point is correctly set to Median Point. However, if you create a New>General File and go to Masking or Tracking Workspace, the pivot is set to Individual Origins (which is a very confusing setting for users).

Indeed. It does update correctly however when parenting is turned off and mask is animated manually. @Sergey Sharybin (sergey) any ideas?

It's probably because Pivot Point is set to 'Individual Origins'. It had been solved at some point, but somehow got reverted. Should definitely be set back to Median Point as standard Pivot Point before 2.80 release.

Please try with a more recent build. It does not crash here with current master (2019-05-29 12:48, hash: rB2069b3b888db)

Any news on this? I would like to improve the masking keymap. Even though UI is frozen, but currently it is simply not functional.

Not sure if it is known, but I can confirm it. Probably the option for panoramic should just be hidden from the UI in Eevee, since apparently it doesnt do anything yet. Maybe something for @Clément Foucault (fclem)?

Yeah, not a bug, but I totally agree.

@Bartosz Moniewski (monio) the area that creates links is much bigger for me. are you on a Retina display or something like that?

It's now in the App Menu (Click on the Blender logo in the upper left corner)

Found an interesting twist to this bug.
I have created a collection instance of the collection 'supergroup' in the first Scene, called 'supergroup_instance'.
If you open this file

In D4863#111248, @Brecht Van Lommel (brecht) wrote:

If a Save button is there, I expect most users will press it every time to ensure they don't lose changes, even if that's not actually needed. And that then defeats the purpose of autosaving.

But the auto-saving was added mainly to automatically save the QuickFavorites, wasnt it? So even if there is a save button, auto saving still has a good reason to be there.

I tested the file, it works okay when you add the camera solver constraint. No bug here.