Page MenuHome

Sebastián Barschkis (sebbas)
Physics Developer, Blender Foundation

Projects (11)

User Details

User Since
Jan 18 2016, 12:14 PM (282 w, 11 h)

Recent Activity

Yesterday

Sebastián Barschkis (sebbas) added a comment to D11400: Mantaflow bake optimization.

That's a nice improvement! I even think that this kind of loop optimization will be useful in other parts of the manta code too.
We should place it in a more generic container so that it can be used everywhere (e.g. plugin/secondaryparticles.cpp has similar for-loops with radius offsets).

Mon, Jun 14, 1:56 PM · Nodes & Physics

Thu, May 27

Sebastián Barschkis (sebbas) committed rBL62631: macOS: Updated ffmpeg to version 4.4.
macOS: Updated ffmpeg to version 4.4
Thu, May 27, 12:26 AM

Tue, May 25

Sebastián Barschkis (sebbas) accepted D11392: Bump FFmpeg version from 4.2.3 to 4.4.
Tue, May 25, 6:59 PM
Sebastián Barschkis (sebbas) accepted D11389: Fix T88531: Mantaflow problem with geometry nodes.

+1, geonodes should always be considered non-static

Tue, May 25, 4:40 PM · Nodes & Physics
Sebastián Barschkis (sebbas) accepted D11388: Fix T88566: Mantaflow inflow with shapekeys is not working anymore (regression).

+1

Tue, May 25, 4:34 PM · Nodes & Physics

Tue, May 18

Sebastián Barschkis (sebbas) committed rB748b5f025d74: Merge branch 'blender-v2.93-release' (authored by Sebastián Barschkis (sebbas)).
Merge branch 'blender-v2.93-release'
Tue, May 18, 10:38 PM
Sebastián Barschkis (sebbas) committed rB8dd43ac23ebe: Fluid: Updated Mantaflow source files (authored by Sebastián Barschkis (sebbas)).
Fluid: Updated Mantaflow source files
Tue, May 18, 10:37 PM
Sebastián Barschkis (sebbas) awarded rBb1584775515b: Fix ocean modifier giving different result on Arm than x86 a Like token.
Tue, May 18, 3:48 PM
Sebastián Barschkis (sebbas) committed rBeaf3160f13ef: Merge branch 'blender-v2.93-release' (authored by Sebastián Barschkis (sebbas)).
Merge branch 'blender-v2.93-release'
Tue, May 18, 12:53 PM
Sebastián Barschkis (sebbas) committed rB53376ec7fcd5: Tests: Disabled physics ocean test on macOS arm64 (authored by Sebastián Barschkis (sebbas)).
Tests: Disabled physics ocean test on macOS arm64
Tue, May 18, 12:53 PM
Sebastián Barschkis (sebbas) committed rBf4eae747f991: Tests: Remove threshold param from physics ocean mesh test (authored by Sebastián Barschkis (sebbas)).
Tests: Remove threshold param from physics ocean mesh test
Tue, May 18, 12:48 PM
Sebastián Barschkis (sebbas) added a comment to T87231: macOS: Glass shader is black in viewport.

Running macOS with AMD graphics here. I am not seeing the issue, all good for me.

Tue, May 18, 10:41 AM · Platform: macOS, BF Blender

Mon, May 17

Sebastián Barschkis (sebbas) committed rBc17433bb55b4: Tests: Increased threshold param for physics_ocean test (authored by Sebastián Barschkis (sebbas)).
Tests: Increased threshold param for physics_ocean test
Mon, May 17, 11:23 PM
Sebastián Barschkis (sebbas) committed rBc9afea5bbf95: Tests: Added threshold to physics ocean mesh test (authored by Sebastián Barschkis (sebbas)).
Tests: Added threshold to physics ocean mesh test
Mon, May 17, 9:16 PM
Sebastián Barschkis (sebbas) committed rBL62627: Tests: Updated physics_ocean .blend file, might fix test failure on macOS arm.
Tests: Updated physics_ocean .blend file, might fix test failure on macOS arm
Mon, May 17, 5:12 PM

Apr 29 2021

Vit Kovalcik (Blackx) awarded T86053: 2.9x - Crash while baking particle and/or smoke simulations a Like token.
Apr 29 2021, 6:37 PM · Nodes & Physics, BF Blender

Apr 22 2021

Sebastián Barschkis (sebbas) accepted D11012: macOS: Fix unknown -Wsuggest-override warning.
Apr 22 2021, 12:35 PM

Apr 14 2021

Sebastián Barschkis (sebbas) committed rB2cc3a89cf60d: CMake/deps: Remove CPP11 option for OpenImageIO (authored by Sebastián Barschkis (sebbas)).
CMake/deps: Remove CPP11 option for OpenImageIO
Apr 14 2021, 9:34 PM

Apr 12 2021

Sebastián Barschkis (sebbas) committed rBL62615: macOS: Recompiled Python libs on 10.13.
macOS: Recompiled Python libs on 10.13
Apr 12 2021, 8:45 PM

Apr 3 2021

Florian Kamenz (TimBrown) awarded T68981: New hair object type a Love token.
Apr 3 2021, 11:34 AM · Physics, BF Blender
Maged afra (Maged_afra) awarded T68981: New hair object type a Love token.
Apr 3 2021, 1:31 AM · Physics, BF Blender

Mar 29 2021

Baichuan Wu (relubwu) awarded rB8bdf191461a6: Fluid: Added APIC simulation method a 100 token.
Mar 29 2021, 6:12 PM

Mar 26 2021

Sebastián Barschkis (sebbas) accepted D10792: Overrides: API to create an override template..

LGTM

Mar 26 2021, 12:45 PM · BF Blender (3.0), Core

Mar 24 2021

Emilien Colombier (Peine_Perdue) awarded T68981: New hair object type a Love token.
Mar 24 2021, 4:24 PM · Physics, BF Blender

Mar 23 2021

Sebastián Barschkis (sebbas) added a comment to T86053: 2.9x - Crash while baking particle and/or smoke simulations.

@Marc (Polyflogger) It seems this issue comes from OpenVDB and blosc (v1.5.0) directly: A build with the latest blosc (v1.21.0) has no problems whatsoever.

Mar 23 2021, 4:45 PM · Nodes & Physics, BF Blender

Mar 20 2021

Sebastián Barschkis (sebbas) accepted D10777: Fix T86746: Description missing from Quick Liquid.

+1

Mar 20 2021, 1:42 PM · Nodes & Physics

Mar 18 2021

Sebastián Barschkis (sebbas) changed the status of T86053: 2.9x - Crash while baking particle and/or smoke simulations from Needs Triage to Confirmed.

Hi together! It looks like this problem comes from the OpenVDB compression.
Until this is fixed, can you try using a compression method that is not "Blosc" (Cache -> Advanced -> Compression Volumes)?

Mar 18 2021, 3:45 PM · Nodes & Physics, BF Blender
Sebastián Barschkis (sebbas) removed a reviewer for D10757: Fix T83638: Fix mirror motion blur: BF Blender.
Mar 18 2021, 12:41 PM
Sebastián Barschkis (sebbas) requested changes to D10727: Add `make source_archive_complete` target.

One thing: macOS arm64 currently uses different versions for LLVM and OpenMP (rB21236af80c8e).
make source_archive_complete will not fetch these when creating the archive on a system != macOS arm64.

Mar 18 2021, 11:23 AM

Mar 17 2021

Sebastián Barschkis (sebbas) accepted D10727: Add `make source_archive_complete` target.

Just ran this too. LGTM, have nothing to add to the discussion.

Mar 17 2021, 5:24 PM
Sebastián Barschkis (sebbas) accepted D10747: LibraryOverrides: Initial Test Case..
Mar 17 2021, 3:29 PM · BF Blender (2.93), Core
Sebastián Barschkis (sebbas) reopened D10718: macOS/Audaspace: Add CoreAudio back-end.

It's unclear to me why this landed without proper testing a day before bcon2. We should have tested this patch with the upcoming macOS arm buildbot and functionality directly on arm devices.

Mar 17 2021, 10:40 AM · Platform: macOS, Audio

Mar 16 2021

Sebastián Barschkis (sebbas) awarded rB3e87d8a4315d: Grease Pencil: Add LineArt modifier a Love token.
Mar 16 2021, 8:35 PM
Sebastián Barschkis (sebbas) committed rB21236af80c8e: Libraries: Fix deps build on macOS arm64 (authored by Sebastián Barschkis (sebbas)).
Libraries: Fix deps build on macOS arm64
Mar 16 2021, 5:09 PM
Sebastián Barschkis (sebbas) committed rB970e246ccc11: CMake/deps: Updated deps build requirements prompt for macOS arm64 (authored by Sebastián Barschkis (sebbas)).
CMake/deps: Updated deps build requirements prompt for macOS arm64
Mar 16 2021, 5:09 PM

Mar 12 2021

Sebastián Barschkis (sebbas) committed rBb01e9ad4f0e3: Fluid: Enable scale options for fluid particles (authored by Sebastián Barschkis (sebbas)).
Fluid: Enable scale options for fluid particles
Mar 12 2021, 5:33 PM
Sebastián Barschkis (sebbas) changed the status of T86530: Crash when enabling Open Shading Language with Cycles on macOS and Apple Silicon M1 from Needs Triage to Confirmed.
Mar 12 2021, 4:38 PM · Render & Cycles, Platform: macOS, BF Blender

Mar 11 2021

Sebastián Barschkis (sebbas) committed rBd518b0fda5c1: Fluid: Updated hidden symbol visibility comment (authored by Sebastián Barschkis (sebbas)).
Fluid: Updated hidden symbol visibility comment
Mar 11 2021, 4:16 PM

Mar 9 2021

Sebastián Barschkis (sebbas) accepted D10649: LibOverride: Add a utils to check if override has been user-edited..

Didn't see any issues either!

Mar 9 2021, 5:36 PM
Sebastián Barschkis (sebbas) accepted D10616: Update to @autorelease and stop checking for null on non-nullable return results..
Mar 9 2021, 10:58 AM · Platform: macOS
Sebastián Barschkis (sebbas) accepted D10652: Build Environment: set MAKE_THREADS as per the CPU.

LGTM

Mar 9 2021, 10:28 AM
Sebastián Barschkis (sebbas) committed rBDTb66c22e1fb97: Credits: Fix duplicate credit users (authored by Sebastián Barschkis (sebbas)).
Credits: Fix duplicate credit users
Mar 9 2021, 10:22 AM

Mar 8 2021

Sebastián Barschkis (sebbas) accepted D10642: Library Overrides: Manual.
Mar 8 2021, 7:48 PM · Pipeline, Assets & I/O
Sebastián Barschkis (sebbas) committed rBe9e53ff3a6a4: Cleanup: Removed duplicate slash in macOS SDK path (authored by Sebastián Barschkis (sebbas)).
Cleanup: Removed duplicate slash in macOS SDK path
Mar 8 2021, 11:56 AM

Mar 5 2021

Sebastián Barschkis (sebbas) committed rBed8416152952: Cleanup: Rename func occurences to _fn (authored by Sebastián Barschkis (sebbas)).
Cleanup: Rename func occurences to _fn
Mar 5 2021, 5:36 PM
Sebastián Barschkis (sebbas) updated the task description for T73586: Code Quality Day Tasks.
Mar 5 2021, 4:21 PM · Development Management, BF Blender
Sebastián Barschkis (sebbas) added a comment to D10598: Fix T86124: Self-hosting external libraries packages.

I think https://svn.blender.org/svnroot/bf-blender/trunk/packages/${TARGET_FILE} is fine, assuming that there will only ever be one version of each package in there. If that assumption turns out to be false, I would suggest something like https://svn.blender.org/svnroot/bf-blender/trunk/packages/${dep}/${TARGET_FILE}

Mar 5 2021, 3:04 PM

Mar 4 2021

Sebastián Barschkis (sebbas) accepted D10606: Opt out of AppKit’s default automatic window tabbing.

Thanks for the explanations and the patch.

Mar 4 2021, 4:48 PM · Platform: macOS

Mar 3 2021

Félix (Miadim) awarded D10498: CMake/deps: Append platform CFLAGS and LDFLAGS to Python build to ensure compatibility with minimum macOS version a Burninate token.
Mar 3 2021, 5:12 PM
Sebastián Barschkis (sebbas) accepted D10597: Ghost/macOS: Fix memory leak..
Mar 3 2021, 4:32 PM · Platform: macOS
Sebastián Barschkis (sebbas) accepted D10603: NSWindow’s initWithContentRect never returns nil; so don’t check for nil after calling it.

LGTM

Mar 3 2021, 4:31 PM · Platform: macOS
Sebastián Barschkis (sebbas) updated the task description for T85365: Libraries Changes for Blender 2.93.
Mar 3 2021, 4:29 PM · Platforms, Builds, Tests & Devices, BF Blender (2.93)
Sebastián Barschkis (sebbas) updated the task description for T85365: Libraries Changes for Blender 2.93.
Mar 3 2021, 3:14 PM · Platforms, Builds, Tests & Devices, BF Blender (2.93)
Sebastián Barschkis (sebbas) added a comment to T83631: Cycles OSL - compiling shaders failing due "\" and "n" symbols combination inside include paths - Needs OSL update.

@Phil Hargett (hargettp) ARM libraries have been updated, so after make update builds should work again!

Mar 3 2021, 3:07 PM · Platforms, Builds, Tests & Devices, BF Blender (2.93)
Sebastián Barschkis (sebbas) committed rBL62595: macOS: Added missing USD *.a files.
macOS: Added missing USD *.a files
Mar 3 2021, 2:57 PM
Sebastián Barschkis (sebbas) committed rBL62594: macOS: Fix missing LLVM *.a files.
macOS: Fix missing LLVM *.a files
Mar 3 2021, 1:06 PM
Sebastián Barschkis (sebbas) committed rBL62593: macOS: Updated Alembic, LLVM, OpenEXR, OpenImageIO, OpenVDB, OSL, USD.
macOS: Updated Alembic, LLVM, OpenEXR, OpenImageIO, OpenVDB, OSL, USD
Mar 3 2021, 12:51 PM
Sebastián Barschkis (sebbas) committed rBL62592: macOS: Upgraded TBB to 2020U2.
macOS: Upgraded TBB to 2020U2
Mar 3 2021, 11:47 AM
Sebastián Barschkis (sebbas) committed rBL62591: macOS: Upgrade Python to 3.9.2.
macOS: Upgrade Python to 3.9.2
Mar 3 2021, 11:39 AM
Sebastián Barschkis (sebbas) updated the task description for T85365: Libraries Changes for Blender 2.93.
Mar 3 2021, 11:03 AM · Platforms, Builds, Tests & Devices, BF Blender (2.93)
Sebastián Barschkis (sebbas) updated the task description for T85365: Libraries Changes for Blender 2.93.
Mar 3 2021, 11:03 AM · Platforms, Builds, Tests & Devices, BF Blender (2.93)
Sebastián Barschkis (sebbas) committed rBL62590: macOS: Updated Python 3.9.2 library files.
macOS: Updated Python 3.9.2 library files
Mar 3 2021, 11:02 AM
Sebastián Barschkis (sebbas) committed rBL62589: macOS: Updated boost to 1.73.
macOS: Updated boost to 1.73
Mar 3 2021, 11:01 AM

Mar 2 2021

Sebastián Barschkis (sebbas) committed rB81c770944c99: CMake/deps: Append platform CFLAGS and LDFLAGS to Python build to ensure… (authored by Sebastián Barschkis (sebbas)).
CMake/deps: Append platform CFLAGS and LDFLAGS to Python build to ensure…
Mar 2 2021, 7:08 PM
Sebastián Barschkis (sebbas) closed D10498: CMake/deps: Append platform CFLAGS and LDFLAGS to Python build to ensure compatibility with minimum macOS version.
Mar 2 2021, 7:08 PM
Sebastián Barschkis (sebbas) updated subscribers of D10360: Animation: Prevent keyframe manipulation in linked data.

Is it possible to have a linked ID that uses a local Action?

Mar 2 2021, 1:55 PM · Animation & Rigging, BF Blender

Mar 1 2021

Sebastián Barschkis (sebbas) added inline comments to D10498: CMake/deps: Append platform CFLAGS and LDFLAGS to Python build to ensure compatibility with minimum macOS version.
Mar 1 2021, 8:10 PM
Sebastián Barschkis (sebbas) updated the diff for D10498: CMake/deps: Append platform CFLAGS and LDFLAGS to Python build to ensure compatibility with minimum macOS version.

To prevent platform flags from being overridden, use them within the Python flags variables.

Mar 1 2021, 8:07 PM
Sebastián Barschkis (sebbas) retitled D10498: CMake/deps: Append platform CFLAGS and LDFLAGS to Python build to ensure compatibility with minimum macOS version from CMake/deps: Use default cmake flags for Python to CMake/deps: Append platform CFLAGS and LDFLAGS to Python build to ensure compatibility with minimum macOS version.
Mar 1 2021, 4:31 PM
Sebastián Barschkis (sebbas) added a reviewer for D10498: CMake/deps: Append platform CFLAGS and LDFLAGS to Python build to ensure compatibility with minimum macOS version: Sybren A. Stüvel (sybren).
Mar 1 2021, 4:16 PM
Sebastián Barschkis (sebbas) added inline comments to D10498: CMake/deps: Append platform CFLAGS and LDFLAGS to Python build to ensure compatibility with minimum macOS version.
Mar 1 2021, 3:46 PM
Sebastián Barschkis (sebbas) committed rB4b3dcd80698a: CMake/deps: Added new macOS arm64 build dependency to instructions (authored by Sebastián Barschkis (sebbas)).
CMake/deps: Added new macOS arm64 build dependency to instructions
Mar 1 2021, 1:08 PM

Feb 26 2021

Sebastián Barschkis (sebbas) committed rBL62585: Removed shader that was not removed in rBL62578..
Removed shader that was not removed in rBL62578.
Feb 26 2021, 11:18 PM
Sebastián Barschkis (sebbas) committed rBe00a87163cfd: CMake/deps: Adjust OSL shader directory (authored by Sebastián Barschkis (sebbas)).
CMake/deps: Adjust OSL shader directory
Feb 26 2021, 9:36 PM
Sebastián Barschkis (sebbas) closed D10552: CMake/deps: Adjust OSL shader directory.
Feb 26 2021, 9:36 PM
Sebastián Barschkis (sebbas) added a comment to D10552: CMake/deps: Adjust OSL shader directory.

Okay, this patch is actually just for me :)

Feb 26 2021, 9:30 PM
Sebastián Barschkis (sebbas) requested review of D10552: CMake/deps: Adjust OSL shader directory.
Feb 26 2021, 9:14 PM
Sebastián Barschkis (sebbas) committed rBfb7751f3e6c3: CMake/deps: Fix LLVM and OSL builds (authored by Sebastián Barschkis (sebbas)).
CMake/deps: Fix LLVM and OSL builds
Feb 26 2021, 5:39 PM
Sebastián Barschkis (sebbas) updated the task description for T85365: Libraries Changes for Blender 2.93.
Feb 26 2021, 12:58 PM · Platforms, Builds, Tests & Devices, BF Blender (2.93)
Sebastián Barschkis (sebbas) committed rBL62584: macOS: Updated Python to 3.9.2.
macOS: Updated Python to 3.9.2
Feb 26 2021, 12:57 PM

Feb 25 2021

Sebastián Barschkis (sebbas) added a comment to T83631: Cycles OSL - compiling shaders failing due "\" and "n" symbols combination inside include paths - Needs OSL update.

I see you're on Apple M1. @Phil Hargett (hargettp) the libs still have to be updated for that, so far the changes only considered x86.

Feb 25 2021, 4:47 PM · Platforms, Builds, Tests & Devices, BF Blender (2.93)
Sebastián Barschkis (sebbas) committed rBL62579: macOS: Rebuilt OpenImageDenoise and OpenSubdiv.
macOS: Rebuilt OpenImageDenoise and OpenSubdiv
Feb 25 2021, 2:09 PM
Sebastián Barschkis (sebbas) updated the task description for T85365: Libraries Changes for Blender 2.93.
Feb 25 2021, 1:27 PM · Platforms, Builds, Tests & Devices, BF Blender (2.93)
Sebastián Barschkis (sebbas) committed rBL62578: - OpenEXR 2.5.5.
- OpenEXR 2.5.5
Feb 25 2021, 1:14 PM
Sebastián Barschkis (sebbas) accepted D10523: CMake/Deps: Python 3.9.2.

Builds fine on macOS. Yes, I'd say if there is a heads-up elsewhere (e.g. bchat) then I wouldn't mind getting in such smaller changes quicker.

Feb 25 2021, 10:29 AM

Feb 24 2021

Sebastián Barschkis (sebbas) committed rB9a1b29e16c21: CMake: Removed temporarily disabled clang block (authored by Sebastián Barschkis (sebbas)).
CMake: Removed temporarily disabled clang block
Feb 24 2021, 8:24 PM
Sebastián Barschkis (sebbas) committed rBL62576: Requirement for OSL update + clang-tidy addition.
Requirement for OSL update + clang-tidy addition
Feb 24 2021, 8:08 PM
Sebastián Barschkis (sebbas) committed rBc778fd981e63: CMake: Temporarily removing find clang block (authored by Sebastián Barschkis (sebbas)).
CMake: Temporarily removing find clang block
Feb 24 2021, 4:13 PM
Sebastián Barschkis (sebbas) accepted D10212: Cmake/deps: Update OSL to 1.11.10.0.

Builds fine on macOS, let's get this in!

Feb 24 2021, 1:32 PM

Feb 23 2021

Sebastián Barschkis (sebbas) updated the diff for D10498: CMake/deps: Append platform CFLAGS and LDFLAGS to Python build to ensure compatibility with minimum macOS version.

Now appending the platform flags to the python flags. @Brecht Van Lommel (brecht) not sure if this is the nicest way to do this. Appending to CFLAGS within the export didn't work for me - maybe some weird formatting issue than I'm overseeing.

Feb 23 2021, 9:25 PM
Sebastián Barschkis (sebbas) awarded rB9fe53bd4a1ac: Build Environment/macOS/Python: link against zlib statically a Love token.
Feb 23 2021, 9:00 AM

Feb 22 2021

Sebastián Barschkis (sebbas) added a comment to D10498: CMake/deps: Append platform CFLAGS and LDFLAGS to Python build to ensure compatibility with minimum macOS version.

Right, it built fine but probably just ignored the CMAKE_ARGS.

Feb 22 2021, 5:40 PM
Sebastián Barschkis (sebbas) requested review of D10498: CMake/deps: Append platform CFLAGS and LDFLAGS to Python build to ensure compatibility with minimum macOS version.
Feb 22 2021, 4:07 PM

Feb 19 2021

Sebastián Barschkis (sebbas) added a comment to D10212: Cmake/deps: Update OSL to 1.11.10.0.

@Sybren A. Stüvel (sybren) On macOS x86 it builds just fine. For macOS arm I can test next week (I am fairly certain there will be a problem with OSL C++11 and LLVM 11).
What about ILMBASE_HOME, OPENEXR_HOME and LLVM_ROOT? Can they be removed? (also @Ray molenkamp (LazyDodo))

Feb 19 2021, 4:06 PM
Sebastián Barschkis (sebbas) changed the status of T84849: Preview in sequencer is green with alpha<1 when not displaying alpha from Needs Triage to Confirmed.

Confirmed on macOS Catalina (AMD GPU) with rB55c1021be449

Feb 19 2021, 12:08 PM · BF Blender (2.93), User Interface, VFX & Video, Platform: macOS, Video Sequencer
Sebastián Barschkis (sebbas) added a comment to D10212: Cmake/deps: Update OSL to 1.11.10.0.

Oh, the upgrade to llvm 11 in that commit will most likely break the OSL build on macOS arm ... @Ray molenkamp (LazyDodo) this is not over yet :)

Feb 19 2021, 11:16 AM

Feb 18 2021

Sebastián Barschkis (sebbas) added a comment to T85648: macOS: addons fail to import due to Python 3.9 libraries linking against libz.dylib.

@Ankit Meel (ankitm) Interesting .. not yet sure if it's is related to the issue but this looks odd to me:

Feb 18 2021, 10:58 PM · BF Blender (2.93), Platforms, Builds, Tests & Devices, Platform: macOS
Sebastián Barschkis (sebbas) updated the diff for D10212: Cmake/deps: Update OSL to 1.11.10.0.
  • CMake/deps: Removed duplicate shared libs variables
Feb 18 2021, 3:54 PM
Sebastián Barschkis (sebbas) added inline comments to D10212: Cmake/deps: Update OSL to 1.11.10.0.
Feb 18 2021, 3:52 PM
Sebastián Barschkis (sebbas) accepted D10212: Cmake/deps: Update OSL to 1.11.10.0.

@Sybren A. Stüvel (sybren) @Ray molenkamp (LazyDodo) Are DOPENEXR_HOME, DILMBASE_HOME and DLLVM_ROOT needed on Windows / Linux?
On macOS they were just unused variables.

Feb 18 2021, 3:49 PM