Page MenuHome

Sergey Sharybin (sergey)
Principal Software Engineer, BlenderAdministrator

Projects (41)

User Details

User Since
Nov 28 2009, 10:22 PM (568 w, 3 d)
Roles
Administrator

Recent Activity

Today

Sergey Sharybin (sergey) added inline comments to D9296: Documentation for tracking/clip/properties/track/camera.html and Brown-Conrady lens distortion model.
Wed, Oct 21, 2:51 PM · BF Blender (2.91)
Sergey Sharybin (sergey) added a reviewer for D9296: Documentation for tracking/clip/properties/track/camera.html and Brown-Conrady lens distortion model: Aaron Carlisle (Blendify).
Wed, Oct 21, 2:26 PM · BF Blender (2.91)
Sergey Sharybin (sergey) removed a project from T81662: Camera projection mapping for brush texture: Libmv.

I think proper approach here would be to ensure there is a solid workflow is laid down. The issue with what is being discussed here is not only comes down to the lack of preview, but also to a rather cumbersome interaction with entities.

Wed, Oct 21, 11:35 AM · Sculpt, Paint & Texture
Sergey Sharybin (sergey) added a reviewer for D9294: Tracking: Allow refining any subset of intrinsics: Julian Eisel (Severin).
Wed, Oct 21, 11:05 AM
Sergey Sharybin (sergey) requested review of D9294: Tracking: Allow refining any subset of intrinsics.
Wed, Oct 21, 11:05 AM
Sergey Sharybin (sergey) added a comment to D8393: Media transform redesign.

Do we have an automated regression tests for sequencer?

Wed, Oct 21, 10:35 AM · VFX & Video, Video Sequencer
Sergey Sharybin (sergey) requested changes to D8393: Media transform redesign.
Wed, Oct 21, 10:32 AM · VFX & Video, Video Sequencer
Sergey Sharybin (sergey) added inline comments to D9292: Sculpt: Preserve Face Sets shape option for Smooth.
Wed, Oct 21, 9:18 AM
Sergey Sharybin (sergey) accepted D9289: Fix T81901: Use the 2.90 scrape brush preset as default.
Wed, Oct 21, 9:15 AM
Sergey Sharybin (sergey) accepted D9281: Clang-tidy: disable new warnings .

I think those warnings are nice to be officially enabled one day, so please add them to the list in T78535.

Wed, Oct 21, 9:14 AM

Yesterday

Sergey Sharybin (sergey) committed rBL62497: Linux: Re-compile GMP as fat library.
Linux: Re-compile GMP as fat library
Tue, Oct 20, 4:45 PM
Sergey Sharybin (sergey) added a comment to T81835: Blender crash with illegal instruction in »Collection/Exact« Boolean Modifier.

Please grab latest Linux build from builder.blender.org and see if it works.

Tue, Oct 20, 4:30 PM · BF Blender
Sergey Sharybin (sergey) committed rB1c08ab45357c: CMake: Compile GMP library as fat library (authored by Sergey Sharybin (sergey)).
CMake: Compile GMP library as fat library
Tue, Oct 20, 4:19 PM
Sergey Sharybin (sergey) closed T81835: Blender crash with illegal instruction in »Collection/Exact« Boolean Modifier as Resolved by committing rB1c08ab45357c: CMake: Compile GMP library as fat library.
Tue, Oct 20, 4:19 PM · BF Blender
Sergey Sharybin (sergey) committed rB360282cf1f83: Libmv: Refactor camera intrinsics parameter block (authored by Sergey Sharybin (sergey)).
Libmv: Refactor camera intrinsics parameter block
Tue, Oct 20, 3:05 PM
Sergey Sharybin (sergey) closed D9192: Libmv: Refactor camera intrinsics parameter block.
Tue, Oct 20, 3:05 PM
Sergey Sharybin (sergey) committed rB549841bbc091: Libmv: Add generic class for packed intrinsics (authored by Sergey Sharybin (sergey)).
Libmv: Add generic class for packed intrinsics
Tue, Oct 20, 3:05 PM
Sergey Sharybin (sergey) committed rB151173fefe49: Libmv: Add array<type, size> to libmv namespace (authored by Sergey Sharybin (sergey)).
Libmv: Add array<type, size> to libmv namespace
Tue, Oct 20, 3:05 PM
Sergey Sharybin (sergey) edited reviewers for D9282: Sculpt: Add pie menu for global automasking options, added: Julian Eisel (Severin); removed: Sergey Sharybin (sergey).
Tue, Oct 20, 3:03 PM
Sergey Sharybin (sergey) accepted D9275: Fix sculpt pen tilt support changing the brush strength.
Tue, Oct 20, 3:03 PM
Sergey Sharybin (sergey) added a member for Infrastructure: Blender Buildbot: James Monteath (jmonteath).
Tue, Oct 20, 2:58 PM
Sergey Sharybin (sergey) added inline comments to D9275: Fix sculpt pen tilt support changing the brush strength.
Tue, Oct 20, 11:36 AM
Sergey Sharybin (sergey) added a comment to D9270: Fix T81854: crash when undoing switch between sculpt and edit mode..

Currently non-fully-formalized rule of thumb is to do ensure_evaluated at the top level, and pass evaluated depsgraph. The function must be clear whether it expects things to be evaluated or not. The reason for this is to avoid re-evaluations o nthe "bottom" levels when, say, operator does modify a lot of objects. So general flow is such:

Tue, Oct 20, 11:29 AM

Mon, Oct 19

Sergey Sharybin (sergey) added a comment to D9270: Fix T81854: crash when undoing switch between sculpt and edit mode..

Tagging and forcing an update for something what is needed 5 levels deeper in the callstack does not sound correct at all.

Mon, Oct 19, 5:14 PM
nazir (aicedor) awarded D9056: Hair: Shape-preserving length brush a Love token.
Mon, Oct 19, 12:50 PM
Sergey Sharybin (sergey) accepted D9264: Fix Recursion when rendering scene strip.
Mon, Oct 19, 12:16 PM
Sergey Sharybin (sergey) accepted D8968: Fix libmv eigen alignment issues when compiling with AVX support.
Mon, Oct 19, 11:34 AM
Sergey Sharybin (sergey) accepted D9262: Fix T81426: Infinite loop building VSE relations.

This part seems fine. Please commit it.

Mon, Oct 19, 11:15 AM
Sergey Sharybin (sergey) requested changes to D9262: Fix T81426: Infinite loop building VSE relations.

First of all, the relations builder should be doing same tag as in nodes builder:

Mon, Oct 19, 10:49 AM
Sergey Sharybin (sergey) accepted D9259: Split BKE_sequencer.h intern/extern definitions.

From quick read seems fine.
In the future it would need to be split further, to separate rendering from cache and things like that. But baby steps!

Mon, Oct 19, 10:43 AM
Sergey Sharybin (sergey) accepted D9215: Fix Boundary brush not working when the whole mesh is inside the brush radius.
Mon, Oct 19, 10:35 AM
Sergey Sharybin (sergey) accepted D9202: Sculpt: Reduce the displacement step in the cloth solver.
Mon, Oct 19, 10:34 AM
Sergey Sharybin (sergey) requested changes to D9226: Sculpt Code Breaks With NaN Vertices.

Please make sure your IDE is configured for the clang-format.

Mon, Oct 19, 10:14 AM
Sergey Sharybin (sergey) accepted D9249: Fix T81776: Sculpt line gestures not working with transformed objects.

Sounds reasonable!

Mon, Oct 19, 10:09 AM
Sergey Sharybin (sergey) accepted D9204: Sculpt: Smooth deform type for Boundary Brush.
Mon, Oct 19, 10:06 AM
Sergey Sharybin (sergey) added a comment to T52046: Filmic not working on rendered frame in EEVEE.

It might be re-introduced issue, might be different codepath.

Mon, Oct 19, 10:05 AM · BF Blender: 2.8
Sergey Sharybin (sergey) accepted D9240: Fix T81250: Crash after undoing with prefetching.
Mon, Oct 19, 10:02 AM
Evan Wilson (EAW) awarded D9211: Compositor: Ensure keying node result is pre-multiplied a Mountain of Wealth token.
Mon, Oct 19, 10:02 AM
Sergey Sharybin (sergey) added a comment to D8968: Fix libmv eigen alignment issues when compiling with AVX support.

It seems the move construct must use noexcept

Mon, Oct 19, 10:01 AM
Sergey Sharybin (sergey) added a comment to T68996: OpenSubdiv GPU acceleration.

The "bump" comment witnesses the popularity of this request

Mon, Oct 19, 9:23 AM · EEVEE & Viewport, BF Blender

Fri, Oct 16

Gilberto Rodrigues (gilberto_rodrigues) awarded T74491: Compositor improvement plan a Love token.
Fri, Oct 16, 9:58 PM · VFX & Video, Compositing
Sergey Sharybin (sergey) added a comment to T68996: OpenSubdiv GPU acceleration.

There is no update. Team is overloaded with a lot of other projects. It is still a planned-to-be-worked-on project, but there are no time allocated for it a far as I know. As soon as there is anything, you'll see it reflected in this task.

Fri, Oct 16, 5:52 PM · EEVEE & Viewport, BF Blender
Sergey Sharybin (sergey) requested review of D9238: Multires: Remove legacy compatibility code.
Fri, Oct 16, 5:45 PM
Sergey Sharybin (sergey) added a comment to T81452: Policy for style guide: code comments.

There is a convention, there is a guide which is worded in terms of "preferred". If we don't change the wording/meaning/convention I would like not to see project-wide cleanups (which switches from acceptable to preferred state).

Fri, Oct 16, 1:58 PM · BF Blender
Sergey Sharybin (sergey) added a comment to T81452: Policy for style guide: code comments.

Much excitement is going on here now! There is one point I am forgetting to raise about

Fri, Oct 16, 11:18 AM · BF Blender
Sergey Sharybin (sergey) added a comment to T81452: Policy for style guide: code comments.

In my opinion, we shouldn't even be committing commented-out code.

Fri, Oct 16, 11:15 AM · BF Blender
Sergey Sharybin (sergey) added a comment to T81452: Policy for style guide: code comments.

C-style comments:

  • ✓ Allows to more visually separate English from code
  • ✗ Verbose
  • ✗ Requires trade-off for */ on the same line vs. next line
  • ✗ Unavoidable in C++ code (violating use-for-English-only rule)
Fri, Oct 16, 11:05 AM · BF Blender
Sergey Sharybin (sergey) closed D5113: Fix T63766: Multiresolution behavior when using crease edge.

The patch has been actually committed in rB9f48a04799f. The D number got lost, so the review didn't close automatically.

Fri, Oct 16, 10:28 AM
Sergey Sharybin (sergey) added a comment to D9192: Libmv: Refactor camera intrinsics parameter block.

@Ivan Perevala (ivpe), if there are no obvious flaws I'd like to move on with this change and get it in master :)

Fri, Oct 16, 10:26 AM
Sergey Sharybin (sergey) added a comment to T81452: Policy for style guide: code comments.

There are some points we agree on indeed.

Fri, Oct 16, 10:02 AM · BF Blender

Thu, Oct 15

Sergey Sharybin (sergey) accepted D9173: Fix Multires edge adjacency info returning wrong vertex indices.
Thu, Oct 15, 5:03 PM
Sergey Sharybin (sergey) accepted D9183: Fix brush tip delta orientation with anchored strokes.
Thu, Oct 15, 5:02 PM
Sergey Sharybin (sergey) accepted D9181: Fix T81649: Cloth simulation dynamic area mode tearing the mesh.
Thu, Oct 15, 5:00 PM
Sergey Sharybin (sergey) accepted D9175: Sculpt: Use mpoly flags to sync Face Sets visibility.

Sounds good.

Thu, Oct 15, 4:59 PM
Sergey Sharybin (sergey) added a comment to D9173: Fix Multires edge adjacency info returning wrong vertex indices.

That is a good find!
Code is fine. The commit message can use some simplification in terms of sentence length. My take in the simplification:

Thu, Oct 15, 4:55 PM
Sergey Sharybin (sergey) accepted D9171: Sculpt: Add global automasking settings support in filters.

Seems fine.
Suggestion is to unify automask vs. automasking in variable naming. For the rest seems rather straightforward change. Testing I'll leave up to you :)

Thu, Oct 15, 4:49 PM
Sergey Sharybin (sergey) accepted D9129: Sculpt: Use cursor depth in trimming gestures.

From the code side seems fine. See the inlined comment, that part seems to be related to an independent fix related on correct order of bounding box corners.

Thu, Oct 15, 4:46 PM · Sculpt, Paint & Texture
Sergey Sharybin (sergey) accepted D9105: Fix mask expand creating wrong masks when the cursor is not over the mesh.
Thu, Oct 15, 4:40 PM
Sergey Sharybin (sergey) accepted D8893: Sculpt: Experimental Pen Tilt Support.

Not sure if others want to have a review here.

Thu, Oct 15, 4:29 PM
Sergey Sharybin (sergey) accepted D8852: Fix T80625: Trimming tools not working with transformed objects.
Thu, Oct 15, 4:25 PM
Sergey Sharybin (sergey) requested review of D9223: Cleanup: Simplify check and reset of ID->recalc flags.
Thu, Oct 15, 3:34 PM
Sergey Sharybin (sergey) added a comment to D9220: Cleanup: Remove no-op id recalc statement.

That is a very good question :)
Configure dynamic paint with subframes would be one of the ways to hit the codepath.

Thu, Oct 15, 3:03 PM
Sergey Sharybin (sergey) requested review of D9220: Cleanup: Remove no-op id recalc statement.
Thu, Oct 15, 1:29 PM
Sergey Sharybin (sergey) added a comment to T81340: UBSan: several runtime errors at launch. .

Ok, good!
After spending some time trying to make it less fragile solution, it seems to be most reliable to remove ID_RECALC_ALL. It is only couple of places where it requiers some brain cells, the rest seems to be straightforward. I'll start moving towards that direction.

Thu, Oct 15, 12:27 PM · BF Blender
Sergey Sharybin (sergey) added a comment to D9215: Fix Boundary brush not working when the whole mesh is inside the brush radius.

The code as it is now requires two places where "serialization-before-loop-is-finished" happens. This is intrinsicly proone to errors. Is it possible to handle both max-distance-reached and no-vertices-to-be-processed in the single statement? Something like

Thu, Oct 15, 10:31 AM

Wed, Oct 14

Sergey Sharybin (sergey) added a comment to T81340: UBSan: several runtime errors at launch. .

-8392829 is an weird value. It might be coming from ID_RECALC_ALL and some bits cleared explicitly.
Can you try to replace ID_RECALC_ALL = ~(0) with ID_RECALC_ALL = ((1 << 25) - 1) ?

Wed, Oct 14, 6:36 PM · BF Blender
Sergey Sharybin (sergey) accepted D9213: Fix T68343: Rendered video plays at 600fps.

Seems reasonable. FFmpeg source was always source of truth for such things anyway.

Wed, Oct 14, 6:30 PM
Sergey Sharybin (sergey) changed the status of T80533: VSE: Sequencer & Playhead drawing is broken. from Needs Triage to Needs Information from User.

@Peter Fog (tintwotin), such things are heavily GPU+driver specific. Can't say for everyone, but doesn't happen on my laptop, but its Linux and older GPU.

Wed, Oct 14, 6:23 PM · VFX & Video, Video Sequencer, User Interface, BF Blender
Sergey Sharybin (sergey) added a comment to T80748: Keying node bug.

Added D9211 which sanitizes the keying node alpha behaviour.

Wed, Oct 14, 4:23 PM · VFX & Video, BF Blender
Sergey Sharybin (sergey) updated subscribers of D9211: Compositor: Ensure keying node result is pre-multiplied.
Wed, Oct 14, 4:05 PM
Sergey Sharybin (sergey) requested review of D9211: Compositor: Ensure keying node result is pre-multiplied.
Wed, Oct 14, 4:05 PM
Sergey Sharybin (sergey) added a comment to T81340: UBSan: several runtime errors at launch. .

Is my understanding correct, that the error happens because cast attempts to convert int-value to IDRecalcFlag and the value does not exist in any of the enumerator items?

Wed, Oct 14, 2:51 PM · BF Blender
Sergey Sharybin (sergey) added a comment to T81340: UBSan: several runtime errors at launch. .

Is it signess issue? Will 1u << bitscan_forward_clear_i(...) + makign current_flag unsigned resolve the error?

Wed, Oct 14, 12:06 PM · BF Blender
Sergey Sharybin (sergey) moved T81594: Unable to reassign input for effect strips in the Sequencer from Backlog to Blender 2.91 on the VFX & Video board.
Wed, Oct 14, 11:39 AM · Video Sequencer, VFX & Video, BF Blender
Sergey Sharybin (sergey) accepted D8956: Fix missing Sculpt Overlays updates when using modifiers.
Wed, Oct 14, 10:45 AM
Sergey Sharybin (sergey) requested changes to D9204: Sculpt: Smooth deform type for Boundary Brush.
Wed, Oct 14, 10:44 AM
Sergey Sharybin (sergey) added a comment to D8619: Fix Cloth Brush creating artifacts on planes.

There is still 1 week in bcon2 for new features, and then about 3-4 weeks in bcon3 for bugfix.
Is implementation of bending springs really a 3 months project? What's the status of it?

Wed, Oct 14, 10:37 AM
Sergey Sharybin (sergey) added inline comments to D9192: Libmv: Refactor camera intrinsics parameter block.
Wed, Oct 14, 10:18 AM
Sergey Sharybin (sergey) updated the diff for D9192: Libmv: Refactor camera intrinsics parameter block.

Fix typo in comment.

Wed, Oct 14, 10:11 AM
Sergey Sharybin (sergey) requested changes to D9202: Sculpt: Reduce the displacement step in the cloth solver.
Wed, Oct 14, 10:07 AM
Sergey Sharybin (sergey) accepted D9201: Fix Cloth brush grab artifacts in the affected area.

The code seems fine.
The description of the change can explicitly mention the solution: scale the fade with an empirically found scale factor.

Wed, Oct 14, 10:05 AM
Sergey Sharybin (sergey) accepted D9197: Fix T81594: Unable to reassign effect inputs.
Wed, Oct 14, 9:25 AM

Tue, Oct 13

Ivan Perevala (ivpe) awarded rBc4c8d855c67d: Libmv: Remove array access from camera intrinsics a Like token.
Tue, Oct 13, 9:08 PM
Sergey Sharybin (sergey) accepted D9187: Sculpt: Use plasticity for softbody influence.

From code side seems fine.
From presentation level -- would be more insightful to have side-by-side comparison of old/new behavior.

Tue, Oct 13, 4:40 PM
Vlad Kuzmin (Ssh4) awarded D9192: Libmv: Refactor camera intrinsics parameter block a Like token.
Tue, Oct 13, 3:57 PM
Sergey Sharybin (sergey) retitled D9192: Libmv: Refactor camera intrinsics parameter block from Libmv: Add array<type, size> to libmv namespace to Libmv: Refactor camera intrinsics parameter block.
Tue, Oct 13, 2:23 PM
Jakub Vanko (jvanko) awarded D7484: Tracking: Implement Nuke/Natron distortion model a Love token.
Tue, Oct 13, 1:10 PM
Sergey Sharybin (sergey) accepted D9120: Fix sculpting/painting with viewport clipping and radial symmetry.

This patch seems fine. Isolated and does one thing only.

Tue, Oct 13, 12:56 PM · Sculpt, Paint & Texture
Sergey Sharybin (sergey) updated subscribers of T80748: Keying node bug.

Keying node violates pre-multiplication of the compositing buffer: it sets alpha without multiplying color channels. The original motivation behind this was to be able to chain multiple keying nodes. But now it seems that this decision causes more problems than solutions, so probably need to ensure pre-multiplication of result at where it is expected to be.

Tue, Oct 13, 12:37 PM · VFX & Video, BF Blender
Sergey Sharybin (sergey) requested changes to D9120: Fix sculpting/painting with viewport clipping and radial symmetry.
Tue, Oct 13, 12:34 PM · Sculpt, Paint & Texture
Sergey Sharybin (sergey) moved T81064: UI: TimeCode SMPTE(Full) and channel numbers becomes unreadable with higher values. from Backlog to Known Issues on the VFX & Video board.
Tue, Oct 13, 12:20 PM · VFX & Video, Video Sequencer, User Interface, BF Blender
Sergey Sharybin (sergey) moved T80565: Multiple Frame Rates/ Playback/ VSE scene strips from Backlog to Known Issues on the VFX & Video board.
Tue, Oct 13, 12:20 PM · Video Sequencer, VFX & Video, BF Blender
Sergey Sharybin (sergey) moved T81250: Crashes when undoing VSE from Backlog to Blender 2.91 on the VFX & Video board.
Tue, Oct 13, 12:19 PM · VFX & Video, Video Sequencer, BF Blender
Sergey Sharybin (sergey) added a comment to D9019: Make the operators that change keyframe data update the motion paths.

@Sybren A. Stüvel (sybren), I don't think it is the motion paths themselves to be looked into, but more like a system integration type of a thing. One thing to keep in mind is that calculation of motion path could be very resource-involved (both CPU time and memory).

Tue, Oct 13, 12:19 PM · Animation & Rigging
Sergey Sharybin (sergey) requested review of D9192: Libmv: Refactor camera intrinsics parameter block.
Tue, Oct 13, 12:00 PM

Mon, Oct 12

Sergey Sharybin (sergey) abandoned D9116: Fix lens distortion bug in libmv after rB3a7d62cd1f5e.

Thanks for the time spent in investigation and working on the patch. However, I don't think this is a good way to go. There are few aspects:

Mon, Oct 12, 3:23 PM · BF Blender (2.91), VFX & Video, Motion Tracking, Libmv
Sergey Sharybin (sergey) committed rBc4c8d855c67d: Libmv: Remove array access from camera intrinsics (authored by Sergey Sharybin (sergey)).
Libmv: Remove array access from camera intrinsics
Mon, Oct 12, 3:12 PM
Sergey Sharybin (sergey) committed rBff5e3d68342b: Libmv: Fix wrong packing order of intrinsics for BA step (authored by Sergey Sharybin (sergey)).
Libmv: Fix wrong packing order of intrinsics for BA step
Mon, Oct 12, 3:12 PM
Sergey Sharybin (sergey) added a reverting change for rB7e836bde11ce: Fix critical lens distortion bug in libmv after rB3a7d62cd1f5e.: rB86138d88f6b4: Revert "Fix critical lens distortion bug in libmv after rB3a7d62cd1f5e.".
Mon, Oct 12, 3:12 PM
Sergey Sharybin (sergey) committed rB86138d88f6b4: Revert "Fix critical lens distortion bug in libmv after rB3a7d62cd1f5e." (authored by Sergey Sharybin (sergey)).
Revert "Fix critical lens distortion bug in libmv after rB3a7d62cd1f5e."
Mon, Oct 12, 3:12 PM