Sergey Sharybin (sergey)Administrator
User

Projects (35)

User Details

User Since
Nov 28 2009, 10:22 PM (437 w, 4 d)
Roles
Administrator

Recent Activity

Today

Sergey Sharybin (sergey) added a comment to D3155: Modifiers: Add wrapper functions with Mesh / DerivedMesh conversion.

Not sure why you need to do a list lookup. This is where LIB_TAG_COPY_ON_WRITE_EVAL comes in handy. But the tricky part is: this flags is *NOT* to be used for decision making, it is more a consistency check helper.

Thu, Apr 19, 12:51 PM · BF Blender: 2.8
Sergey Sharybin (sergey) committed rBb352d2705d1f: Depsgraph: Fix crash with copy-on-write enabled (authored by Sergey Sharybin (sergey)).
Depsgraph: Fix crash with copy-on-write enabled
Thu, Apr 19, 12:05 PM
Sergey Sharybin (sergey) committed rB63225d7c8b3a: Port particle instance modifier changes from Gooseberry branch (authored by Sergey Sharybin (sergey)).
Port particle instance modifier changes from Gooseberry branch
Thu, Apr 19, 10:55 AM
Sergey Sharybin (sergey) closed D3157: Port particle instance modifier changes from Gooseberry branch.
Thu, Apr 19, 10:55 AM
Sergey Sharybin (sergey) added a comment to T54708: Segfault .

@John Luke Gibson (eaterjolly), can you compile in debug mode and run blender from gdb to get more meaningful backtrace?

Thu, Apr 19, 10:02 AM · BF Blender

Yesterday

Sergey Sharybin (sergey) committed rBec0756af6c75: Depsgraph: Fix base flag flush for objects from set scene (authored by Sergey Sharybin (sergey)).
Depsgraph: Fix base flag flush for objects from set scene
Wed, Apr 18, 6:06 PM
Sergey Sharybin (sergey) committed rB3701cf785cf5: Depsgraph; Correct assert for depsgraph scene (authored by Sergey Sharybin (sergey)).
Depsgraph; Correct assert for depsgraph scene
Wed, Apr 18, 6:06 PM
Sergey Sharybin (sergey) committed rB3c7254ffb65d: Depsgraph: Fix missing bases array update (authored by Sergey Sharybin (sergey)).
Depsgraph: Fix missing bases array update
Wed, Apr 18, 5:35 PM
Sergey Sharybin (sergey) updated the diff for D3157: Port particle instance modifier changes from Gooseberry branch.

Inverted return value by mistake

Wed, Apr 18, 5:03 PM
Sergey Sharybin (sergey) updated the diff for D3157: Port particle instance modifier changes from Gooseberry branch.

Addressed comments

Wed, Apr 18, 5:02 PM
Sergey Sharybin (sergey) updated subscribers of T54666: Make a design for operators CoW support.

Some quick notes on progress.

Wed, Apr 18, 4:58 PM · Dependency Graph, Code Quest
Sergey Sharybin (sergey) updated the diff for D3158: Make View Selected to be aware of copy-on-write.

Missed one commit in original patch

Wed, Apr 18, 4:51 PM
Sergey Sharybin (sergey) created D3159: Camera manipulator: Make it aware of evaluated version of object.
Wed, Apr 18, 4:50 PM
Sergey Sharybin (sergey) created D3158: Make View Selected to be aware of copy-on-write.
Wed, Apr 18, 4:48 PM
Sergey Sharybin (sergey) committed rB24b3b9fa215b: Fix bad merge conflict resolution (authored by Sergey Sharybin (sergey)).
Fix bad merge conflict resolution
Wed, Apr 18, 4:14 PM
Sergey Sharybin (sergey) updated subscribers of T54708: Segfault .

Building blender as module is not very official feature, and i'm not sure why logging will be attempted to be initialized twice. This is more a question to @Campbell Barton (campbellbarton).

Wed, Apr 18, 3:48 PM · BF Blender
Sergey Sharybin (sergey) committed rB3b209a45de42: Fix missing initialization of depsgraph for snapping context (authored by Sergey Sharybin (sergey)).
Fix missing initialization of depsgraph for snapping context
Wed, Apr 18, 3:42 PM
Sergey Sharybin (sergey) added a comment to D3155: Modifiers: Add wrapper functions with Mesh / DerivedMesh conversion.

@Campbell Barton (campbellbarton) , think it would make sense to wrap arguments of apply* functions into a context type of a structure (similar to ModifierUpdateDepsgraphContext). So then it's no longer an issue to modify arguments of those functions. Surely, some things would need to be still outside of structure (such as input mesh and output mesh/coords), but lots of other things can go there.

Wed, Apr 18, 3:27 PM · BF Blender: 2.8
Sergey Sharybin (sergey) committed rBb3e479757e4b: Cleanup: Indentation (authored by Sergey Sharybin (sergey)).
Cleanup: Indentation
Wed, Apr 18, 2:47 PM
Sergey Sharybin (sergey) committed rBc67a2bd5ba84: Merge branch 'master' into blender2.8 (authored by Sergey Sharybin (sergey)).
Merge branch 'master' into blender2.8
Wed, Apr 18, 1:55 PM
Sergey Sharybin (sergey) committed rBf28aec17e9d6: Depsgraph: Fix missinf relation for particle instance modifier (authored by Sergey Sharybin (sergey)).
Depsgraph: Fix missinf relation for particle instance modifier
Wed, Apr 18, 1:54 PM
Sergey Sharybin (sergey) created D3157: Port particle instance modifier changes from Gooseberry branch.
Wed, Apr 18, 1:37 PM
Sergey Sharybin (sergey) committed rB3811998177a8: Cleanup: Trailing whitespace (authored by Sergey Sharybin (sergey)).
Cleanup: Trailing whitespace
Wed, Apr 18, 12:31 PM
Sergey Sharybin (sergey) committed rBBeb7034f3a050: Tweaks to policy manager (authored by Sergey Sharybin (sergey)).
Tweaks to policy manager
Wed, Apr 18, 12:10 PM
Sergey Sharybin (sergey) committed rB0afe1032695f: Particles: Interpolate size for interpolated children (authored by Sergey Sharybin (sergey)).
Particles: Interpolate size for interpolated children
Wed, Apr 18, 10:57 AM
Sergey Sharybin (sergey) closed T54551: Color Picker in Texture Nodes defaults to first view transform as Archived.

Not only this issue is already reported, system behaves according to its current design.

Wed, Apr 18, 10:27 AM · BF Blender

Tue, Apr 17

Sergey Sharybin (sergey) committed rB821722ac057d: Interface: Show properties values from evaluated datablocks (authored by Sergey Sharybin (sergey)).
Interface: Show properties values from evaluated datablocks
Tue, Apr 17, 5:28 PM
Sergey Sharybin (sergey) updated the diff for D3036: Manipulator: Use evaluated object's matrix to get maipulator position.

Avoid some extra NULL pointer checks

Tue, Apr 17, 1:52 PM
Sergey Sharybin (sergey) committed rBc991bb0baf60: Depsgraph: Allow querying NULL IDs for evaluated version (authored by Sergey Sharybin (sergey)).
Depsgraph: Allow querying NULL IDs for evaluated version
Tue, Apr 17, 1:49 PM
Sergey Sharybin (sergey) committed rB17041bd895ea: Depsgraph: Fix unwanted node tree copy-over (authored by Sergey Sharybin (sergey)).
Depsgraph: Fix unwanted node tree copy-over
Tue, Apr 17, 12:53 PM
Sergey Sharybin (sergey) moved T54666: Make a design for operators CoW support from Short Term Backlog to Doing on the Code Quest board.
Tue, Apr 17, 12:17 PM · Dependency Graph, Code Quest
Sergey Sharybin (sergey) lowered the priority of T54667: Make sure dependency graph does not have known regressions from Confirmed to Normal.
Tue, Apr 17, 12:16 PM · Dependency Graph, Code Quest
Sergey Sharybin (sergey) added a comment to T54667: Make sure dependency graph does not have known regressions.

Went over regression tests and some Spring production files. Think there should be no stoppers from DEG to start porting operators.

Tue, Apr 17, 12:16 PM · Dependency Graph, Code Quest
Sergey Sharybin (sergey) claimed T54689: Lattice objects do not support shapekeys.
Tue, Apr 17, 12:15 PM · BF Blender: 2.8
Sergey Sharybin (sergey) created T54689: Lattice objects do not support shapekeys.
Tue, Apr 17, 12:15 PM · BF Blender: 2.8
Sergey Sharybin (sergey) committed rBL62028: Depsgraph tests: Make it more visible test for shapekey drievrs.
Depsgraph tests: Make it more visible test for shapekey drievrs
Tue, Apr 17, 11:53 AM
Sergey Sharybin (sergey) claimed T54688: Driving bone translate from bone scale is broken in 2.8.
Tue, Apr 17, 11:32 AM · BF Blender: 2.8
Sergey Sharybin (sergey) created T54688: Driving bone translate from bone scale is broken in 2.8.
Tue, Apr 17, 11:32 AM · BF Blender: 2.8
Sergey Sharybin (sergey) committed rBL62027: Depsgraph tests: Use Emission shader to make textures more visible.
Depsgraph tests: Use Emission shader to make textures more visible
Tue, Apr 17, 10:46 AM

Mon, Apr 16

Sergey Sharybin (sergey) triaged T54667: Make sure dependency graph does not have known regressions as Confirmed priority.
Mon, Apr 16, 5:57 PM · Dependency Graph, Code Quest
Sergey Sharybin (sergey) triaged T54666: Make a design for operators CoW support as Normal priority.
Mon, Apr 16, 5:56 PM · Dependency Graph, Code Quest
Sergey Sharybin (sergey) assigned T54665: Notifier from pose bone is not received by viewport to Campbell Barton (campbellbarton).
Mon, Apr 16, 5:48 PM · BF Blender: 2.8
Sergey Sharybin (sergey) created T54665: Notifier from pose bone is not received by viewport.
Mon, Apr 16, 5:47 PM · BF Blender: 2.8
Sergey Sharybin (sergey) committed rBcf95267456a0: Merge branch 'master' into blender2.8 (authored by Sergey Sharybin (sergey)).
Merge branch 'master' into blender2.8
Mon, Apr 16, 4:19 PM
Sergey Sharybin (sergey) committed rB047950db7ccd: Depsgraph: Pull indirect relations via driver targets (authored by Sergey Sharybin (sergey)).
Depsgraph: Pull indirect relations via driver targets
Mon, Apr 16, 4:16 PM
Sergey Sharybin (sergey) accepted D3152: Depsgraph: remove EvaluationContext, pass Depsgraph instead..

From the description of the change -- +1.

Mon, Apr 16, 1:03 PM
Sergey Sharybin (sergey) committed rB6a75a1a669d2: Depsgraph: Tag scene after changing cursor location (authored by Sergey Sharybin (sergey)).
Depsgraph: Tag scene after changing cursor location
Mon, Apr 16, 12:59 PM
Sergey Sharybin (sergey) raised the priority of T54625: Depsgraph: Create list of all operators needing COW fixes from Normal to Needs Triage.
Mon, Apr 16, 10:57 AM · Code Quest
Sergey Sharybin (sergey) committed rB8ad93dd0098d: Merge branch 'master' into blender2.8 (authored by Sergey Sharybin (sergey)).
Merge branch 'master' into blender2.8
Mon, Apr 16, 10:19 AM
Sergey Sharybin (sergey) committed rB5bfe6126f8bd: Added lock-free single linked list implementation (authored by Sergey Sharybin (sergey)).
Added lock-free single linked list implementation
Mon, Apr 16, 10:19 AM
Sergey Sharybin (sergey) committed rB6617818c7a1f: Make ID icons safe for deletion from threads (authored by Sergey Sharybin (sergey)).
Make ID icons safe for deletion from threads
Mon, Apr 16, 10:19 AM
Sergey Sharybin (sergey) closed D3146: Added lock-free single linked list implementation.
Mon, Apr 16, 10:19 AM
Sergey Sharybin (sergey) assigned T54209: 2.8: Changing modes doesn't execute in other windows using different objects. to Campbell Barton (campbellbarton).
Mon, Apr 16, 9:38 AM · BF Blender: 2.8

Fri, Apr 13

Sergey Sharybin (sergey) updated the diff for D3146: Added lock-free single linked list implementation.

Fix wrong deferred icon delete registration

Fri, Apr 13, 3:16 PM
Sergey Sharybin (sergey) updated the diff for D3146: Added lock-free single linked list implementation.

Added strict flags to lockfree link list file

Fri, Apr 13, 3:14 PM
Sergey Sharybin (sergey) updated the diff for D3146: Added lock-free single linked list implementation.

Update with fixes to atomic insert

Fri, Apr 13, 3:12 PM
Sergey Sharybin (sergey) accepted D3148: Python API: remove preview/render resolution settings from API functions..
Fri, Apr 13, 2:36 PM
Sergey Sharybin (sergey) accepted D3147: Depsgraph: don't pass evaluation context to update functions..

As i understood, it's about BKE_scene_graph_update* functions, and NOT about modifier's eval/update functions. If it is so, then it's all correct approach.

Fri, Apr 13, 2:13 PM
Sergey Sharybin (sergey) accepted D3145: Depsgraph: remove engine type from evaluation context..
Fri, Apr 13, 2:11 PM
Sergey Sharybin (sergey) accepted D3143: Python API: remove object.dupli_list_create and dupli_list_clear..
Fri, Apr 13, 2:10 PM
Sergey Sharybin (sergey) accepted D3144: Depsgraph: store mode and time in depsgraph, add view layer / scene accessors..

Think is fine.

Fri, Apr 13, 2:08 PM
Sergey Sharybin (sergey) created D3146: Added lock-free single linked list implementation.
Fri, Apr 13, 2:07 PM

Thu, Apr 12

Sergey Sharybin (sergey) triaged T54579: Significant differences in rendering hairs on different hardware platform as Incomplete priority.

Please provide simple .blend file which demonstrates the issue.

Thu, Apr 12, 4:00 PM · BF Blender
Sergey Sharybin (sergey) assigned T54568: More than 100Mb of memory allocation per click-selection to Campbell Barton (campbellbarton).

Caused by rB651b8fb14eb.

Thu, Apr 12, 3:38 PM · BF Blender
Sergey Sharybin (sergey) added a comment to D1676: Cycles: Implement execution group concept for SVM shaders.

Another report to consider when working on this feature: T54560.

Thu, Apr 12, 3:33 PM
Sergey Sharybin (sergey) closed T54560: Cycles limits textures at 62 inside one material as Archived.

Increasing SVM stack size will marginally increase GPU memory usage.

Thu, Apr 12, 3:33 PM · Cycles
Sergey Sharybin (sergey) committed rB31067c975759: Depsgraph: Move CoW tag to ID datablock tag (authored by Sergey Sharybin (sergey)).
Depsgraph: Move CoW tag to ID datablock tag
Thu, Apr 12, 11:43 AM
Sergey Sharybin (sergey) committed rB15698f99070f: Depsgraph: Avoid relations build time scene datablock expansion (authored by Sergey Sharybin (sergey)).
Depsgraph: Avoid relations build time scene datablock expansion
Thu, Apr 12, 11:43 AM
Sergey Sharybin (sergey) committed rB18c7575f93aa: Depsgraph: Introduce ID recalc flag for COW component (authored by Sergey Sharybin (sergey)).
Depsgraph: Introduce ID recalc flag for COW component
Thu, Apr 12, 11:43 AM
Sergey Sharybin (sergey) committed rBfac1892e1109: Depsgraph: Bind base by it's index (authored by Sergey Sharybin (sergey)).
Depsgraph: Bind base by it's index
Thu, Apr 12, 11:43 AM
Sergey Sharybin (sergey) committed rB9c406b786fae: Depsgraph: Bind view layer by index (authored by Sergey Sharybin (sergey)).
Depsgraph: Bind view layer by index
Thu, Apr 12, 11:43 AM
Sergey Sharybin (sergey) committed rBca2484e09005: Depsgraph: Remove function bindings with collections (authored by Sergey Sharybin (sergey)).
Depsgraph: Remove function bindings with collections
Thu, Apr 12, 11:43 AM
This revision was not accepted when it landed; it landed in state Needs Review.
Thu, Apr 12, 11:43 AM

Tue, Apr 10

Sergey Sharybin (sergey) created D3141: Depsgraph: Remove function bindings with collections.
Tue, Apr 10, 3:15 PM
Sergey Sharybin (sergey) closed T54313: Objects disappear from viewport after F12 render. as Archived.

Can not reproduce the issue with copy-on-write enabled, which makes sense: visibility is flushed to the actual object, which causes conflicts between viewport and render, With copy-on-write enabled, both viewport and render has own data, without visibility flags conflicting.

Tue, Apr 10, 2:17 PM · BF Blender: 2.8
Sergey Sharybin (sergey) committed rB6962119e7f91: Merge branch 'master' into blender2.8 (authored by Sergey Sharybin (sergey)).
Merge branch 'master' into blender2.8
Tue, Apr 10, 12:00 PM
Sergey Sharybin (sergey) committed rB5c3857b3051f: Depsgraph: Build relations for objects linked via pchan constraints (authored by Sergey Sharybin (sergey)).
Depsgraph: Build relations for objects linked via pchan constraints
Tue, Apr 10, 11:57 AM
Sergey Sharybin (sergey) committed rBbd76c8875465: Depsgraph: Flush debug prints (authored by Sergey Sharybin (sergey)).
Depsgraph: Flush debug prints
Tue, Apr 10, 9:56 AM
Sergey Sharybin (sergey) updated subscribers of T54043: Blender crashes when I try baking an image sequence with dynamic paint.

Still can not reproduce, but i'm on Linux as well.

Tue, Apr 10, 9:22 AM · BF Blender

Thu, Apr 5

Sergey Sharybin (sergey) committed rBba821ad2adca: Depsgraph: Avoid build-time armature expanding (authored by Sergey Sharybin (sergey)).
Depsgraph: Avoid build-time armature expanding
Thu, Apr 5, 6:42 PM
Sergey Sharybin (sergey) committed rB025bf11a9ff3: Merge branch 'master' into blender2.8 (authored by Sergey Sharybin (sergey)).
Merge branch 'master' into blender2.8
Thu, Apr 5, 6:26 PM
Sergey Sharybin (sergey) committed rB9b8a92b874d3: Depsgraph: Pull indirect dependencies via pchan constraints (authored by Sergey Sharybin (sergey)).
Depsgraph: Pull indirect dependencies via pchan constraints
Thu, Apr 5, 6:17 PM
Sergey Sharybin (sergey) committed rBL62025: Depsgraph tests: Add test for indirect relations for pchan constraints.
Depsgraph tests: Add test for indirect relations for pchan constraints
Thu, Apr 5, 6:16 PM
Sergey Sharybin (sergey) accepted D3130: Remove workspace object mode (reverting changes in 2.8).

After all the discussion here at the studio, seems to be indeed less of an evil.

Thu, Apr 5, 6:14 PM · BF Blender: 2.8

Wed, Apr 4

Sergey Sharybin (sergey) committed rBdb3c3d133817: Depsgraph: Fix/workaround crash with animation and drivers and CoW (authored by Sergey Sharybin (sergey)).
Depsgraph: Fix/workaround crash with animation and drivers and CoW
Wed, Apr 4, 5:49 PM
Sergey Sharybin (sergey) committed rBb561707bed0e: Gawain: Make removing batches more thread safe (authored by Sergey Sharybin (sergey)).
Gawain: Make removing batches more thread safe
Wed, Apr 4, 5:49 PM
Sergey Sharybin (sergey) committed rB7db4b935e15c: Depsgraph: Cleanup, reduce indentation level (authored by Sergey Sharybin (sergey)).
Depsgraph: Cleanup, reduce indentation level
Wed, Apr 4, 1:02 PM
Sergey Sharybin (sergey) committed rBef22b837e8e2: Merge branch 'master' into blender2.8 (authored by Sergey Sharybin (sergey)).
Merge branch 'master' into blender2.8
Wed, Apr 4, 12:57 PM
Sergey Sharybin (sergey) committed rB0c7ec5896638: Depsgraph: Make sure textures used by modifiers are in the graph (authored by Sergey Sharybin (sergey)).
Depsgraph: Make sure textures used by modifiers are in the graph
Wed, Apr 4, 12:56 PM
Sergey Sharybin (sergey) committed rB39585e1abc13: Fix undefined workspace in UI script (authored by Sergey Sharybin (sergey)).
Fix undefined workspace in UI script
Wed, Apr 4, 12:33 PM
Sergey Sharybin (sergey) committed rB948f4e8c943e: Depsgraph: Get pchan index from correct pose (authored by Sergey Sharybin (sergey)).
Depsgraph: Get pchan index from correct pose
Wed, Apr 4, 11:56 AM
Sergey Sharybin (sergey) committed rBa6999a869ef1: Merge branch 'master' into blender2.8 (authored by Sergey Sharybin (sergey)).
Merge branch 'master' into blender2.8
Wed, Apr 4, 11:49 AM
Sergey Sharybin (sergey) committed rBc1287389269c: Depsgraph: Ensure root pchan is always found (authored by Sergey Sharybin (sergey)).
Depsgraph: Ensure root pchan is always found
Wed, Apr 4, 11:49 AM
Sergey Sharybin (sergey) committed rBc9ad9b260ad0: Depsgraph: Pass CoW version of object to armature update done (authored by Sergey Sharybin (sergey)).
Depsgraph: Pass CoW version of object to armature update done
Wed, Apr 4, 11:47 AM
Sergey Sharybin (sergey) committed rBe217fb439ffa: Merge branch 'master' into blender2.8 (authored by Sergey Sharybin (sergey)).
Merge branch 'master' into blender2.8
Wed, Apr 4, 10:37 AM
Sergey Sharybin (sergey) committed rB909efe6be577: Depsgraph: Assert that pchan index is always valid (authored by Sergey Sharybin (sergey)).
Depsgraph: Assert that pchan index is always valid
Wed, Apr 4, 10:36 AM
Sergey Sharybin (sergey) committed rBd54a058f35d3: Merge branch 'master' into blender2.8 (authored by Sergey Sharybin (sergey)).
Merge branch 'master' into blender2.8
Wed, Apr 4, 10:17 AM
Sergey Sharybin (sergey) committed rBf913e6909353: Depsgraph: Add missing expansion od custom bone shapes (authored by Sergey Sharybin (sergey)).
Depsgraph: Add missing expansion od custom bone shapes
Wed, Apr 4, 10:16 AM
Sergey Sharybin (sergey) committed rBeaf8608ba5e9: Merge branch 'master' into blender2.8 (authored by Sergey Sharybin (sergey)).
Merge branch 'master' into blender2.8
Wed, Apr 4, 9:55 AM
Sergey Sharybin (sergey) committed rB4674e0256263: Depsgraph: Only bind ID-data and indices to depsgraph callbacks (authored by Sergey Sharybin (sergey)).
Depsgraph: Only bind ID-data and indices to depsgraph callbacks
Wed, Apr 4, 9:49 AM