Page MenuHome

Simon Thommes (simonthommes)
User

Projects

User Details

User Since
Nov 29 2018, 10:03 PM (133 w, 6 d)

Recent Activity

Fri, Jun 18

Simon Thommes (simonthommes) requested changes to D11470: Geometry Nodes: New Viewer node..

Behavior seems great to me even with different combination of pinned contexts!

Fri, Jun 18, 2:03 PM · Geometry Nodes

Wed, Jun 16

Simon Thommes (simonthommes) created T89195: Annotations in node editor do not properly scale with interface scale setting.
Wed, Jun 16, 11:59 AM · User Interface, Nodes & Physics, BF Blender

Tue, Jun 15

Simon Thommes (simonthommes) created T89178: Modifier viewport visibility of linked objects exposed.
Tue, Jun 15, 5:46 PM · BF Blender

Thu, Jun 10

Simon Thommes (simonthommes) added a comment to D11547: Geometry Nodes: New Attribute Processor..

Found a couple of crashes and bugs:

  • Adding output with either dragging a connection to the group output or bpy.ops.node.tree_socket_add(in_out='OUT') in the output UIList
  • Outputs don't seem to get properly exposed in the node interface. E.g. create output that has position as the default attribute. It will work as a proper output, but not be shown in the node interface.
Thu, Jun 10, 1:51 PM · Geometry Nodes

Tue, Jun 8

Simon Thommes (simonthommes) added a comment to D10925: Geometry Nodes: Convex Hull Node.

Looks quite good to me! Also nice how this works for point clouds.

Tue, Jun 8, 12:17 PM · Geometry Nodes

Fri, Jun 4

Simon Thommes (simonthommes) created T88834: Eevee RGB Curves node inaccurate compared to Cycles.
Fri, Jun 4, 3:52 PM · EEVEE & Viewport, Nodes & Physics, BF Blender

Wed, Jun 2

Simon Thommes (simonthommes) changed the status of T88747: Improve UX for interaction of modifier stack and node editor from Needs Triage to Confirmed.
Wed, Jun 2, 5:43 PM · Geometry Nodes

Tue, Jun 1

Simon Thommes (simonthommes) accepted D10748: Geometry Nodes: Add a new Delete Geometry node..

Thanks for the change, looks good to me now!

Tue, Jun 1, 6:40 PM · Geometry Nodes

Wed, May 26

Simon Thommes (simonthommes) added a reviewer for D10748: Geometry Nodes: Add a new Delete Geometry node.: Simon Thommes (simonthommes).

Patch looks good to me for 99% of cases! The regular behavior with points, edges and polugons looks good.

Wed, May 26, 7:16 PM · Geometry Nodes
Simon Thommes (simonthommes) moved T88602: Add flag to material sockets to not show input name 'Material' if not necessary from Backlog to Product Backlog on the Geometry Nodes board.
Wed, May 26, 7:13 PM · Geometry Nodes
Simon Thommes (simonthommes) accepted D11376: Geometry Nodes: Support interpolation between curve domains.

This looks good!
There is a crash with the example file, but that is also happening in master, so likely due to the curve resample node:
T88603

Wed, May 26, 6:59 PM · Geometry Nodes
Simon Thommes (simonthommes) created T88602: Add flag to material sockets to not show input name 'Material' if not necessary.
Wed, May 26, 6:35 PM · Geometry Nodes
Simon Thommes (simonthommes) moved T88175: Material Assign Node for material pipeline from Waiting for Feedback/Review to Done on the Geometry Nodes board.
Wed, May 26, 6:31 PM · Geometry Nodes
Simon Thommes (simonthommes) moved T88056: Input Material for the material pipeline from Waiting for Feedback/Review to Done on the Geometry Nodes board.
Wed, May 26, 6:30 PM · Geometry Nodes

May 23 2021

Simon Thommes (simonthommes) created T88499: Copy data path operator does not consider library affiliation.
May 23 2021, 11:34 AM · User Interface, Python API, Core, BF Blender

May 21 2021

Simon Thommes (simonthommes) created T88455: Object-linked material slot not working correctly with generated geometry in geometry nodes.
May 21 2021, 11:01 AM · Geometry Nodes, Nodes & Physics, BF Blender

May 17 2021

Simon Thommes (simonthommes) added a comment to D11251: Geometry Nodes: Support for dynamic attributes on curve splines.

It's working well for me from a user perspective.
Apart from the fact that curves should be drawn after they are made real I couldn't find any issues!

May 17 2021, 4:57 PM · Geometry Nodes

May 14 2021

Simon Thommes (simonthommes) added a comment to D11191: New Geometry Nodes evaluator..

I checked the patch with 2 different production files from Sprite Fright using geometry nodes in multiple different ways. All seems to work well!

May 14 2021, 12:12 PM

May 12 2021

Simon Thommes (simonthommes) created T88234: Crash with Eevee when shader displacement socket connection is muted.
May 12 2021, 6:20 PM · Render & Cycles, EEVEE & Viewport, BF Blender
Simon Thommes (simonthommes) accepted D11222: Geometry Nodes: Use texture socket in Attribute Sample Texture node..

Don't really have a way to test the functionality as we don't have a way to pass around textures with other nodes yet, but looks good!

May 12 2021, 3:36 PM

May 10 2021

Simon Thommes (simonthommes) added a comment to D11155: Geometry Nodes: New Material Assign node..

Apart from the issues outlined, this is looking good to me now from a user perspective!

May 10 2021, 4:35 PM

May 7 2021

Simon Thommes (simonthommes) accepted D11042: Geometry Nodes: Add Attribute Vector Rotate node.

Apart from the related UI issue of type changing that we have to address separately this looks look to go for me now, will be nice to have this in master!

May 7 2021, 7:50 PM · Nodes & Physics, Geometry Nodes

May 6 2021

Simon Thommes (simonthommes) changed the status of T88081: Write and read generated texture coordinate space with the alembic exporter and modifier from Needs Triage to Confirmed.
May 6 2021, 4:36 PM · Alembic, BF Blender
Vyacheslav (hitrpr) awarded T87489: Text Data-Blocks get deleted on Recursive Purge a Like token.
May 6 2021, 11:51 AM · BF Blender

May 5 2021

Simon Thommes (simonthommes) added a comment to T88058: Editing a value with hover+return does not accept 0 as input.

@Falk David (filedescriptor) great, thanks! Very niche issue, but it's driving me a bit insane :D

May 5 2021, 5:57 PM · User Interface, BF Blender
Simon Thommes (simonthommes) created T88058: Editing a value with hover+return does not accept 0 as input.
May 5 2021, 3:32 PM · User Interface, BF Blender

May 4 2021

Simon Thommes (simonthommes) created T88029: Alembic export of shrinkwrap modifier evaluation has mesh artifacts.
May 4 2021, 6:18 PM · Alembic, BF Blender
Simon Thommes (simonthommes) added a comment to D11155: Geometry Nodes: New Material Assign node..

Works great for the propagation of materials for instances that are made real!

May 4 2021, 3:30 PM

May 3 2021

Simon Thommes (simonthommes) moved T86843: Attribute Transfer Node from Done to Product Backlog on the Geometry Nodes board.
May 3 2021, 2:26 PM · Geometry Nodes
Simon Thommes (simonthommes) updated the task description for T88006: Switch node polishing.
May 3 2021, 2:24 PM · Geometry Nodes
Simon Thommes (simonthommes) added a comment to T87919: State of hidden geometry not synced between edit mode and vertex paint/weight paint mode.

@Philipp Oeser (lichtwerk) Thanks for looking into it! For now I worked around the issue by fully recreating the object using geometry nodes to transfer the geometry data.

May 3 2021, 12:32 PM · Sculpt, Paint & Texture, Modeling, BF Blender

Apr 29 2021

Simon Thommes (simonthommes) created T87919: State of hidden geometry not synced between edit mode and vertex paint/weight paint mode.
Apr 29 2021, 9:08 PM · Sculpt, Paint & Texture, Modeling, BF Blender
Simon Thommes (simonthommes) created T87912: Dragging objects/collections into geometry nodes references the wrong datablock for duplicate names.
Apr 29 2021, 1:10 PM · Nodes & Physics, Geometry Nodes, BF Blender

Apr 26 2021

Simon Thommes (simonthommes) changed the status of T87842: Outliner in `Blender File` mode has large performance impact from Needs Triage to Confirmed.
Apr 26 2021, 6:21 PM · BF Blender
Simon Thommes (simonthommes) created T87842: Outliner in `Blender File` mode has large performance impact.
Apr 26 2021, 6:21 PM · BF Blender

Apr 22 2021

Simon Thommes (simonthommes) added a comment to D11037: Geometry Nodes: Initial Attribute Transfer node..

Working great in general!

Apr 22 2021, 12:31 PM
Simon Thommes (simonthommes) requested changes to D11042: Geometry Nodes: Add Attribute Vector Rotate node.

Thanks for adding this!

Apr 22 2021, 11:57 AM · Nodes & Physics, Geometry Nodes

Apr 19 2021

Simon Thommes (simonthommes) added a comment to D10959: Spreadsheet Editor: Row filters.

I don't know if it's been mentioned already, but all the animation editors (except timeline) have a selected only option. In those cases it's in the header, and it's an icon


Maybe this could use the same?

Apr 19 2021, 3:50 PM · Nodes & Physics, Geometry Nodes

Apr 16 2021

Simon Thommes (simonthommes) added a comment to D10959: Spreadsheet Editor: Row filters.

I'm honestly not a big fan of combining the Selected Only option with the filters under one toggle.
To me the selection works on a separate level as it's strongly and globally connected to the viewport and should be a separate toggle from the filters that are local per editor.

Apr 16 2021, 8:42 PM · Nodes & Physics, Geometry Nodes

Apr 14 2021

Simon Thommes (simonthommes) updated subscribers of T87489: Text Data-Blocks get deleted on Recursive Purge.
Apr 14 2021, 12:44 PM · BF Blender
Simon Thommes (simonthommes) reassigned T87489: Text Data-Blocks get deleted on Recursive Purge from Zed (ZedMaster) to Sebastian Parborg (zeddb).
Apr 14 2021, 12:44 PM · BF Blender
Simon Thommes (simonthommes) changed the status of T87489: Text Data-Blocks get deleted on Recursive Purge from Needs Triage to Confirmed.
Apr 14 2021, 12:43 PM · BF Blender
Simon Thommes (simonthommes) created T87489: Text Data-Blocks get deleted on Recursive Purge.
Apr 14 2021, 12:42 PM · BF Blender

Apr 13 2021

Simon Thommes (simonthommes) accepted D10931: Spreadsheet: Breadcrumbs and node pinning..

I think after changing the active modifier the context should also update to the state of that new active modifier.

That is doable, but I think I'd rather do it as a bug fix instead, just to keep this patch a little bit simpler.

Apr 13 2021, 5:16 PM
Simon Thommes (simonthommes) moved T87314: Decide on design for switching between geometry contexts in regards to the node inspection from Product Backlog to In Progress on the Geometry Nodes board.
Apr 13 2021, 5:15 PM · Geometry Nodes
Damian (damian) awarded T85374: Add a simple Switch node a Love token.
Apr 13 2021, 1:49 PM · Geometry Nodes
Simon Thommes (simonthommes) added a comment to D10959: Spreadsheet Editor: Row filters.

Very nice!
I think the design of the filters themselves works super well.

Apr 13 2021, 12:43 PM · Nodes & Physics, Geometry Nodes
Simon Thommes (simonthommes) added a comment to D10931: Spreadsheet: Breadcrumbs and node pinning..

I think the general behaviour as it is now is nice!
Small request though:
I think after changing the active modifier the context should also update to the state of that new active modifier.

Apr 13 2021, 12:08 PM
Simon Thommes (simonthommes) accepted D10921: Geometry Nodes: Add Attribute Curve Mapping node.

Okay, thanks for the responses!

Apr 13 2021, 10:51 AM · Geometry Nodes, BF Blender

Apr 12 2021

Simon Thommes (simonthommes) added a comment to D10921: Geometry Nodes: Add Attribute Curve Mapping node.

Thanks for implementing this! Absolutely fantastic node to have :)

Apr 12 2021, 8:20 PM · Geometry Nodes, BF Blender
Simon Thommes (simonthommes) changed the status of T87434: Attribute convert between data types shows in multiple columns in spreadsheet from Needs Triage to Confirmed.
Apr 12 2021, 5:13 PM · Geometry Nodes, BF Blender
Simon Thommes (simonthommes) created T87434: Attribute convert between data types shows in multiple columns in spreadsheet.
Apr 12 2021, 5:13 PM · Geometry Nodes, BF Blender
Simon Thommes (simonthommes) updated the task description for T87421: Attribute Transfer Node initial version.
Apr 12 2021, 4:17 PM · Geometry Nodes

Apr 9 2021

Simon Thommes (simonthommes) changed the status of T87348: Geometry Nodes don't convert vertex colors accurately when data is realized from Needs Triage to Confirmed.
Apr 9 2021, 3:44 PM · Geometry Nodes, BF Blender
Simon Thommes (simonthommes) created T87348: Geometry Nodes don't convert vertex colors accurately when data is realized.
Apr 9 2021, 3:43 PM · Geometry Nodes, BF Blender
Simon Thommes (simonthommes) changed the status of T87335: Geometry nodes material index attribute not working correctly on generated/instanced geometry from Needs Triage to Confirmed.
Apr 9 2021, 12:32 PM · Nodes & Physics, Geometry Nodes, BF Blender
Simon Thommes (simonthommes) created T87335: Geometry nodes material index attribute not working correctly on generated/instanced geometry.
Apr 9 2021, 12:31 PM · Nodes & Physics, Geometry Nodes, BF Blender

Apr 8 2021

Simon Thommes (simonthommes) changed the status of T87314: Decide on design for switching between geometry contexts in regards to the node inspection from Needs Triage to Confirmed.
Apr 8 2021, 6:39 PM · Geometry Nodes
Simon Thommes (simonthommes) changed the status of T87311: Find design for choosing and highlighting the inspected node context from Needs Triage to Confirmed.
Apr 8 2021, 6:15 PM · Geometry Nodes
Simon Thommes (simonthommes) added a comment to D10875: Spreadsheet: Show data of node..
  • It wasn't obvious that I needed to change the spreadsheet evaluation state to get this to work.
    • Link the evaluation state dynamically so if a node is explicitly toggled the spreadsheet automatically reflects this.
  • It is not possible to uncheck a toggled node.
    • Make the toggle work as a true toggle so it can be unchecked. When untoggled, the evaluation state revert backs to Final.
Apr 8 2021, 1:39 PM

Apr 7 2021

Simon Thommes (simonthommes) added a comment to D10875: Spreadsheet: Show data of node..
Apr 7 2021, 6:16 PM
Simon Thommes (simonthommes) updated subscribers of D10875: Spreadsheet: Show data of node..

Thanks for making this change, I much prefer the way this works.
I do think that it has to be more clearly readable which node is being inspected. The icon alone does not grab a lot of attention and it is quite crucial which node is inspected, especially once this is connected to a viewport inspection.
So I would propose adding something more striking that identifies the inspected node in the UI.
An idea that comes to mind would be a thick border of multiple pixels around the node.


Maybe @Pablo Vazquez (pablovazquez) has a good idea for that.

Apr 7 2021, 3:32 PM

Apr 6 2021

Simon Thommes (simonthommes) added a comment to T86499: Create Workspace for Geometry Nodes.

I think when we get the data set sidebar for the spreadsheet we may need some additional horizontal space.
So maybe we use a 50/50 split between Spreadsheet and 3DView?

Apr 6 2021, 10:30 AM · Geometry Nodes

Apr 2 2021

Simon Thommes (simonthommes) added a comment to D10506: Point Distribute Volume.

You've done a great job of bringing the patch this far and I think it would be great if you could bring it all the way into master as well. But, of course, you're not obligated to do that and I can understand that when there are regularly more requests made, that it can just be too much.

Apr 2 2021, 9:41 PM · Geometry Nodes
Simon Thommes (simonthommes) added a comment to D10420: Geometry Nodes: Bounding Box Node.

Okay great, thanks :)

Apr 2 2021, 8:57 PM · Geometry Nodes
Simon Thommes (simonthommes) added a comment to D10459: Geometry Nodes: Add alternative distribution options to the Attribute Randomize node.

Thanks for addressing my feedback!
I'm pretty happy with what we have with this node now!

Apr 2 2021, 8:54 PM · Geometry Nodes, BF Blender
Simon Thommes (simonthommes) added a comment to D10420: Geometry Nodes: Bounding Box Node.

For meshes it looks all good to me now!

Apr 2 2021, 8:13 PM · Geometry Nodes
Simon Thommes (simonthommes) added a comment to D9441: Eyedropper tool for Texture Paint mode.

Thanks for addressing my feedback!

Apr 2 2021, 7:28 PM · User Interface

Apr 1 2021

Simon Thommes (simonthommes) added a comment to D10875: Spreadsheet: Show data of node..

Works great!

Apr 1 2021, 5:16 PM
Simon Thommes (simonthommes) added a comment to D10506: Point Distribute Volume.

One thing I've been doing in mockups is naming the fields "Mesh" or "Volume" or "Curve" instead of "Geometry". We haven't "officially" agreed on that, but I think it's a nice solution to this.

I would still prefer it if we had implicit conversion, honestly. Then the type should not matter. But for when we explicitly have only one possible input component that is being used that sounds like a good idea!

I would actually do this the same way as with the surface distribution node, calling it Density Attribute.

IMO the "Attribute" at the end is a bit too long, and I don't really think it's necessary, it goes without saying that a string field refers to an attribute in geometry nodes.

I agree, but having two inputs both called Density doesn't sound like a good solution to me either. We could call the attribute input Mask. I remember that we decided against that, but I can't see a great option right now.

Hopefully in the future we can find some way to abstract this that makes it less painful.

Agreed :D

Apr 1 2021, 4:36 PM · Geometry Nodes
Simon Thommes (simonthommes) added a comment to D10506: Point Distribute Volume.

Thanks for the response!

Apr 1 2021, 12:07 PM · Geometry Nodes
Simon Thommes (simonthommes) added a comment to T85585: Geometry Nodes: Point Distribute Node - Density Max value.

I think the behavior of being able to control the density with both inputs to a similar capacity without capping it is fine. But I do agree that the Naming should change. I think just using Density is totally fine even though it is more vague. Density Factor is a bit misleading when no attribute is used.

Apr 1 2021, 11:45 AM · Nodes & Physics, Geometry Nodes, BF Blender

Mar 31 2021

Simon Thommes (simonthommes) added a project to T87087: Losing geometry attributes when branching geometry nodes: Geometry Nodes.
Mar 31 2021, 3:55 PM · Geometry Nodes, BF Blender
Simon Thommes (simonthommes) created T87087: Losing geometry attributes when branching geometry nodes.
Mar 31 2021, 3:55 PM · Geometry Nodes, BF Blender
Simon Thommes (simonthommes) requested changes to D10506: Point Distribute Volume.

I forgot to mention one thing:
The default spacing of (0.3,0.3,0.3) seems a bit arbitrary to me. I would just put it at (1.0,1.0,1.0) that is equivalent to the default density of 1 and also means less points by default which is good when dealing with large volumes.

Mar 31 2021, 2:52 PM · Geometry Nodes
Simon Thommes (simonthommes) added a comment to D10506: Point Distribute Volume.

Just chatted about this with Hans, Jacques and Pablo and there was a consensus that we should probably rename the Grid attribute to Density.

Mar 31 2021, 2:46 PM · Geometry Nodes
Simon Thommes (simonthommes) added a comment to D10506: Point Distribute Volume.

Just checked the patch for the first time and it looks great!
I do have some concerns from a usability standpoint, regarding the context of this node.

Mar 31 2021, 2:27 PM · Geometry Nodes
Simon Thommes (simonthommes) added a comment to T86499: Create Workspace for Geometry Nodes.

Should the workspace be named something different then "Geometry Nodes"? Maybe "Procedural Modeling" or something similar? It seems the other categories describe the workflow rather than the system or a the name of a single editor.

Mar 31 2021, 12:27 PM · Geometry Nodes
Simon Thommes (simonthommes) added a comment to T86499: Create Workspace for Geometry Nodes.

Actually... maybe the outliner should be more prominent, as we support linking collections/objects.
So maybe the same proportions as Layout would be good here:

Mar 31 2021, 11:52 AM · Geometry Nodes
Simon Thommes (simonthommes) added a comment to T86499: Create Workspace for Geometry Nodes.

I was thinking of this for the workspace:

Mar 31 2021, 11:50 AM · Geometry Nodes

Mar 30 2021

Simon Thommes (simonthommes) added a comment to D8286: Popover search menu when Drag&Release a NodeLink in node editors.

I haven't been following the full conversation but from what I see the main open question was the placement of the selected node.
Something that I would actually expect instead of the current behavior is that the node is not directly placed but instead grabbed by the cursor just like when adding a node.
That adds an additional click but I think it would come intuitively and might be a nice way of solving the question of placement by putting it directly into the hands of the user.

Mar 30 2021, 2:22 PM · BF Blender, User Interface
Simon Thommes (simonthommes) added a comment to D10459: Geometry Nodes: Add alternative distribution options to the Attribute Randomize node.

@Simon Thommes (simonthommes) this is really good feedback. I agree with pretty much everything you've said.

Great, I'm glad!

Mar 30 2021, 12:31 PM · Geometry Nodes, BF Blender

Mar 29 2021

Simon Thommes (simonthommes) requested changes to D10459: Geometry Nodes: Add alternative distribution options to the Attribute Randomize node.

Okay, I tested the patch and have a bunch of impressions.
First of all: I think it's super useful to have alternative random distributions, especially the symmetrical ones around a center directly inside of this node!

Mar 29 2021, 6:24 PM · Geometry Nodes, BF Blender
Simon Thommes (simonthommes) added a comment to D10459: Geometry Nodes: Add alternative distribution options to the Attribute Randomize node.

@Charlie Jolly (charlie) Is this patch ready to test? If so could you merge it with current master? It didn't build for me when I tried it just now.

Mar 29 2021, 2:09 PM · Geometry Nodes, BF Blender

Mar 26 2021

Simon Thommes (simonthommes) added a comment to D10420: Geometry Nodes: Bounding Box Node.

hm, it make sense to make Boundbox output as a part of 'Object/Collection Info' Node?

Mar 26 2021, 4:52 PM · Geometry Nodes

Mar 25 2021

Simon Thommes (simonthommes) added a comment to T86843: Attribute Transfer Node.

The way this is split up into details totally makes sense to me.
In terms of needed mapping methods I have a couple of thoughts:

  • How many options are necessary is quite difficult to say. Unfortunately, which option works best, can heavily rely on the specific case and topology.
  • At least there should probably also be a 'Projected' option
  • By far the biggest issue is the transfer on the Corner domain, with for example UV seams. Even the current operator/modifier works far from ideal in this case.
    • Having some method that is a bit smarter when handling split corners would be nice in general...
Mar 25 2021, 11:58 AM · Geometry Nodes
Simon Thommes (simonthommes) added a comment to D9441: Eyedropper tool for Texture Paint mode.

Thanks for the response!

Mar 25 2021, 11:49 AM · User Interface

Mar 23 2021

Simon Thommes (simonthommes) added a comment to D9441: Eyedropper tool for Texture Paint mode.

Just tested the patch and I think it's a good idea!
A few things though:

  • The operator settings should be exposed as tool settings instead

  • When the sampler is activated in another tool by holding the modifier key it should already indicate that in the cursor display.
  • These same changes should also be added in parallel to the paint mode of the image editor
Mar 23 2021, 3:58 PM · User Interface
Simon Thommes (simonthommes) added a comment to D10459: Geometry Nodes: Add alternative distribution options to the Attribute Randomize node.

@Charlie Jolly (charlie) thanks for looking into it that looks good now! I didn't really have an example file, sorry. Just seemed wrong to me when looking at it.

Mar 23 2021, 2:40 PM · Geometry Nodes, BF Blender

Mar 22 2021

Stig Oskar (Stig) awarded T86196: Find solution to unify color picking methods with options for sample space a Like token.
Mar 22 2021, 10:27 PM · Sculpt, Paint & Texture
Simon Thommes (simonthommes) added a comment to D10459: Geometry Nodes: Add alternative distribution options to the Attribute Randomize node.

Add Triangular distribution

Left to right:
Uniform, Midpoint, Gaussian, Triangular

Mar 22 2021, 12:08 PM · Geometry Nodes, BF Blender

Mar 18 2021

Damian (damian) awarded T83238: Tree moss and leaves sample file a Love token.
Mar 18 2021, 3:38 AM · Geometry Nodes

Mar 17 2021

Simon Thommes (simonthommes) added a comment to T86395: Prototype for tool system for nodes for mushroom scattering.

I made a demo file for this to show some of it's potential with the current status of geometry nodes:

Mar 17 2021, 5:33 PM · Geometry Nodes
Simon Thommes (simonthommes) added a comment to D2807: Nodes: Add support to mute node wires.

Muting logic works perfectly now, from what I've been testing! Nice job!

Mar 17 2021, 11:45 AM · User Interface, Nodes

Mar 16 2021

Simon Thommes (simonthommes) accepted D10526: Geometry Nodes: Add Attribute Clamp Node.

Looks good to me!
At some point when we have an attribute data type more exposed it might make sense to drop the the enum and do it automatic instead but that's besides this patch.

Mar 16 2021, 4:32 PM · Geometry Nodes, BF Blender

Mar 15 2021

Simon Thommes (simonthommes) added a comment to D2807: Nodes: Add support to mute node wires.

Tested again, seems to be working great for the most part! The tagging works great and both up- and downstream muting usually give the expected results.
But there seems to be two issues left that I could find.

  1. That is when muting two wires that lead to the same reroute node upstream. (Same for doing the same in two separate muting steps.) If all outgoing wires are muted/unmuted that should also propagate this state upstream. Otherwise that results in this kind of behaviour:

  1. Unmuting should probably always propagate upstream. Otherwise it can result in something like this:

Mar 15 2021, 6:30 PM · User Interface, Nodes

Mar 12 2021

Simon Thommes (simonthommes) accepted D10460: Geometry Nodes: Switch Node.

Thank you for the adjustments! Looks good to me now from a user standpoint. I'll leave the final sign-off to code review by a developer.

Mar 12 2021, 4:18 PM · Geometry Nodes
Simon Thommes (simonthommes) added a comment to D10701: Spreadsheet: Support showing data from original/unevaluated object..

I mean if this change is going to be redundant soon it doesn't really matter, @Dalai Felinto (dfelinto) has a point.
But once we have the navigation in the side panel, I think it would still make sense to hide the ones that have no data by design, or gray them out. So I think if this will be easier already addressing it in the current version and doesn't create unnecessary work, it could still be done now.

Mar 12 2021, 1:09 PM
Simon Thommes (simonthommes) requested changes to D10460: Geometry Nodes: Switch Node.

I agree that this node should be in Utilities.
Other than that, it should work the opposite way than it does right now. I'm am not sure why this was changed but in the original design it was shown that True should return B, not A.

Mar 12 2021, 1:03 PM · Geometry Nodes
Simon Thommes (simonthommes) placed T86462: Smooth shading issue with Eevee and AO with Bent Normals up for grabs.
Mar 12 2021, 12:44 PM · EEVEE & Viewport, BF Blender