Page MenuHome

Takahiro Shizuki (sntulix)
User

Projects

User Details

User Since
Sep 9 2010, 10:18 PM (610 w, 6 d)

Recent Activity

Mar 29 2022

Takahiro Shizuki (sntulix) added a comment to D14369: Cleanup: Check for IME key events using window messages.

I think this will make refine to avoid sensitive with a pattern of the languages.
Though, by GHOST_ImeWin32::IsImeKeyEventCandidate()'s code got simple, I can't see it what do from the code.

bool GHOST_ImeWin32::IsImeKeyEventCandidate(bool keyDown, GHOST_TKey key)
{
  if (!(IsEnglishMode()) && !(GHOST_kKeyLeftShift <= key && key <= GHOST_kKeyDownPage) && keyDown) {
    return true;
  }
  return false;
}
Mar 29 2022, 10:16 AM

Mar 24 2022

Takahiro Shizuki (sntulix) added a comment to D14369: Cleanup: Check for IME key events using window messages.

Hi, @Yuki Hashimoto (hzuika)
Thank you for your detail writing for my easy understanding.
Excuse me, I appended in your image.

Mar 24 2022, 5:19 AM

Mar 22 2022

Takahiro Shizuki (sntulix) added a comment to D14369: Cleanup: Check for IME key events using window messages.

I need some explain.
Would you explain below, please?

Mar 22 2022, 8:36 AM

Mar 19 2022

Takahiro Shizuki (sntulix) accepted D14354: Fix D14173: Chinese IME Full Width Numbers.
Mar 19 2022, 11:13 AM · Platform: Windows
Takahiro Shizuki (sntulix) added a comment to D14354: Fix D14173: Chinese IME Full Width Numbers.

I did test some case.

Mar 19 2022, 11:12 AM · Platform: Windows

Mar 16 2022

Takahiro Shizuki (sntulix) added a comment to D14354: Fix D14173: Chinese IME Full Width Numbers.

I just looked, it seems that is ok. But I will test some case later.

Mar 16 2022, 3:04 PM · Platform: Windows

Mar 14 2022

Takahiro Shizuki (sntulix) added a comment to T94868: [Windows] With Microsoft IME PinYin, when it input "0" with fullwidth at text edit, it gets "00"..

Are you able to give some more information on what is the expected behavior and use case for this?

I don't expect a something about this. Because I'm not a End User of Chinese Language.
Also this is a just reporting I found.

Mar 14 2022, 4:31 AM · User Interface, BF Blender, Platform: Windows

Feb 1 2022

炎臻 (PrettyFireNOI7) awarded D13771: Fix T94434: Windows IME Pinyin Forward Slash a Love token.
Feb 1 2022, 8:06 AM · Platform: Windows

Jan 29 2022

Takahiro Shizuki (sntulix) added a comment to D13902: Fix T93626: Win IME Chinese Numpad Decimal.

(updated.)

I’m not Chinese IME User, so I can’t review about converting “ 。” to “.”.

No problem. You are always so helpful. What languages do you use?

Jan 29 2022, 4:20 AM · BF Blender (3.2)
Takahiro Shizuki (sntulix) added a comment to D13902: Fix T93626: Win IME Chinese Numpad Decimal.

I’m not Chinese IME User, so I can’t review about converting “ 。” to “.”.

Jan 29 2022, 2:52 AM · BF Blender (3.2)

Jan 22 2022

Takahiro Shizuki (sntulix) added a comment to T93626: Can't input '. ' in Transform input box (when using IME).

The change to IsImeKeyEvent is needed to allow numpad decimal entry. The change to ui_do_but_textedit allows using Chinese full stop as decimal. So this allows both keys to enter "." into a number, while still allowing entry of "。" into text fields.

Jan 22 2022, 9:38 AM · BF Blender

Jan 13 2022

Takahiro Shizuki (sntulix) added a comment to T93626: Can't input '. ' in Transform input box (when using IME).
Jan 13 2022, 12:46 PM · BF Blender
Takahiro Shizuki (sntulix) created T94868: [Windows] With Microsoft IME PinYin, when it input "0" with fullwidth at text edit, it gets "00"..
Jan 13 2022, 10:17 AM · User Interface, BF Blender, Platform: Windows
Takahiro Shizuki (sntulix) added a comment to T92700: IME will cause the shortcut keys not work.

I seem that this is similar with T93421. And it will be fix by D13551.
Could you find it is similar with it?

Jan 13 2022, 10:02 AM · BF Blender
Takahiro Shizuki (sntulix) added a comment to T93626: Can't input '. ' in Transform input box (when using IME).

FYI

ime_cmodes.h
// bit field for conversion mode
#define IME_CMODE_ALPHANUMERIC          0x0000
#define IME_CMODE_NATIVE                0x0001
#define IME_CMODE_CHINESE               IME_CMODE_NATIVE
#define IME_CMODE_HANGUL                IME_CMODE_NATIVE
#define IME_CMODE_JAPANESE              IME_CMODE_NATIVE
#define IME_CMODE_KATAKANA              0x0002  // only effect under IME_CMODE_NATIVE
#define IME_CMODE_LANGUAGE              0x0003
#define IME_CMODE_FULLSHAPE             0x0008
#define IME_CMODE_ROMAN                 0x0010
#define IME_CMODE_CHARCODE              0x0020
#define IME_CMODE_HANJACONVERT          0x0040
#define IME_CMODE_NATIVESYMBOL          0x0080
Jan 13 2022, 8:18 AM · BF Blender
Takahiro Shizuki (sntulix) added a comment to T93626: Can't input '. ' in Transform input box (when using IME).

I found a icon Chinese/English punctuation in Microsoft IME PinYin.

Jan 13 2022, 8:15 AM · BF Blender

Jan 12 2022

Takahiro Shizuki (sntulix) added a comment to T93626: Can't input '. ' in Transform input box (when using IME).

@Takahiro Shizuki (sntulix) - I am seeing proper behavior in number input while in Pinyin if I remove decimal from your list of IsImeKeyEvent, like this:

Jan 12 2022, 8:43 AM · BF Blender
Takahiro Shizuki (sntulix) added a comment to T93626: Can't input '. ' in Transform input box (when using IME).

@Takahiro Shizuki (sntulix), it takes someone with experience in this to review the suggested change (if you're sure it's safe, i think we can skip the review).
I suggest creating a patch through https://developer.blender.org/differential/diff/create/ and contacting one of the developers who worked in the area (Eg. https://developer.blender.org/diffusion/B/history/master/intern/ghost/intern/GHOST_ImeWin32.cpp).

Jan 12 2022, 8:28 AM · BF Blender

Jan 9 2022

Yuro (Yuro) awarded D13771: Fix T94434: Windows IME Pinyin Forward Slash a Love token.
Jan 9 2022, 12:04 AM · Platform: Windows

Jan 8 2022

Takahiro Shizuki (sntulix) added a comment to T93626: Can't input '. ' in Transform input box (when using IME).

I am checking this.

Jan 8 2022, 7:40 AM · BF Blender
Takahiro Shizuki (sntulix) updated the summary of D13771: Fix T94434: Windows IME Pinyin Forward Slash.
Jan 8 2022, 5:47 AM · Platform: Windows
Takahiro Shizuki (sntulix) updated the summary of D13771: Fix T94434: Windows IME Pinyin Forward Slash.
Jan 8 2022, 5:45 AM · Platform: Windows
Takahiro Shizuki (sntulix) added a comment to T94434: A happen appearing a letter "/、" not "、" when input "/" key with Microsoft PinYin. [Windows].

Ah, I can confirm this now, I'm OK because I enable this before:

Jan 8 2022, 5:20 AM · Platform: Windows
Takahiro Shizuki (sntulix) added a comment to T94434: A happen appearing a letter "/、" not "、" when input "/" key with Microsoft PinYin. [Windows].
Jan 8 2022, 5:00 AM · Platform: Windows
Takahiro Shizuki (sntulix) requested review of D13771: Fix T94434: Windows IME Pinyin Forward Slash.
Jan 8 2022, 4:58 AM · Platform: Windows

Dec 28 2021

Takahiro Shizuki (sntulix) added a comment to T94434: A happen appearing a letter "/、" not "、" when input "/" key with Microsoft PinYin. [Windows].

I may be found the point to fix.

Dec 28 2021, 10:51 AM · Platform: Windows
Takahiro Shizuki (sntulix) created T94434: A happen appearing a letter "/、" not "、" when input "/" key with Microsoft PinYin. [Windows].
Dec 28 2021, 9:58 AM · Platform: Windows

Dec 23 2021

Takahiro Shizuki (sntulix) added a comment to T91103: Chinese input error when archiving….

I confirmed reproducing this problem with Blender 2.93.3 and both Microsoft Chinese Pinyin and Microsoft ChangJie and its had been fixed by D11929 (v3.0 alpha).

Dec 23 2021, 10:34 AM · BF Blender

Dec 22 2021

Takahiro Shizuki (sntulix) added a comment to T91103: Chinese input error when archiving….

I see.

Dec 22 2021, 5:35 AM · BF Blender

Dec 21 2021

Takahiro Shizuki (sntulix) added a comment to T91103: Chinese input error when archiving….

I can't reproduce "J輸O入L中Y文J字" with Blender 2.93.3 and Japanese keyboard. But I think it was fixed with D11929.

I think this is confirmed. And close please.

Sorry I am not sure if I understand, do you mean this is resolved already?

Dec 21 2021, 7:14 AM · BF Blender

Dec 16 2021

Takahiro Shizuki (sntulix) added a comment to T91103: Chinese input error when archiving….


Well I just tested in 3.0 alpha, all the things are good,former one is in 2.93.4.

Dec 16 2021, 6:10 AM · BF Blender
Takahiro Shizuki (sntulix) added a comment to T91355: Some hotkeys stop functioning after conforming Chinese/Japanese text input.

I reproduced with Blender 3.0.0 alpha at September 18. And I confirm that it is not happend with T93421's triaging build binary (https://developer.blender.org/T93421#1268780).
So I think it is same with T93421 and will be fixed at D13551.

Dec 16 2021, 5:40 AM · User Interface, BF Blender
Takahiro Shizuki (sntulix) added a comment to T80532: Microsoft Chinese Pinyin Input BUG.

This was fixed at D11929. So close here, please.

Dec 16 2021, 4:26 AM · User Interface, BF Blender
Takahiro Shizuki (sntulix) added a subtask for T89831: When IME is On, passing key inputs excluding caret operation to IME. (Windows): T80532: Microsoft Chinese Pinyin Input BUG.
Dec 16 2021, 4:24 AM · User Interface, Platform: Windows, BF Blender
Takahiro Shizuki (sntulix) added a parent task for T80532: Microsoft Chinese Pinyin Input BUG: T89831: When IME is On, passing key inputs excluding caret operation to IME. (Windows).
Dec 16 2021, 4:24 AM · User Interface, BF Blender

Dec 13 2021

Yuro (Yuro) awarded D13551: Fix Hotkeys malfunction after leaving text field with no input using IME(Chinese/Japanese/Korean) Ref T93421 a Love token.
Dec 13 2021, 1:27 PM · Platform: Windows, BF Blender

Dec 12 2021

Takahiro Shizuki (sntulix) added a comment to T93421: Hotkeys malfunction after leaving text field with no input using IME(Chinese/Japanese/Korean).

Since only numbers will be inputted in numeric text editing.

Dec 12 2021, 10:12 AM · User Interface, BF Blender
Takahiro Shizuki (sntulix) closed T93986: Fix Hotkeys malfunction after leaving text field with no input using IME(Chinese/Japanese/Korean) Ref T93421, a subtask of T92410: Shortcuts sometimes malfunction in 3.0 alpha master, as Archived.
Dec 12 2021, 9:26 AM · User Interface, BF Blender
Takahiro Shizuki (sntulix) closed T93986: Fix Hotkeys malfunction after leaving text field with no input using IME(Chinese/Japanese/Korean) Ref T93421 as Archived.
Dec 12 2021, 9:26 AM · Platform: Windows, BF Blender
Takahiro Shizuki (sntulix) closed T93986: Fix Hotkeys malfunction after leaving text field with no input using IME(Chinese/Japanese/Korean) Ref T93421, a subtask of T93421: Hotkeys malfunction after leaving text field with no input using IME(Chinese/Japanese/Korean), as Archived.
Dec 12 2021, 9:26 AM · User Interface, BF Blender
Takahiro Shizuki (sntulix) added inline comments to D13551: Fix Hotkeys malfunction after leaving text field with no input using IME(Chinese/Japanese/Korean) Ref T93421.
Dec 12 2021, 9:24 AM · Platform: Windows, BF Blender
Takahiro Shizuki (sntulix) updated subscribers of D13551: Fix Hotkeys malfunction after leaving text field with no input using IME(Chinese/Japanese/Korean) Ref T93421.
Dec 12 2021, 9:22 AM · Platform: Windows, BF Blender
Takahiro Shizuki (sntulix) added a reviewer for D13551: Fix Hotkeys malfunction after leaving text field with no input using IME(Chinese/Japanese/Korean) Ref T93421: Richard Antalik (ISS).
Dec 12 2021, 9:19 AM · Platform: Windows, BF Blender
Takahiro Shizuki (sntulix) added a revision to T92410: Shortcuts sometimes malfunction in 3.0 alpha master: D13551: Fix Hotkeys malfunction after leaving text field with no input using IME(Chinese/Japanese/Korean) Ref T93421.
Dec 12 2021, 9:18 AM · User Interface, BF Blender
Takahiro Shizuki (sntulix) added a task to D13551: Fix Hotkeys malfunction after leaving text field with no input using IME(Chinese/Japanese/Korean) Ref T93421: T92410: Shortcuts sometimes malfunction in 3.0 alpha master.
Dec 12 2021, 9:18 AM · Platform: Windows, BF Blender
Takahiro Shizuki (sntulix) requested review of D13551: Fix Hotkeys malfunction after leaving text field with no input using IME(Chinese/Japanese/Korean) Ref T93421.
Dec 12 2021, 9:17 AM · Platform: Windows, BF Blender
Takahiro Shizuki (sntulix) added a revision to T93421: Hotkeys malfunction after leaving text field with no input using IME(Chinese/Japanese/Korean): D13551: Fix Hotkeys malfunction after leaving text field with no input using IME(Chinese/Japanese/Korean) Ref T93421.
Dec 12 2021, 9:17 AM · User Interface, BF Blender
Takahiro Shizuki (sntulix) added a comment to T93986: Fix Hotkeys malfunction after leaving text field with no input using IME(Chinese/Japanese/Korean) Ref T93421.

Sorry, This is the task, not differental. I close here.

Dec 12 2021, 9:15 AM · Platform: Windows, BF Blender
Takahiro Shizuki (sntulix) updated subscribers of T93421: Hotkeys malfunction after leaving text field with no input using IME(Chinese/Japanese/Korean).

Thank you for watching the task about IME.
By the way, I posted D13551 without closing here, can I close here?

Dec 12 2021, 9:12 AM · User Interface, BF Blender
Takahiro Shizuki (sntulix) added a subtask for T92410: Shortcuts sometimes malfunction in 3.0 alpha master: T93986: Fix Hotkeys malfunction after leaving text field with no input using IME(Chinese/Japanese/Korean) Ref T93421.
Dec 12 2021, 9:05 AM · User Interface, BF Blender
Takahiro Shizuki (sntulix) added a subtask for T93421: Hotkeys malfunction after leaving text field with no input using IME(Chinese/Japanese/Korean): T93986: Fix Hotkeys malfunction after leaving text field with no input using IME(Chinese/Japanese/Korean) Ref T93421.
Dec 12 2021, 9:05 AM · User Interface, BF Blender
Takahiro Shizuki (sntulix) added parent tasks for T93986: Fix Hotkeys malfunction after leaving text field with no input using IME(Chinese/Japanese/Korean) Ref T93421: T93421: Hotkeys malfunction after leaving text field with no input using IME(Chinese/Japanese/Korean), T92410: Shortcuts sometimes malfunction in 3.0 alpha master.
Dec 12 2021, 9:05 AM · Platform: Windows, BF Blender
Takahiro Shizuki (sntulix) updated subscribers of T93986: Fix Hotkeys malfunction after leaving text field with no input using IME(Chinese/Japanese/Korean) Ref T93421.
Dec 12 2021, 9:03 AM · Platform: Windows, BF Blender
Takahiro Shizuki (sntulix) created T93986: Fix Hotkeys malfunction after leaving text field with no input using IME(Chinese/Japanese/Korean) Ref T93421.
Dec 12 2021, 8:59 AM · Platform: Windows, BF Blender

Dec 11 2021

Takahiro Shizuki (sntulix) added a comment to T93421: Hotkeys malfunction after leaving text field with no input using IME(Chinese/Japanese/Korean).

@Takahiro Shizuki (sntulix) Hi, I have tested the new build in Chinese, Korean, Japanese.

  • One bug, when using Chinese IME, the input / outputs "/、“ :
    ,which should be ”、“ :
    There is a redundant "/".
Dec 11 2021, 8:48 AM · User Interface, BF Blender

Dec 9 2021

Takahiro Shizuki (sntulix) added a comment to T93421: Hotkeys malfunction after leaving text field with no input using IME(Chinese/Japanese/Korean).

I built a binary that I'm working on.
https://www.futuregadget.com/file/Blender-master-3.1.0-T93421-working_on.zip

Dec 9 2021, 5:37 AM · User Interface, BF Blender

Dec 7 2021

Takahiro Shizuki (sntulix) added a comment to T93626: Can't input '. ' in Transform input box (when using IME).

a reproducing capture by ffmpeg. (ffmpeg.exe -offset_x 1360 -offset_y 0 -video_size 1200x1600 -framerate 30 -f gdigrab -i desktop -vcodec libx264 -pix_fmt yuv420p desktop.mp4)

Dec 7 2021, 7:58 AM · BF Blender
Takahiro Shizuki (sntulix) added a comment to T93626: Can't input '. ' in Transform input box (when using IME).

I reproduce this with Microsoft Chinese IME, maybe.

Dec 7 2021, 7:28 AM · BF Blender
Takahiro Shizuki (sntulix) added a comment to T93626: Can't input '. ' in Transform input box (when using IME).

I don’t know it yet.

Dec 7 2021, 5:48 AM · BF Blender

Dec 3 2021

Takahiro Shizuki (sntulix) added a comment to T93421: Hotkeys malfunction after leaving text field with no input using IME(Chinese/Japanese/Korean).

Hi.
Thank you for your concern. @炎臻 (PrettyFireNOI7)

Dec 3 2021, 3:10 PM · User Interface, BF Blender

Dec 1 2021

Takahiro Shizuki (sntulix) added a comment to T93421: Hotkeys malfunction after leaving text field with no input using IME(Chinese/Japanese/Korean).

Thank you for your work @炎臻 (PrettyFireNOI7)

Dec 1 2021, 11:34 AM · User Interface, BF Blender
Takahiro Shizuki (sntulix) added a comment to T93421: Hotkeys malfunction after leaving text field with no input using IME(Chinese/Japanese/Korean).
ui_textedit_end() {
...
#ifdef WITH_INPUT_IME
  ui_textedit_ime_end(win, but);
#endif
}

I confirmed with Microsoft IME Chinese pinyin that IME end when clicking 3D viewport after no inputting to a text edit box.

Dec 1 2021, 5:23 AM · User Interface, BF Blender
Takahiro Shizuki (sntulix) added a comment to T93421: Hotkeys malfunction after leaving text field with no input using IME(Chinese/Japanese/Korean).

I think if the IME auto-switching is functional, after switching to other programs, IME's mode should be automatically set back to Japanese so it is able to input Japanese and write commentary (I don't know what plate is). Then after switching back to Blender, the mode would be automatically set to English. Also as my testing (Windows,daily 3.0), this is currently what IME auto-switching is doing in Blender but I don't know if this behavior is consistent for other Windows user.

Dec 1 2021, 5:18 AM · User Interface, BF Blender

Nov 30 2021

Takahiro Shizuki (sntulix) added a comment to T93421: Hotkeys malfunction after leaving text field with no input using IME(Chinese/Japanese/Korean).

I found Blender calls a IME End function when exit a text edit box by clicking. But it doesn't call the function when no IME input currently.
It's below:

  • source file: source\blender\editors\interface\interface_handlers.c
ui_textedit_end() {
...
#ifdef WITH_INPUT_IME
  if (win->ime_data) {
    ui_textedit_ime_end(win, but);
  }
#endif
}
Nov 30 2021, 12:51 PM · User Interface, BF Blender

Nov 29 2021

炎臻 (PrettyFireNOI7) awarded D11929: IME Win32: Fix Duplicated Initial Character a Love token.
Nov 29 2021, 2:18 PM
Takahiro Shizuki (sntulix) added a comment to T93421: Hotkeys malfunction after leaving text field with no input using IME(Chinese/Japanese/Korean).

Thank you for confirm on previous task and comming new task.

Nov 29 2021, 11:23 AM · User Interface, BF Blender

Nov 27 2021

Takahiro Shizuki (sntulix) added a comment to T92410: Shortcuts sometimes malfunction in 3.0 alpha master.

I am not sure if I understand what current status is, I saw one comment that this is not resolved, but with no updated steps.

Nov 27 2021, 10:01 AM · User Interface, BF Blender

Nov 26 2021

Takahiro Shizuki (sntulix) added a comment to T92410: Shortcuts sometimes malfunction in 3.0 alpha master.

I do reproduce a similary malfunction everytime with the exact step at this page's description by a few different way.

Exact steps for others to reproduce the error
(Steps may need tweaking with different setup)
Nov 26 2021, 8:58 AM · User Interface, BF Blender

Nov 25 2021

Takahiro Shizuki (sntulix) added a comment to T92410: Shortcuts sometimes malfunction in 3.0 alpha master.

I found another bug that blender crash when the the manupilation repeatly that doing typing in text box and swtching from text box to 3d viewport with keep IME word convertioning list box and back to text box and type again, though I don't know it has releation with this malfunction.

Nov 25 2021, 1:51 PM · User Interface, BF Blender
Takahiro Shizuki (sntulix) added a comment to T92410: Shortcuts sometimes malfunction in 3.0 alpha master.
Nov 25 2021, 7:58 AM · User Interface, BF Blender

Nov 24 2021

Takahiro Shizuki (sntulix) added a comment to T92410: Shortcuts sometimes malfunction in 3.0 alpha master.

I can't reproduce with Microsoft IME installed Japanese, English and Chinese Pinyin but I build a Blender binary from master branch with debug prints about Input event and IME status to system console.
https://www.futuregadget.com/file/Blender-T92410-Debug.zip

Nov 24 2021, 10:55 AM · User Interface, BF Blender

Nov 23 2021

炎臻 (PrettyFireNOI7) awarded D12848: IME: Fix Multi-Window Duplicated First Character a Love token.
Nov 23 2021, 2:26 AM · BF Blender (3.1), Platform: Windows

Nov 21 2021

Takahiro Shizuki (sntulix) added a comment to D12848: IME: Fix Multi-Window Duplicated First Character.

This patch consists of just a single line change: calling UpdateConversionStatus in WM_IME_SETCONTEXT handler. This simple change appears to fix the problem and seems quite harmless, since this is only on the window gaining focus.

Nov 21 2021, 11:16 AM · BF Blender (3.1), Platform: Windows
Takahiro Shizuki (sntulix) added a comment to D12848: IME: Fix Multi-Window Duplicated First Character.

A proposal to rename "UpdateConversionStatus" to "UpdateConversionModes" would need to be a separate patch submission. Although not sure I would support that refactor. The function gets "modes" but it is a wrapper for "ImmGetConversionStatus" so I'd prefer the names to match as that makes it easier to understand for others who are familiar with the IME API.

Nov 21 2021, 10:44 AM · BF Blender (3.1), Platform: Windows
Takahiro Shizuki (sntulix) updated the diff for D12848: IME: Fix Multi-Window Duplicated First Character.

add below in WM_IME_SETCONTEXT event in GHOST_SystemWin32::s_wndProc()

ime->UpdateConversionStatus();
Nov 21 2021, 10:42 AM · BF Blender (3.1), Platform: Windows

Nov 18 2021

Takahiro Shizuki (sntulix) added a comment to D12848: IME: Fix Multi-Window Duplicated First Character.

I finished.
Would you review, please?

Nov 18 2021, 5:25 AM · BF Blender (3.1), Platform: Windows

Nov 12 2021

Takahiro Shizuki (sntulix) added a comment to T92410: Shortcuts sometimes malfunction in 3.0 alpha master.

@Takahiro Shizuki (sntulix) Do you know what's going on? I am tagging you because you were the author of the patch D11929 that I suspect might be related.

Nov 12 2021, 6:16 AM · User Interface, BF Blender

Nov 8 2021

Takahiro Shizuki (sntulix) added a comment to D12848: IME: Fix Multi-Window Duplicated First Character.

I fixed this :)

Nov 8 2021, 12:09 PM · BF Blender (3.1), Platform: Windows

Nov 7 2021

Takahiro Shizuki (sntulix) added a comment to D12848: IME: Fix Multi-Window Duplicated First Character.

@Takahiro Shizuki (sntulix) - I made a patch about this with minimum changes and no duplication codes.

Interesting!

I think this is functionally equivalent but with less changes and it might be easier to follow?

Nov 7 2021, 1:38 PM · BF Blender (3.1), Platform: Windows

Nov 6 2021

Takahiro Shizuki (sntulix) added a comment to D12848: IME: Fix Multi-Window Duplicated First Character.

I made a patch about this with minimum changes and no duplication codes.

Nov 6 2021, 1:18 PM · BF Blender (3.1), Platform: Windows

Nov 1 2021

Takahiro Shizuki (sntulix) added a comment to D12848: IME: Fix Multi-Window Duplicated First Character.

Here’s a quick update that ImmGetContext() return 0 at WA_ACTIVE.
It is happen when switched to main window after a new window closed with IME off.

Nov 1 2021, 1:59 PM · BF Blender (3.1), Platform: Windows
Takahiro Shizuki (sntulix) added a comment to D12848: IME: Fix Multi-Window Duplicated First Character.

added checking WA_CLICKACTIVE when switching between windows by mouse click.

Nov 1 2021, 11:27 AM · BF Blender (3.1), Platform: Windows
Takahiro Shizuki (sntulix) added a comment to D12848: IME: Fix Multi-Window Duplicated First Character.
Nov 1 2021, 11:23 AM · BF Blender (3.1), Platform: Windows

Oct 31 2021

Takahiro Shizuki (sntulix) added a comment to D12848: IME: Fix Multi-Window Duplicated First Character.

I've never liked that else as I'd rather leave things alone when in an unknown state rather than clear them. We already initialize those variables to those values on window creation, so there should be no good reason to set them to that when we are without imm_context. And when I breakpoint that else I only ever see the default values being assigned to those variables, and they already have those values.

Oct 31 2021, 9:57 AM · BF Blender (3.1), Platform: Windows

Oct 30 2021

Takahiro Shizuki (sntulix) added a comment to D12848: IME: Fix Multi-Window Duplicated First Character.

I checked the a bug and fixed.
Watch please.

Oct 30 2021, 11:09 AM · BF Blender (3.1), Platform: Windows

Oct 29 2021

Takahiro Shizuki (sntulix) added a comment to D12848: IME: Fix Multi-Window Duplicated First Character.

I need some feedbacks. but are you on BCon in all time?

Oct 29 2021, 7:22 AM · BF Blender (3.1), Platform: Windows

Oct 14 2021

Takahiro Shizuki (sntulix) added a comment to D12848: IME: Fix Multi-Window Duplicated First Character.
  • add GHOST_ImeWin32::SaveConversionStatus(hwnd).
Oct 14 2021, 2:57 PM · BF Blender (3.1), Platform: Windows
Takahiro Shizuki (sntulix) updated the diff for D12848: IME: Fix Multi-Window Duplicated First Character.
  • add GHOST_ImeWin32::SaveConversionStatus(hwnd).
  • fixed to avoid needless reset IME status with initial value by failing ImmGetContext() after creating new window.
Oct 14 2021, 2:32 PM · BF Blender (3.1), Platform: Windows
Takahiro Shizuki (sntulix) added a comment to D12848: IME: Fix Multi-Window Duplicated First Character.
- Open blender with defaults.
- Enter IME text correctly in Properties.
- Right-click on Properties header, select "Duplicate Area into new window",
- Do not enter text there, just move the new window aside.
- Enter text in main window Properties
Oct 14 2021, 8:39 AM · BF Blender (3.1), Platform: Windows
Takahiro Shizuki (sntulix) added a comment to T92172: Additional work to [D11929] IME Win32: Fix Duplicated Initial Character.

@Richard Antalik (ISS) Thank you.

Oct 14 2021, 4:19 AM · Platform: Windows, BF Blender

Oct 13 2021

Takahiro Shizuki (sntulix) added a comment to D12848: IME: Fix Multi-Window Duplicated First Character.

Thank you for your looking.

Oct 13 2021, 3:21 PM · BF Blender (3.1), Platform: Windows
Takahiro Shizuki (sntulix) retitled D12848: IME: Fix Multi-Window Duplicated First Character from T92172: fix Duplicated Initial Character at dialog (save dialog etc). to fix Duplicated Initial Character at dialog (for save dialog etc)..
Oct 13 2021, 10:24 AM · BF Blender (3.1), Platform: Windows
Takahiro Shizuki (sntulix) added projects to D12848: IME: Fix Multi-Window Duplicated First Character: BF Blender, Platform: Windows.
Oct 13 2021, 10:23 AM · BF Blender (3.1), Platform: Windows
Takahiro Shizuki (sntulix) placed T92172: Additional work to [D11929] IME Win32: Fix Duplicated Initial Character up for grabs.
Oct 13 2021, 10:23 AM · Platform: Windows, BF Blender
Takahiro Shizuki (sntulix) updated the summary of D12848: IME: Fix Multi-Window Duplicated First Character.
Oct 13 2021, 10:22 AM · BF Blender (3.1), Platform: Windows
Takahiro Shizuki (sntulix) added a revision to T92172: Additional work to [D11929] IME Win32: Fix Duplicated Initial Character: D12848: IME: Fix Multi-Window Duplicated First Character.
Oct 13 2021, 10:20 AM · Platform: Windows, BF Blender
Takahiro Shizuki (sntulix) requested review of D12848: IME: Fix Multi-Window Duplicated First Character.
Oct 13 2021, 10:20 AM · BF Blender (3.1), Platform: Windows
Takahiro Shizuki (sntulix) added a project to T92172: Additional work to [D11929] IME Win32: Fix Duplicated Initial Character: Platform: Windows.
Oct 13 2021, 8:07 AM · Platform: Windows, BF Blender
Takahiro Shizuki (sntulix) created T92172: Additional work to [D11929] IME Win32: Fix Duplicated Initial Character.
Oct 13 2021, 8:03 AM · Platform: Windows, BF Blender

Oct 12 2021

Takahiro Shizuki (sntulix) reopened D11929: IME Win32: Fix Duplicated Initial Character.

I found Dialog Window (Save Dialog etc) has this bug yet.
May be, Dialog window's window procedure is separated from main window's. So we have to call setting IME status per window and dialog.

Oct 12 2021, 11:40 AM