Page MenuHome

Andrew Williams (sobakasu)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 23 2018, 1:25 AM (17 w, 5 d)

Recent Activity

Feb 17 2019

Andrew Williams (sobakasu) updated the summary of D4291: Window manager: position windows centrally and restore previous window position and sizes.
Feb 17 2019, 9:08 AM
Andrew Williams (sobakasu) updated the diff for D4339: Window manager: window size/position persistence.
  • Updated diff so that it can be applied to master separately from D4291
  • Added sanity checks on window size when reading/writing window position preferences
Feb 17 2019, 2:09 AM
Andrew Williams (sobakasu) updated the diff for D4291: Window manager: position windows centrally and restore previous window position and sizes.
  • Removed ghost_rect from wmWindow struct
  • Renamed WM_WINDOW_MAIN to WM_WINDOW_DEFAULT
  • Added BLI_rcti_inset to simplify some code in wm_window.c
Feb 17 2019, 1:32 AM

Feb 13 2019

Andrew Williams (sobakasu) added inline comments to D4291: Window manager: position windows centrally and restore previous window position and sizes.
Feb 13 2019, 10:31 AM
Andrew Williams (sobakasu) updated the diff for D4291: Window manager: position windows centrally and restore previous window position and sizes.
  • revert function name change, wm_window_init() -> wm_ghost_init()/_exit()
  • fix ghost constants, add GHOST_ prefix
  • update ghost getDisplayDimensions() argument order (return arguments last)
  • update ghost CMakeLists, Ghost_BoundsTracker only needed for X11 and SDL
Feb 13 2019, 10:28 AM
Andrew Williams (sobakasu) added a comment to D4291: Window manager: position windows centrally and restore previous window position and sizes.

How is this supposed to work on multi-display Linux? I'm doing blender --factory-startup and the window is opened in a way which makes it to stick to the right edge of my left monitor (the window is vertically aligned on center though).

Feb 13 2019, 3:50 AM

Feb 12 2019

Andrew Williams (sobakasu) added a comment to D4291: Window manager: position windows centrally and restore previous window position and sizes.

On Mac we get this already for free - it's built into the system.

Feb 12 2019, 1:02 AM
Andrew Williams (sobakasu) updated the diff for D4291: Window manager: position windows centrally and restore previous window position and sizes.
  • removed the code that saved window position to disk, that is now in D4339
  • fixed a crash with show drivers editor
  • area dupli windows now have type WM_TYPE_CUSTOM which is not saved
Feb 12 2019, 12:13 AM
Andrew Williams (sobakasu) added a parent revision for D4339: Window manager: window size/position persistence: D4291: Window manager: position windows centrally and restore previous window position and sizes.
Feb 12 2019, 12:05 AM
Andrew Williams (sobakasu) added a child revision for D4291: Window manager: position windows centrally and restore previous window position and sizes: D4339: Window manager: window size/position persistence.
Feb 12 2019, 12:05 AM
Andrew Williams (sobakasu) created D4339: Window manager: window size/position persistence.
Feb 12 2019, 12:04 AM

Feb 11 2019

Andrew Williams (sobakasu) added a comment to D4291: Window manager: position windows centrally and restore previous window position and sizes.

How is this supposed to work on multi-display Linux? I'm doing blender --factory-startup and the window is opened in a way which makes it to stick to the right edge of my left monitor (the window is vertically aligned on center though).

Didn't test other platforms yet.

Feb 11 2019, 10:25 AM

Feb 10 2019

Andrew Williams (sobakasu) added a comment to D4323: Add a command line argument to allow starting Blender maximized.

I looked around how some applications on Linux does it and in most cases they save the window state (maximized or not) when the application closes and uses that state on the next startup.
So I would suggest that as with the user pref settings, we move out the window settings outside the startup.blend file and then simply save the state when the program is closed and reuse it when blender is run the next time.

Feb 10 2019, 5:14 AM
Andrew Williams (sobakasu) updated the diff for D4291: Window manager: position windows centrally and restore previous window position and sizes.

fixes for X11 and SDL

Feb 10 2019, 4:43 AM

Feb 9 2019

Andrew Williams (sobakasu) updated the diff for D4291: Window manager: position windows centrally and restore previous window position and sizes.

now working on macOS (tested on mojave)

Feb 9 2019, 12:24 AM

Feb 7 2019

Andrew Williams (sobakasu) updated the diff for D4291: Window manager: position windows centrally and restore previous window position and sizes.

fixed compiler warnings

Feb 7 2019, 12:19 AM

Feb 6 2019

Andrew Williams (sobakasu) added a comment to T59802: Preferences window opening behind main window when in fullscreen mode.

this happens for me too. i've never used fullscreen mode before so I hadn't noticed it before.
I also have a GeForce GTX 1070 on windows 10 pro x64

Feb 6 2019, 10:43 AM · User Interface, Platform: Windows, BF Blender: 2.8, BF Blender
Andrew Williams (sobakasu) added a reviewer for D4291: Window manager: position windows centrally and restore previous window position and sizes: Sergey Sharybin (sergey).
Feb 6 2019, 7:04 AM
Andrew Williams (sobakasu) updated the summary of D4291: Window manager: position windows centrally and restore previous window position and sizes.
Feb 6 2019, 7:01 AM
Andrew Williams (sobakasu) updated the diff for D4291: Window manager: position windows centrally and restore previous window position and sizes.

fixed comment style and put printfs in if(G.debug) {} blocks

Feb 6 2019, 6:56 AM
Andrew Williams (sobakasu) updated the diff for D4291: Window manager: position windows centrally and restore previous window position and sizes.
Feb 6 2019, 6:27 AM

Feb 3 2019

Andrew Williams (sobakasu) updated the diff for D4291: Window manager: position windows centrally and restore previous window position and sizes.
  • now saves window positions to disk on exit and restores on start up
Feb 3 2019, 2:53 PM
Andrew Williams (sobakasu) created D4300: Preferences: allow search on module name.
Feb 3 2019, 12:17 PM
Andrew Williams (sobakasu) updated the diff for D4293: Addons: add_mesh_extra_objects with ModuleLoader.
  • updated to use new ModuleLoader constructor
  • removed more unneeded code
Feb 3 2019, 11:24 AM
Andrew Williams (sobakasu) updated the diff for D4295: Addons: netrender updates for 2.80 (uses ModuleLoader).
  • updated due to changes in ModuleLoader constructor
Feb 3 2019, 11:15 AM
Andrew Williams (sobakasu) updated the diff for D4292: Addons: ModuleLoader utility class.
  • constructor now takes package argument
  • added 'include_main' option to register/unregister, to optionally skip main module (needed for rigify legacy mode)
  • added support for dynamically generated classes (used by rigify)
Feb 3 2019, 11:11 AM
Andrew Williams (sobakasu) added a parent revision for D4299: Addons: rigify with ModuleLoader: D4292: Addons: ModuleLoader utility class.
Feb 3 2019, 11:03 AM
Andrew Williams (sobakasu) added a child revision for D4292: Addons: ModuleLoader utility class: D4299: Addons: rigify with ModuleLoader.
Feb 3 2019, 11:03 AM
Andrew Williams (sobakasu) created D4299: Addons: rigify with ModuleLoader.
Feb 3 2019, 11:03 AM
Andrew Williams (sobakasu) added reviewers for D4295: Addons: netrender updates for 2.80 (uses ModuleLoader): Campbell Barton (campbellbarton), Martin Poirier (theeth).
Feb 3 2019, 12:12 AM
Andrew Williams (sobakasu) updated the diff for D4295: Addons: netrender updates for 2.80 (uses ModuleLoader).

changed class properties to use type annotations

Feb 3 2019, 12:07 AM
Andrew Williams (sobakasu) retitled D4295: Addons: netrender updates for 2.80 (uses ModuleLoader) from Addons: netrender updates for 2.80 to Addons: netrender updates for 2.80 (uses ModuleLoader).
Feb 3 2019, 12:05 AM

Feb 2 2019

Andrew Williams (sobakasu) updated the diff for D4292: Addons: ModuleLoader utility class.
  • simplified constructor to just take module name, so caller doesn't need to import sys.
  • fix to only register classes defined by each module and not imported ones
Feb 2 2019, 2:27 PM
Andrew Williams (sobakasu) updated the diff for D4292: Addons: ModuleLoader utility class.
  • added some documentation
  • added a 'LoadedModule' class
  • added register()/unregister() which registers/unregisters classes and also calls register()/unregister() on submodules
Feb 2 2019, 11:39 AM
Andrew Williams (sobakasu) updated the diff for D4295: Addons: netrender updates for 2.80 (uses ModuleLoader).
  • found a problem in slave.py, slave was deleting the original file when running client, master and slave all on the same computer.
  • fixed commented out RENDER_PT_network_output panel
  • fixed render engine constants
Feb 2 2019, 11:35 AM

Feb 1 2019

Andrew Williams (sobakasu) added a parent revision for D4295: Addons: netrender updates for 2.80 (uses ModuleLoader): D4292: Addons: ModuleLoader utility class.
Feb 1 2019, 2:12 PM
Andrew Williams (sobakasu) added a child revision for D4292: Addons: ModuleLoader utility class: D4295: Addons: netrender updates for 2.80 (uses ModuleLoader).
Feb 1 2019, 2:12 PM
Andrew Williams (sobakasu) created D4295: Addons: netrender updates for 2.80 (uses ModuleLoader).
Feb 1 2019, 2:12 PM
Andrew Williams (sobakasu) updated the diff for D4292: Addons: ModuleLoader utility class.

Updated to iterate registerable classes in the order that they were defined, which is sometimes required when they have dependencies.

Feb 1 2019, 2:04 PM
Andrew Williams (sobakasu) added reviewers for D4292: Addons: ModuleLoader utility class: Brendon Murphy (meta-androcto), Campbell Barton (campbellbarton).
Feb 1 2019, 8:00 AM
Andrew Williams (sobakasu) added reviewers for D4293: Addons: add_mesh_extra_objects with ModuleLoader: Brendon Murphy (meta-androcto), Campbell Barton (campbellbarton).
Feb 1 2019, 8:00 AM
Andrew Williams (sobakasu) retitled D4293: Addons: add_mesh_extra_objects with ModuleLoader from Addons: add_mesh_extra_objects changes using ModuleLoader to Addons: add_mesh_extra_objects with ModuleLoader.
Feb 1 2019, 7:56 AM
Andrew Williams (sobakasu) added a parent revision for D4293: Addons: add_mesh_extra_objects with ModuleLoader: D4292: Addons: ModuleLoader utility class.
Feb 1 2019, 7:55 AM
Andrew Williams (sobakasu) added a child revision for D4292: Addons: ModuleLoader utility class: D4293: Addons: add_mesh_extra_objects with ModuleLoader.
Feb 1 2019, 7:55 AM
Andrew Williams (sobakasu) created D4293: Addons: add_mesh_extra_objects with ModuleLoader.
Feb 1 2019, 7:55 AM
Andrew Williams (sobakasu) updated the diff for D4292: Addons: ModuleLoader utility class.
Feb 1 2019, 7:54 AM
Andrew Williams (sobakasu) updated the diff for D4292: Addons: ModuleLoader utility class.
Feb 1 2019, 7:51 AM
Andrew Williams (sobakasu) created D4292: Addons: ModuleLoader utility class.
Feb 1 2019, 7:50 AM
Andrew Williams (sobakasu) added inline comments to D4291: Window manager: position windows centrally and restore previous window position and sizes.
Feb 1 2019, 3:03 AM
Andrew Williams (sobakasu) added a comment to T61074: Exporting.

so how do i do that

Feb 1 2019, 2:46 AM · BF Blender
Andrew Williams (sobakasu) added a comment to T61074: Exporting.

you'll need to supply a blend file that reproduces the problem and/or include any error messages from the console.

Feb 1 2019, 2:19 AM · BF Blender
Andrew Williams (sobakasu) created D4291: Window manager: position windows centrally and restore previous window position and sizes.
Feb 1 2019, 1:51 AM

Jan 29 2019

Andrew Williams (sobakasu) added a comment to T60963: Hair dynamics: hair dynamics not rendered in animation mode when using a force field.

I tried to simplify the steps to reproduce by adding an instance of the collection in the same file like you suggested. Then blender crashes when I try to render the animation.

Jan 29 2019, 12:16 PM · Datablocks and Libraries, Physics, BF Blender
Andrew Williams (sobakasu) updated the task description for T60945: Force field + hair dynamics not working in (linked) instanced collections.
Jan 29 2019, 12:06 PM · Datablocks and Libraries, Physics, BF Blender
Andrew Williams (sobakasu) updated the task description for T60945: Force field + hair dynamics not working in (linked) instanced collections.
Jan 29 2019, 12:06 PM · Datablocks and Libraries, Physics, BF Blender
Andrew Williams (sobakasu) updated the task description for T60963: Hair dynamics: hair dynamics not rendered in animation mode when using a force field.
Jan 29 2019, 12:03 PM · Datablocks and Libraries, Physics, BF Blender
Andrew Williams (sobakasu) added a comment to T60963: Hair dynamics: hair dynamics not rendered in animation mode when using a force field.

Yes, sorry I should have mentioned I linked in the collection.
I have not tried changing the link options. I have instance collections turned on.

Jan 29 2019, 12:02 PM · Datablocks and Libraries, Physics, BF Blender
Andrew Williams (sobakasu) added inline comments to D4277: Logging: changed printf statements to clog.
Jan 29 2019, 5:13 AM
Andrew Williams (sobakasu) created D4277: Logging: changed printf statements to clog.
Jan 29 2019, 4:59 AM
Andrew Williams (sobakasu) added a comment to T60963: Hair dynamics: hair dynamics not rendered in animation mode when using a force field.

Jan 29 2019, 1:04 AM · Datablocks and Libraries, Physics, BF Blender
Andrew Williams (sobakasu) created T60963: Hair dynamics: hair dynamics not rendered in animation mode when using a force field.
Jan 29 2019, 1:02 AM · Datablocks and Libraries, Physics, BF Blender

Jan 28 2019

Andrew Williams (sobakasu) added a comment to T60946: Point cache: crash on free all bakes.

just retested in latest version, it's fixed

Jan 28 2019, 2:24 PM · BF Blender
Andrew Williams (sobakasu) closed T60946: Point cache: crash on free all bakes as Resolved.
Jan 28 2019, 2:23 PM · BF Blender
Andrew Williams (sobakasu) created T60946: Point cache: crash on free all bakes.
Jan 28 2019, 11:38 AM · BF Blender
Andrew Williams (sobakasu) created T60945: Force field + hair dynamics not working in (linked) instanced collections.
Jan 28 2019, 11:30 AM · Datablocks and Libraries, Physics, BF Blender

Jan 25 2019

Andrew Williams (sobakasu) renamed T60845: Export OBJ: error exporting as obj when file contains collection instances from Export OBJ: error exporting collection instances to Export OBJ: error exporting as obj when file contains collection instances.
Jan 25 2019, 5:17 AM · Import/Export, Addons
Andrew Williams (sobakasu) created T60845: Export OBJ: error exporting as obj when file contains collection instances.
Jan 25 2019, 5:17 AM · Import/Export, Addons

Jan 22 2019

Andrew Williams (sobakasu) added inline comments to D4201: Fix T55974: Crash when using Surface Force Field Type on UV Sphere.
Jan 22 2019, 11:02 PM
Andrew Williams (sobakasu) updated the diff for D4236: blenfont: minor changes to reduce code duplication.

fixed diff

Jan 22 2019, 2:42 AM
Andrew Williams (sobakasu) created D4236: blenfont: minor changes to reduce code duplication.
Jan 22 2019, 2:41 AM

Jan 21 2019

Andrew Williams (sobakasu) added a comment to D4231: Undo: increase speed of transformation undo by over 9000.

agreed optimising the global undo sounds like a better way. at least i learnt how the undo system works. kind of

Jan 21 2019, 7:33 AM
Andrew Williams (sobakasu) added a comment to D4231: Undo: increase speed of transformation undo by over 9000.
  • Even if you detect all that, you still can't reverse the operation exactly due to floating point precision errors.
Jan 21 2019, 4:27 AM
Andrew Williams (sobakasu) updated the diff for D4224: Logging: experimental CLOG_DEBUG code.
  • reverted err_out parameter related changes.
  • removed blen_font refactored code
  • added an exciting new ERROR_OUT macro for gpu_*
Jan 21 2019, 1:34 AM
Andrew Williams (sobakasu) added a reviewer for D4231: Undo: increase speed of transformation undo by over 9000: Campbell Barton (campbellbarton).
Jan 21 2019, 12:12 AM
Andrew Williams (sobakasu) created D4231: Undo: increase speed of transformation undo by over 9000.
Jan 21 2019, 12:08 AM

Jan 20 2019

Andrew Williams (sobakasu) added a comment to T60418: Undo - One step back takes very long.

i started to write some code that could speed up undo by over 9000 times

Jan 20 2019, 1:41 AM · BF Blender

Jan 19 2019

Andrew Williams (sobakasu) added inline comments to D4224: Logging: experimental CLOG_DEBUG code.
Jan 19 2019, 12:14 AM
Andrew Williams (sobakasu) added a comment to D4224: Logging: experimental CLOG_DEBUG code.

ok, thanks for those tips, i'll keep them in mind for next time

Jan 19 2019, 12:03 AM

Jan 18 2019

Andrew Williams (sobakasu) updated the diff for D4224: Logging: experimental CLOG_DEBUG code.

removed parts of diff that weren't supposed to be in this set of changes

Jan 18 2019, 6:01 AM
Andrew Williams (sobakasu) added a reviewer for D4224: Logging: experimental CLOG_DEBUG code: Campbell Barton (campbellbarton).
Jan 18 2019, 5:35 AM
Andrew Williams (sobakasu) added inline comments to D4224: Logging: experimental CLOG_DEBUG code.
Jan 18 2019, 5:33 AM
Andrew Williams (sobakasu) updated the diff for D4224: Logging: experimental CLOG_DEBUG code.

diff fixes

Jan 18 2019, 5:24 AM
Andrew Williams (sobakasu) updated the summary of D4224: Logging: experimental CLOG_DEBUG code.
Jan 18 2019, 5:23 AM
Andrew Williams (sobakasu) created D4224: Logging: experimental CLOG_DEBUG code.
Jan 18 2019, 4:57 AM

Jan 16 2019

Andrew Williams (sobakasu) added a comment to D4214: Add --log-console and --log-show-timestamp options.

thanks for committing the timestamp functionality

Jan 16 2019, 7:01 AM
Andrew Williams (sobakasu) added a reviewer for D4214: Add --log-console and --log-show-timestamp options: Campbell Barton (campbellbarton).
Jan 16 2019, 2:15 AM
Andrew Williams (sobakasu) updated the diff for D4214: Add --log-console and --log-show-timestamp options.

fixed diff

Jan 16 2019, 2:14 AM
Andrew Williams (sobakasu) created D4214: Add --log-console and --log-show-timestamp options.
Jan 16 2019, 2:12 AM
Andrew Williams (sobakasu) retitled D4201: Fix T55974: Crash when using Surface Force Field Type on UV Sphere from Fix for T55974 to Fix T55974: Crash when using Surface Force Field Type on UV Sphere.
Jan 16 2019, 2:03 AM

Jan 15 2019

Andrew Williams (sobakasu) added a comment to T60509: Cycles render CPU + GPU computer crash.

I couldn't reproduce this on my computer using blender 2.80 (2019-01-12) with the attached file

Jan 15 2019, 1:40 AM · BF Blender
Andrew Williams (sobakasu) added a comment to T55974: Crash when using Surface Force Field Type on UV Sphere.

i've made a fix for this here: https://developer.blender.org/D4201

Jan 15 2019, 1:11 AM · BF Blender, Physics
Andrew Williams (sobakasu) added reviewers for D4201: Fix T55974: Crash when using Surface Force Field Type on UV Sphere: Sybren A. Stüvel (sybren), Bastien Montagne (mont29).
Jan 15 2019, 1:09 AM
Andrew Williams (sobakasu) updated the diff for D4201: Fix T55974: Crash when using Surface Force Field Type on UV Sphere.

I think i've found the problem that causes this crash. MOD_surface.c deformVerts, calls BKE_id_free on surmd->mesh. This frees the cached tree used by surmd->bvhtree. surmd->bvhtree is not rebuilt until later, so other threads can access the invalid bvhtree. setting surmd->bvhtree to NULL stops this happening.

Jan 15 2019, 1:07 AM

Jan 13 2019

Andrew Williams (sobakasu) updated the summary of D4201: Fix T55974: Crash when using Surface Force Field Type on UV Sphere.
Jan 13 2019, 10:53 AM
Andrew Williams (sobakasu) created D4201: Fix T55974: Crash when using Surface Force Field Type on UV Sphere.
Jan 13 2019, 10:50 AM

Jan 10 2019

Andrew Williams (sobakasu) added reviewers for D4152: Bevel modifier add invert vertex group option: Howard Trickey (howardt), Rohan Rathi (RohanRathi).
Jan 10 2019, 10:18 PM

Jan 2 2019

Andrew Williams (sobakasu) added a reviewer for D4152: Bevel modifier add invert vertex group option: Campbell Barton (campbellbarton).
Jan 2 2019, 2:13 AM
Andrew Williams (sobakasu) created D4152: Bevel modifier add invert vertex group option.
Jan 2 2019, 2:10 AM