Page MenuHome

Victor-Louis De Gusseme (victorlouis)
User

Projects

User Details

User Since
Dec 29 2020, 10:33 AM (16 w, 2 d)

Recent Activity

Fri, Apr 16

Victor-Louis De Gusseme (victorlouis) added a comment to T87564: Geometry Nodes: Using "Input-Value"-node with "Attribute-Math-Divide"-node leads to incorrect results in following "Attribute-Math-Modulo"-node.

Maybe this is a floating point thing:

Fri, Apr 16, 4:52 PM · BF Blender
Victor-Louis De Gusseme (victorlouis) added a comment to D10202: Geometry Nodes: Attribute Statistic node.

@Henrik Dick (weasel) I guess this comes down to preference. We could remove Range and Variance, but honestly they don't really bother me.

Fri, Apr 16, 1:38 PM · Geometry Nodes
Victor-Louis De Gusseme (victorlouis) updated the diff for D10202: Geometry Nodes: Attribute Statistic node.
  • merge master
Fri, Apr 16, 9:20 AM · Geometry Nodes
Victor-Louis De Gusseme (victorlouis) updated the summary of D10202: Geometry Nodes: Attribute Statistic node.
Fri, Apr 16, 12:03 AM · Geometry Nodes

Thu, Apr 15

Victor-Louis De Gusseme (victorlouis) updated the summary of D10202: Geometry Nodes: Attribute Statistic node.
Thu, Apr 15, 11:51 PM · Geometry Nodes
Victor-Louis De Gusseme (victorlouis) updated the diff for D10202: Geometry Nodes: Attribute Statistic node.
  • median, min and max now via std::sort
Thu, Apr 15, 11:49 PM · Geometry Nodes
Victor-Louis De Gusseme (victorlouis) updated the summary of D10202: Geometry Nodes: Attribute Statistic node.
Thu, Apr 15, 10:37 PM · Geometry Nodes
Victor-Louis De Gusseme (victorlouis) updated the diff for D10202: Geometry Nodes: Attribute Statistic node.
  • fixed float3 statistics
Thu, Apr 15, 9:53 PM · Geometry Nodes
Victor-Louis De Gusseme (victorlouis) updated the diff for D10202: Geometry Nodes: Attribute Statistic node.
  • WIP refactoring to use stl parallel algorithms
Thu, Apr 15, 8:42 PM · Geometry Nodes
Victor-Louis De Gusseme (victorlouis) abandoned D10935: MultiSpan datastructure for iterating over several spans transparently.

Closing this revision, and abandoning the idea of a multispan or of a custom iterator that loops over multiple spans.

Thu, Apr 15, 4:28 PM
Victor-Louis De Gusseme (victorlouis) updated the diff for D10935: MultiSpan datastructure for iterating over several spans transparently.
  • some testing
Thu, Apr 15, 4:23 PM

Mon, Apr 12

Victor-Louis De Gusseme (victorlouis) added a comment to T87428: Curve to Mesh Node.

From the description it seems like it's planned that the extrusion part will be contained in this node, right?

Mon, Apr 12, 3:47 PM · Geometry Nodes

Sat, Apr 10

Victor-Louis De Gusseme (victorlouis) added a comment to D10935: MultiSpan datastructure for iterating over several spans transparently.

Current plan: keep MultiSpan, it's job is to provide a .begin() and .end() for the iterator. Then use algorithms that work with iterators, see the sum test for an example with std::accumulate().

Sat, Apr 10, 5:06 PM
Victor-Louis De Gusseme (victorlouis) updated the diff for D10935: MultiSpan datastructure for iterating over several spans transparently.
  • Sum test that shows this is not how inheritance works in c++
  • removed sum() and calculate sum with std::accumulate() instead
Sat, Apr 10, 5:01 PM
Victor-Louis De Gusseme (victorlouis) added a comment to D10935: MultiSpan datastructure for iterating over several spans transparently.

As Jacques pointed out, what I explained in my previous comment is not possible in C++.

Sat, Apr 10, 4:24 PM
Victor-Louis De Gusseme (victorlouis) added a comment to D10935: MultiSpan datastructure for iterating over several spans transparently.

The overhead for each element access is not ideal, but when you need this functionality, the alternative is usually copying all the data in all the spans.

Sat, Apr 10, 3:43 PM
Victor-Louis De Gusseme (victorlouis) updated the diff for D10935: MultiSpan datastructure for iterating over several spans transparently.
  • a bit of cleanup
Sat, Apr 10, 2:07 PM
Victor-Louis De Gusseme (victorlouis) updated the summary of D10935: MultiSpan datastructure for iterating over several spans transparently.
Sat, Apr 10, 2:00 PM
Victor-Louis De Gusseme (victorlouis) requested review of D10935: MultiSpan datastructure for iterating over several spans transparently.
Sat, Apr 10, 1:58 PM

Fri, Apr 9

Victor-Louis De Gusseme (victorlouis) added a comment to D10202: Geometry Nodes: Attribute Statistic node.

Addressed the small comments. I'll look into a solution for the unnecessary copying in compute_median.

Fri, Apr 9, 6:39 PM · Geometry Nodes
Victor-Louis De Gusseme (victorlouis) updated the diff for D10202: Geometry Nodes: Attribute Statistic node.
  • cleanup
Fri, Apr 9, 6:35 PM · Geometry Nodes
Gregory (Apofis) awarded D10202: Geometry Nodes: Attribute Statistic node a Love token.
Fri, Apr 9, 1:21 PM · Geometry Nodes
Victor-Louis De Gusseme (victorlouis) added a comment to D10202: Geometry Nodes: Attribute Statistic node.

Pass spans by value and removed std::vector.

Fri, Apr 9, 10:54 AM · Geometry Nodes
Victor-Louis De Gusseme (victorlouis) updated the diff for D10202: Geometry Nodes: Attribute Statistic node.
  • Pass Spans by value and replaced std::vector with Vector and MutableSpan
Fri, Apr 9, 10:51 AM · Geometry Nodes
Victor-Louis De Gusseme (victorlouis) added a comment to D10202: Geometry Nodes: Attribute Statistic node.

Removed CombinedSpan and I addressed most of the other comments. I've done some quick tests and everything still seems to work, but I'll do some more thorough tests later.

Fri, Apr 9, 12:21 AM · Geometry Nodes
Victor-Louis De Gusseme (victorlouis) updated the diff for D10202: Geometry Nodes: Attribute Statistic node.
  • removed unused includes
Fri, Apr 9, 12:14 AM · Geometry Nodes

Thu, Apr 8

Victor-Louis De Gusseme (victorlouis) updated the diff for D10202: Geometry Nodes: Attribute Statistic node.
  • removed CombinedSpan and replaced with function that take Span<Span<>>
Thu, Apr 8, 11:57 PM · Geometry Nodes
Damian (damian) awarded D10202: Geometry Nodes: Attribute Statistic node a Pterodactyl token.
Thu, Apr 8, 1:26 PM · Geometry Nodes

Wed, Apr 7

Victor-Louis De Gusseme (victorlouis) updated the diff for D10202: Geometry Nodes: Attribute Statistic node.
  • WIP refactoring
Wed, Apr 7, 11:10 PM · Geometry Nodes
Victor-Louis De Gusseme (victorlouis) added a comment to D10905: Geometry Nodes: add Attribute Edge Length.

Yeah I wasn't really sure what category to put this one in. My thinking was: all the nodes in the Mesh category really alter the mesh topology, this node just adds an attribute so I thought it fitted there better.

Wed, Apr 7, 10:20 PM · Nodes & Physics, Geometry Nodes
Victor-Louis De Gusseme (victorlouis) added a comment to T87217: Poisson Disk Seed Repeats distribution every 125 values.

Ah yes indeed, forgot about that. Just tried it with the rng outside the loop and it causes the points to shift around while weight painting.

Wed, Apr 7, 9:11 PM · Geometry Nodes, BF Blender, Nodes & Physics
Gregory (Apofis) awarded D10905: Geometry Nodes: add Attribute Edge Length a Love token.
Wed, Apr 7, 2:47 PM · Nodes & Physics, Geometry Nodes
Paul Larson (GeorgiaPacific) awarded D10905: Geometry Nodes: add Attribute Edge Length a Like token.
Wed, Apr 7, 2:42 AM · Nodes & Physics, Geometry Nodes

Tue, Apr 6

Some User (someuser) awarded D10905: Geometry Nodes: add Attribute Edge Length a Love token.
Tue, Apr 6, 11:51 PM · Nodes & Physics, Geometry Nodes
Victor-Louis De Gusseme (victorlouis) updated the summary of D10905: Geometry Nodes: add Attribute Edge Length.
Tue, Apr 6, 11:21 PM · Nodes & Physics, Geometry Nodes
Victor-Louis De Gusseme (victorlouis) requested review of D10905: Geometry Nodes: add Attribute Edge Length.
Tue, Apr 6, 11:17 PM · Nodes & Physics, Geometry Nodes
Victor-Louis De Gusseme (victorlouis) updated the summary of D10896: UI: make submenus open faster after being hovered.
Tue, Apr 6, 10:24 PM · User Interface
Victor-Louis De Gusseme (victorlouis) updated the diff for D10896: UI: make submenus open faster after being hovered.
  • reverted previous change and instead just changed default userpref
Tue, Apr 6, 10:17 PM · User Interface
Victor-Louis De Gusseme (victorlouis) awarded T87245: Geometry Nodes: Curve Support Implementation a Love token.
Tue, Apr 6, 8:22 PM · Geometry Nodes
Victor-Louis De Gusseme (victorlouis) updated the summary of D10896: UI: make submenus open faster after being hovered.
Tue, Apr 6, 12:05 PM · User Interface
Victor-Louis De Gusseme (victorlouis) updated the summary of D10896: UI: make submenus open faster after being hovered.
Tue, Apr 6, 12:55 AM · User Interface
Victor-Louis De Gusseme (victorlouis) retitled D10896: UI: make submenus open faster after being hovered from removed 5* multiplier for time to open submenus to UI: make submenus open faster after being hovered.
Tue, Apr 6, 12:47 AM · User Interface
Victor-Louis De Gusseme (victorlouis) requested review of D10896: UI: make submenus open faster after being hovered.
Tue, Apr 6, 12:43 AM · User Interface

Mon, Apr 5

Victor-Louis De Gusseme (victorlouis) closed T84330: Geometry Nodes: Point Distribute Node Methods as Archived.

Archiving this because it is not actively being investigated.

Mon, Apr 5, 10:20 PM · Geometry Nodes
Victor-Louis De Gusseme (victorlouis) added a comment to T87217: Poisson Disk Seed Repeats distribution every 125 values.

Another solution would be to create a single RandomNumberGenerator rng(seed); outside the loop over looptris, instead of creating a new rng for each looptri.

Mon, Apr 5, 9:52 PM · Geometry Nodes, BF Blender, Nodes & Physics
Victor-Louis De Gusseme (victorlouis) added a comment to T87217: Poisson Disk Seed Repeats distribution every 125 values.

The problem is this line in sample_mesh_surface():

const int looptri_seed = BLI_hash_int(looptri_index + seed);
Mon, Apr 5, 9:31 PM · Geometry Nodes, BF Blender, Nodes & Physics

Thu, Apr 1

Victor-Louis De Gusseme (victorlouis) added a comment to T87117: Geometry Nodes: Utilities Map Range only works in 'Linear' interpolation mode.

I'm not sure whether this is a bug. I believe the Utilities Map Range node uses the code from node_shader_map_range.cc. In that file you can find this:

Thu, Apr 1, 9:33 PM · Geometry Nodes, BF Blender, Nodes & Physics

Tue, Mar 30

Deen (Bit) awarded D10202: Geometry Nodes: Attribute Statistic node a Love token.
Tue, Mar 30, 9:40 AM · Geometry Nodes

Mon, Mar 29

Victor-Louis De Gusseme (victorlouis) updated the summary of D10202: Geometry Nodes: Attribute Statistic node.
Mon, Mar 29, 11:49 PM · Geometry Nodes
Victor-Louis De Gusseme (victorlouis) updated the summary of D10202: Geometry Nodes: Attribute Statistic node.
Mon, Mar 29, 11:47 PM · Geometry Nodes
Victor-Louis De Gusseme (victorlouis) updated the diff for D10202: Geometry Nodes: Attribute Statistic node.
  • fix bug that caused saved nodes to load as Undefined
Mon, Mar 29, 11:46 PM · Geometry Nodes
Victor-Louis De Gusseme (victorlouis) updated the diff for D10202: Geometry Nodes: Attribute Statistic node.
  • vector median and removed size_()
Mon, Mar 29, 11:41 PM · Geometry Nodes
Victor-Louis De Gusseme (victorlouis) updated the diff for D10202: Geometry Nodes: Attribute Statistic node.
  • Merge branch 'master' into geometry-nodes-attribute-statistics
  • removed operation dropdown and exposed all stats as sockets instead
Mon, Mar 29, 11:03 PM · Geometry Nodes

Sun, Mar 28

Trung Phạm (zNight) awarded D10202: Geometry Nodes: Attribute Statistic node a Love token.
Sun, Mar 28, 3:04 PM · Geometry Nodes

Sat, Mar 27

Victor-Louis De Gusseme (victorlouis) updated the summary of D10202: Geometry Nodes: Attribute Statistic node.
Sat, Mar 27, 10:26 PM · Geometry Nodes
Victor-Louis De Gusseme (victorlouis) updated the diff for D10202: Geometry Nodes: Attribute Statistic node.
  • added support for pointcloud and volume
Sat, Mar 27, 10:20 PM · Geometry Nodes
Victor-Louis De Gusseme (victorlouis) updated the diff for D10202: Geometry Nodes: Attribute Statistic node.
  • WIP refactoring to include pointcloud and volume
Sat, Mar 27, 8:06 PM · Geometry Nodes
Victor-Louis De Gusseme (victorlouis) updated the summary of D10202: Geometry Nodes: Attribute Statistic node.
Sat, Mar 27, 4:10 PM · Geometry Nodes
Victor-Louis De Gusseme (victorlouis) updated the diff for D10202: Geometry Nodes: Attribute Statistic node.
  • removed prints
Sat, Mar 27, 4:05 PM · Geometry Nodes
Victor-Louis De Gusseme (victorlouis) updated the diff for D10202: Geometry Nodes: Attribute Statistic node.
  • merge master
Sat, Mar 27, 3:37 PM · Geometry Nodes

Fri, Mar 26

Damian (damian) awarded D10344: Geometry Nodes: add Attribute Map Range a Like token.
Fri, Mar 26, 2:40 PM · Geometry Nodes
Victor-Louis De Gusseme (victorlouis) updated subscribers of T86955: Geometry Nodes: Laplacian Smooth Node.

This functionality might be covered by this desgin task by @Hans Goudey (HooglyBoogly): Mesh Smooth Node https://developer.blender.org/T86903. Or is this something different?

Fri, Mar 26, 12:38 PM · Geometry Nodes
Daniel Salazar (zanqdo) awarded rBdda02a448a38: Geometry Nodes: Add Attribute Map Range Node a Love token.
Fri, Mar 26, 4:52 AM

Mar 23 2021

Victor-Louis De Gusseme (victorlouis) added a comment to T86843: Attribute Transfer Node.

As I understand it:

Mar 23 2021, 2:13 PM · Geometry Nodes

Mar 21 2021

Victor-Louis De Gusseme (victorlouis) added inline comments to D10344: Geometry Nodes: add Attribute Map Range.
Mar 21 2021, 6:45 PM · Geometry Nodes
Victor-Louis De Gusseme (victorlouis) updated the diff for D10344: Geometry Nodes: add Attribute Map Range.
  • Made a few variables const and removed comment about get_result_domain()
Mar 21 2021, 6:32 PM · Geometry Nodes
Victor-Louis De Gusseme (victorlouis) updated the diff for D10344: Geometry Nodes: add Attribute Map Range.
  • Merge branch 'master' into geometry-nodes-attribute-map-range
Mar 21 2021, 6:02 PM · Geometry Nodes

Mar 19 2021

Victor-Louis De Gusseme (victorlouis) added a comment to D10344: Geometry Nodes: add Attribute Map Range.

Ah yes of course, thanks! Should have checked the docs :p

Mar 19 2021, 12:39 AM · Geometry Nodes

Mar 18 2021

Victor-Louis De Gusseme (victorlouis) added a comment to D10344: Geometry Nodes: add Attribute Map Range.

@Jacques Lucke (JacquesLucke) no that wasn't intented. I've updated the patch with a fix. The problem was that I changed the CLAMP() to std::clamp() last minute and didn't bother to test thoroughly. Apparently std::clamp() doesn't work.

Mar 18 2021, 11:37 PM · Geometry Nodes
Victor-Louis De Gusseme (victorlouis) updated the diff for D10344: Geometry Nodes: add Attribute Map Range.
  • one more std::clamp changed to CLAMP
Mar 18 2021, 11:34 PM · Geometry Nodes
Victor-Louis De Gusseme (victorlouis) updated the diff for D10344: Geometry Nodes: add Attribute Map Range.
  • changed std::clamp back to CLAMP because it doesn't work
Mar 18 2021, 11:32 PM · Geometry Nodes
Victor-Louis De Gusseme (victorlouis) updated the diff for D10344: Geometry Nodes: add Attribute Map Range.
  • merge master
  • add node back to menu (removed by accident with merge) and set default vectors to (1,1,1) instead of (1,0,0)
Mar 18 2021, 1:10 PM · Geometry Nodes

Mar 15 2021

Daniel Salazar (zanqdo) awarded D10344: Geometry Nodes: add Attribute Map Range a Love token.
Mar 15 2021, 3:02 AM · Geometry Nodes

Mar 14 2021

Simon Sommer (CreatorSiSo) awarded D10344: Geometry Nodes: add Attribute Map Range a Love token.
Mar 14 2021, 5:23 PM · Geometry Nodes
Victor-Louis De Gusseme (victorlouis) updated the summary of D10344: Geometry Nodes: add Attribute Map Range.
Mar 14 2021, 4:59 PM · Geometry Nodes
Victor-Louis De Gusseme (victorlouis) updated the diff for D10344: Geometry Nodes: add Attribute Map Range.
  • std::clamp instead of CLAMP
Mar 14 2021, 4:51 PM · Geometry Nodes
Victor-Louis De Gusseme (victorlouis) updated the summary of D10344: Geometry Nodes: add Attribute Map Range.
Mar 14 2021, 4:34 PM · Geometry Nodes
Victor-Louis De Gusseme (victorlouis) updated the diff for D10344: Geometry Nodes: add Attribute Map Range.
  • simplified smoothstep and smootherstep
Mar 14 2021, 4:32 PM · Geometry Nodes
Victor-Louis De Gusseme (victorlouis) updated the summary of D10344: Geometry Nodes: add Attribute Map Range.
Mar 14 2021, 3:04 PM · Geometry Nodes
Victor-Louis De Gusseme (victorlouis) updated the diff for D10344: Geometry Nodes: add Attribute Map Range.
  • merge master and new way to choose result domain
Mar 14 2021, 2:59 PM · Geometry Nodes
Victor-Louis De Gusseme (victorlouis) updated the diff for D10344: Geometry Nodes: add Attribute Map Range.
  • Fixed conversion issue
Mar 14 2021, 2:25 PM · Geometry Nodes
Victor-Louis De Gusseme (victorlouis) updated the diff for D10344: Geometry Nodes: add Attribute Map Range.
  • Added result field and clamp socket, however there's still a bug with float to float3 conversion
Mar 14 2021, 2:07 PM · Geometry Nodes

Mar 13 2021

Victor-Louis De Gusseme (victorlouis) updated the summary of D10344: Geometry Nodes: add Attribute Map Range.
Mar 13 2021, 3:00 PM · Geometry Nodes
Victor-Louis De Gusseme (victorlouis) updated the summary of D10344: Geometry Nodes: add Attribute Map Range.
Mar 13 2021, 2:37 PM · Geometry Nodes
Victor-Louis De Gusseme (victorlouis) updated the diff for D10344: Geometry Nodes: add Attribute Map Range.
  • merge master
  • More documentation and removed 0.00001f because the old stepped function is used again.
Mar 13 2021, 2:35 PM · Geometry Nodes

Mar 9 2021

dorian (helloidonthaveanyideaformyusername) awarded D10202: Geometry Nodes: Attribute Statistic node a Burninate token.
Mar 9 2021, 11:29 AM · Geometry Nodes
Victor-Louis De Gusseme (victorlouis) added a comment to T86413: Creating the 'position' attribute with type 'float' failed..

I think this is the intended behavior (with Attribute Vector Math):

Mar 9 2021, 10:09 AM · Geometry Nodes, BF Blender
Victor-Louis De Gusseme (victorlouis) added a comment to T86413: Creating the 'position' attribute with type 'float' failed..

I believe the problem is that the Attribute Math node is trying to save it's result, a float attribute, into the position attribute. However position always has to be a vector attribute, so it gives this error. Should be fixed by used Attribute Vector Math instead.

Mar 9 2021, 10:05 AM · Geometry Nodes, BF Blender

Mar 8 2021

Victor-Louis De Gusseme (victorlouis) committed rBM7809: Add page for Attribute Proximity node.
Add page for Attribute Proximity node
Mar 8 2021, 9:35 PM

Mar 6 2021

Victor-Louis De Gusseme (victorlouis) updated the summary of D10556: Manual: Add Page for Attribute Proximity (Geometry) Node.
Mar 6 2021, 2:56 PM
Victor-Louis De Gusseme (victorlouis) updated the diff for D10556: Manual: Add Page for Attribute Proximity (Geometry) Node.

feedback by Hans an example with point cloud

Mar 6 2021, 2:55 PM

Mar 2 2021

Victor-Louis De Gusseme (victorlouis) updated the diff for D10556: Manual: Add Page for Attribute Proximity (Geometry) Node.

added examples

Mar 2 2021, 9:38 PM
Victor-Louis De Gusseme (victorlouis) updated the summary of D10556: Manual: Add Page for Attribute Proximity (Geometry) Node.
Mar 2 2021, 9:37 PM
Victor-Louis De Gusseme (victorlouis) updated the diff for D10556: Manual: Add Page for Attribute Proximity (Geometry) Node.

change Location to Position

Mar 2 2021, 9:05 PM

Feb 27 2021

Victor-Louis De Gusseme (victorlouis) requested review of D10556: Manual: Add Page for Attribute Proximity (Geometry) Node.
Feb 27 2021, 3:43 PM
Victor-Louis De Gusseme (victorlouis) updated the diff for D10344: Geometry Nodes: add Attribute Map Range.
  • merge master
Feb 27 2021, 12:44 PM · Geometry Nodes
Victor-Louis De Gusseme (victorlouis) added a comment to D10344: Geometry Nodes: add Attribute Map Range.

Charlie and Simon I agree with your comments about the stepped function so I've reverted it back to floor(x * (steps + 1)) / steps. It only behaves somewhat "weird" when input values are outside the [From Min, From Max] range and when clamping is disabled, so it's not that big of a deal and definitely not worth breaking consistency for.

Feb 27 2021, 4:55 AM · Geometry Nodes
Victor-Louis De Gusseme (victorlouis) updated the diff for D10344: Geometry Nodes: add Attribute Map Range.
  • reverted stepped function based on feedback
Feb 27 2021, 4:39 AM · Geometry Nodes

Feb 26 2021

Victor-Louis De Gusseme (victorlouis) added a comment to D10344: Geometry Nodes: add Attribute Map Range.

Not yet, I guess we should revert to original stepped function for consistency, even though it's not perfect for attribute values outside of the [0, 1] range when clamping is disabled.

Feb 26 2021, 11:56 PM · Geometry Nodes

Feb 22 2021

Victor-Louis De Gusseme (victorlouis) awarded T85898: Geometry Nodes: Distribute Points in Volume a Burninate token.
Feb 22 2021, 9:11 PM · Geometry Nodes