- User Since
- Aug 26 2019, 12:12 PM (148 w, 1 d)
May 23 2022
This issue is due to the precision of the used numbers. It is exactly the same in the edit mode convex hull.
May 15 2022
@tempdevnova (tempdevnova) In your test file Bevel_pinching2.blend it is clearly a user problem, as the faces are non planar. Bevel mostly works with non planar surfaces, but normals behave different and happen to cause problems.
May 2 2022
This bug is now there again
Apr 19 2022
- consider all values in the grease pencil object for the correct thickness
Apr 18 2022
There is a regression in the complex solidify modifier. This should fix it.
diff --git a/source/blender/modifiers/intern/MOD_solidify_nonmanifold.c b/source/blender/modifiers/intern/MOD_solidify_nonmanifold.c index 658eced3c20..d032a176bf2 100644 --- a/source/blender/modifiers/intern/MOD_solidify_nonmanifold.c +++ b/source/blender/modifiers/intern/MOD_solidify_nonmanifold.c @@ -1973,7 +1973,7 @@ Mesh *MOD_solidify_nonmanifold_modifyMesh(ModifierData *md, int *origindex_edge = CustomData_get_layer(&result->edata, CD_ORIGINDEX); int *origindex_poly = CustomData_get_layer(&result->pdata, CD_ORIGINDEX);
apart from the one comment it looks good. I will check if my tests work later.
Apr 7 2022
Apr 4 2022
Yes, this is caused by me. If you take a look at the removed lines in D14548 you can see how the code was doing the smooth based on the original stroke and not on the new position data. So the result was a slight smooth and nothing else.
Looks like the correct fix. Thanks for looking at it.
Apr 3 2022
Mar 30 2022
I have no trouble selecting it with box select. Clicking to select seems to be broken. So maybe the bug is somewhere in the selection code. Maybe it tries to select the non selectable strokes, as they are first in the list of strokes?
Mar 29 2022
The whole problem came when the eye needed the colorful backdrop. If implemented naively, the backdrop would be blue when the eye is closed and gray when the eye is open. This does not match other areas, so to solve this, a new rna property was introduced which is equivalent to the property in modifiers. The old property is called mute, the new property is called enabled. Both access the same flag, but one is inverted. Since the new eye icon has a new rna property with the inverted meaning, the old drivers don't show up.
Mar 28 2022
I still very much dislike Minimum Radius. From the name you really don't get any intuition that it is just a factor which gets multiplied on to the final weight.
Don't know the exact commit, but this problem does no longer persist.
The file MOD_gpencilweight_curvature.c is missing right now.
Mar 25 2022
Mar 24 2022
Mar 23 2022
- fix: add new icon to modifier as well
- fix crash in sculpt mode
- change icon to ICON_MOD_SKIN
- requested changes to the UI and defaults
- cleanup of the code
@Matias Mendiola (mendio) I think the thickness slider in deform mode is quite nice, since the usual usecase, that I am optimizing for would otherwise always require a thickness modifier before with thickness = 0. Since I am changing the thickness in the modifier anyway and since I have the slider already from the other modes, I may as well just include it and make the modifier stack more compact for the most common usecase.
The most common usecase for the deform mode that I am talking about, is using it as an alternative to the thickness from curvature modifier stack, mostly when doing handwriting.
- fix interpf bug, where interpf works the other way round from interp_v3_v3v3
- cleanup UI to only show the relevant options
Mar 21 2022
- add thickness and strength slider for new geometry in segments/fill mode
- add mode option instead of checkbox
- add material option for newly generated strokes
Mar 19 2022
- added a function for general purpose smooth operations.
Mar 18 2022
@Falk David (filedescriptor) so you want me to just move all of the code of the smooth modifier with all features into one function in BKE_gpencil_geom.cc? I would still need the per point functions for sculpt mode though.
@Falk David (filedescriptor) The problem is that the function is called for every point, so allocating inside is no option. Then also, not always can the function be used to skip iteration completely, see gpencil_edit.c. There it's very useful to allocate ouside the loop and then copy multiple times to the allocated memory. Sometimes if there is only one smooth iteration, it is not even really worth doing the allocation as the result is basically the same without.
Mar 17 2022
Mar 16 2022
- add versioning
I just did some good performance testing. The setup was a single grease pencil object with a noise modifier to make sure it gets updated every frame and a smooth modifier after that. The object has 23130 points accross 58 strokes. Then frame times are recorded for the old version (most recent commit) and the new version (next revision of this patch). The results where stunning.
- fully support cyclic strokes
- improve no segments mode
If you are on KDE you can save your computer from going down by pressing Ctrl+Alt+Esc and then click on blender to kill it.
Mar 15 2022
@Antonio Vazquez (antoniov) I am not changing the active smooth in the function gpencil_smooth_buffer. That one works really well and gives a good feeling while drawing and I don't wanna mess with that. The change here is most beneficial for really strong global smoothing operations so highly doubt that it could improve the active smooth. For the editmode smooth I even had to use the old approach of using multiple iterations with less reach in order to account for unselected points in an easy way.
- cleanup patch files
Mar 14 2022
Adding versioning here would mean changing the iterations option. So if you would load the updated file in an old version you would then get too strong smoothing. Is that fine? If so, I would like to add versioning code.
Cannot reproduce on linux.
Can you reproduce it with a factory settings?
Green is the new algorithm. Red is the old algorithm. They can be matched by changing the iterations and then the only remaining difference is that the old one had a bias towards one direction of the stroke.
- cleanup code
- fix editmode smooth defaults and ranges
Currently there is a few things left to do:
- Smoothing for the grease pencil sculpt mode is not yet improved. I could add two options to the smooth brush to keep_shape and smooth_caps. I would also wish to make it smooth symmetrically, but I haven't figured that out yet.
- Check the places where smooth was used, where I put in default values to try to match the old smooth.
- Find all places where the smooth factor is set to a default of 0.5 and replace it with 1.0 because that works much better with the new algorithm.
Mar 13 2022
Mar 12 2022
Mar 9 2022
The patch works, but it's not yet in the state I would like it. Using the code from the curvature length modifier like in the previous revision is probably not the best fit for purpose.
Mar 8 2022
Currently the patch is breaking the length modifier (as said). Make a stroke with 4 points and use the length modifier on it. Only one side will make a helix.
Mar 7 2022
@Campbell Barton (campbellbarton) can you take a look here and comment on this?
The usage of Vertex Bevel Weight for the rim is currently only implemented for complex solidify. The same feature will be missing for Vertex Creases when D14170 lands.
Mar 3 2022
@Bastien Montagne (mont29) Even if undo of vertex group can be considered a known issue, the silent corruption of all the other vertex groups should be considered a bug and should get fixed (maybe by disabling the undo behavior here completely?).
Mar 2 2022
Mar 1 2022
The patch currently breaks the length modifier. It does not apply the curvature thing on the start extention.
Feb 28 2022
Feb 25 2022
@Germano Cavalcante (mano-wii) The behavior is very different for vertices as vertices don't just get the selection behavior of the vertex group, but also different sizes for different weight values. To resolve this problem, either the vertex only behavior would need to be changed to use weight purely as selection and use bevel weights for this fine control or the threshold for a vertex to be bevels should be set to > 0 to avoid the jump (see previous comment).
It actually happens not only with the new operators, but also with the old ones like bpy.ops.constraint.delete(constraint="Transform Cache").
@Simon Thommes (simonthommes) I tried your new file in T95963 and there is still one little spike left on the bar. The artifact is clearly new and came from D14143. The problem with D14143 is that is does not handle non planar faces very well. I will have to think about a better solution for non planar faces, but that is out of the scope of this patch. I could increase the thresholds higher to hide the artifacts, but that will cause more and more inprecision in clean models with only planar faces. For your particular model the artifact dissappears if you triangulate your mesh using a triangulate modifier before solidify or if you use the even thickness mode.