Page MenuHome

Sebastian Parborg (zeddb)
User

Projects (15)

User Details

User Since
Mar 9 2013, 6:17 PM (507 w, 3 h)

Recent Activity

Mon, Nov 21

Sebastian Parborg (zeddb) accepted D13001: Un-ignore modules in .gitmodules configuration.

I looked into this thing in the past and I came to the same conclusion as Sergey that removing the ignore flag was better as you could actually see what is going on.

Mon, Nov 21, 2:38 PM · BF Blender (3.1)

Mon, Nov 7

Sebastian Parborg (zeddb) committed rB3e71220efcc1: Fix support for building with ffmpeg < 5.0 (authored by Sebastian Parborg (zeddb)).
Fix support for building with ffmpeg < 5.0
Mon, Nov 7, 5:46 PM
Sebastian Parborg (zeddb) closed D16408: Fix support for ffmpeg < 5.0.
Mon, Nov 7, 5:46 PM
Sebastian Parborg (zeddb) updated the diff for D16408: Fix support for ffmpeg < 5.0.

Updated patch based on feedback.

Mon, Nov 7, 5:35 PM
Sebastian Parborg (zeddb) added inline comments to D16408: Fix support for ffmpeg < 5.0.
Mon, Nov 7, 5:31 PM
Sebastian Parborg (zeddb) requested review of D16408: Fix support for ffmpeg < 5.0.
Mon, Nov 7, 2:31 PM

Wed, Nov 2

Sebastian Parborg (zeddb) accepted D16370: Fix deprecation warnings in FFmpeg related code.

We talked IRL.
I don't really have any test files with higher channel counts that STEREO.
Which was the same that Sergey already tested.
So it is a LGTM from me :)

Wed, Nov 2, 6:05 PM

Oct 25 2022

Sebastian Parborg (zeddb) added a comment to T102015: AV1 - No valid formats found.

Yeah, the tests for videos in our test suite are very poor.

Oct 25 2022, 3:36 PM · VFX & Video, Core, Images & Movies, BF Blender
Sebastian Parborg (zeddb) changed the status of T102048: Cursor disappears when using tool gizmos with the Wayland backend from Needs Triage to Confirmed.
Oct 25 2022, 12:31 PM · BF Blender
Sebastian Parborg (zeddb) created T102048: Cursor disappears when using tool gizmos with the Wayland backend.
Oct 25 2022, 12:31 PM · BF Blender

Oct 23 2022

Sebastian Parborg (zeddb) added a comment to D14920: Video rendering FFMpeg AV1 codec encoding support.

This this is probably the usual causes causes.
IIRC we postponed this as it was too late to merge for 3.3.
Then at least I forgot about it at the start of the 3.4 period.

Oct 23 2022, 7:57 PM

Oct 14 2022

Gary Ritchie (secundar) awarded rB3195a381200e: Introduce headless OpenGL rendering on Linux a Love token.
Oct 14 2022, 7:38 PM

Oct 12 2022

Sebastian Parborg (zeddb) accepted D15847: Fix T95683: FFmpeg seeking is broken.
Oct 12 2022, 2:45 PM

Oct 11 2022

Sebastian Parborg (zeddb) committed rBc4255992163d: Fix linker order of X11 and Wayland libs (authored by Sebastian Parborg (zeddb)).
Fix linker order of X11 and Wayland libs
Oct 11 2022, 2:55 PM

Oct 10 2022

Sebastian Parborg (zeddb) committed rB03fd2f7a5a4f: Fix building WITH_HEADLESS (authored by Sebastian Parborg (zeddb)).
Fix building WITH_HEADLESS
Oct 10 2022, 6:17 PM

Oct 9 2022

Sebastian Parborg (zeddb) accepted D14920: Video rendering FFMpeg AV1 codec encoding support.

Are we landing this for 3.4?

Oct 9 2022, 4:29 PM

Oct 6 2022

Sebastian Parborg (zeddb) committed rB7163a8345065: Fix addons submodule ref (authored by Sebastian Parborg (zeddb)).
Fix addons submodule ref
Oct 6 2022, 12:55 PM

Sep 28 2022

Sebastian Parborg (zeddb) committed rB050b6498d308: Bump submodule versions (authored by Sebastian Parborg (zeddb)).
Bump submodule versions
Sep 28 2022, 1:48 PM

Sep 23 2022

Sebastian Parborg (zeddb) accepted D15842: Fix T100741: Update FFMPEG Dimensions.

If Richard is fine with it, then I'm too.

Sep 23 2022, 4:30 PM · Core

Sep 20 2022

Sebastian Parborg (zeddb) committed rB7a239812ca55: Fix misleading operator name in the dope-sheet and action editor (authored by Sebastian Parborg (zeddb)).
Fix misleading operator name in the dope-sheet and action editor
Sep 20 2022, 10:52 AM

Sep 19 2022

Sebastian Parborg (zeddb) added inline comments to D15847: Fix T95683: FFmpeg seeking is broken.
Sep 19 2022, 2:09 PM

Sep 11 2022

Satish Goda (satishgoda) awarded rB3195a381200e: Introduce headless OpenGL rendering on Linux a 100 token.
Sep 11 2022, 12:27 AM

Aug 28 2022

Sebastian Parborg (zeddb) added a comment to D11489: enable Wayland via environment variable at runtime.

This already exists. You can just set WAYLAND_DISPLAYto something invalid (e.g. WAYLAND_DISPLAY=0 blender) and Blender will fall back to X11.

Aug 28 2022, 10:17 AM

Aug 27 2022

Sebastian Parborg (zeddb) added a comment to D11489: enable Wayland via environment variable at runtime.

As I've stated before in this review task, I don't think this should be opt in.
If Blender has been compiled with wayland support then no runtime flags should be needed to use it.

Aug 27 2022, 8:35 PM
Asger Langhoff (Asger) awarded rB3195a381200e: Introduce headless OpenGL rendering on Linux a Party Time token.
Aug 27 2022, 7:41 AM

Aug 26 2022

Sebastian Parborg (zeddb) requested review of D15792: Cycles: Add option to specify OptiX runtime root directory.
Aug 26 2022, 5:32 PM · Cycles

Aug 25 2022

Sen Jacob (senjacob) awarded rB3195a381200e: Introduce headless OpenGL rendering on Linux a Yellow Medal token.
Aug 25 2022, 8:18 PM
Sebastian Parborg (zeddb) added a comment to D15752: T100442: Rigidbody Physics Refactor - Separating Simulation Logic.

Other than my nitpick, I don't see any issue with moving out the different parts like this.

Aug 25 2022, 3:13 PM · BF Blender, Core, Nodes & Physics

Aug 23 2022

Sebastian Parborg (zeddb) added a comment to D15745: GHOST/X11: enable EGL.

If I recall correctly the USE_EGL ifdefs were put in the X11 files because we didn't want to make too many changes to the defaults immediately.

Aug 23 2022, 11:27 AM

Aug 17 2022

Sebastian Parborg (zeddb) committed rB1c63e4233d3c: Cleanup: Fix "unused m_system" warnings (authored by Sebastian Parborg (zeddb)).
Cleanup: Fix "unused m_system" warnings
Aug 17 2022, 12:55 PM

Aug 16 2022

Sebastian Parborg (zeddb) changed the status of T100442: Rigidbody Physics Refactor from Needs Triage to Confirmed.
Aug 16 2022, 4:52 PM · Core, BF Blender, Nodes & Physics
Sebastian Parborg (zeddb) added a comment to T100442: Rigidbody Physics Refactor.

Just to have it in writing here:
I'm fine with these steps. I don't think any of the other developers will have any issues with these either.

Aug 16 2022, 4:51 PM · Core, BF Blender, Nodes & Physics
kursad k (kursadk) awarded rB3195a381200e: Introduce headless OpenGL rendering on Linux a Burninate token.
Aug 16 2022, 3:35 AM

Aug 15 2022

Sebastian Parborg (zeddb) updated the task description for T76428: GHOST/Wayland Support.
Aug 15 2022, 6:18 PM · Platform: Linux, BF Blender
Sebastian Parborg (zeddb) updated the task description for T76428: GHOST/Wayland Support.
Aug 15 2022, 5:38 PM · Platform: Linux, BF Blender
Raimund Klink (Raimund58) awarded D15555: Introduce headless OpenGL rendering a Love token.
Aug 15 2022, 5:14 PM
Raimund Klink (Raimund58) awarded rB3195a381200e: Introduce headless OpenGL rendering on Linux a Love token.
Aug 15 2022, 5:14 PM
Sebastian Parborg (zeddb) committed rB3195a381200e: Introduce headless OpenGL rendering on Linux (authored by Sebastian Parborg (zeddb)).
Introduce headless OpenGL rendering on Linux
Aug 15 2022, 4:59 PM
Sebastian Parborg (zeddb) closed D15555: Introduce headless OpenGL rendering.
Aug 15 2022, 4:59 PM
Sebastian Parborg (zeddb) closed D15554: Cleanup OpenGL linking and function after libepoxy merge.
Aug 15 2022, 4:59 PM
Sebastian Parborg (zeddb) committed rB8ffc11dbcb21: Cleanup OpenGL linking and related code after libepoxy merge (authored by Sebastian Parborg (zeddb)).
Cleanup OpenGL linking and related code after libepoxy merge
Aug 15 2022, 4:59 PM
Sebastian Parborg (zeddb) closed T100300: Regression: Dropping a file in VSE does not create the strip at the cursor position as it did before as Resolved.
Aug 15 2022, 2:28 PM · BF Blender (3.3), VFX & Video, Video Sequencer
Sebastian Parborg (zeddb) added a comment to T100300: Regression: Dropping a file in VSE does not create the strip at the cursor position as it did before.

The fix has been pushed to the 3.3 release branch.
Feel free to reopen if the issue persists.

Aug 15 2022, 2:28 PM · BF Blender (3.3), VFX & Video, Video Sequencer
Sebastian Parborg (zeddb) committed rB3551b0a67213: Fix T99255: Strips inserting incorrectly (authored by Sebastian Parborg (zeddb)).
Fix T99255: Strips inserting incorrectly
Aug 15 2022, 2:25 PM

Aug 12 2022

Sebastian Parborg (zeddb) committed rB3de18e16ddf4: Merge branch 'blender-v3.3-release' (authored by Sebastian Parborg (zeddb)).
Merge branch 'blender-v3.3-release'
Aug 12 2022, 5:57 PM
Sebastian Parborg (zeddb) committed rBc1c0473a7efb: Fix out of bounds read in LineArt if there are only interestion edges (authored by Sebastian Parborg (zeddb)).
Fix out of bounds read in LineArt if there are only interestion edges
Aug 12 2022, 5:56 PM

Aug 4 2022

Sebastian Parborg (zeddb) added a comment to D15333: Fix T99255: Strips inserting incorrectly.

Or in other words, how many times are you supposed to walk into a closed door, before you're allowed to say out loud that the door is closed?

Aug 4 2022, 2:53 PM
Sebastian Parborg (zeddb) added a comment to D15333: Fix T99255: Strips inserting incorrectly.

Well, all the QA I've been doing on the VSE patches, is supposed to be a help.

It is helping as you catch bugs and issues we have overlooked. Thank you for that, I appreciate it.
Without it, this fix would have been much worse!

Aug 4 2022, 12:26 PM

Aug 3 2022

Sebastian Parborg (zeddb) added a comment to D15333: Fix T99255: Strips inserting incorrectly.

You can see the currently supported types when you try to mark something as an asset that is not currently supported:

Aug 3 2022, 7:28 PM
Sebastian Parborg (zeddb) added a comment to D15333: Fix T99255: Strips inserting incorrectly.

Sounds and video files has not been white listed as being supported as an asset.
IE it is currently not possible (or shouldn't be) to mark any of those IDs as an asset without disabling this white list.

Aug 3 2022, 5:50 PM
Sebastian Parborg (zeddb) committed rB144027d70ffc: Fix sequencer viewport render not respecting the "use_stamp" option (authored by Sebastian Parborg (zeddb)).
Fix sequencer viewport render not respecting the "use_stamp" option
Aug 3 2022, 5:15 PM
Sebastian Parborg (zeddb) changed the status of T100173: Assert when opening sculpting template ("SRDefault.003" in name map but not in Main) from Needs Triage to Confirmed.
Aug 3 2022, 4:35 PM · Core, BF Blender
Sebastian Parborg (zeddb) accepted D15327: LineArt: Usability improvement for "Enclosed Shapes"..
Aug 3 2022, 11:33 AM · Line Art

Aug 2 2022

Sebastian Parborg (zeddb) committed rBb010985e4ac4: Fix T99255: Strips inserting incorrectly (authored by Sebastian Parborg (zeddb)).
Fix T99255: Strips inserting incorrectly
Aug 2 2022, 7:39 PM
Sebastian Parborg (zeddb) closed T99255: VSE movie clips inserting incorrectly as Resolved by committing rBb010985e4ac4: Fix T99255: Strips inserting incorrectly.
Aug 2 2022, 7:39 PM · VFX & Video, Video Sequencer, BF Blender
Sebastian Parborg (zeddb) closed D15333: Fix T99255: Strips inserting incorrectly.
Aug 2 2022, 7:39 PM
Sebastian Parborg (zeddb) added a comment to D15333: Fix T99255: Strips inserting incorrectly.

I couldn't get it to work on my setup.
It simply just printed "Can't load <name of mp3 file>" and a broken strip was inserted.
The preview strip duration while dragging was zero.

Aug 2 2022, 7:25 PM
Sebastian Parborg (zeddb) added a comment to T100138: LineArt: Missing intersection lines .

I'm getting an ASAN heap overflow error. So I'm guessing that this might be a memory related issue:

==14506==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x6020000e3f38 at pc 0x7fae2b1eee37 bp 0x7fff33c6af90 sp 0x7fff33c6a738
READ of size 8000 at 0x6020000e3f38 thread T0
    #0 0x7fae2b1eee36 in __interceptor_memcpy (/usr/lib/gcc/x86_64-pc-linux-gnu/11.3.0/libasan.so.6+0x39e36)
    #1 0xcb165c1 in lineart_add_edge_to_array /home/zed/prog/blender/source/blender/gpencil_modifiers/intern/lineart/lineart_cpu.c:1785
    #2 0xcb6a060 in lineart_create_edges_from_isec_data /home/zed/prog/blender/source/blender/gpencil_modifiers/intern/lineart/lineart_cpu.c:4637
    #3 0xcb6a709 in lineart_main_add_triangles /home/zed/prog/blender/source/blender/gpencil_modifiers/intern/lineart/lineart_cpu.c:4670
    #4 0xcb7d14c in MOD_lineart_compute_feature_lines /home/zed/prog/blender/source/blender/gpencil_modifiers/intern/lineart/lineart_cpu.c:5039
    #5 0xca9aa2f in generateStrokes /home/zed/prog/blender/source/blender/gpencil_modifiers/intern/MOD_gpencillineart.c:147
    #6 0x696519 in BKE_gpencil_modifiers_calc /home/zed/prog/blender/source/blender/blenkernel/intern/gpencil_modifier.c:805
    #7 0xc404aa in BKE_object_handle_data_update /home/zed/prog/blender/source/blender/blenkernel/intern/object_update.c:192
    #8 0xc424b4 in BKE_object_eval_uber_data /home/zed/prog/blender/source/blender/blenkernel/intern/object_update.c:331
    #9 0x469b39f in operator() /home/zed/prog/blender/source/blender/depsgraph/intern/builder/deg_builder_nodes.cc:1470
Aug 2 2022, 7:08 PM · Grease Pencil, Line Art, BF Blender
Sebastian Parborg (zeddb) committed rB0830320a7ce8: CMake: Check if freetype is compiled with brotli support (authored by Sebastian Parborg (zeddb)).
CMake: Check if freetype is compiled with brotli support
Aug 2 2022, 2:51 PM

Jul 29 2022

Sebastian Parborg (zeddb) updated the diff for D15554: Cleanup OpenGL linking and function after libepoxy merge.

Fix building on Windows.

Jul 29 2022, 6:47 PM
Sebastian Parborg (zeddb) updated the diff for D15555: Introduce headless OpenGL rendering.

Hopefully fixed building on Mac and Windows (EGL not available there)

Jul 29 2022, 6:18 PM
Sebastian Parborg (zeddb) added a comment to D15555: Introduce headless OpenGL rendering.

The headless backend will now only be initialized in background mode.

Jul 29 2022, 5:46 PM
Sebastian Parborg (zeddb) updated the diff for D15555: Introduce headless OpenGL rendering.
Jul 29 2022, 5:46 PM
Sebastian Parborg (zeddb) updated the diff for D15555: Introduce headless OpenGL rendering.

Fix headless rendering with the SDL backend.

Jul 29 2022, 4:18 PM
Sebastian Parborg (zeddb) updated the summary of D15555: Introduce headless OpenGL rendering.
Jul 29 2022, 3:38 PM
Sebastian Parborg (zeddb) updated the diff for D15555: Introduce headless OpenGL rendering.

Revert the headless cmake variable name change.

Jul 29 2022, 3:37 PM
Sebastian Parborg (zeddb) updated the diff for D15554: Cleanup OpenGL linking and function after libepoxy merge.

Update with removing the GL defines in Cycles.

Jul 29 2022, 3:07 PM
Sebastian Parborg (zeddb) updated the diff for D15555: Introduce headless OpenGL rendering.

Updated to adress most of the feedback

Jul 29 2022, 12:43 PM
Sebastian Parborg (zeddb) added a comment to D15327: LineArt: Usability improvement for "Enclosed Shapes"..

I can't seem to find a way to show an icon with tooltip. So I made it like this:

That is acceptable to me :)

Jul 29 2022, 12:26 PM · Line Art
Sebastian Parborg (zeddb) added a comment to D15291: replace GLEW with libepoxy.

Sometimes I bypass libraries in lib/ (occasionally I run into compatibility issues) and was used to using system glew, but your right, this is mainly for libraries in extern/ with the exception of freetype which is a special case IIRC.

Removed WITH_SYSTEM_EPOXY.

Jul 29 2022, 12:22 PM

Jul 28 2022

Sebastian Parborg (zeddb) updated the diff for D15554: Cleanup OpenGL linking and function after libepoxy merge.

Introduced a ifdef guard to not load EGL in the X11 backend.

Jul 28 2022, 4:43 PM
Sebastian Parborg (zeddb) added a comment to D15555: Introduce headless OpenGL rendering.

I would not rename the CMake option and break people's build scripts, its meaning and purpose has not really changed. You still can't run Blender on a purely headless system without it as the new name implies, since this is Linux only + the X11 lib dependency remains.

Jul 28 2022, 4:06 PM
Sebastian Parborg (zeddb) added inline comments to D15555: Introduce headless OpenGL rendering.
Jul 28 2022, 3:48 PM
Sebastian Parborg (zeddb) updated the diff for D15554: Cleanup OpenGL linking and function after libepoxy merge.

Updated to adress most comments.

Jul 28 2022, 3:29 PM
Sebastian Parborg (zeddb) added inline comments to D15554: Cleanup OpenGL linking and function after libepoxy merge.
Jul 28 2022, 3:18 PM
Sebastian Parborg (zeddb) added a comment to D15554: Cleanup OpenGL linking and function after libepoxy merge.

Commit message should also note that this removes WITH_X11_ALPHA (which was ON by default) and the implications of that.

Done!

Jul 28 2022, 2:53 PM
Sebastian Parborg (zeddb) updated the summary of D15554: Cleanup OpenGL linking and function after libepoxy merge.
Jul 28 2022, 2:49 PM
Sebastian Parborg (zeddb) added inline comments to D15554: Cleanup OpenGL linking and function after libepoxy merge.
Jul 28 2022, 2:46 PM
Sebastian Parborg (zeddb) added a comment to D15291: replace GLEW with libepoxy.

Add WITH_SYSTEM_EPOXY to support linking with the system's libepoxy.
without this I wasn't able to test D15554, D15555.

Jul 28 2022, 1:17 PM

Jul 27 2022

Sebastian Parborg (zeddb) added a comment to D15291: replace GLEW with libepoxy.

I've posted my follow up cleanup D15554 and headless rendering patch D15555

Jul 27 2022, 5:04 PM
Sebastian Parborg (zeddb) requested review of D15555: Introduce headless OpenGL rendering.
Jul 27 2022, 5:01 PM
Sebastian Parborg (zeddb) requested review of D15554: Cleanup OpenGL linking and function after libepoxy merge.
Jul 27 2022, 4:54 PM

Jul 22 2022

Sebastian Parborg (zeddb) changed the edit policy for P3098 GL cleanup (only example).
Jul 22 2022, 11:56 AM
Sebastian Parborg (zeddb) added a comment to D15291: replace GLEW with libepoxy.

Just a heads up, the patch doesn't apply cleanly with the latest master changes.
The rebase conflicts are trivial though. (I would push the changes here, but I currently do not have arc working and I don't want to commandeer the revision for this small fix)

Jul 22 2022, 11:38 AM
Sebastian Parborg (zeddb) created P3098 GL cleanup (only example).
Jul 22 2022, 11:26 AM

Jul 20 2022

Sebastian Parborg (zeddb) added a comment to D15327: LineArt: Usability improvement for "Enclosed Shapes"..

Yes it's ordered this way, just like how we determine maximum occlusion level.

Ok, then the suggested updated comment looks good to me.

Jul 20 2022, 4:14 PM · Line Art

Jul 19 2022

Sebastian Parborg (zeddb) added a comment to D15327: LineArt: Usability improvement for "Enclosed Shapes"..
  • Change "Lit" into "Illuminated" so it's less ambiguous and sounds a bit better (maybe?) .

Seems good to me.

Jul 19 2022, 7:21 PM · Line Art
Sebastian Parborg (zeddb) reopened T99737: Drag and drop does not work with the wayland backend as "Confirmed".

This seems to still not be fixed.

Jul 19 2022, 4:25 PM · BF Blender

Jul 18 2022

Sebastian Parborg (zeddb) added a comment to D15333: Fix T99255: Strips inserting incorrectly.

I can't seem to reproduce that issue.
It works properly for me.

Jul 18 2022, 3:23 PM

Jul 15 2022

Sebastian Parborg (zeddb) added a comment to D15303: Fix T91369: Frequent crashes when performing minor adjustments with rigid body constraints.

Hmm, I just tried out the patch with my test file above.
When I do the undo ASAN shuts down blender with a heap-use-after-free error.

Jul 15 2022, 7:32 PM · Nodes & Physics, BF Blender
Sebastian Parborg (zeddb) updated the diff for D15333: Fix T99255: Strips inserting incorrectly.

This should fix the latest issues.

Jul 15 2022, 7:12 PM
Sebastian Parborg (zeddb) changed the status of T99737: Drag and drop does not work with the wayland backend from Needs Triage to Confirmed.
Jul 15 2022, 3:12 PM · BF Blender
Sebastian Parborg (zeddb) created T99737: Drag and drop does not work with the wayland backend.
Jul 15 2022, 3:11 PM · BF Blender

Jul 14 2022

Sebastian Parborg (zeddb) updated the diff for D15333: Fix T99255: Strips inserting incorrectly.

Updated to fix the outliner drag drop issues.

Jul 14 2022, 7:20 PM

Jul 12 2022

Sebastian Parborg (zeddb) committed rBb76762817344: Fix: Memory leaks in indexer code (authored by Sebastian Parborg (zeddb)).
Fix: Memory leaks in indexer code
Jul 12 2022, 4:59 PM
Sebastian Parborg (zeddb) closed D15376: Fix memory leaks in indexer code.
Jul 12 2022, 4:59 PM
Sebastian Parborg (zeddb) added a comment to D15333: Fix T99255: Strips inserting incorrectly.

I sadly can't reproduce that issue with the media files I have on my computer.
So I don't really know what is going wrong there.

Jul 12 2022, 4:37 PM
Sebastian Parborg (zeddb) updated the diff for D15333: Fix T99255: Strips inserting incorrectly.

Drag and dropping internal IDs from the outliner now works as expected.

Jul 12 2022, 3:32 PM

Jul 6 2022

Sebastian Parborg (zeddb) updated the diff for D15333: Fix T99255: Strips inserting incorrectly.

I changed the logic so that dropping show now work correctly in the VSE timeline.
(IE the dropped media tries to insert at the mouse cursor position)

Jul 6 2022, 12:16 PM
Sebastian Parborg (zeddb) commandeered D15333: Fix T99255: Strips inserting incorrectly.
Jul 6 2022, 12:15 PM