I looked into this thing in the past and I came to the same conclusion as Sergey that removing the ignore flag was better as you could actually see what is going on.

Updated patch based on feedback.

We talked IRL.
I don't really have any test files with higher channel counts that STEREO.
Which was the same that Sergey already tested.
So it is a LGTM from me :)

Yeah, the tests for videos in our test suite are very poor.

This this is probably the usual causes causes.
IIRC we postponed this as it was too late to merge for 3.3.
Then at least I forgot about it at the start of the 3.4 period.

In D14920#440928, @Ray molenkamp (LazyDodo) wrote:

Are we landing this for 3.4?

If Richard is fine with it, then I'm too.

In D11489#428972, @Christian Rauch (christian.rauch) wrote:

This already exists. You can just set WAYLAND_DISPLAYto something invalid (e.g. WAYLAND_DISPLAY=0 blender) and Blender will fall back to X11.

As I've stated before in this review task, I don't think this should be opt in.
If Blender has been compiled with wayland support then no runtime flags should be needed to use it.

Other than my nitpick, I don't see any issue with moving out the different parts like this.

If I recall correctly the USE_EGL ifdefs were put in the X11 files because we didn't want to make too many changes to the defaults immediately.

Just to have it in writing here:
I'm fine with these steps. I don't think any of the other developers will have any issues with these either.

The fix has been pushed to the 3.3 release branch.
Feel free to reopen if the issue persists.

In D15333#424006, @Peter Fog (tintwotin) wrote:

Or in other words, how many times are you supposed to walk into a closed door, before you're allowed to say out loud that the door is closed?

In D15333#423843, @Peter Fog (tintwotin) wrote:

Well, all the QA I've been doing on the VSE patches, is supposed to be a help.

It is helping as you catch bugs and issues we have overlooked. Thank you for that, I appreciate it.
Without it, this fix would have been much worse!

You can see the currently supported types when you try to mark something as an asset that is not currently supported:

Sounds and video files has not been white listed as being supported as an asset.
IE it is currently not possible (or shouldn't be) to mark any of those IDs as an asset without disabling this white list.

I couldn't get it to work on my setup.
It simply just printed "Can't load <name of mp3 file>" and a broken strip was inserted.
The preview strip duration while dragging was zero.

I'm getting an ASAN heap overflow error. So I'm guessing that this might be a memory related issue:

==14506==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x6020000e3f38 at pc 0x7fae2b1eee37 bp 0x7fff33c6af90 sp 0x7fff33c6a738
READ of size 8000 at 0x6020000e3f38 thread T0
    #0 0x7fae2b1eee36 in __interceptor_memcpy (/usr/lib/gcc/x86_64-pc-linux-gnu/11.3.0/libasan.so.6+0x39e36)
    #1 0xcb165c1 in lineart_add_edge_to_array /home/zed/prog/blender/source/blender/gpencil_modifiers/intern/lineart/lineart_cpu.c:1785
    #2 0xcb6a060 in lineart_create_edges_from_isec_data /home/zed/prog/blender/source/blender/gpencil_modifiers/intern/lineart/lineart_cpu.c:4637
    #3 0xcb6a709 in lineart_main_add_triangles /home/zed/prog/blender/source/blender/gpencil_modifiers/intern/lineart/lineart_cpu.c:4670
    #4 0xcb7d14c in MOD_lineart_compute_feature_lines /home/zed/prog/blender/source/blender/gpencil_modifiers/intern/lineart/lineart_cpu.c:5039
    #5 0xca9aa2f in generateStrokes /home/zed/prog/blender/source/blender/gpencil_modifiers/intern/MOD_gpencillineart.c:147
    #6 0x696519 in BKE_gpencil_modifiers_calc /home/zed/prog/blender/source/blender/blenkernel/intern/gpencil_modifier.c:805
    #7 0xc404aa in BKE_object_handle_data_update /home/zed/prog/blender/source/blender/blenkernel/intern/object_update.c:192
    #8 0xc424b4 in BKE_object_eval_uber_data /home/zed/prog/blender/source/blender/blenkernel/intern/object_update.c:331
    #9 0x469b39f in operator() /home/zed/prog/blender/source/blender/depsgraph/intern/builder/deg_builder_nodes.cc:1470

Fix building on Windows.

Hopefully fixed building on Mac and Windows (EGL not available there)

The headless backend will now only be initialized in background mode.

Fix headless rendering with the SDL backend.

Revert the headless cmake variable name change.

Update with removing the GL defines in Cycles.

Updated to adress most of the feedback

In D15327#422180, @YimingWu (NicksBest) wrote:

I can't seem to find a way to show an icon with tooltip. So I made it like this:

That is acceptable to me :)

In D15291#422446, @Campbell Barton (campbellbarton) wrote:

Sometimes I bypass libraries in lib/ (occasionally I run into compatibility issues) and was used to using system glew, but your right, this is mainly for libraries in extern/ with the exception of freetype which is a special case IIRC.

Removed WITH_SYSTEM_EPOXY.

Introduced a ifdef guard to not load EGL in the X11 backend.

In D15555#422074, @Brecht Van Lommel (brecht) wrote:

I would not rename the CMake option and break people's build scripts, its meaning and purpose has not really changed. You still can't run Blender on a purely headless system without it as the new name implies, since this is Linux only + the X11 lib dependency remains.

Updated to adress most comments.

In D15554#422145, @Campbell Barton (campbellbarton) wrote:

Commit message should also note that this removes WITH_X11_ALPHA (which was ON by default) and the implications of that.

Done!

In D15291#422160, @Campbell Barton (campbellbarton) wrote:

Add WITH_SYSTEM_EPOXY to support linking with the system's libepoxy.
without this I wasn't able to test D15554, D15555.

I've posted my follow up cleanup D15554 and headless rendering patch D15555

Just a heads up, the patch doesn't apply cleanly with the latest master changes.
The rebase conflicts are trivial though. (I would push the changes here, but I currently do not have arc working and I don't want to commandeer the revision for this small fix)

Yes it's ordered this way, just like how we determine maximum occlusion level.

Ok, then the suggested updated comment looks good to me.

In D15327#419657, @YimingWu (NicksBest) wrote:

• Change "Lit" into "Illuminated" so it's less ambiguous and sounds a bit better (maybe?) .

Seems good to me.

This seems to still not be fixed.

I can't seem to reproduce that issue.
It works properly for me.

Hmm, I just tried out the patch with my test file above.
When I do the undo ASAN shuts down blender with a heap-use-after-free error.

This should fix the latest issues.

Updated to fix the outliner drag drop issues.

I sadly can't reproduce that issue with the media files I have on my computer.
So I don't really know what is going wrong there.

Drag and dropping internal IDs from the outliner now works as expected.

I changed the logic so that dropping show now work correctly in the VSE timeline.
(IE the dropped media tries to insert at the mouse cursor position)