Page MenuHome

Sebastian Parborg (zeddb)
User

Projects (10)

User Details

User Since
Mar 9 2013, 6:17 PM (403 w, 1 d)

Recent Activity

Yesterday

Sebastian Parborg (zeddb) accepted D9657: QuadriFlow: Fix std::allocator deprecation warnings.

LGTM

Sun, Nov 29, 3:32 PM

Sat, Nov 28

Sebastian Parborg (zeddb) added a comment to D9657: QuadriFlow: Fix std::allocator deprecation warnings.

Upstream for quadriflow is pretty much dead.
We could probably have these changes upstreamed, but I'm not sure if we should wait for this.

Sat, Nov 28, 2:36 PM

Tue, Nov 17

Sebastian Parborg (zeddb) awarded T73394: bf-manual: Migrate From SVN to Git + Git-LFS a Love token.
Tue, Nov 17, 8:50 PM · Documentation

Thu, Nov 5

Sebastian Parborg (zeddb) added a comment to T80194: LineArt: New module to generate lines over meshes using grease pencil as target.

Could the baking settings be moved to the modifier? That way you could get editable strokes for only one collection / object? I just tested and it seems this isn't possible right now.

Thu, Nov 5, 10:39 PM · Freestyle, BF Blender (2.92), User Interface, Grease Pencil
Sebastian Parborg (zeddb) added a comment to T80194: LineArt: New module to generate lines over meshes using grease pencil as target.

From looking at the code, it seems that the modifier actually outputs the geometry, and further modifiers can be applied on top of it.

Correct.

Thu, Nov 5, 7:09 PM · Freestyle, BF Blender (2.92), User Interface, Grease Pencil
Sebastian Parborg (zeddb) added a comment to T80194: LineArt: New module to generate lines over meshes using grease pencil as target.
Thu, Nov 5, 6:58 PM · Freestyle, BF Blender (2.92), User Interface, Grease Pencil
Sebastian Parborg (zeddb) added a comment to D8758: Line Art module (Grease Pencil) main functions.

The intent as I understand it is to get a basic version of Line Art ready for master, as a base to build further improvemnts on. We could support both as a modifier or rendering feature in the future. But for the basic version please pick one and then we can ensure the UI and implementation for that works well.

Thu, Nov 5, 5:10 PM · Freestyle, BF Blender (2.92), User Interface, Grease Pencil
Sebastian Parborg (zeddb) added a comment to D8758: Line Art module (Grease Pencil) main functions.

This would mean you implement this feature as a regular grease pencil modifier, generating strokes. Depsgraph integration shouldn't be very difficult, probably it's just a matter of implementing a modifier in a way that is similar to existing modifiers and this might require no direct changes to the depsgraph.

The thresholds and angle splitting are artistic choices as far as I can tell. The line types I guess could be useful as global overrides since they are also in the modifier, though I'm not sure how useful it is in practice.

Thu, Nov 5, 1:58 PM · Freestyle, BF Blender (2.92), User Interface, Grease Pencil
Sebastian Parborg (zeddb) added a comment to D8758: Line Art module (Grease Pencil) main functions.

To reduce any confusion about the modifier part of things I'll explain the way we came here a bit.

Thu, Nov 5, 1:54 PM · Freestyle, BF Blender (2.92), User Interface, Grease Pencil

Tue, Nov 3

Sebastian Parborg (zeddb) committed rBed4540b79949: Fix paste f-curve modifiers default "Only Active" value (authored by Sebastian Parborg (zeddb)).
Fix paste f-curve modifiers default "Only Active" value
Tue, Nov 3, 5:23 PM

Mon, Nov 2

Sebastian Parborg (zeddb) added a comment to T81452: Policy for style guide: code comments.

I get where you're coming from, my main concern with this is - in practice it means extending existing comments would be tedious - or developers would forget to change the comment style & we'd end up with a mix of both... having to make clean-up commits to enforce the rule.

I've already had to fix old comments that didn't follow our current guidelines in cleanup commits, so we already have issues like this.

Mon, Nov 2, 7:27 PM · BF Blender
Sebastian Parborg (zeddb) added a comment to T81452: Policy for style guide: code comments.

I'll just throw in my two cents:

Mon, Nov 2, 12:30 PM · BF Blender
Sebastian Parborg (zeddb) added a project to D8366: Fix T69979: Make "offset edge loop" slide evenly: Modeling.
Mon, Nov 2, 11:32 AM · Modeling

Oct 29 2020

Sebastian Parborg (zeddb) updated subscribers of T81541: Symmetrize Transform Constraint, Y rotational axis unexpected results..

@Daniel Salazar (zanqdo) why is this moved to known issues when we have a fix in review for it?

Oct 29 2020, 3:54 PM · Animation & Rigging, BF Blender

Oct 28 2020

Sebastian Parborg (zeddb) closed D6379: Add a Un-Bake FCurves operator.
Oct 28 2020, 11:46 AM · Animation & Rigging
Sebastian Parborg (zeddb) committed rBfb88d4eda8a8: Add a Un-Bake FCurves operator (authored by Sebastian Parborg (zeddb)).
Add a Un-Bake FCurves operator
Oct 28 2020, 11:46 AM

Oct 27 2020

Sebastian Parborg (zeddb) added inline comments to D6379: Add a Un-Bake FCurves operator.
Oct 27 2020, 3:16 PM · Animation & Rigging
Sebastian Parborg (zeddb) closed T81844: Change Bone Layers fails in Pose Mode as Resolved by committing rB4975aa410cf0: Fix T81844: Change Bone Layers fails in Pose Mode.
Oct 27 2020, 3:14 PM · BF Blender (2.91), Animation & Rigging
Sebastian Parborg (zeddb) committed rBf6990c235ab9: Merge branch 'blender-v2.91-release' (authored by Sebastian Parborg (zeddb)).
Merge branch 'blender-v2.91-release'
Oct 27 2020, 3:14 PM
Sebastian Parborg (zeddb) committed rB4975aa410cf0: Fix T81844: Change Bone Layers fails in Pose Mode (authored by Sebastian Parborg (zeddb)).
Fix T81844: Change Bone Layers fails in Pose Mode
Oct 27 2020, 3:14 PM
Sebastian Parborg (zeddb) closed D9354: Fix T81844: Change Bone Layers fails in Pose Mode.
Oct 27 2020, 3:14 PM
Sebastian Parborg (zeddb) updated the diff for D6379: Add a Un-Bake FCurves operator.

Updated with latest feedback.

Oct 27 2020, 3:07 PM · Animation & Rigging
Sebastian Parborg (zeddb) added a comment to D9354: Fix T81844: Change Bone Layers fails in Pose Mode.

Also, should we back port this?

Oct 27 2020, 2:31 PM
Sebastian Parborg (zeddb) updated the diff for D9354: Fix T81844: Change Bone Layers fails in Pose Mode.

Updated with feedback

Oct 27 2020, 2:30 PM
Sebastian Parborg (zeddb) added inline comments to D9354: Fix T81844: Change Bone Layers fails in Pose Mode.
Oct 27 2020, 12:20 PM

Oct 26 2020

Sebastian Parborg (zeddb) requested review of D9354: Fix T81844: Change Bone Layers fails in Pose Mode.
Oct 26 2020, 10:36 PM
Sebastian Parborg (zeddb) added a comment to T82070: Ratio displayed with a % sign in the Decimate Keyframes Adjust Last Operation panel..

@Hans Goudey (HooglyBoogly) thanks for fixing this!

Oct 26 2020, 11:49 AM · User Interface, BF Blender

Oct 23 2020

Sebastian Parborg (zeddb) added a comment to T81844: Change Bone Layers fails in Pose Mode.

Ok, this issue doesn't happen with "Undo Legacy" activated (Preferences -> Experimental -> Undo Legacy).

Oct 23 2020, 5:50 PM · BF Blender (2.91), Animation & Rigging

Oct 22 2020

Sebastian Parborg (zeddb) updated the diff for D6379: Add a Un-Bake FCurves operator.
Oct 22 2020, 3:08 PM · Animation & Rigging
Sebastian Parborg (zeddb) added inline comments to D6379: Add a Un-Bake FCurves operator.
Oct 22 2020, 3:07 PM · Animation & Rigging
Sebastian Parborg (zeddb) updated the diff for D6379: Add a Un-Bake FCurves operator.

Updated with latest feedback.

Oct 22 2020, 3:04 PM · Animation & Rigging

Oct 21 2020

Sebastian Parborg (zeddb) updated the diff for D6379: Add a Un-Bake FCurves operator.

Updated code to latest master and incorporated given feedback.

Oct 21 2020, 12:57 AM · Animation & Rigging
Sebastian Parborg (zeddb) added inline comments to D6379: Add a Un-Bake FCurves operator.
Oct 21 2020, 12:56 AM · Animation & Rigging

Oct 20 2020

Sebastian Parborg (zeddb) committed rB711b55b52770: Fix libmv test on windows (authored by Sebastian Parborg (zeddb)).
Fix libmv test on windows
Oct 20 2020, 3:05 PM
Sebastian Parborg (zeddb) added a comment to rBe3c76f793724: Fix libmv eigen alignment issues when compiling with AVX support.

The test should now pass on windows. Thanks for pointing this out!

Oct 20 2020, 2:56 PM
Sebastian Parborg (zeddb) added a reviewer for D8758: Line Art module (Grease Pencil) main functions: Grease Pencil.
Oct 20 2020, 2:27 PM · Freestyle, BF Blender (2.92), User Interface, Grease Pencil
Sebastian Parborg (zeddb) added a comment to rBe3c76f793724: Fix libmv eigen alignment issues when compiling with AVX support.

Use ctest -VV -R libmv_vector_test if you want more verbose output on why it failed.

Oct 20 2020, 1:28 PM
Sebastian Parborg (zeddb) added a comment to rBe3c76f793724: Fix libmv eigen alignment issues when compiling with AVX support.

You have to provide more info than that.

Oct 20 2020, 1:23 PM
Sebastian Parborg (zeddb) committed rB0105f146bb40: Cleanup: General comment style clean up of graph_edit.c and fcurve.c (authored by Sebastian Parborg (zeddb)).
Cleanup: General comment style clean up of graph_edit.c and fcurve.c
Oct 20 2020, 1:05 PM
Sebastian Parborg (zeddb) closed D7850: General comment style clean up of graph_edit.c and fcurve.c.
Oct 20 2020, 1:04 PM · Animation & Rigging

Oct 19 2020

Sebastian Parborg (zeddb) claimed T81844: Change Bone Layers fails in Pose Mode.
Oct 19 2020, 2:16 PM · BF Blender (2.91), Animation & Rigging
Sebastian Parborg (zeddb) edited projects for T81844: Change Bone Layers fails in Pose Mode, added: BF Blender (2.91); removed BF Blender.
Oct 19 2020, 2:15 PM · BF Blender (2.91), Animation & Rigging
Sebastian Parborg (zeddb) changed the status of T81844: Change Bone Layers fails in Pose Mode from Needs Triage to Confirmed.
Oct 19 2020, 2:11 PM · BF Blender (2.91), Animation & Rigging
Sebastian Parborg (zeddb) committed rBe3c76f793724: Fix libmv eigen alignment issues when compiling with AVX support (authored by Sebastian Parborg (zeddb)).
Fix libmv eigen alignment issues when compiling with AVX support
Oct 19 2020, 1:07 PM
Sebastian Parborg (zeddb) closed D8968: Fix libmv eigen alignment issues when compiling with AVX support.
Oct 19 2020, 1:06 PM
Sebastian Parborg (zeddb) added a comment to D9047: Fix tests when building with GCC and march=native.

@Brecht Van Lommel (brecht) so how are we going to do this? Are we going to do the remove_cc_flag route?
To me it does makes sense to have the contract=off flag for GCC as it is the default with both clang and the intel compiler it seems (I don't know if it is the same with windows VS compiler)

Oct 19 2020, 11:16 AM
Sebastian Parborg (zeddb) added a comment to D8968: Fix libmv eigen alignment issues when compiling with AVX support.

Updated with the latest feedback.

Oct 19 2020, 11:13 AM
Sebastian Parborg (zeddb) updated the diff for D8968: Fix libmv eigen alignment issues when compiling with AVX support.
Oct 19 2020, 11:12 AM
Sebastian Parborg (zeddb) added a comment to D8968: Fix libmv eigen alignment issues when compiling with AVX support.

I am still waiting for the inlined comment about template alias to be addressed.

Oct 19 2020, 10:47 AM

Oct 15 2020

Sebastian Parborg (zeddb) added a comment to D9214: Fix T81541: Symmetrize Transform Constraint, Y rotational axis unexpected results..

At least in the example file, this is the case.

Oct 15 2020, 6:38 PM
Sebastian Parborg (zeddb) moved T73921: Eevee volume render test memory leak in Mantaflow from Backlog to Fluid on the Physics board.
Oct 15 2020, 2:09 PM · Physics, Nodes & Physics, BF Blender
Sebastian Parborg (zeddb) closed T50765: Rigid body dynamics: Initially deactivated objects are not activated on collision, but on bounding box intersection as Resolved.

I've updated the documentation to reflect the actual behavior of how rigidbodies becomes activated.

Oct 15 2020, 2:08 PM · Nodes & Physics, Physics, BF Blender
Sebastian Parborg (zeddb) committed rBM7251: Rigid Body: Update deactivation description text.
Rigid Body: Update deactivation description text
Oct 15 2020, 2:07 PM
Sebastian Parborg (zeddb) moved T71731: Wrong particle distribution from Backlog to Particles on the Physics board.
Oct 15 2020, 1:41 PM · Physics, BF Blender
Sebastian Parborg (zeddb) moved T76685: Force field can't expand smoke evenly. from Backlog to Smoke on the Physics board.
Oct 15 2020, 1:40 PM · Physics, Nodes & Physics, BF Blender
Sebastian Parborg (zeddb) moved T80752: Mouse movement causes crash during particle bake from Backlog to Particles on the Physics board.
Oct 15 2020, 1:38 PM · Nodes & Physics, Physics, BF Blender
Sebastian Parborg (zeddb) moved T79871: Liquid Emission unlimited from Backlog to Fluid on the Physics board.
Oct 15 2020, 1:38 PM · Physics, BF Blender
Sebastian Parborg (zeddb) moved T80438: Hair Dynamics Strange Behaviour from Backlog to Cloth on the Physics board.
Oct 15 2020, 1:37 PM · Physics, BF Blender
Sebastian Parborg (zeddb) moved T64877: Adding and Removing RigidBodyWorld is broken from Backlog to Rigid Body on the Physics board.
Oct 15 2020, 1:36 PM · Physics, BF Blender
Sebastian Parborg (zeddb) moved T62863: 2.8 - Dynamic Paint and Rigid body does not work from Backlog to Rigid Body on the Physics board.
Oct 15 2020, 1:35 PM · Physics, BF Blender
Sebastian Parborg (zeddb) moved T60945: Force field + hair dynamics not working in (linked) instanced collections from Backlog to Particles on the Physics board.
Oct 15 2020, 1:35 PM · Dependency Graph, Nodes & Physics, Physics, BF Blender
Sebastian Parborg (zeddb) moved T60749: Hair from 2.79 messed up in 2.8 (modifiers prior to PSys and partially broken without 'Use Modifer Stack') from Backlog to Particles on the Physics board.
Oct 15 2020, 1:34 PM · Physics, BF Blender
Sebastian Parborg (zeddb) moved T60485: Hair particles: 'Use modifier Stack' option with simple children leads to texture disappearing in cycles [interpolated children are fine] from Backlog to Particles on the Physics board.
Oct 15 2020, 1:34 PM · Render & Cycles, Physics, Modifiers, BF Blender
Sebastian Parborg (zeddb) moved T56818: Hair Dynamics does not work for all strands when hair has been cut from Backlog to Particles on the Physics board.
Oct 15 2020, 1:33 PM · Physics, Animation & Rigging, BF Blender
Sebastian Parborg (zeddb) moved T55405: Interpolated hair curves sharp turns from Backlog to Particles on the Physics board.
Oct 15 2020, 1:33 PM · Nodes & Physics, Physics, BF Blender
Sebastian Parborg (zeddb) moved T56596: Cloth improvements in 2.8 from Backlog to Cloth on the Physics board.
Oct 15 2020, 1:33 PM · Physics, BF Blender: 2.8
Sebastian Parborg (zeddb) moved T55433: Particle physics type: Keyed Bug from Backlog to Particles on the Physics board.
Oct 15 2020, 1:33 PM · Physics, BF Blender
Sebastian Parborg (zeddb) moved T53440: v2.79 - Particle System "Current Cache to Bake" Not Work from Backlog to Particles on the Physics board.
Oct 15 2020, 1:31 PM · Nodes & Physics, Physics, BF Blender
Sebastian Parborg (zeddb) moved T53226: Parented Rigid Body offsets on transform if the parent has been moved from Backlog to Rigid Body on the Physics board.
Oct 15 2020, 1:31 PM · Dependency Graph, Physics, BF Blender
Sebastian Parborg (zeddb) moved T69628: Improve UI for rigid body collections from Backlog to Rigid Body on the Physics board.
Oct 15 2020, 1:28 PM · User Interface, Physics, BF Blender
Sebastian Parborg (zeddb) moved T73617: Fluid Sim Improve UI from Backlog to Fluid on the Physics board.
Oct 15 2020, 1:27 PM · Physics, User Interface, BF Blender
Sebastian Parborg (zeddb) moved T73232: Mantaflow: Adaptive Domain breaks Dissolve if 'slow' is checked from Backlog to Fluid on the Physics board.
Oct 15 2020, 1:27 PM · Nodes & Physics, Physics, BF Blender
Sebastian Parborg (zeddb) moved T74737: Render cloth animation does not resets cache from Backlog to Cloth on the Physics board.
Oct 15 2020, 1:26 PM · Physics, Nodes & Physics, BF Blender
Sebastian Parborg (zeddb) moved T75557: Simple ball shooting animation not working as before from Backlog to Rigid Body on the Physics board.
Oct 15 2020, 1:26 PM · Physics, Nodes & Physics, BF Blender
Sebastian Parborg (zeddb) moved T78953: Rigid Body Constraints break when copying its empty object from Backlog to Rigid Body on the Physics board.
Oct 15 2020, 1:26 PM · Nodes & Physics, Physics, BF Blender
Sebastian Parborg (zeddb) moved T79954: Generic Rigid Body Constraint Bug from Backlog to Rigid Body on the Physics board.
Oct 15 2020, 1:25 PM · Animation & Rigging, Physics, BF Blender
Sebastian Parborg (zeddb) moved T76861: Rigidbody Mesh Collision Instability with Simple Torus from Backlog to Rigid Body on the Physics board.
Oct 15 2020, 1:25 PM · Physics, BF Blender

Oct 14 2020

Sebastian Parborg (zeddb) added a revision to T81541: Symmetrize Transform Constraint, Y rotational axis unexpected results.: D9214: Fix T81541: Symmetrize Transform Constraint, Y rotational axis unexpected results..
Oct 14 2020, 6:29 PM · Animation & Rigging, BF Blender
Sebastian Parborg (zeddb) added a task to D9214: Fix T81541: Symmetrize Transform Constraint, Y rotational axis unexpected results.: T81541: Symmetrize Transform Constraint, Y rotational axis unexpected results..
Oct 14 2020, 6:29 PM
Sebastian Parborg (zeddb) requested review of D9214: Fix T81541: Symmetrize Transform Constraint, Y rotational axis unexpected results..
Oct 14 2020, 6:28 PM
Sebastian Parborg (zeddb) accepted D8687: Directly select animation curves in the graph editor.

I think it looks fine code wise still.

Oct 14 2020, 1:46 PM · User Interface, Animation & Rigging, BF Blender (2.91)
Sebastian Parborg (zeddb) accepted D9196: Graph Editor - Code refactoring for the selection operators.

LGTM

Oct 14 2020, 1:44 PM
Sebastian Parborg (zeddb) added a comment to D8619: Fix Cloth Brush creating artifacts on planes.

I thought we had the bending springs working when I helped you implement them a while back?

Oct 14 2020, 1:30 PM
Sebastian Parborg (zeddb) accepted D9201: Fix Cloth brush grab artifacts in the affected area.
Oct 14 2020, 1:21 PM
Sebastian Parborg (zeddb) added a comment to D9202: Sculpt: Reduce the displacement step in the cloth solver.

I agree with Sergey's comments

Oct 14 2020, 1:21 PM

Oct 13 2020

Sebastian Parborg (zeddb) accepted D9187: Sculpt: Use plasticity for softbody influence.

This does look fine to me.

Oct 13 2020, 3:35 PM
Sebastian Parborg (zeddb) added a comment to T79954: Generic Rigid Body Constraint Bug.

@Sybren A. Stüvel (sybren) not yet, I talked to Brecht and Sergey about it and it seems like I should probably make a bigger proposal and design about this.

Oct 13 2020, 2:57 PM · Animation & Rigging, Physics, BF Blender
Sebastian Parborg (zeddb) added a project to D6100: Armature Make/Clear Parent: Grey out options that don't do anything: Animation & Rigging.
Oct 13 2020, 2:33 PM · Animation & Rigging
Sebastian Parborg (zeddb) accepted rBdeaff945d0b9: Mesh: skip conversion from edit-mesh to mesh in edit-mode.
Oct 13 2020, 2:29 PM

Oct 6 2020

Sebastian Parborg (zeddb) added a reviewer for D9054: Pose Sliding tools improvements: User Interface.
Oct 6 2020, 4:26 PM · BF Blender (2.92), User Interface, Animation & Rigging
Sebastian Parborg (zeddb) accepted D9054: Pose Sliding tools improvements.

The only thing I have to add is that we should probably port this to other parts of blender that uses the same logic.
I there are a few other operators (like the decimate keyframes one) that does the same thing.

Oct 6 2020, 2:24 PM · BF Blender (2.92), User Interface, Animation & Rigging
Sebastian Parborg (zeddb) added a reviewer for D8904: FCurves: Offset modifier: Sybren A. Stüvel (sybren).
Oct 6 2020, 1:35 PM · Animation & Rigging
Sebastian Parborg (zeddb) accepted D8904: FCurves: Offset modifier.
Oct 6 2020, 1:30 PM · Animation & Rigging
Sebastian Parborg (zeddb) added a reviewer for D8904: FCurves: Offset modifier: Animation & Rigging.

I think this looks good to me as well.

Oct 6 2020, 1:30 PM · Animation & Rigging

Oct 3 2020

Sebastian Parborg (zeddb) added a comment to D8968: Fix libmv eigen alignment issues when compiling with AVX support.
Oct 3 2020, 2:06 AM

Oct 2 2020

Sebastian Parborg (zeddb) added a comment to D9047: Fix tests when building with GCC and march=native.

Perhaps we can use the remove_cc_flag macro and simply do remove_cc_flag("-ffp-contract=off") for cycles?

Oct 2 2020, 4:03 PM

Oct 1 2020

Sebastian Parborg (zeddb) added a comment to D8968: Fix libmv eigen alignment issues when compiling with AVX support.

If you add a move constructor to Foo, then the number of constructor/destructor calls should no longer be STL implementation-dependent, and the number of calls should go back to what it was before.

Foo(Foo&& other) = default;
Oct 1 2020, 6:54 PM
Sebastian Parborg (zeddb) accepted D8726: Sculpt: Cloth Simulation Dynamic area mode.

I don't spot anything bad/wrong either. LGTM

Oct 1 2020, 6:15 PM
Sebastian Parborg (zeddb) added a comment to D9047: Fix tests when building with GCC and march=native.

Adding it to the global compiler flags here may disable FMA in the Cycles kernel with optimized compile flags (and potentially other code), where we do actually want to keep it enabled.

Cycles optimization flags will be added after the PLATFORM_CFLAGS, so if the order -ffp-contract=off -match=native still enables FMA it's fine. Can you check if that is the case?

Oct 1 2020, 6:03 PM

Sep 30 2020

Sebastian Parborg (zeddb) added a comment to D8968: Fix libmv eigen alignment issues when compiling with AVX support.

Sure, but my point is: number of re-allocations will depend on how exactly STL grows the capacity. GCC and MSVC are using different strategies, i.e. It might not be an immediate issue here, but relying on such match is like burring a dead cat into the code.

Hmm, perhaps we should just remove this test then?
If we are using the std::vector class as base, I don't think testing this is that useful?

Sep 30 2020, 5:19 PM