Page MenuHome

CompositingProject
ActivePublic

Details

Recent Activity

Thu, Jun 13

Sebastian Parborg (zeddb) closed T64052: Compositor constanttly crashes on particular input frames as Resolved.

Glad that it is now working for you.

Thu, Jun 13, 11:39 AM · Compositing, BF Blender
Konstantin (Mechanic) added a comment to T64052: Compositor constanttly crashes on particular input frames.

Yes, it seems to be fixed now. I tried the frames in this build:

Thu, Jun 13, 9:40 AM · Compositing, BF Blender

Wed, Jun 12

Bintang Senja Pratama (bintang) added a watcher for Compositing: Bintang Senja Pratama (bintang).
Wed, Jun 12, 5:21 PM

Tue, Jun 11

Sebastian Parborg (zeddb) triaged T64052: Compositor constanttly crashes on particular input frames as Needs Information from User priority.

The issue is that the pictures that doesn't render contains pixels that have a glitched pixels (pixels that have a very high value).

Tue, Jun 11, 2:33 PM · Compositing, BF Blender

Thu, May 23

Brecht Van Lommel (brecht) closed T60961: Camera DOF distance based on an object doesn't update on animations with compositing Defocus as Resolved.
Thu, May 23, 5:23 PM · Animation, Compositing, BF Blender
Sergey Sharybin (sergey) added a comment to T60961: Camera DOF distance based on an object doesn't update on animations with compositing Defocus.

Actually, i think it is now fixed by rBfaf48c0f6473.

Thu, May 23, 5:16 PM · Animation, Compositing, BF Blender
Brecht Van Lommel (brecht) updated subscribers of T60961: Camera DOF distance based on an object doesn't update on animations with compositing Defocus.

@Sergey Sharybin (sergey), this bug is still happening after rBb432209f63f8: Render: Use dependency graph for compositor/sequencer.

Thu, May 23, 4:45 PM · Animation, Compositing, BF Blender
Jeroen Bakker (jbakker) closed T55040: Blur Node Breaks on High Scene Referred Values as Invalid.
Thu, May 23, 1:33 PM · BF Blender, Compositing

Tue, May 21

Brecht Van Lommel (brecht) raised the priority of T64052: Compositor constanttly crashes on particular input frames from Needs Information from User to Needs Triage by Developer.
Tue, May 21, 5:15 PM · Compositing, BF Blender

May 9 2019

Konstantin (Mechanic) added a comment to T64052: Compositor constanttly crashes on particular input frames.

Sebastian, no, they aren't. They are EXR multi-layer files, and they have source image in 'Render layer', and a pitch-black result in 'Composite' layer. In the image node there is a switch, where you can choose the 'Render layer' to see the image. By default, when you open a new file in the node it selects 'Composite' layer, which is wrong, so just select 'Render layer' in the combobox below.
Thank you for your attention.

May 9 2019, 1:06 AM · Compositing, BF Blender

May 4 2019

Brecht Van Lommel (brecht) added a comment to D4304: Compositor: Added denoising node.

This will be for 2.81.

May 4 2019, 8:18 PM · Compositing
Kalyan (coder.kalyan) added a comment to D4304: Compositor: Added denoising node.

Will this branch make it into stable 2.80? Is there anything else that needs to be done - maybe I could help?

May 4 2019, 8:16 PM · Compositing

May 3 2019

Philipp Oeser (lichtwerk) placed T60961: Camera DOF distance based on an object doesn't update on animations with compositing Defocus up for grabs.

Since I wouldnt know how to proceed with this, stepping down...

May 3 2019, 2:06 PM · Animation, Compositing, BF Blender

May 2 2019

Sebastian Parborg (zeddb) triaged T64052: Compositor constanttly crashes on particular input frames as Needs Information from User priority.

The bad files you have attached are pitch black, so I'm unsure what there is to reproduce here.

May 2 2019, 12:26 PM · Compositing, BF Blender

May 1 2019

Konstantin (Mechanic) added a project to T64052: Compositor constanttly crashes on particular input frames: Compositing.
May 1 2019, 8:22 AM · Compositing, BF Blender

Apr 23 2019

Stefan Werner (swerner) updated the diff for D4304: Compositor: Added denoising node.
  • Merge 'master' into 'openimagedenoise'
  • Merge 'master' into 'openimagedenoise'
  • Merge 'master' into 'openimagedenoise'
Apr 23 2019, 9:33 AM · Compositing

Mar 30 2019

Rainer Trummer (aliasguru) added a comment to D4304: Compositor: Added denoising node.

I can't get this branch to compile properly. At the end of compilation, I get the following errors (there are more, but these are the first):

Mar 30 2019, 4:31 PM · Compositing

Mar 29 2019

Stefan Werner (swerner) updated the diff for D4304: Compositor: Added denoising node.
  • Added support for debug versions of OpenImageDenoise Windows DLLs.
Mar 29 2019, 2:37 PM · Compositing
Stefan Werner (swerner) updated the diff for D4304: Compositor: Added denoising node.
  • Compositor: More fixes for OIDN build on Windows.
Mar 29 2019, 12:29 PM · Compositing

Mar 28 2019

Stefan Werner (swerner) updated the diff for D4304: Compositor: Added denoising node.
  • Merge remote-tracking branch 'origin' into openimagedenoise
  • Merge branch 'master' of git.blender.org:blender into openimagedenoise
  • Fixed padding for OIDN node.
  • build_environemnt: Updated OpenImageDenoise to static 0.8.2
  • build_environment: OpenImageDenoise fixes for Linux and Windows.
  • build_environment: Fixed FindOpenImageDenoise.cmake.
  • build_environment: Fixed Windows build with static OpenImageDenoise.
Mar 28 2019, 8:32 PM · Compositing

Mar 27 2019

Kalyan (coder.kalyan) added a comment to D4304: Compositor: Added denoising node.
Mar 27 2019, 5:52 PM · Compositing

Mar 25 2019

Juan Gea (juang3d) added a comment to D4304: Compositor: Added denoising node.

@Stefan Werner (swerner) Intel said that they just uploaded 0.8.2 with that you said fixed!

Mar 25 2019, 4:49 PM · Compositing
Jeroen Bakker (jbakker) abandoned D3003: PoC: Sample based compositor.
Mar 25 2019, 1:40 PM · BF Blender: 2.8, Compositing

Mar 19 2019

Jeroen Bakker (jbakker) closed T54716: Corner Pin adds blur to an input image? as Archived.

Archiving this issue as it is not a bug. Questions and possible future improvements etc should go to the proper channels.

Mar 19 2019, 4:37 PM · Compositing, BF Blender

Mar 18 2019

Sergey Sharybin (sergey) added a comment to D4304: Compositor: Added denoising node.

That is quite interesting results, and clearly there is a niche where OIDN clearly shines. (probably, i was testing it on too complex or too simple file).
SO me being skeptical in the beginning is more like feeling that is something useful to have. Probably, also as an option for Cycles itself.

Mar 18 2019, 11:45 AM · Compositing

Mar 15 2019

Jeroen Bakker (jbakker) added a comment to T54716: Corner Pin adds blur to an input image?.

There are artifacts with the default settings as corner pinning uses EWA filtering. At this moment we don't have the capability to configure what filtering to use. EWA filtering is selected as it gives better result in normal use cases.

Mar 15 2019, 11:00 AM · Compositing, BF Blender
Jeroen Bakker (jbakker) added a comment to T55040: Blur Node Breaks on High Scene Referred Values.

Hi Troy, sorry for the late reply.

Mar 15 2019, 8:47 AM · BF Blender, Compositing

Mar 7 2019

Stefan Werner (swerner) added a comment to D4304: Compositor: Added denoising node.

FYI, I'm waiting for Intel to release the next version of OIDN that can build as a static library.

Mar 7 2019, 4:08 PM · Compositing

Mar 5 2019

padma kumaran (kumaran7) added a comment to D4304: Compositor: Added denoising node.

What are you doing to get Albedo > 1? I didn't see that happen in my test scenes. Adding clamping to the albedo input will be easy though.

Hi @Stefan Werner (swerner)
I figured out in my tests, the Albedo > 1 appears when a material (Pricipled BSDF), has Specular > 1.
If you look here, first image shows the brown material with Specular = 0.0, second image has same settings but a slight Specular value was added (about 0.1 or so)
When adding Specular, Albedo denoise pass goes above 1.0, thus resulting in pure white and then not preserving details in case a textured material is used.


Mar 5 2019, 5:57 AM · Compositing

Mar 1 2019

Philipp Oeser (lichtwerk) closed T62053: Composite rendering more images than needed as Resolved by committing rB9f77c202868b: Fix T62053: Composite rendering more images than needed.
Mar 1 2019, 12:54 PM · Compositing, BF Blender
Philipp Oeser (lichtwerk) added a revision to T62053: Composite rendering more images than needed: D4432: Fix T62053: Composite rendering more images than needed.
Mar 1 2019, 11:53 AM · Compositing, BF Blender
Philipp Oeser (lichtwerk) claimed T62053: Composite rendering more images than needed.

Seems like it is going over all RenderLayer nodes and renders the corresponding scene no matter if has been rendered already...

Mar 1 2019, 10:58 AM · Compositing, BF Blender

Feb 28 2019

Marco G (marcog) added a comment to D4304: Compositor: Added denoising node.

What are you doing to get Albedo > 1? I didn't see that happen in my test scenes. Adding clamping to the albedo input will be easy though.

Feb 28 2019, 4:14 PM · Compositing

Feb 22 2019

Jeroen Bakker (jbakker) added a comment to T60940: Compositor RGB Curves artefacts with 'film like' option.
Feb 22 2019, 3:08 PM · Compositing, BF Blender

Feb 20 2019

Stefan Werner (swerner) added a comment to D4304: Compositor: Added denoising node.

What are you doing to get Albedo > 1? I didn't see that happen in my test scenes. Adding clamping to the albedo input will be easy though.

Feb 20 2019, 3:51 PM · Compositing
Sergey Sharybin (sergey) closed T61689: Blender 2.80 crashes when adding keyframe to Fac in compositing node editor as Resolved by committing rBe6bdc950d25c: Fix T61689: Crash when having image and regular animation.
Feb 20 2019, 11:55 AM · Nodes, Compositing, BF Blender

Feb 19 2019

Sebastian Parborg (zeddb) assigned T61689: Blender 2.80 crashes when adding keyframe to Fac in compositing node editor to Sergey Sharybin (sergey).

Backtrace:

Thread 1 "blender" received signal SIGSEGV, Segmentation fault.
0x0000555556bbeba8 in DEG::Depsgraph::check_nodes_connected (this=0x7fffe4fbcb08, from=0x0, to=0x7fffcd67df08, description=0x555557d1e438 "Animation -> Prop")
    at /home/zed/programmering/blender_master/blender/source/blender/depsgraph/intern/depsgraph.cc:211
211		for (Relation *rel : from->outlinks) {
(gdb) bt
#0  0x0000555556bbeba8 in DEG::Depsgraph::check_nodes_connected (this=0x7fffe4fbcb08, from=0x0, to=0x7fffcd67df08,
    description=0x555557d1e438 "Animation -> Prop") at /home/zed/programmering/blender_master/blender/source/blender/depsgraph/intern/depsgraph.cc:211
#1  0x0000555556bbef5d in DEG::Depsgraph::add_new_relation (this=<optimized out>, from=from@entry=0x0, to=to@entry=0x7fffcd67df08,
    description=description@entry=0x555557d1e438 "Animation -> Prop", flags=flags@entry=32)
    at /home/zed/programmering/blender_master/blender/source/blender/depsgraph/intern/depsgraph.cc:183
#2  0x0000555556bcc094 in DEG::DepsgraphRelationBuilder::build_animdata_curves_targets (this=this@entry=0x7fffffffd9d0, id=id@entry=0x7fffcf14c408,
    adt_key=..., operation_from=operation_from@entry=0x0, curves=<optimized out>)
    at /home/zed/programmering/blender_master/blender/source/blender/depsgraph/intern/builder/deg_builder_relations.cc:1287
#3  0x0000555556bcd323 in DEG::DepsgraphRelationBuilder::build_animdata_curves (this=this@entry=0x7fffffffd9d0, id=id@entry=0x7fffcf14c408)
    at /home/zed/programmering/blender_master/blender/source/blender/depsgraph/intern/builder/deg_builder_relations.cc:1240
#4  0x0000555556bcdd0c in DEG::DepsgraphRelationBuilder::build_animdata (this=this@entry=0x7fffffffd9d0, id=id@entry=0x7fffcf14c408)
    at /home/zed/programmering/blender_master/blender/source/blender/depsgraph/intern/builder/deg_builder_relations.cc:1206
#5  0x0000555556bce528 in DEG::DepsgraphRelationBuilder::build_nodetree (this=this@entry=0x7fffffffd9d0, ntree=0x7fffcf14c408)
    at /home/zed/programmering/blender_master/blender/source/blender/depsgraph/intern/builder/deg_builder_relations.cc:2323
#6  0x0000555556bd05bc in DEG::DepsgraphRelationBuilder::build_compositor (this=this@entry=0x7fffffffd9d0, scene=scene@entry=0x7fffcf323008)
    at /home/zed/programmering/blender_master/blender/source/blender/depsgraph/intern/builder/deg_builder_relations.cc:2427
#7  0x0000555556bd3a12 in DEG::DepsgraphRelationBuilder::build_view_layer (this=this@entry=0x7fffffffd9d0, scene=scene@entry=0x7fffcf323008,
    view_layer=view_layer@entry=0x7fffccf88908)
    at /home/zed/programmering/blender_master/blender/source/blender/depsgraph/intern/builder/deg_builder_relations_view_layer.cc:114
#8  0x0000555556bbf360 in DEG_graph_build_from_view_layer (graph=0x7fffe4fbcb08, bmain=0x7fffcf6eaa08, scene=0x7fffcf323008, view_layer=0x7fffccf88908)
    at /home/zed/programmering/blender_master/blender/source/blender/depsgraph/intern/depsgraph_build.cc:264
#9  0x000055555696b9d1 in BKE_scene_graph_update_tagged (depsgraph=depsgraph@entry=0x7fffe4fbcb08, bmain=bmain@entry=0x7fffcf6eaa08)
    at /home/zed/programmering/blender_master/blender/source/blender/blenkernel/intern/scene.c:1487
#10 0x000055555610e478 in wm_event_do_depsgraph (C=C@entry=0x7fffea058108)
    at /home/zed/programmering/blender_master/blender/source/blender/windowmanager/intern/wm_event_system.c:341
#11 0x000055555610e515 in wm_event_do_refresh_wm_and_depsgraph (C=C@entry=0x7fffea058108)
    at /home/zed/programmering/blender_master/blender/source/blender/windowmanager/intern/wm_event_system.c:366
#12 0x0000555556114d5a in wm_event_do_notifiers (C=C@entry=0x7fffea058108)
    at /home/zed/programmering/blender_master/blender/source/blender/windowmanager/intern/wm_event_system.c:524
#13 0x000055555610ad88 in WM_main (C=0x7fffea058108) at /home/zed/programmering/blender_master/blender/source/blender/windowmanager/intern/wm.c:421
#14 0x00005555560f58e3 in main (argc=1, argv=0x7fffffffdd28) at /home/zed/programmering/blender_master/blender/source/creator/creator.c:505
Feb 19 2019, 7:30 PM · Nodes, Compositing, BF Blender
Haig Petrus (hpetrus) added a comment to T61689: Blender 2.80 crashes when adding keyframe to Fac in compositing node editor.

Sure. It would appear as though it occurs with Image Sequences, in particular. I've included a packed .blend file with a simple node set-up to demo the crash. Just change one or all of the Image nodes to Image Sequence and add a keyframe to Fac on the third Alpha Over node. It'll crash.

Feb 19 2019, 7:23 PM · Nodes, Compositing, BF Blender
Sebastian Parborg (zeddb) triaged T61689: Blender 2.80 crashes when adding keyframe to Fac in compositing node editor as Needs Information from User priority.

I can't reproduce this on my end.

Feb 19 2019, 12:08 PM · Nodes, Compositing, BF Blender
Haig Petrus (hpetrus) created T61689: Blender 2.80 crashes when adding keyframe to Fac in compositing node editor.
Feb 19 2019, 12:08 AM · Nodes, Compositing, BF Blender

Feb 14 2019

Philipp Oeser (lichtwerk) closed T61520: Incorrect assignment of layers to compositor nodes in 2.8 when reading 2.79 .blend as Resolved by committing rB87bba05d25e0: Fix T61520: Incorrect assignment of layers to compositor nodes in 2.8 when….
Feb 14 2019, 2:01 PM · BF Blender: 2.8, Compositing, BF Blender
Philipp Oeser (lichtwerk) added a project to T61520: Incorrect assignment of layers to compositor nodes in 2.8 when reading 2.79 .blend: BF Blender: 2.8.
Feb 14 2019, 1:14 PM · BF Blender: 2.8, Compositing, BF Blender
Philipp Oeser (lichtwerk) removed a project from T61520: Incorrect assignment of layers to compositor nodes in 2.8 when reading 2.79 .blend: BF Blender: 2.8.
Feb 14 2019, 1:13 PM · BF Blender: 2.8, Compositing, BF Blender
Philipp Oeser (lichtwerk) added a project to T61520: Incorrect assignment of layers to compositor nodes in 2.8 when reading 2.79 .blend: BF Blender: 2.8.
Feb 14 2019, 1:13 PM · BF Blender: 2.8, Compositing, BF Blender
Philipp Oeser (lichtwerk) assigned T61520: Incorrect assignment of layers to compositor nodes in 2.8 when reading 2.79 .blend to Brecht Van Lommel (brecht).
Feb 14 2019, 1:11 PM · BF Blender: 2.8, Compositing, BF Blender
Philipp Oeser (lichtwerk) added a comment to T61520: Incorrect assignment of layers to compositor nodes in 2.8 when reading 2.79 .blend.

Looks like this is caused by adding a vanilla "Viewport" viewlayer and making it the first in the list here
(special case in do_version_layers_to_collections() if there are layer overrides...)

/* Make it first in the list. */
BLI_remlink(&scene->view_layers, view_layer);
BLI_addhead(&scene->view_layers, view_layer);
Feb 14 2019, 1:11 PM · BF Blender: 2.8, Compositing, BF Blender
Philipp Oeser (lichtwerk) added a revision to T61520: Incorrect assignment of layers to compositor nodes in 2.8 when reading 2.79 .blend: D4352: Fix T61520: Incorrect assignment of layers to compositor nodes in 2.8 when reading 2.79 .blend.
Feb 14 2019, 1:10 PM · BF Blender: 2.8, Compositing, BF Blender
Philipp Oeser (lichtwerk) edited projects for T61520: Incorrect assignment of layers to compositor nodes in 2.8 when reading 2.79 .blend, added: Compositing; removed BF Blender: 2.8.
Feb 14 2019, 9:24 AM · BF Blender: 2.8, Compositing, BF Blender

Feb 13 2019

Marco G (marcog) added a comment to D4304: Compositor: Added denoising node.

Nice tests @Malte S (pandrodor), i also had issues with Albedo pass being in the wrong range for some objects in my scenes and they turned white , I used the same fix as you did but isn't the Mix node unnecessary? I got same results with just the Greater Than node and the Color Subtract.

Feb 13 2019, 1:11 AM · Compositing

Feb 12 2019

Malte S (pandrodor) added a comment to D4304: Compositor: Added denoising node.

OIDN does work with Animations and it also works with high sample renders. The bug I showed earlier was rendered with just 4 samples just to make the point very clear.
This setup is a simple fix for the wrong “Denoising Albedo” pass:


@derek barker (lordodin) You should try this setup. It should fix the areas where no denoising is happening and improves the texture sharpness.

Feb 12 2019, 11:10 PM · Compositing