Page MenuHome

Line ArtProject
ActivePublic

Members (5)

Details

Description

Project to organize the Line Art modifier tasks and TODOs. Line Art is a subproject of Grease Pencil

The creator and main developer of the Line Art modifier is @YimingWu (NicksBest)

Recent Activity

Sun, Sep 18

Antonio Vazquez (antoniov) added a comment to T101087: GPencil: Important feature request for Blender 3.3 LTS: Add new option "Forced Intersection".

@YimingWu (NicksBest) Add this commit to 3.3.1: https://developer.blender.org/T100749

Sun, Sep 18, 3:51 PM · Line Art, Grease Pencil, BF Blender
Christoph Werner (Taros) added a comment to T101087: GPencil: Important feature request for Blender 3.3 LTS: Add new option "Forced Intersection".

Thank you a lot, Yiming. This is a great addition for all Gpencil

Sun, Sep 18, 3:13 PM · Line Art, Grease Pencil, BF Blender
YimingWu (NicksBest) changed the status of T101087: GPencil: Important feature request for Blender 3.3 LTS: Add new option "Forced Intersection" from Archived to Resolved.

Hi! This is resolved with D15978. It's a minor change, so we might be able to get it in for the next corrective release of 3.3.

Sun, Sep 18, 3:49 AM · Line Art, Grease Pencil, BF Blender

Thu, Sep 15

YimingWu (NicksBest) added a revision to T101087: GPencil: Important feature request for Blender 3.3 LTS: Add new option "Forced Intersection": D15978: LineArt: Force intersection option..
Thu, Sep 15, 4:10 PM · Line Art, Grease Pencil, BF Blender
Christoph Werner (Taros) added a comment to T101087: GPencil: Important feature request for Blender 3.3 LTS: Add new option "Forced Intersection".

Hi! I actually encourage this feature to be included with later fixes for 3.3, because it's really a minor improvement and it could make a lot of things easier for complex scenes.

If I were to do a better design for a later version, I probably should separate this one flag into "generate lines", "generate intersections", "cause occlusion" three options for more flexible configuration. But for this time I would just add "force intersection" option in the menu.

Thu, Sep 15, 3:15 PM · Line Art, Grease Pencil, BF Blender
YimingWu (NicksBest) added a comment to T101087: GPencil: Important feature request for Blender 3.3 LTS: Add new option "Forced Intersection".

Hi! I actually encourage this feature to be included with later fixes for 3.3, because it's really a minor improvement and it could make a lot of things easier for complex scenes.

Thu, Sep 15, 2:44 PM · Line Art, Grease Pencil, BF Blender
Omar Emara (OmarSquircleArt) closed T101087: GPencil: Important feature request for Blender 3.3 LTS: Add new option "Forced Intersection" as Archived.

3.3 LTS is already released, and it will only get fixes, not new features. So I am afraid it is too late for that feature in LTS.
Regardless, since we do not handle feature requests in the tracker, I will archive this. Yiming is free to create a design task for that if he wishes.
While things can get buried in Right-Click Select, it seems like you are already in contact with the developer, so pointing him to the topic in RCS should be equivalent to creating a topic here in the tracker.

Thu, Sep 15, 1:46 PM · Line Art, Grease Pencil, BF Blender
Antonio Vazquez (antoniov) renamed T101087: GPencil: Important feature request for Blender 3.3 LTS: Add new option "Forced Intersection" from Important Grease Pencil feature request for Blender 3.3 LTS: Add new option "Forced Intersection" to GPencil: Important feature request for Blender 3.3 LTS: Add new option "Forced Intersection".
Thu, Sep 15, 11:38 AM · Line Art, Grease Pencil, BF Blender
Christoph Werner (Taros) updated the task description for T101087: GPencil: Important feature request for Blender 3.3 LTS: Add new option "Forced Intersection".
Thu, Sep 15, 11:30 AM · Line Art, Grease Pencil, BF Blender
Christoph Werner (Taros) updated the task description for T101087: GPencil: Important feature request for Blender 3.3 LTS: Add new option "Forced Intersection".
Thu, Sep 15, 11:29 AM · Line Art, Grease Pencil, BF Blender
Antonio Vazquez (antoniov) added projects to T101087: GPencil: Important feature request for Blender 3.3 LTS: Add new option "Forced Intersection": Grease Pencil, Line Art.

@YimingWu (NicksBest) You decide what to do with this task... do you consider it as Design?

Thu, Sep 15, 11:25 AM · Line Art, Grease Pencil, BF Blender

Fri, Sep 2

Clément Foucault (fclem) added a comment to D15780: Fix T100595: Lineart screenspace thickness ignores Resolution Percentage.

@Brecht Van Lommel (brecht) I took the wireframe node as an example, but to me anything labelled as in pixel units inside the shader system should behave consistently. IIRC it is the only shader node that has a pixel unit property.

Fri, Sep 2, 6:19 PM · Line Art, Grease Pencil
Brecht Van Lommel (brecht) added a comment to D15780: Fix T100595: Lineart screenspace thickness ignores Resolution Percentage.

I'm not sure it's worth doing this for wireframes?

Fri, Sep 2, 5:57 PM · Line Art, Grease Pencil
Clément Foucault (fclem) updated subscribers of D15780: Fix T100595: Lineart screenspace thickness ignores Resolution Percentage.

Just checking: this should still only affect rendering, right? (we dont want to change anything for the viewport when changing render percentage if I am not mistaken)

Fri, Sep 2, 9:58 AM · Line Art, Grease Pencil
Philipp Oeser (lichtwerk) added a comment to D15780: Fix T100595: Lineart screenspace thickness ignores Resolution Percentage.

But if that's something we want to fix for all screen space radii, we better put it in the ViewInfos instead and do the multiplication in the shader.

Fri, Sep 2, 9:53 AM · Line Art, Grease Pencil

Thu, Sep 1

wilson Fan (echofan) added a watcher for Line Art: wilson Fan (echofan).
Thu, Sep 1, 10:48 AM

Mon, Aug 29

Philipp Oeser (lichtwerk) updated subscribers of T100595: Line Art Thickness doesn't consider Render Resolution Percentage.

Just dropping a note from D15780:

Mon, Aug 29, 12:39 PM · Line Art, BF Blender
Philipp Oeser (lichtwerk) abandoned D15780: Fix T100595: Lineart screenspace thickness ignores Resolution Percentage.

But if that's something we want to fix for all screen space radii, we better put it in the ViewInfos instead and do the multiplication in the shader.

Mon, Aug 29, 12:39 PM · Line Art, Grease Pencil
Clément Foucault (fclem) added a comment to D15780: Fix T100595: Lineart screenspace thickness ignores Resolution Percentage.

However I don't like where it gets injected.

Got a hint for a better place?
(we are already messing with gpThicknessWorldScale in a similar way in the same function here https://developer.blender.org/diffusion/B/browse/master/source/blender/draw/engines/gpencil/gpencil_cache_utils.c$276)

Mon, Aug 29, 11:15 AM · Line Art, Grease Pencil
Philipp Oeser (lichtwerk) added a comment to D15780: Fix T100595: Lineart screenspace thickness ignores Resolution Percentage.

Things like wireframe shader also do not respect the scaling factor. So i am unsure if we should fix this

Mon, Aug 29, 10:53 AM · Line Art, Grease Pencil
Philipp Oeser (lichtwerk) added a comment to D15780: Fix T100595: Lineart screenspace thickness ignores Resolution Percentage.

However I don't like where it gets injected.

Mon, Aug 29, 10:50 AM · Line Art, Grease Pencil
Philipp Oeser (lichtwerk) updated the diff for D15780: Fix T100595: Lineart screenspace thickness ignores Resolution Percentage.

better readability

Mon, Aug 29, 10:48 AM · Line Art, Grease Pencil

Aug 28 2022

Clément Foucault (fclem) requested changes to D15780: Fix T100595: Lineart screenspace thickness ignores Resolution Percentage.

Well, that's quite a breaking change. Things like wireframe shader also do not respect the scaling factor. So i am unsure if we should fix this. But it does make sense.

Aug 28 2022, 7:20 PM · Line Art, Grease Pencil

Aug 25 2022

Germano Cavalcante (mano-wii) changed the status of T100595: Line Art Thickness doesn't consider Render Resolution Percentage from Needs Information from User to Needs Information from Developers.
Aug 25 2022, 11:08 PM · Line Art, BF Blender
Antonio Vazquez (antoniov) updated subscribers of D15780: Fix T100595: Lineart screenspace thickness ignores Resolution Percentage.

The change looks logic, but I would like to hear the opinion of @Clément Foucault (fclem) before changing anything in the Draw Engine code.

Aug 25 2022, 4:21 PM · Line Art, Grease Pencil
Philipp Oeser (lichtwerk) updated subscribers of T100595: Line Art Thickness doesn't consider Render Resolution Percentage.

We could compensate with something like D15780: Fix T100595: Lineart screenspace thickness ignores Resolution Percentage, not 100% sure though if this desired in all scenarios (would assume so though).

Aug 25 2022, 1:07 PM · Line Art, BF Blender
Philipp Oeser (lichtwerk) added projects to D15780: Fix T100595: Lineart screenspace thickness ignores Resolution Percentage: Grease Pencil, Line Art.
Aug 25 2022, 1:05 PM · Line Art, Grease Pencil
Philipp Oeser (lichtwerk) added a revision to T100595: Line Art Thickness doesn't consider Render Resolution Percentage: D15780: Fix T100595: Lineart screenspace thickness ignores Resolution Percentage.
Aug 25 2022, 1:05 PM · Line Art, BF Blender
Nick Alberelli (Pushingframes) added a comment to T100595: Line Art Thickness doesn't consider Render Resolution Percentage.

I did mean sceeen space, when i go to screen space mode theres the thickness still just reports as a value not a pixel value.

Aug 25 2022, 1:33 AM · Line Art, BF Blender

Aug 24 2022

Germano Cavalcante (mano-wii) changed the status of T100595: Line Art Thickness doesn't consider Render Resolution Percentage from Needs Triage to Needs Information from User.
  1. Under Object Data Properties>Strokes>Stroke Thickness and set to World Space

Did you mean Screen Space instead of World Space?
If so, I'm not sure it's a bug as in the case of Screen Space the line thickness seems to be measured in pixels.
So a higher resolution image is to be expected with relatively thinner lines.

Aug 24 2022, 5:44 PM · Line Art, BF Blender
Germano Cavalcante (mano-wii) changed the status of T100596: Line Art doesn't render from Sequencer Perspective from Needs Triage to Confirmed.

Looks like some update is missing.
The Sequencer changes the active camera of the other scene, but the modifier doesn't seem to update.

Aug 24 2022, 5:28 PM · Grease Pencil, Line Art, BF Blender

Aug 23 2022

Nick Alberelli (Pushingframes) added a project to T100596: Line Art doesn't render from Sequencer Perspective : Line Art.
Aug 23 2022, 11:02 PM · Grease Pencil, Line Art, BF Blender
Nick Alberelli (Pushingframes) added a project to T100595: Line Art Thickness doesn't consider Render Resolution Percentage: Line Art.
Aug 23 2022, 10:54 PM · Line Art, BF Blender

Aug 21 2022

scillidan (scillidan) added a watcher for Line Art: scillidan (scillidan).
Aug 21 2022, 12:21 PM

Aug 18 2022

YimingWu (NicksBest) updated subscribers of T99492: GPencil: Cached grease pencil objects renders up to 5 times faster when LineArt Modifiers are deleted after baking.

@Aleš Jelovčan (frogstomp) prompted me, maybe this is related: https://developer.blender.org/T99492 If the behaviour is fixed then I suppose this is the problem

Aug 18 2022, 2:07 PM · Line Art, Grease Pencil, BF Blender

Aug 17 2022

Germano Cavalcante (mano-wii) changed the status of T99492: GPencil: Cached grease pencil objects renders up to 5 times faster when LineArt Modifiers are deleted after baking from Needs Information from User to Needs Information from Developers.
Aug 17 2022, 8:04 PM · Line Art, Grease Pencil, BF Blender

Aug 16 2022

YimingWu (NicksBest) added a comment to T100435: Grease Pencil: "Set Material Node" in Geometry Nodes doesn't transfer material settings for "Line Art" Masks.

OK Thanks! :)

Aug 16 2022, 3:18 PM · Line Art, Geometry Nodes, Grease Pencil, BF Blender
Pratik Borhade (PratikPB2123) updated subscribers of T100435: Grease Pencil: "Set Material Node" in Geometry Nodes doesn't transfer material settings for "Line Art" Masks.

No need :)
3.2.2 was the last corrective release.


Also closing this one, since there won't be another 3.2.x release.

Aug 16 2022, 12:41 PM · Line Art, Geometry Nodes, Grease Pencil, BF Blender
YimingWu (NicksBest) updated subscribers of T100435: Grease Pencil: "Set Material Node" in Geometry Nodes doesn't transfer material settings for "Line Art" Masks.

Now it should work fine in 3.3. Should I apply this to 3.2 as well? @Pratik Borhade (PratikPB2123)

Aug 16 2022, 12:35 PM · Line Art, Geometry Nodes, Grease Pencil, BF Blender
YimingWu (NicksBest) closed T100435: Grease Pencil: "Set Material Node" in Geometry Nodes doesn't transfer material settings for "Line Art" Masks as Resolved by committing rBaccf38c1d1d9: Fix T100435: Use evaluated material for line art loading..
Aug 16 2022, 12:33 PM · Line Art, Geometry Nodes, Grease Pencil, BF Blender
Christoph Werner (Taros) added a comment to T100435: Grease Pencil: "Set Material Node" in Geometry Nodes doesn't transfer material settings for "Line Art" Masks.

Looks like by adding two material slots in the original object could resolve the issue.

I'm trying if changing BKE_object_material_get to BKE_object_material_get_eval would resolve the issue without requiring extra modification on the user side.

Aug 16 2022, 12:14 PM · Line Art, Geometry Nodes, Grease Pencil, BF Blender
YimingWu (NicksBest) added a comment to T100435: Grease Pencil: "Set Material Node" in Geometry Nodes doesn't transfer material settings for "Line Art" Masks.

Looks like by adding two material slots in the original object could resolve the issue.

Aug 16 2022, 11:59 AM · Line Art, Geometry Nodes, Grease Pencil, BF Blender
Omar Emara (OmarSquircleArt) changed the status of T100435: Grease Pencil: "Set Material Node" in Geometry Nodes doesn't transfer material settings for "Line Art" Masks from Needs Triage to Confirmed.
Aug 16 2022, 11:58 AM · Line Art, Geometry Nodes, Grease Pencil, BF Blender
Christoph Werner (Taros) added a comment to T100435: Grease Pencil: "Set Material Node" in Geometry Nodes doesn't transfer material settings for "Line Art" Masks.

I'll take a look. :)

Aug 16 2022, 11:55 AM · Line Art, Geometry Nodes, Grease Pencil, BF Blender
YimingWu (NicksBest) added a project to T100435: Grease Pencil: "Set Material Node" in Geometry Nodes doesn't transfer material settings for "Line Art" Masks: Line Art.
Aug 16 2022, 11:47 AM · Line Art, Geometry Nodes, Grease Pencil, BF Blender

Aug 12 2022

YimingWu (NicksBest) closed T100138: LineArt: Missing intersection lines as Resolved by committing rB498e26fa0f64: Fix T100138: Use `double` for LineArt intersection record..
Aug 12 2022, 12:16 PM · Grease Pencil, Line Art, BF Blender

Aug 11 2022

Pratik Borhade (PratikPB2123) added a project to T99117: Grease pencil scale issue: Grease Pencil.
Aug 11 2022, 12:31 PM · Grease Pencil, Line Art, BF Blender
Pratik Borhade (PratikPB2123) added a project to T100138: LineArt: Missing intersection lines : Grease Pencil.
Aug 11 2022, 12:30 PM · Grease Pencil, Line Art, BF Blender

Aug 6 2022

YimingWu (NicksBest) closed D15327: LineArt: Usability improvement for "Enclosed Shapes"..
Aug 6 2022, 6:29 AM · Line Art

Aug 3 2022

Sebastian Parborg (zeddb) accepted D15327: LineArt: Usability improvement for "Enclosed Shapes"..
Aug 3 2022, 11:33 AM · Line Art