Think this is close to completion.
Declare iterators in for loops where possible
Cleanup: use 'uint' instead of 'unsigned int', wrap struct declarations using trailing comma
fixed all sort of linear algebra mistakes and cleaned up the angle calculation.
Tue, Sep 17
improved naming further, used a few more makros, fixed constraints calculation for offset != 0. Need to fix even and simple method for offset != 0 as well but had no time for that yet. The error in solidify_crash.blend is still unresolved.
made naming more understandable, applied all the other suggestions from above.
👍 Thank you too, @Juan Gea (juang3d) !
It's probably for 2.82.
- The "Only Rim" option works differently to the current extrude method (doesn't keep the original shell).b
- This is asserting on the attached file (play the animation, crashes on the last frame)
Mon, Sep 16
Ok I have fixed all the bugs I found and added a lot of code to support duplicates. Also I added the offset property that was missing. I have a file with my test objects that I will add to this comment.
Sun, Sep 15
Added layer/material selector for UI/functionality consistency with other GPencil modifiers. Works after simple test.
Fixed stroke shrinking function for correct length handling. Now Length modifier in both relative and absolute mode works correctly, and they handles 0 length situations correctly.
Sat, Sep 14
No, this is stand-alone and don't need LANPR patch to run. I'll remove this from gp-object branch later.
As this is base on master, we can test this change only. Of course, this would be in 2.82.
Have just re-tried by moving both objects after creation to a different position in the scene and it works. Previous attempt was at 0,0,0, Is it a scene issue?
I'm getting this problem repeatedly in 2.80. Sometimes the Boolean difference works. It seems that the previous operations are conflicting, As if you only get one chance. Restarting seems to clear issue , sometimes.
Fri, Sep 13
I didn't do an in-depth code review, some notes from testing.
improved sharpening mode : usable for csg objects and now threaded with tbb::parallel_for
Is it possible to split up the functions and add comment of what they are doing to make it easier to review the code and its logic (and, in the future, make it more maintainable) ?
Could this be closed then?
Thu, Sep 12
fixed a bug where very complicated geometry would create wrong loops resulting in all sorts of failure
Wed, Sep 11
fixed normalized vertex normals for curves
changed the obsolete designated initializers to standard syntax
sharpen features works with accumulate now + a few cleanups
Tue, Sep 10
some linux compile fixes
removed some now unnecessary old experimental, active code
I agree with @Martin Felke (scorpion81) here.
Not necessary any more since particle meshing functionality is included as mode toggle inside D4960 (voxel remesher / metaball remesher)
- Improved the gaussian smoothing algorithm and using this instead of openvdbs standard gaussian
- added sharpen edges / corners feature for voxel remesher to try to preserve original features of the mesh
- included particle meshing mode into voxel remesher. It belongs there too, since it shares openvdb and volume csg logic. This would be duplicated otherwise. A new modifier also creates more noise as other modifier devs need to take care of new numbering, modifying a lot of more files etc. It is just more hassle to add a new modifier than to add a new mode to a thematically totally related modifier, aka remeshing. It is also easier for users to remember to look for one modifier and know that the functionality is grouped in there.
Mon, Sep 9
Same problem here on linux and OSX official builds for 2.80.
Fri, Sep 6
@Brecht Van Lommel (brecht) : I have added this to 2.81 milestone (since it was set to "High"), mind checking again?
Thu, Sep 5
Sergey and I noticed that this will still break if the vertex count of the mesh is the same (but not the topology) or if the input vertex weight group is animated.
However, we deemed that these use cases are not that common and we are unsure if it would be worth to try to guard against these issues at this point in time.