ModifiersProject
ActivePublic

Watchers

  • This project does not have any watchers.

Properties

Description

Modifier stack for meshes, curves, metaballs.

Developers:

Module Owners: @Campbell Barton (campbellbarton) @Sergey Sharybin (sergey) @Brecht Van Lommel (brecht)
Booleans: @Sergey Sharybin (sergey)

Recent Activity

Today

Serge Lyatin (SergeL) created T52478: Error report "Shrinkwrap: out of memory" on invisible target.
Mon, Aug 21, 1:25 PM · Modifiers, BF Blender

Fri, Aug 11

Eric Schwab (oaschwab) closed T52340: Bone Selection with OpenSubDiv Extremely slow as "Resolved".

Changing OpenGL selection to OpenGL Occlusion Queries does fix that problem. Thank you.

Fri, Aug 11, 2:05 PM · Modifiers, BF Blender
Aaron Carlisle (Blendify) triaged T52340: Bone Selection with OpenSubDiv Extremely slow as "Incomplete" priority.

Can you test if changeing the OpenGL selection method to OpenGL Occlusion Queries fixes the problem?
https://docs.blender.org/manual/en/dev/preferences/system.html#opengl

Fri, Aug 11, 5:44 AM · Modifiers, BF Blender

Mon, Jul 31

Bastien Montagne (mont29) triaged T52221: Shading difference between applied and unapplied subsurf modifier as "Confirmed" priority.

Not sure… looks like the 'sharp' status of corner vertices somehow survive the subsurf modifier (while sharp edges being totally lost)… maybe @Sergey Sharybin (sergey) will want to have a look?

Mon, Jul 31, 4:22 PM · Modifiers, BF Blender

Sat, Jul 29

Serge Lyatin (SergeL) created T52221: Shading difference between applied and unapplied subsurf modifier.
Sat, Jul 29, 10:41 PM · Modifiers, BF Blender

Fri, Jul 28

Sergey Sharybin (sergey) closed T52212: Vgroups doesn't work after Carve Boolean as "Resolved" by committing rBd41acacc61a2: Fix T52212: Vgroups doesn't work after Carve Boolean.
Fri, Jul 28, 11:56 AM · Modifiers, BF Blender
Serge Lyatin (SergeL) created T52212: Vgroups doesn't work after Carve Boolean.
Fri, Jul 28, 11:28 AM · Modifiers, BF Blender

Wed, Jul 26

LazyDodo (LazyDodo) updated subscribers of D2724: [Modifiers] Screw modifier generates doubles. .

Hmmmm… this is way too late to add anything like that in master for 2.79 now… :/

Wed, Jul 26, 4:31 PM · Modifiers
Bastien Montagne (mont29) closed T52176: Bevel doesn't correctly work with default empty Vgroup as "Resolved" by committing rB66e28a2827ab: Fix T52176: Bevel doesn't correctly work with default empty Vgroup..
Wed, Jul 26, 4:26 PM · Modifiers, BF Blender
Bastien Montagne (mont29) added a comment to T52176: Bevel doesn't correctly work with default empty Vgroup.

Note that this affect other modifiers too (shrinkwrap and simple deform at least).

Wed, Jul 26, 4:21 PM · Modifiers, BF Blender
Bastien Montagne (mont29) claimed T52176: Bevel doesn't correctly work with default empty Vgroup.

This is actually a bug in our defvert_array_find_weight_safe(), which was assuming that having a valid vgroup index but NULL vgroup data pointer was same as not having a valid vgroup index, and was returning '1.0' in both cases.

Wed, Jul 26, 4:21 PM · Modifiers, BF Blender
Bastien Montagne (mont29) closed T52178: Build modifier: frame start is working with delay as "Invalid".

Thanks for the report, but I don’t actually see a bug here - maybe some inconsistency between two rather different tools, but that’s all. Harmonizing this would be a TODO (and it would be slightly hairy too, to avoid old files suddenly starting to behave differently).

Wed, Jul 26, 4:11 PM · Modifiers, BF Blender
Bastien Montagne (mont29) requested changes to D2724: [Modifiers] Screw modifier generates doubles. .

Hmmmm… this is way too late to add anything like that in master for 2.79 now… :/

Wed, Jul 26, 3:09 PM · Modifiers
LazyDodo (LazyDodo) added a reviewer for D2724: [Modifiers] Screw modifier generates doubles. : Bastien Montagne (mont29).

It's been over month with no activity, no idea who normally does modifier code review, @Bastien Montagne (mont29) can you take a peek here?

Wed, Jul 26, 3:00 PM · Modifiers
john peterson (bliblubli) added a comment to T52163: carve boolean modifier make some files impossible to open or very unstable..

@Sergey Sharybin (sergey) T51975 shows variants of bug that pops up when this carve object is in scene. Sometime, some part of the mesh (the box containing the vegetables) was missing, sometime the textures were pink, sometime the shader got white. Most of the time hitting F12 would segfault. Sometime it succeeded, but the segfault appeared just after render finished (couldn't even save the file).
@Fable Fox (fablefox) debug builds indeed are working. Of course, replacing carve with bmesh also makes the file stable again.
To more easily the bugs and crash, you have to:

  • open with VS2013 buildbots
  • append everything in the file attached into a very complex scene (there must be something to corrupt in memory, so many shaders, lot of meshes, etc. make crash more often)
  • duplicate in place ( location may be important to trigger the bug) what you appended to make the probability of crash higher (the overflows are more likely to produce a crash if many part of memory are overwritten/corrupted, so duplicate it a hundred time if it doesn't crash)
  • then try to render, undo, etc...

This part of the scene was modeledin november last year and wasn't touched since then. The bugs and crash happened more often as scene complexity increased.

Wed, Jul 26, 2:29 PM · Modifiers, BF Blender
Sergey Sharybin (sergey) added a comment to T52163: carve boolean modifier make some files impossible to open or very unstable..

@john peterson (bliblubli), please define what exact instability is and how to reproduce it.

Wed, Jul 26, 1:38 PM · Modifiers, BF Blender
Fable Fox (fablefox) added a comment to T52163: carve boolean modifier make some files impossible to open or very unstable..

I can open it with VS 2015 build (blender-2.78-edc6bec-win64-vc14.zip). Using parameter -d. I changed the modifier type to Carve and save it.

Wed, Jul 26, 1:37 PM · Modifiers, BF Blender
john peterson (bliblubli) added a comment to T52163: carve boolean modifier make some files impossible to open or very unstable..

Note that the crash on file open is only on VS2015 release, but instability is in VS2013 = official release too. It just happens randomly during a material change or an undo or a final render start or whatever part of memory was corrupted.

Wed, Jul 26, 1:36 PM · Modifiers, BF Blender
Sergey Sharybin (sergey) assigned T52163: carve boolean modifier make some files impossible to open or very unstable. to LazyDodo (LazyDodo).

I can confirm the issue, but only happens in release build done with MSVC 2015. It doesn't even happen in RelWithDebInfo configuration, which makes it really hard to troubleshoot.

Wed, Jul 26, 12:11 PM · Modifiers, BF Blender
Sergey Sharybin (sergey) merged T51975: crash and textures artifacts in cycles (CPU and GPU) into T52163: carve boolean modifier make some files impossible to open or very unstable..
Wed, Jul 26, 12:10 PM · Modifiers, BF Blender

Mon, Jul 24

john peterson (bliblubli) merged T51975: crash and textures artifacts in cycles (CPU and GPU) into T52163: carve boolean modifier make some files impossible to open or very unstable..
Mon, Jul 24, 8:29 PM · Modifiers, BF Blender
Serge Lyatin (SergeL) created T52178: Build modifier: frame start is working with delay.
Mon, Jul 24, 8:16 PM · Modifiers, BF Blender
Serge Lyatin (SergeL) renamed T52176: Bevel doesn't correctly work with default empty Vgroup from "Bevel doesn't correctly work with default empty group" to "Bevel doesn't correctly work with default empty Vgroup".
Mon, Jul 24, 6:45 PM · Modifiers, BF Blender
Serge Lyatin (SergeL) created T52176: Bevel doesn't correctly work with default empty Vgroup.
Mon, Jul 24, 5:48 PM · Modifiers, BF Blender

Sun, Jul 23

Vuk Gardašević (lijenstina) added a project to T52163: carve boolean modifier make some files impossible to open or very unstable.: Modifiers.
Sun, Jul 23, 10:04 PM · Modifiers, BF Blender
Fable Fox (fablefox) closed T52076: Boolean. Change BMesh to Carve = crush as "Invalid".

More than a week passed without a reply.
Due to the tracker policy, archiving until the required additional information / data is provided.

Sun, Jul 23, 8:15 PM · BF Blender, Modifiers

Jul 21 2017

Amos Manneschmidt (amoose136) added a comment to T36648: Carve library fails on Boolean operations -- not robust as advertised..

I'm having many "good-in, garbage out" scenarios with carve as well where two manifold input meshes will sometimes return non manifold results. Is Carve even actively maintained? If so, where? I saw something on code.google.com where the last issue was posted 2 years ago and last release 6 years ago and a github repository that was also inactive for 7 years. For what I'm doing right now, if boolean operations were more robust I could eliminate commercial software from my workflow.

Jul 21 2017, 6:55 PM · BF Blender, Modifiers

Jul 16 2017

Bastien Montagne (mont29) triaged T52076: Boolean. Change BMesh to Carve = crush as "Incomplete" priority.

Please follow our submission template and guidelines and make a complete, valid bug report, with required info, precise description of the issue, precise steps to reproduce it, small and simple .blend and/or other files to do so if needed, etc.
Videos and/or links to external sites etc. are not acceptable as bug report (they can be provided as additional information only).

Jul 16 2017, 7:22 PM · BF Blender, Modifiers
Axel (AxelMening) removed a project from T52076: Boolean. Change BMesh to Carve = crush: BF Blender.
Jul 16 2017, 12:22 AM · BF Blender, Modifiers
Axel (AxelMening) edited the description of T52076: Boolean. Change BMesh to Carve = crush.
Jul 16 2017, 12:20 AM · BF Blender, Modifiers

Jul 3 2017

Luca Rood (LucaRood) closed T51523: Particles with disabled lattice modifier produce unclear feature as "Resolved" by committing rB56422ff6c3f3: Fix T51523: Lattice modifier affecting particles even when disabled.
Jul 3 2017, 6:05 PM · Modifiers, BF Blender

Jun 30 2017

john peterson (bliblubli) added a comment to D2724: [Modifiers] Screw modifier generates doubles. .

looks good :)

Jun 30 2017, 6:47 PM · Modifiers

Jun 29 2017

Bastien Montagne (mont29) closed T51890: Turning off viewport display for array modifier is blocking dupliface in final render as "Resolved" by committing rB0210c6b9de38: Fix T51890: Turning off viewport display for array modifier is blocking….
Jun 29 2017, 3:45 PM · Modifiers, BF Blender
Bastien Montagne (mont29) claimed T51890: Turning off viewport display for array modifier is blocking dupliface in final render.
Jun 29 2017, 3:44 PM · Modifiers, BF Blender

Jun 28 2017

matali23 (matali23) triaged T51890: Turning off viewport display for array modifier is blocking dupliface in final render as "Confirmed" priority.

I can confirm the bug

Jun 28 2017, 9:02 AM · Modifiers, BF Blender

Jun 24 2017

Serge Lyatin (SergeL) created T51890: Turning off viewport display for array modifier is blocking dupliface in final render.
Jun 24 2017, 9:13 PM · Modifiers, BF Blender
LazyDodo (LazyDodo) created D2724: [Modifiers] Screw modifier generates doubles. .
Jun 24 2017, 8:26 PM · Modifiers

Jun 23 2017

raja kedia (decoda) added a comment to T50672: Boolean modifier in bmesh solver creates random verts.

I got the problem. I am currently looking for the solution in code. For time being, you can manually select the extra vertices and press Ctrl + X to merge it in Edge. for first scenario. For second case, It will look into details.

Jun 23 2017, 1:48 PM · Modifiers, BF Blender

Jun 21 2017

Bastien Montagne (mont29) renamed T51540: Crash with Carve solver and boolean modifier on MSVC2015 builds (MSVC2013 builds are OK) from "Crash with Carve solver and boolean modifier" to "Crash with Carve solver and boolean modifier on MSVC2015 builds (MSVC2013 builds are OK)".
Jun 21 2017, 12:53 PM · Platform: Windows, Modifiers, BF Blender

Jun 8 2017

Bastien Montagne (mont29) closed T51732: Array Modifier: Fit Curve calculation method ignores parent relation as "Invalid".

Mmmh… in fact there is no bug here, even though the result may not be what one would expect off hands.

Jun 8 2017, 9:23 AM · Modifiers, BF Blender

Jun 7 2017

Karja Krähwald (karja) created T51732: Array Modifier: Fit Curve calculation method ignores parent relation.
Jun 7 2017, 10:22 AM · Modifiers, BF Blender

May 31 2017

cédric lepiller (pitiwazou) added a comment to T48583: Bevel Improvements.

Edge group for bevel could be better than vertex group

May 31 2017, 7:22 PM · Modifiers, Mesh Modeling, BF Blender
Howard Trickey (howardt) added a comment to T48583: Bevel Improvements.

Someone else requested something similar to what you suggest -- just that when some vertices get blocked, they stay there and the unblocked ones continue to move. Maybe this should be the default, but I'd like to get some kind of consensus from artists before changing. As you say, it could be an option, but there is a lot of pushback on Blender devs from Ton not to add too many options to tools, but rather make them smart enough to "do the right thing" without options.

May 31 2017, 3:28 PM · Modifiers, Mesh Modeling, BF Blender

May 29 2017

marc dion (marcclintdion) added a comment to T48583: Bevel Improvements.

I think what I'd like to see is a threshold that prevents close vertices from overlapping without blocking the movement of vertices that are far from each other. I suppose something like a weighting that diminishes the bevel effect for close vertices.
Something like in the following which shows how Edge-Slide has less impact on close vertices but a large influence on vertices with larger distances. I think this would have to be an option though since it would best suit organic or choppy shapes like rocks. It would likely be inappropriate for machined surfaces.

May 29 2017, 11:47 PM · Modifiers, Mesh Modeling, BF Blender
Bastien Montagne (mont29) added a parent task for T50165: Bmesh booleans fail on simple cube array: T47030: BMesh booleans (track todo's).
May 29 2017, 10:53 PM · Modifiers, BF Blender
Ian Bruce (ian_bruce) added a comment to T50165: Bmesh booleans fail on simple cube array.

For a much simpler testcase, apparently demonstrating a similar problem -- non-solid objects resulting from boolean intersect with BMesh -- see T51236 . Again, "Carve" produces the correct result, "BMesh" doesn't.

May 29 2017, 9:53 PM · Modifiers, BF Blender
Howard Trickey (howardt) claimed T51247: Bevel modifier: Unnecessary clamping.

The problem is that the clamping is very naive right now: just clamps to the min of the half-length of all the edges involved in a vertex bevel. In this case, that means it clamps to the half length of the vertical edge, which doesn't even have advancing vertices on it, and it is a lot shorter than the edge that the vertices move along. It is a TODO to do much smarter clamping, but I'll spend some time now to see if cases like this, at least, can be improved.

May 29 2017, 9:52 PM · Modifiers, BF Blender
Howard Trickey (howardt) raised the priority of T51247: Bevel modifier: Unnecessary clamping from "Normal" to "Confirmed".

This is different from T50994, as it is only about one edge (as reporter notes). It may overlap with one of the problems reported in T50819, premature clamping. I will look into this one now.

May 29 2017, 9:09 PM · Modifiers, BF Blender
Howard Trickey (howardt) added a comment to T48583: Bevel Improvements.

Another requested bevel clamping change. See T50994. Requester would like clamp to apply to edges individually rather than globally. Could be consider as breaking backward compatibility for 2.8. Or an option (but we dislike adding too many options).

May 29 2017, 9:06 PM · Modifiers, Mesh Modeling, BF Blender
Mathias Panzenböck (panzi) added a comment to T51621: Boolean modifier is completely broken.

But shouldn't a mesh generated by a fluid sim be closed and non-self intersecting?

May 29 2017, 4:16 PM · Modifiers, BF Blender