Thu, Jul 18
I've posted a potential fix: D5288
@Sergey Sharybin (sergey) I'm guessing this an update event is missing?
Tue, Jul 16
Sat, Jul 13
Mon, Jul 1
I'm also not a huge fan of hiding the existance of fake users in the UI. While I understand that it confuses new people (trying to avoid the term "new users" here for clarity's sake), it also "forces" them to learn about how Blender handles data in general, and what the concept of user counting is. A fake user IS a second user of a datablock, as long as there is something else referencing the datablock. Not showing that will all the more confuse all the other people who have learned about the user count system.
Fri, Jun 28
That was not an intentional change, fixed in rB8401ee24ffe6: Fix issue in Blender 2.7x mask keymap after recent changes.
@Brecht Van Lommel (brecht) @Sergey Sharybin (sergey) Thanks so much for helping out with this. It also works great! :)
I am just not so sure about line 1191. When using the 27x keymap and rightclicking on a curve point it goes directly into transform mode. This feels a bit odd, since it should just select the point. If I want to drag a curve point with RMB I can simply rightclick and drag.
So as far as we can tell, "select" + "move" is mostly there for historical reasons and "slide" is really enough. So for the Blender LMB and industry compatible keymap we can have the context menu on RMB overriding it.
Thu, Jun 27
It appears that mask.slide_point also does selection, which means putting mask.select on RMB keeps selection on LMB working.
Mon, Jun 24
I am not sure from the top of my head what is involved here, would need to check myself.
Or maybe you can try implementing that behaviour and poke me with missing bits?
@Sergey Sharybin (sergey) is there anything I can do to help here?
Sat, Jun 22
I have removed the extra class and added a poll.
While doing the poll function I figured it would make sense to make the context menu aware of if there is a mask or not, so you can create an empty new mask or add a new mask with primitive shape from the context menu.
Fri, Jun 21
Thu, Jun 20
Jun 19 2019
@Sergey Sharybin (sergey) hehe, no other pending changes at the moment, so you can apply. Thanks! :)
@Sebastian Jansson (sebastian): Do you have more pending updates, or i can apply the patch?
I noticed that the "Adjust Last Operation" checkbox was missing from the Clip Editor's View menu, so I added that.
Jun 18 2019
I have fixed some inconsistent icons and elimated some whitespace.
Jun 17 2019
Seems fine to add this back since it was not intended to be removed.
Well, somehow the closest functionality seems to be nodes, somehow. At least that is another big area where we allow selection, dragging, select-and-drag.
Shall we stick to the same rules for masking?
From implementation seems fine.
Jun 14 2019
Jun 13 2019
I know, it's a bit weird, but when select is set to select_mouse (LMB by default), there is a conflict with the tweak functionality, so when you try to slide a single mask point, you slide the entire mask.
We had 2 different select modes in 2.79 as well: left-clicking would do a select + move when dragggin, right-clicking would select as well, and, if mouse dragged, would start a transform as well. However, only with RMB you could also extend the selection by holding shift.
Jun 10 2019
Jun 8 2019
I would say Fake User is different than normal user. The UI doesn’t even use the F anymore, so to non-old-farts or developers it would not be obvious why enabling the shield icon (formerly know as F) would add a user. So, clicking the shield icon should not raise number.
I think part of the problem is, that there is not really a second user, because the Scene doesn’t really “use” it. The thing is that in this case as well as in the case of Node Groups there is no obvious way to create a second user to begin with. So I would rather not make the user count hidden at all.
It certainly is an intentional change… had to git blame to find it: rBf2132b023734 (yeah, own commit even, given the date that was most certainly a post-BConf commit after some talk with someone :| ).
@Bastien Montagne (mont29) that has always been the case though? As far back as I can remember, IDs with a User count of 1 don’t show it.
@William Reynish (billreynish) number button is hidden when there is only one user, and iirc, UI code was changed to show 'usercount-1' when Fake User is set (i.e. not consider FakeUser in user counter)? That is the issue here.
Afaik this is not an intentional change. For all normal IDs we still show the Fake User button, as well as the user count. Probably it’s just a bug that makes it not show here.
No, I don’t really have an opinion here (don’t think hiding the 'fake user' usage from UI was ever my idea, I tend to dislike hiding too much of the dirty guts of an engine to its final user, in general…).