Wed, Oct 16
Mon, Oct 14
For people who have come here from the latest Blender Today with @Pablo Vazquez (pablovazquez): The delete feature for folders will be added. It will require more changes though, since all previous versions (also back in 2.79) didn't allow to delete folders. I've got some more tasks to do, but perhaps I'm able to implement it before the Blender Conference.
Sat, Oct 12
Thu, Oct 10
@Brecht Van Lommel (brecht) thank you for testing this on macOS and noticing the error in the includes.
- Fix build error on macOS.
- Don't show confirmation popup when using Delete from the context menu.
Run some quick tests on Windows 10, worked fine, even with troublesome file paths.
Also quickly checking the Win32 code, didn't note anything obviously wrong.
It would be great if the patch could be thoroughly tested on all platforms, especially on macOS because I don't have Apple hardware. Any feedback is appreciated.
Wed, Oct 9
Well, setting up all that polling and messaging between slave_pack.py and the signing machine is what then needs to be set up and tested. With the buildbot we have already something that is tested and working with certainty, without having to write custom code that can fail.
slave_pack.py can copy files to some folder, and the signing VM can poll that folder for any files to be signed. Accessing that shared folder can be done through SSH, or whatever is the most convenient way to share files between two virtual machines running on the same host.
Oh, I see. the patch I uploaded doesn't have all necessary changes, the scheduler bit is missing at least. Let me upload an updated patch in a bit.
After receiving the uploaded build zip blender-buildbot master writes the contained zipfile package name to the file zipname of the blendersigner.git repository and pushes that change.
Tue, Oct 8
Can you explain how these pieces fit together? It's not clear to me how starting a build on the main buildbot would trigger work on the signing buildbot, or how files get passed around.
nvm about the size increase of blender.exe - I was looking in the wrong places and comparing the wrong numbers. Size increase of a few kb is what actually happens and is expected.
Executable shouldn't increase dramatically, i ran a quick local test with a self signed cert
It took a while to prepare the patches to form a more cohesive whole. No doubt it can be improved upon.
Mon, Oct 7
The current delete_soft() implementation would allow to delete directories as well. There are adjustments necessary to the way BLI_delete_soft() is called, which is why I'd like to put that in a separate diff.
Updated the description of FILE_OT_delete.
Works fine on Sway now :) I'd also say the Linux implementation is ready. We could try to run gio first, and only check for the KDE variant if that fails, but in practice it probably doesn't make a difference.
Fixed errors in previous update.
There are errors in the latest diff update. They will be fixed in about an hour.
Patch for the error messages and slightly different error handling. It still needs to be tested, especially on Linux and macOS.
I've got another patch update for the error messages, but I'm unsure how useful it actually is. Besides Windows, there are very few extra information we can give to the user on macOS and Linux. The main benefit on Linux is that we can check when the exec failed hard, indicating that there is no gio available.
Sun, Oct 6
Integration into the new file browser.
Fri, Oct 4
Removed duplicate entry for the backspace key and made small adjustments to the soft delete function for Linux.
Thu, Oct 3
Wed, Oct 2
Tue, Oct 1
Mon, Sep 30
I'm currently on a very tight time budget, because I have to complete a university project. I'll try to squeeze this in, but can't make any promises. Believe me when I say I'd rather work on this than the other project. If I can't get it done in time, feel free to take over this revision.
I'd like to get this in for 2.81, it makes sense with the recent file browser changes. You've picked a nice but tricky task, given that this is so OS dependent :)
Rebase patch on latest master
Wed, Sep 25
I think this is all done now.
I think this is all done.
This is resolved by rB50ad4428ac76: Windows/MSI: Rework MSI installer., for the upcoming 2.81 release.