BF Blender: RegressionsProject
ActivePublic

Details

Description

2.79 Release

Project to tag bugs that are release blockers and other tasks that are planned to be included in the upcoming Blender release.

Revisions to be ported to the release branch
(range XXXX..XXXX, sorted in order of cherry-pick)


For 2.79rc3/release

SHA1XXX
SHA1XXX

From @Campbell Barton (campbellbarton) in range (2ff9c8a3bc51142a1d7ad19d8b772b58e4dcc890..3789ab4166c40d254ab1cf9f07d429730650efdb)

  • 2ff9c8a3bc51142a1d7ad19d8b772b58e4dcc890
  • f6825d333bfe2d58227e5e7421cd8719d89cd59a
  • 361c7cbbc57720db3b04698c7e45fe72297e2b24 & 592dd9dea6aa6e8f954e7604b497bdd9c2387e21
  • f09dee5aed35ede00bdbaedba171ce24edf5e0b0
  • 46b9f89f5e46109ea811ccf474acb09616e7c33b
  • b8d77c44f112cae1e98308ff33ce055ea4fb46ff
  • 55861cb2346bdb4b1346c6999b99ff00f27e7d4b
  • 3277bd4031d08f750526168a50e1856d2936cf69
  • 76d695f7611dfe3f2560525771399008f0bf9f40 & 0b5b464e823660f4ce47107d63004e762372122e & e47629808404cd03019ed6de2c5d6fd5307630fa
  • fa365d5f2f9d2e4bbe0b5c7800093723c7d09de6
  • b6b27b067113184093c3023ac7c9bf9a6ad5914b & b07dcb8fb06f622c8521878df6cbef01d98d6cc4
  • 0b5cabdca5dfcc61bb06b0edc1a55c44d041b615
  • cb7f1f8160606e92a4f6d216f03254e870b8eca6
  • 2ca1f297486804dcdb90c376e68dce656a73c726
  • 3750389ce3f3b6b386986c33608d6aed348e6f7e ???

From @Joerg Mueller (nexyon)


Candidates for review:

Recent Activity

Sat, Dec 2

Brecht Van Lommel (brecht) added a commit to T53349: Cycles - difference between OpenCL and CUDA with AO simplify: rCaf120f146aaf: Fix T53349: AO bounces not working correct with OpenCL.
Sat, Dec 2, 6:11 AM · BF Blender: Regressions, Cycles

Sun, Nov 26

Brecht Van Lommel (brecht) closed T53349: Cycles - difference between OpenCL and CUDA with AO simplify as Resolved by committing rB83e80db56ec9: Fix T53349: AO bounces not working correct with OpenCL..
Sun, Nov 26, 4:00 PM · BF Blender: Regressions, Cycles
mathieu menuet (bliblubli) added a comment to T53349: Cycles - difference between OpenCL and CUDA with AO simplify.

@Brecht Van Lommel (brecht) I don't have commit rights, could you commit it please?

Sun, Nov 26, 9:57 AM · BF Blender: Regressions, Cycles

Sat, Nov 25

mathieu menuet (bliblubli) added a comment to T53349: Cycles - difference between OpenCL and CUDA with AO simplify.

here is the fix

Sat, Nov 25, 9:32 AM · BF Blender: Regressions, Cycles

Tue, Nov 21

Mai Lavelle (maiself) reassigned T53349: Cycles - difference between OpenCL and CUDA with AO simplify from Mai Lavelle (maiself) to Brecht Van Lommel (brecht).
Tue, Nov 21, 9:21 AM · BF Blender: Regressions, Cycles

Mon, Nov 20

Bastien Montagne (mont29) assigned T53349: Cycles - difference between OpenCL and CUDA with AO simplify to Mai Lavelle (maiself).

@Mai Lavelle (maiself), think that one is for you? Thanks. :)

Mon, Nov 20, 8:38 AM · BF Blender: Regressions, Cycles

Sun, Nov 19

mathieu menuet (bliblubli) updated the task description for T53349: Cycles - difference between OpenCL and CUDA with AO simplify.
Sun, Nov 19, 5:37 PM · BF Blender: Regressions, Cycles
mathieu menuet (bliblubli) updated the task description for T53349: Cycles - difference between OpenCL and CUDA with AO simplify.
Sun, Nov 19, 5:24 PM · BF Blender: Regressions, Cycles

Nov 6 2017

Brecht Van Lommel (brecht) added a comment to T53249: [regression] OpenCL performance becomes very random with big scenes..

Ok, if the code was modified then indeed a new log would be useful.

Nov 6 2017, 4:44 PM · BF Blender, Cycles
mathieu menuet (bliblubli) updated subscribers of T53249: [regression] OpenCL performance becomes very random with big scenes..
Nov 6 2017, 4:28 PM · BF Blender, Cycles
mathieu menuet (bliblubli) added a comment to T53249: [regression] OpenCL performance becomes very random with big scenes..

Where is the "Free mem AMD" print coming from? I can't find that code in master or earlier revisions. In master, the split kernel global size is determined by max_buffer_size and num_elements, which from the logs don't appear to change. Yet the global size is reported as being different.

Yes, I used another version to get the free memory reported and tried to see if limiting global size to make it all fit in memory would solve the problem, but it didn't. I can redo the log with vanilla master if you want. Here is the code:

Nov 6 2017, 2:25 PM · BF Blender, Cycles
Brecht Van Lommel (brecht) added a comment to T53249: [regression] OpenCL performance becomes very random with big scenes..

Where is the "Free mem AMD" print coming from? I can't find that code in master or earlier revisions. In master, the split kernel global size is determined by max_buffer_size and num_elements, which from the logs don't appear to change. Yet the global size is reported as being different.

Nov 6 2017, 12:47 PM · BF Blender, Cycles
mathieu menuet (bliblubli) added a comment to T53249: [regression] OpenCL performance becomes very random with big scenes..

@Brecht Van Lommel (brecht) thanks for P555 . Tried it but bug is still there.

Nov 6 2017, 10:24 AM · BF Blender, Cycles
mathieu menuet (bliblubli) added a comment to T53249: [regression] OpenCL performance becomes very random with big scenes..

@LazyDodo (LazyDodo) the GPU-Z log is wrong somehow, it ignores half of the memory. But it gives the impression that no memory leak happens on the GPU.

Nov 6 2017, 8:38 AM · BF Blender, Cycles
Brecht Van Lommel (brecht) added a comment to T53249: [regression] OpenCL performance becomes very random with big scenes..

Thanks for the tests! To be clear I'm not expecting anyone to work on this bug, and if no one else does I'll probably do it at some point, but the work is certainly helpful.

Nov 6 2017, 12:38 AM · BF Blender, Cycles

Nov 5 2017

LazyDodo (LazyDodo) added a comment to T53249: [regression] OpenCL performance becomes very random with big scenes..

Could be interesting to look at the output of gpu-z to see what the cards actual memory is doing in between those two runs.

Nov 5 2017, 8:34 PM · BF Blender, Cycles
mathieu menuet (bliblubli) added a comment to T53249: [regression] OpenCL performance becomes very random with big scenes..

actually, 2.79 has the bug, only the official one had the device selection bug and took the 1080Ti instead, which doesn't use system memory.
So it may be a driver bug, but then why is the first render always 30sec?
After some renders, I got up to 114seconds to render = nearly 3x slower... At this point however, the GPU was idling a lot, maybe waiting all the time for system memory access?
Here is a picture of the task manager with 2 consecutive renders on the same instance of Blender.


It may be a coincidence, but VS2013 builds had only +/-10% between first and consecutive renders (made 5 of them) while VS2015 builds go crazy with up to 3x the render time.
If someone could test on Linux with a RX480 to see if GCC or the Linux driver handles this differently. As said before, the RX480 can render this scene. On Linux, the Nvidia drivers destroy a part of the AMD driver and I couldn't find a solution to have both drivers side by side yet.

Nov 5 2017, 8:30 PM · BF Blender, Cycles
mathieu menuet (bliblubli) added a comment to T53249: [regression] OpenCL performance becomes very random with big scenes..

commit b53e35c655d4 already has the bug, so it's not due to the buffer patch.

Nov 5 2017, 6:44 PM · BF Blender, Cycles

Nov 4 2017

mathieu menuet (bliblubli) added a comment to T53249: [regression] OpenCL performance becomes very random with big scenes..

got some explanations on IRC, sorry I didn't know the whole story.

Nov 4 2017, 9:02 PM · BF Blender, Cycles
mathieu menuet (bliblubli) added a comment to T53249: [regression] OpenCL performance becomes very random with big scenes..
Nov 4 2017, 8:19 PM · BF Blender, Cycles
mathieu menuet (bliblubli) added a comment to T53249: [regression] OpenCL performance becomes very random with big scenes..

the bug was already there 24.08.2017, so my guess is that rBec8ae4d5e9f7 is the commit we look for.

Nov 4 2017, 8:15 PM · BF Blender, Cycles
mathieu menuet (bliblubli) added a comment to T53249: [regression] OpenCL performance becomes very random with big scenes..

just to give an idea of the mess to bisect:

  • cuda disables completly opencl in the majority of revision, so you have to rebuild without cuda
  • device selection changed, so userpref have to be modified depending on the revision you test and bisecting requires to go back and forth in time.
  • kernel compilation takes 1min50 for victor
  • scene preparation takes 2min04

so it takes about 5minutes of VS compile, then manual tweaks for user pref, then 2minute kernel compile+ then 2 renders at 2 (scene preps)+2(render)=8minutes of rendering. That's a quarter of an hour with 4 user intervention between which you can't do much.

Nov 4 2017, 7:59 PM · BF Blender, Cycles
mathieu menuet (bliblubli) added a comment to T53249: [regression] OpenCL performance becomes very random with big scenes..

rBec8ae4d5e9f7 only added support for more than 4GB of textures iirc.
You don't need HBCC support. On win7, even on Vega, there is no HBCC and my RX480 also renders full victor scene since a year on windows and since some months on Linux.
@Brecht Van Lommel (brecht) Is there a simple command to disable the context caching?
I could try to bisect, but @Mai Lavelle (maiself) should have better guesses of what could have introduced this bug. The scene preparation of Victor takes more than 2 minutes on my computer. With compile time on windows on top, shooting in the dark to bisect would take a lot of time.

Nov 4 2017, 7:27 PM · BF Blender, Cycles
Brecht Van Lommel (brecht) triaged T53249: [regression] OpenCL performance becomes very random with big scenes. as Normal priority.

I thought Victor only rendered on AMD after rBec8ae4d, not yet in the 2.79 release?

Nov 4 2017, 6:27 PM · BF Blender, Cycles
mathieu menuet (bliblubli) edited projects for T53249: [regression] OpenCL performance becomes very random with big scenes., added: Cycles, BF Blender: Regressions; removed BF Blender.
Nov 4 2017, 9:49 AM · BF Blender, Cycles

Nov 3 2017

Brecht Van Lommel (brecht) merged T53192: Cycles produces render artifacts on a large plane into T43865: Cycles: Watertight rendering produces artifacts on a huge plane.
Nov 3 2017, 10:35 AM · BF Blender: Regressions, Cycles, BF Blender

Oct 31 2017

Sergey Sharybin (sergey) added a commit to T52368: OSL trace not working in 2.79 RC!: rC5f0915591600: Fix T52368: Cycles OSL trace() failing on Windows 32 bit.
Oct 31 2017, 4:36 PM · Cycles, BF Blender: Regressions, BF Blender
Bastien Montagne (mont29) raised the priority of T52916: Normal map works weird with multiple UV layouts in BI 2.79 from Incomplete to Normal.
Oct 31 2017, 3:58 PM · BF Blender: Regressions, BF Blender

Oct 9 2017

ronan ducluzeau (zeauro) triaged T53032: Image sequence works bad with Displace modifier as Confirmed priority.

I can confirm that there is a problem, here.
I had to open an Image Editor, modify Number of frames, Start Frame settings and enable autorefresh into Image Properties.

Oct 9 2017, 12:04 PM · Images & Movies, Rendering, BF Blender: Regressions, Modifiers, BF Blender
Serge Lyatin (SergeL) created T53032: Image sequence works bad with Displace modifier.
Oct 9 2017, 9:59 AM · Images & Movies, Rendering, BF Blender: Regressions, Modifiers, BF Blender

Oct 7 2017

Serge Lyatin (SergeL) updated the task description for T52916: Normal map works weird with multiple UV layouts in BI 2.79.
Oct 7 2017, 9:57 AM · BF Blender: Regressions, BF Blender
Serge Lyatin (SergeL) added a comment to T52916: Normal map works weird with multiple UV layouts in BI 2.79.
  1. For default cube create UV as default smart unwrap
  2. Then create second UV, which is different (in my case every face is occupying all UV space)
  3. Add normal map to material and choose second UV for mapping
  4. Now render viewport with first then second UV map set as active in mesh data tab and see the difference
Oct 7 2017, 9:57 AM · BF Blender: Regressions, BF Blender

Oct 6 2017

LazyDodo (LazyDodo) triaged T52916: Normal map works weird with multiple UV layouts in BI 2.79 as Incomplete priority.

I'm not sure how to repro this one, can you post more detailed steps?

Oct 6 2017, 11:08 PM · BF Blender: Regressions, BF Blender

Sep 26 2017

Serge Lyatin (SergeL) created T52916: Normal map works weird with multiple UV layouts in BI 2.79.
Sep 26 2017, 11:57 PM · BF Blender: Regressions, BF Blender

Sep 20 2017

Brecht Van Lommel (brecht) added a commit to T52368: OSL trace not working in 2.79 RC!: rB18a353dd2422: Fix T52368: Cycles OSL trace() failing on Windows 32 bit..
Sep 20 2017, 8:01 PM · Cycles, BF Blender: Regressions, BF Blender

Sep 5 2017

Sergej Reich (sergof) closed T52374: Changes of rigid body related settings during simulation will break the simulation (worked in 2.78c) as Resolved by committing rB4ad5df885820: Fix T52374: Changes of rigid body related settings during simulation will break….
Sep 5 2017, 8:00 PM · BF Blender: Regressions, BF Blender
Sergej Reich (sergof) added a comment to T52434: Setting origin to Center of Mass on zero-volume objects produces wrong results now in 2.79.

So I really don't like this.
Setting the origin already has too many options, when is "Origin to Geometry" ever actually useful, especially since we have the "Center of Mass" option.
If anything we should remove the "Geometry" option.
This is not a trivial matter as well, in the past I had several users being confused by this.

Sep 5 2017, 4:50 PM · BF Blender: Regressions, BF Blender
Kai Kostack (kaikostack) added a comment to T52374: Changes of rigid body related settings during simulation will break the simulation (worked in 2.78c).

The issue seems to be solved by this patch. Thanks for taking care of it.

Sep 5 2017, 1:29 PM · BF Blender: Regressions, BF Blender
Sergej Reich (sergof) added a comment to T52374: Changes of rigid body related settings during simulation will break the simulation (worked in 2.78c).

Also found another bug unrelated to this which was introduced after 2.78 and is in the RC (baking is broken).
Will look into it later today.

Sep 5 2017, 7:53 AM · BF Blender: Regressions, BF Blender
Sergej Reich (sergof) added a comment to T52374: Changes of rigid body related settings during simulation will break the simulation (worked in 2.78c).

Can someone test this patch to make sure it fixes this and T50230 before I commit?

Sep 5 2017, 7:21 AM · BF Blender: Regressions, BF Blender

Sep 4 2017

Satoshi Yamasaki (yamyam) added a comment to T52522: VSE renders with alpha transparent PNG image incorrectly.

Thank you guys!

Sep 4 2017, 2:52 PM · BF Blender: Regressions, Video Sequencer, BF Blender
Sergey Sharybin (sergey) closed T52522: VSE renders with alpha transparent PNG image incorrectly as Resolved by committing rB71f0c32dad84: Fix T52522: VSE renders with alpha transparent PNG image incorrectly.
Sep 4 2017, 2:47 PM · BF Blender: Regressions, Video Sequencer, BF Blender
Campbell Barton (campbellbarton) edited Description on BF Blender: Regressions.
Sep 4 2017, 12:55 PM
Campbell Barton (campbellbarton) edited Description on BF Blender: Regressions.
Sep 4 2017, 12:48 PM
Campbell Barton (campbellbarton) edited Description on BF Blender: Regressions.
Sep 4 2017, 12:47 PM
Campbell Barton (campbellbarton) edited Description on BF Blender: Regressions.
Sep 4 2017, 12:15 PM
Kai Kostack (kaikostack) added a comment to T52374: Changes of rigid body related settings during simulation will break the simulation (worked in 2.78c).

Hey @Luca Rood (LucaRood), if there is no further fix to be expected, can you revert the changes leading to this serious issue now for the release please?

Sep 4 2017, 8:40 AM · BF Blender: Regressions, BF Blender

Sep 1 2017

Campbell Barton (campbellbarton) edited Description on BF Blender: Regressions.
Sep 1 2017, 1:59 PM
Campbell Barton (campbellbarton) edited Description on BF Blender: Regressions.
Sep 1 2017, 1:59 PM
Joerg Mueller (nexyon) edited Description on BF Blender: Regressions.
Sep 1 2017, 12:45 PM