Page MenuHome

CompositingProject
ActivePublic

Details

Recent Activity

Thu, Feb 14

Philipp Oeser (lichtwerk) closed T61520: Incorrect assignment of layers to compositor nodes in 2.8 when reading 2.79 .blend as Resolved by committing rB87bba05d25e0: Fix T61520: Incorrect assignment of layers to compositor nodes in 2.8 when….
Thu, Feb 14, 2:01 PM · BF Blender: 2.8, Compositing, BF Blender
Philipp Oeser (lichtwerk) added a project to T61520: Incorrect assignment of layers to compositor nodes in 2.8 when reading 2.79 .blend: BF Blender: 2.8.
Thu, Feb 14, 1:14 PM · BF Blender: 2.8, Compositing, BF Blender
Philipp Oeser (lichtwerk) removed a project from T61520: Incorrect assignment of layers to compositor nodes in 2.8 when reading 2.79 .blend: BF Blender: 2.8.
Thu, Feb 14, 1:13 PM · BF Blender: 2.8, Compositing, BF Blender
Philipp Oeser (lichtwerk) added a project to T61520: Incorrect assignment of layers to compositor nodes in 2.8 when reading 2.79 .blend: BF Blender: 2.8.
Thu, Feb 14, 1:13 PM · BF Blender: 2.8, Compositing, BF Blender
Philipp Oeser (lichtwerk) assigned T61520: Incorrect assignment of layers to compositor nodes in 2.8 when reading 2.79 .blend to Brecht Van Lommel (brecht).
Thu, Feb 14, 1:11 PM · BF Blender: 2.8, Compositing, BF Blender
Philipp Oeser (lichtwerk) added a comment to T61520: Incorrect assignment of layers to compositor nodes in 2.8 when reading 2.79 .blend.

Looks like this is caused by adding a vanilla "Viewport" viewlayer and making it the first in the list here
(special case in do_version_layers_to_collections() if there are layer overrides...)

/* Make it first in the list. */
BLI_remlink(&scene->view_layers, view_layer);
BLI_addhead(&scene->view_layers, view_layer);
Thu, Feb 14, 1:11 PM · BF Blender: 2.8, Compositing, BF Blender
Philipp Oeser (lichtwerk) added a revision to T61520: Incorrect assignment of layers to compositor nodes in 2.8 when reading 2.79 .blend: D4352: Fix T61520: Incorrect assignment of layers to compositor nodes in 2.8 when reading 2.79 .blend.
Thu, Feb 14, 1:10 PM · BF Blender: 2.8, Compositing, BF Blender
Philipp Oeser (lichtwerk) edited projects for T61520: Incorrect assignment of layers to compositor nodes in 2.8 when reading 2.79 .blend, added: Compositing; removed BF Blender: 2.8.
Thu, Feb 14, 9:24 AM · BF Blender: 2.8, Compositing, BF Blender

Wed, Feb 13

Marco G (marcog) added a comment to D4304: Compositor: Added denoising node.

Nice tests @Malte S (pandrodor), i also had issues with Albedo pass being in the wrong range for some objects in my scenes and they turned white , I used the same fix as you did but isn't the Mix node unnecessary? I got same results with just the Greater Than node and the Color Subtract.

Wed, Feb 13, 1:11 AM · Compositing

Tue, Feb 12

Malte S (pandrodor) added a comment to D4304: Compositor: Added denoising node.

OIDN does work with Animations and it also works with high sample renders. The bug I showed earlier was rendered with just 4 samples just to make the point very clear.
This setup is a simple fix for the wrong “Denoising Albedo” pass:


@derek barker (lordodin) You should try this setup. It should fix the areas where no denoising is happening and improves the texture sharpness.

Tue, Feb 12, 11:10 PM · Compositing
Attila Afra (aafra) added a comment to D4304: Compositor: Added denoising node.

Ive been testing with denoising the light passes instead of the images and it does a significantly better job keeping the texture data.

Tue, Feb 12, 2:30 PM · Compositing
Juan Gea (juang3d) added a comment to D4304: Compositor: Added denoising node.

Ive been testing with denoising the light passes instead of the images and it does a significantly better job keeping the texture data.

Look two posts above. There's a bug that causes textures to get too blurry.

Tue, Feb 12, 11:55 AM · Compositing
Ludvik Koutny (rawalanche) added a comment to D4304: Compositor: Added denoising node.

Ive been testing with denoising the light passes instead of the images and it does a significantly better job keeping the texture data.

Tue, Feb 12, 10:12 AM · Compositing
Adam Friesen (ace_dragon) added a comment to D4304: Compositor: Added denoising node.

In defense of the built-in Cycles denoiser, one needs to take into account the fact that it produces markedly better results on a noticeably noisy image when Branched Path Tracing is used instead of normal Path Tracing (especially in areas like highlights and reflections). There have also been improvements in recent 2.8 builds as indicated by the pass data.

Tue, Feb 12, 1:29 AM · Compositing
derek barker (lordodin) added a comment to D4304: Compositor: Added denoising node.

Ive been testing with denoising the light passes instead of the images and it does a significantly better job keeping the texture data.

Tue, Feb 12, 12:47 AM · Compositing

Mon, Feb 11

Brecht Van Lommel (brecht) merged task T54465: Color Sample From Second Monitor Always Return Black Color into T58162: Object/color picker only works within the same window.
Mon, Feb 11, 3:17 PM · Compositing, BF Blender
vasfi (vgumus) added a comment to T54465: Color Sample From Second Monitor Always Return Black Color.

Yes I checked out in 2.8;. It is still an issue. Eyedropper cannot sample from second window. Returns always black.

Mon, Feb 11, 3:00 PM · Compositing, BF Blender
Sebastian Parborg (zeddb) assigned T54716: Corner Pin adds blur to an input image? to Jeroen Bakker (jbakker).
Mon, Feb 11, 12:42 PM · Compositing, BF Blender
Yevgeny Makarov (jenkm) added a comment to T54716: Corner Pin adds blur to an input image?.

Mon, Feb 11, 12:31 PM · Compositing, BF Blender
Sebastian Parborg (zeddb) triaged T54716: Corner Pin adds blur to an input image? as Needs Information from User priority.

Can you attach a simple .blend with that setup? Don't forget to pack the image.

Mon, Feb 11, 12:11 PM · Compositing, BF Blender

Sat, Feb 9

Juan Gea (juang3d) added a comment to D4304: Compositor: Added denoising node.

I tired this on a Theory Studios build and it is amazing!

Sat, Feb 9, 9:14 PM · Compositing
Malte S (pandrodor) added a comment to D4304: Compositor: Added denoising node.

I think I found a Bug in the current Implementation.
The Denoising Albedo pass contains the Texture data in the value range from 1-2, resulting in blurry textures.
If I manually subtract 1 for every channel, the Image is much sharper.
However, it appears that metal colors are stored in the range of 0-1, just subtracting by one may not be the final solution.
Here is an example render with 4 Samples:

Sat, Feb 9, 4:47 AM · Compositing

Wed, Feb 6

Sebastian Parborg (zeddb) triaged T54465: Color Sample From Second Monitor Always Return Black Color as Needs Information from User priority.

Is this still an issue with 2.8? https://builder.blender.org/download/

Wed, Feb 6, 2:20 PM · Compositing, BF Blender
Marco G (marcog) added a comment to D4304: Compositor: Added denoising node.

Luxcore team is experimenting the integration with Intel OIDN. Keep in mind their previous Bayesian denoiser was overblurring everything (and was much inferior compared to Cycles one), though the test shows the OIDN could do well with higher samplecounts too.

Wed, Feb 6, 1:57 PM · Compositing
Ludvik Koutny (rawalanche) added a comment to D4304: Compositor: Added denoising node.

Here some comparisons at higher sample counts, with hair, SSS, depth of field and motion blur.
11_01_A.lighting.flamenco, 50% resolution, 1024 AA samples.

Could you please also post 256 sample results, or something like that? It will be much better at showing how inferior Cycles denoiser is to OIDN :)

Wed, Feb 6, 1:20 PM · Compositing
Stefan Werner (swerner) added a comment to D4304: Compositor: Added denoising node.

Here some comparisons at higher sample counts, with hair and motion blur.
11_01_A.lighting.flamenco, 50% resolution, 1024 AA samples.

Wed, Feb 6, 12:44 PM · Compositing
derek barker (lordodin) added a comment to D4304: Compositor: Added denoising node.

One thing no one is bringing up is the built in cycles denoiser isn't worth turning on half the time because the amount of time and overhead it adds you can do twice as many samples. We had a 4k render recently take over a minute longer with the denoiser on vs 4x the samples.

Wed, Feb 6, 7:58 AM · Compositing

Tue, Feb 5

Stefan Werner (swerner) added a comment to D4304: Compositor: Added denoising node.

You need to be careful when looking at test posted in various forums - naturally, OIDN shows a big quality difference between with and without normal/albedo passes. The HDR option also makes a significant difference, when it's turned off it is much more aggressive at blurring bright areas.

Tue, Feb 5, 9:18 PM · Compositing
Lukas Stockner (lukasstockner97) added a comment to D4304: Compositor: Added denoising node.

Regarding integrating the Cycles denoiser into the Compositor node: I'm not sure how we would implement that - the animation denoiser patch adds support for standalone denoising, but we'd still need to call that from Blender somehow, and adding a function to the Renderer API specifically for that seems far from ideal as well.

Tue, Feb 5, 8:04 PM · Compositing
Brecht Van Lommel (brecht) added a comment to D4304: Compositor: Added denoising node.

Right, the comparisons in that thread show that OpenImageDenoise is better at low sample counts and that makes it valuable.

Tue, Feb 5, 5:42 PM · Compositing
Marco G (marcog) added a comment to D4304: Compositor: Added denoising node.

Agree with @Ludvik Koutny (rawalanche)

Tue, Feb 5, 5:24 PM · Compositing
Stefan Werner (swerner) updated the diff for D4304: Compositor: Added denoising node.
  • Fixed code style.
  • Cleanup in denoiser compositing node.
Tue, Feb 5, 3:34 PM · Compositing
Brecht Van Lommel (brecht) added a comment to D4304: Compositor: Added denoising node.

It's the job of the developer submitting the new code or the users to demonstrate the new denoiser is better, not the other way around. So I would love to see some test renders with this patch.

Tue, Feb 5, 1:42 PM · Compositing
Ludvik Koutny (rawalanche) added a comment to D4304: Compositor: Added denoising node.

I'm not sure whether it's just an experiment or what, but i am not convinced in this.

Even keeping specific implementation aside, the OpenImagheDenoise fails in a simple scenes, and does almost nothing on our production shots.

I also don't think we should be having more denoising algorithm is a great idea. Better to make Cycles' denoiser available in compositor. So then we can always replicate final F12 result when only having multilayer EXR.

Tue, Feb 5, 11:47 AM · Compositing
Sergey Sharybin (sergey) requested changes to D4304: Compositor: Added denoising node.

I'm not sure whether it's just an experiment or what, but i am not convinced in this.

Tue, Feb 5, 9:59 AM · Compositing

Mon, Feb 4

Stefan Werner (swerner) added a project to D4304: Compositor: Added denoising node: Compositing.
Mon, Feb 4, 10:45 PM · Compositing

Mon, Jan 28

Brecht Van Lommel (brecht) added a comment to T60444: Blender compositor seperate and combine rgba yields different image..

For input you can set the image colorspace to Non-Color. For output you can write EXR files, which will not do any changes to the data. There is no support for writing Non-Color data TGA Files.

Mon, Jan 28, 7:04 PM · Compositing, BF Blender
Daniel Holst (NotHolst) added a comment to T60444: Blender compositor seperate and combine rgba yields different image..

So what you're getting at is that it isn't possible to store different information in R, G, B, and A channels.
In terms of VFX in the real-time industry this is very much a needed feature, since you often need textures containing non-color data

Mon, Jan 28, 6:35 PM · Compositing, BF Blender
Brecht Van Lommel (brecht) closed T60444: Blender compositor seperate and combine rgba yields different image. as Archived.

It appears that the application you are using to view the image is ignoring the alpha channel. If the alpha channel is taken into account the image should appear correctly.

Mon, Jan 28, 2:24 PM · Compositing, BF Blender
Sebastian Parborg (zeddb) reopened T60444: Blender compositor seperate and combine rgba yields different image. as "Open".

Actually, this might be a issue with alpha channels.

Mon, Jan 28, 2:17 PM · Compositing, BF Blender
Daniel Holst (NotHolst) added a comment to T60444: Blender compositor seperate and combine rgba yields different image..

Is there any possible workaround i could use as of now ?

Mon, Jan 28, 1:01 PM · Compositing, BF Blender
Sebastian Parborg (zeddb) closed T60444: Blender compositor seperate and combine rgba yields different image. as Invalid.

This is not because of the split node (at least that didn't matter in my tests).

Mon, Jan 28, 12:12 PM · Compositing, BF Blender
Brecht Van Lommel (brecht) assigned T60940: Compositor RGB Curves artefacts with 'film like' option to Jeroen Bakker (jbakker).
Mon, Jan 28, 7:58 AM · Compositing, BF Blender
Paul R (intracube) updated the task description for T60940: Compositor RGB Curves artefacts with 'film like' option.
Mon, Jan 28, 4:49 AM · Compositing, BF Blender
Paul R (intracube) added a project to T60940: Compositor RGB Curves artefacts with 'film like' option: Compositing.
Mon, Jan 28, 1:53 AM · Compositing, BF Blender

Sun, Jan 27

Troy Sobotka (sobotka) added a comment to D3638: Compositor: Film-like curve.
Sun, Jan 27, 5:34 PM · Video Sequencer, Compositing

Wed, Jan 23

Philipp Oeser (lichtwerk) closed T59939: Masks not Animating in Render as Resolved by committing rBdb78a8ee2e8c: Fix T59939: Masks not Animating in Render.
Wed, Jan 23, 3:16 PM · Masking, Compositing, BF Blender
Sergey Sharybin (sergey) closed T56877: Masking: Enabling Motion Blur overrides the Feather Falloff as Resolved by committing rB44e9fe024bba: Fix T56877: Enabling mask Motion Blur overrides the Feather Falloff.
Wed, Jan 23, 1:06 PM · Masking, Compositing, BF Blender

Tue, Jan 22

Sergey Sharybin (sergey) reassigned T59939: Masks not Animating in Render from Sergey Sharybin (sergey) to Philipp Oeser (lichtwerk).

@Philipp Oeser (lichtwerk), read the comment in the patch. Think is better to solve the issue with such a workaround for now than to keep this being broken. Assigning to you so you can fully tackle it from now.

Tue, Jan 22, 4:14 PM · Masking, Compositing, BF Blender

Jan 18 2019

Lukas Stockner (lukasstockner97) closed T56799: "Save Buffers" doesn't allow saving the volume passes as Resolved by committing rBc9eef2490347: Fix T56799: Custom render passes missing when using Save Buffers.
Jan 18 2019, 1:27 AM · Compositing, Cycles, BF Blender