CompositingProject
ActivePublic

Recent Activity

Tue, Jan 16

Brecht Van Lommel (brecht) triaged T53790: Design Doc: Sample based compositor as Normal priority.
Tue, Jan 16, 4:46 AM · Compositing, BF Blender
Brecht Van Lommel (brecht) added a comment to T53790: Design Doc: Sample based compositor.

So if I understand this correctly, the idea is to handle one sample at a time, using Monte Carlo sampling for operations like blur. The advantage of that is that it simplifies the implementation, as every sample can be handled individually, in a single kernel execution. As a result it may also be easier to optimize than a more complicated implementation that theoretically could be faster but isn't. It also naturally provides a progressive preview. "Monte Carlo compositing" is a very interesting idea and I hadn't realised this was the plan.

Tue, Jan 16, 4:46 AM · Compositing, BF Blender

Mon, Jan 15

Michael P. (forest-house) added a comment to T53790: Design Doc: Sample based compositor.

So the user can add a viewport "object" to the scene, which is a image buffer "dump":

  1. buffer of a input node (image, movie, etc.)?
  2. buffer of a texture node?
  3. buffer of an output node, i.e. a different compositing output?
  4. buffer of another scene (OpenGL / Eevee / Cycles Render)?
Mon, Jan 15, 11:28 PM · Compositing, BF Blender
Aaron Carlisle (Blendify) added a comment to D3003: PoC: Sample based compositor.

Please don't remove whitespace it makes looking for real changes and nightmare

Mon, Jan 15, 10:56 PM · BF Blender: 2.8, Compositing
Francesco Siddi (fsiddi) added a comment to D3003: PoC: Sample based compositor.

Very interesting! I checked it out (both compositor-2106 and compositor-2016-macosand on macOS it simply crashes after basic interaction (plugging in a viewer node). Attached you find some logs, I hope it helps.

Mon, Jan 15, 3:21 PM · BF Blender: 2.8, Compositing
Jeroen Bakker (jbakker) updated the summary of D3003: PoC: Sample based compositor.
Mon, Jan 15, 2:29 PM · BF Blender: 2.8, Compositing
Jeroen Bakker (jbakker) retitled D3003: PoC: Sample based compositor from Design Doc: Sample based compositor to PoC: Sample based compositor.
Mon, Jan 15, 2:20 PM · BF Blender: 2.8, Compositing
Jeroen Bakker (jbakker) added a task to D3003: PoC: Sample based compositor: T53790: Design Doc: Sample based compositor.
Mon, Jan 15, 2:19 PM · BF Blender: 2.8, Compositing
Jeroen Bakker (jbakker) added a revision to T53790: Design Doc: Sample based compositor: D3003: PoC: Sample based compositor.
Mon, Jan 15, 2:19 PM · Compositing, BF Blender
Jeroen Bakker (jbakker) changed Type from Bug to Design on T53790: Design Doc: Sample based compositor.
Mon, Jan 15, 2:19 PM · Compositing, BF Blender
Jeroen Bakker (jbakker) created T53790: Design Doc: Sample based compositor.
Mon, Jan 15, 2:18 PM · Compositing, BF Blender
Jeroen Bakker (jbakker) added a reviewer for D3003: PoC: Sample based compositor: Compositing.
Mon, Jan 15, 2:03 PM · BF Blender: 2.8, Compositing
Jeroen Bakker (jbakker) created D3003: PoC: Sample based compositor.
Mon, Jan 15, 2:01 PM · BF Blender: 2.8, Compositing

Wed, Jan 10

Campbell Barton (campbellbarton) closed T53747: Inpaint doesn't work with transparent pixels as Invalid.

Currently the alpha needs to be 1.0 to inpaint,
We could add a threshold option, but this isn't a bug.

Wed, Jan 10, 4:25 AM · Compositing, BF Blender
Serge Lyatin (SergeL) created T53747: Inpaint doesn't work with transparent pixels.
Wed, Jan 10, 12:15 AM · Compositing, BF Blender

Tue, Jan 9

Sergey Sharybin (sergey) requested changes to D2984: Add Cubic B-Spline with Prefilter Algorithm.

While this might be handy to have, the implementation goes against compositor design:

Tue, Jan 9, 10:38 AM · Compositing, BF Blender
Troy Sobotka (sobotka) added a comment to D2984: Add Cubic B-Spline with Prefilter Algorithm.

If you can't tell the difference, it may not be working correctly. Should be as clearly apparent as in https://youtu.be/nfhTET86kdE

Tue, Jan 9, 7:18 AM · Compositing, BF Blender
Campbell Barton (campbellbarton) added a comment to D2984: Add Cubic B-Spline with Prefilter Algorithm.

Not really happy with how this patch requires a copy of the image (goes against compositor design).

Tue, Jan 9, 6:47 AM · Compositing, BF Blender
Campbell Barton (campbellbarton) updated the diff for D2984: Add Cubic B-Spline with Prefilter Algorithm.
  • Cleanup
Tue, Jan 9, 6:44 AM · Compositing, BF Blender
Campbell Barton (campbellbarton) updated the diff for D2984: Add Cubic B-Spline with Prefilter Algorithm.
  • Update so this now compiles
Tue, Jan 9, 6:21 AM · Compositing, BF Blender

Sat, Jan 6

Brecht Van Lommel (brecht) closed D2981: Fix Luma Matte Node not allowing displaying display referred values.
Sat, Jan 6, 4:44 PM · Compositing, BF Blender
Brecht Van Lommel (brecht) closed D2982: Fix T47212: Use proper coefficients for Luminance Matte Node.
Sat, Jan 6, 4:44 PM · Compositing, BF Blender

Tue, Jan 2

Aaron Carlisle (Blendify) planned changes to D2984: Add Cubic B-Spline with Prefilter Algorithm.
Tue, Jan 2, 5:24 PM · Compositing, BF Blender

Mon, Jan 1

Aaron Carlisle (Blendify) updated the diff for D2984: Add Cubic B-Spline with Prefilter Algorithm.

Update with arc

Mon, Jan 1, 11:19 PM · Compositing, BF Blender
Aaron Carlisle (Blendify) created D2984: Add Cubic B-Spline with Prefilter Algorithm.
Mon, Jan 1, 10:39 PM · Compositing, BF Blender
Fable Fox (fablefox) closed T53591: Composite node result is different from Viewer and File Output (Plane Track Deform) as Invalid.

Close as requested.

Mon, Jan 1, 1:09 PM · Compositing, Motion Tracking, BF Blender
Brecht Van Lommel (brecht) accepted D2981: Fix Luma Matte Node not allowing displaying display referred values.
Mon, Jan 1, 3:19 AM · Compositing, BF Blender
Brecht Van Lommel (brecht) accepted D2982: Fix T47212: Use proper coefficients for Luminance Matte Node.

The node is called Luminance Key and its purpose is similar to other keying nodes: creating a matte.

Mon, Jan 1, 3:16 AM · Compositing, BF Blender
Brecht Van Lommel (brecht) updated the diff for D2982: Fix T47212: Use proper coefficients for Luminance Matte Node.

Update to fix discarding of alpha, also fixes incorrect comment.

Mon, Jan 1, 3:16 AM · Compositing, BF Blender
Aaron Carlisle (Blendify) updated the diff for D2982: Fix T47212: Use proper coefficients for Luminance Matte Node.

Correct tab size

Mon, Jan 1, 12:23 AM · Compositing, BF Blender
Aaron Carlisle (Blendify) updated the diff for D2981: Fix Luma Matte Node not allowing displaying display referred values.

Remove calls to RNA_def_property_range

Mon, Jan 1, 12:14 AM · Compositing, BF Blender
Aaron Carlisle (Blendify) updated the summary of D2982: Fix T47212: Use proper coefficients for Luminance Matte Node.
Mon, Jan 1, 12:09 AM · Compositing, BF Blender

Sun, Dec 31

Aaron Carlisle (Blendify) added a comment to D2982: Fix T47212: Use proper coefficients for Luminance Matte Node.

@Brecht Van Lommel (brecht) I am a little confused by this because that is not what this node is designed for.
It is not a keying node but a matte node used to remove high or low contrast pieces of an image.
Also, the fact that it might look different should not matter. All this patch is fixing something that
was missed in rBdd38dce7f0ae604396d1e96bc49500369fdedf29

Sun, Dec 31, 10:41 PM · Compositing, BF Blender
Troy Sobotka (sobotka) added a comment to D2982: Fix T47212: Use proper coefficients for Luminance Matte Node.

How about we just close this and rename the node to "Doesn't do what the node label is supposed to do" node?

Sun, Dec 31, 8:46 PM · Compositing, BF Blender
Brecht Van Lommel (brecht) added a comment to D2982: Fix T47212: Use proper coefficients for Luminance Matte Node.

The question from @Sergey Sharybin (sergey) in T47212 was to verify if this node still works equally well on actual green screen footage, like the one from Tears of Steel. Did you try that?

Sun, Dec 31, 1:57 PM · Compositing, BF Blender
Brecht Van Lommel (brecht) added a comment to D2981: Fix Luma Matte Node not allowing displaying display referred values.

Looks fine to me, but remove the calls to RNA_def_property_range since they are just setting the default again.

Sun, Dec 31, 1:54 PM · Compositing, BF Blender
Aaron Carlisle (Blendify) updated the summary of D2982: Fix T47212: Use proper coefficients for Luminance Matte Node.
Sun, Dec 31, 3:19 AM · Compositing, BF Blender
Aaron Carlisle (Blendify) added reviewers for D2982: Fix T47212: Use proper coefficients for Luminance Matte Node: Brecht Van Lommel (brecht), Lukas Stockner (lukasstockner97).
Sun, Dec 31, 1:48 AM · Compositing, BF Blender
Aaron Carlisle (Blendify) created D2982: Fix T47212: Use proper coefficients for Luminance Matte Node.
Sun, Dec 31, 1:47 AM · Compositing, BF Blender

Sat, Dec 30

Aaron Carlisle (Blendify) updated the diff for D2981: Fix Luma Matte Node not allowing displaying display referred values.

Fix wrong max ui max value

Sat, Dec 30, 11:21 PM · Compositing, BF Blender
Aaron Carlisle (Blendify) updated the summary of D2981: Fix Luma Matte Node not allowing displaying display referred values.
Sat, Dec 30, 11:19 PM · Compositing, BF Blender
Aaron Carlisle (Blendify) created D2981: Fix Luma Matte Node not allowing displaying display referred values.
Sat, Dec 30, 11:19 PM · Compositing, BF Blender

Tue, Dec 26

Phillip Thomas (philliptee) added a watcher for Compositing: Phillip Thomas (philliptee).
Tue, Dec 26, 3:32 PM

Dec 20 2017

Serge Lyatin (SergeL) added a comment to T53591: Composite node result is different from Viewer and File Output (Plane Track Deform).

Well, on the fresh head, it seems that I want impossible thing. I should rather render scene in 20% and then Composite it with 100% resolution, or stick with File Output. So close it down.

Dec 20 2017, 11:02 AM · Compositing, Motion Tracking, BF Blender
Sergey Sharybin (sergey) triaged T53591: Composite node result is different from Viewer and File Output (Plane Track Deform) as Incomplete priority.

I don't see difference between viewer node and file output. Only difference is between render result and file output, but that's because using lower resolution for final render acts like a "canvas" thing. It does not scale anything up or down. For that you can use Scale node est to "Render Size" mode.

Dec 20 2017, 10:44 AM · Compositing, Motion Tracking, BF Blender

Dec 19 2017

Serge Lyatin (SergeL) created T53591: Composite node result is different from Viewer and File Output (Plane Track Deform).
Dec 19 2017, 5:41 PM · Compositing, Motion Tracking, BF Blender

Dec 7 2017

Sybren A. Stüvel (sybren) resigned from D2945: Issue T53321 resolved.
Dec 7 2017, 3:56 PM · Compositing, BF Blender

Dec 6 2017

Sergey Sharybin (sergey) requested changes to D2945: Issue T53321 resolved.

What i'm afraid here is that applying this fix will break files created after the buggy commit was done before this fix is applied. Probably some do-versions is required.

Dec 6 2017, 2:36 PM · Compositing, BF Blender
José Luis Oliveira Cunha (JoseCunha) added a task to D2945: Issue T53321 resolved: T53321: "Z" changed to "depth" breaks consistency in compositing and in Render layers.
Dec 6 2017, 1:46 PM · Compositing, BF Blender
José Luis Oliveira Cunha (JoseCunha) created D2945: Issue T53321 resolved.
Dec 6 2017, 1:26 PM · Compositing, BF Blender