Partial fix T60148: EEVEE hangs when anamorphic bokeh is too low

Fixed by setting the limit to the original limit I used for Cycles.
Rendering still goes extremely slow when bokeh is lower than 1.0.

But at least now it is "waitable". With lower numbers than 0.01 I don't
think we would ever get a render to finish.

@fclem feel free to address the real root of the problem, but I'm afraid
it may be a limitation of the algorithm you are using.
This commit is contained in:
Dalai Felinto 2019-01-04 11:15:23 -02:00
parent 32ae3abbab
commit 1753177ad8
Notes: blender-bot 2023-02-14 08:33:26 +01:00
Referenced by issue #60148, 2.8 crashes when changing aperture ratio to 0
2 changed files with 8 additions and 1 deletions

View File

@ -2741,5 +2741,12 @@ void blo_do_versions_280(FileData *fd, Library *UNUSED(lib), Main *bmain)
}
}
}
/* Fix anamorphic bokeh eevee rna limits.*/
for (Camera *ca = bmain->camera.first; ca; ca = ca->id.next) {
if (ca->gpu_dof.ratio < 0.01f) {
ca->gpu_dof.ratio = 0.01f;
}
}
}
}

View File

@ -4112,7 +4112,7 @@ static void rna_def_gpu_dof_fx(BlenderRNA *brna)
prop = RNA_def_property(srna, "ratio", PROP_FLOAT, PROP_NONE);
RNA_def_property_ui_text(prop, "Ratio", "Distortion to simulate anamorphic lens bokeh");
RNA_def_property_float_default(prop, 1.0f);
RNA_def_property_range(prop, 0.0000001f, FLT_MAX);
RNA_def_property_range(prop, 0.01f, FLT_MAX);
RNA_def_property_ui_range(prop, 1.0f, 2.0f, 0.1, 3);
RNA_def_property_update(prop, NC_SPACE | ND_SPACE_VIEW3D, NULL);
}