blender
/
blender
129
398
Fork 572
Code Issues 6.2k Pull Requests 749 Projects 19 Wiki Activity

Fix T50003, Bevel makes non-manifold mesh. 

Problem was setting prev/next faces for edges around
a vertex on valence-2 vertices.
This commit is contained in:
Howard Trickey 2016-12-06 07:43:47 -05:00
parent 8ce6de3bdd
commit 1de79c8960
Notes: blender-bot 2023-02-14 07:25:44 +01:00 
Referenced by issue #50003, Bevel ngons result in non-manifold mesh
1 changed files with 14 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
source/blender/bmesh/tools/bmesh_bevel.c
View File

@ -3557,7 +3557,7 @@ static void find_bevel_edge_order(BMesh *bm, BevVert *bv, BMEdge *first_bme)
{
BMEdge *bme, *bme2;
BMIter iter;
BMFace *f;
BMFace *f, *bestf;
EdgeHalf *e;
EdgeHalf *e2;
BMLoop *l;
@ -3595,10 +3595,21 @@ static void find_bevel_edge_order(BMesh *bm, BevVert *bv, BMEdge *first_bme)
bme = e->e;
bme2 = e2->e;
BLI_assert(bme != NULL);
if (e->fnext != NULL || e2->fprev != NULL)
continue;
/* Which faces have successive loops that are for bme and bme2?
* There could be more than one. E.g., in manifold ntot==2 case.
* Prefer one that has loop in same direction as e. */
bestf = NULL;
BM_ITER_ELEM(l, &iter, bme, BM_LOOPS_OF_EDGE) {
f = l->f;
if ((l->prev->e == bme2 || l->next->e == bme2) && !e->fnext && !e2->fprev)
e->fnext = e2->fprev = f;
if ((l->prev->e == bme2 || l->next->e == bme2)) {
if (!bestf || l->v == bv->v)
bestf = f;
}
if (bestf) {
e->fnext = e2->fprev = bestf;
}
}
}
}