blender
/
blender
129
397
Fork 571
Code Issues 6.2k Pull Requests 754 Projects 19 Wiki Activity

Fix memory leak with Python RNA property get callback errors 

Failure to return a list of the expected size & type wasn't
decrementing the value, leaking a reference.

Caused by 127b5423d6 a workaround for the
real error that was fixed f5e020a7a6.
This commit is contained in:
Campbell Barton 2021-07-28 01:07:14 +10:00 committed by Jeroen Bakker
parent 66c65da688
commit 1f96166e08
Notes: blender-bot 2023-02-14 07:39:46 +01:00 
Referenced by issue #77348, Blender LTS: Maintenance Task 2.83
1 changed files with 3 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
source/blender/python/intern/bpy_props.c
View File

@ -494,12 +494,8 @@ static void bpy_prop_boolean_array_get_cb(struct PointerRNA *ptr,
for (i = 0; i < len; i++) {
values[i] = false;
}
/* PyC_AsArray decrements refcount internally on error */
}
else {
Py_DECREF(ret);
}
Py_DECREF(ret);
}
if (use_gil) {
@ -738,12 +734,8 @@ static void bpy_prop_int_array_get_cb(struct PointerRNA *ptr,
for (i = 0; i < len; i++) {
values[i] = 0;
}
/* PyC_AsArray decrements refcount internally on error */
}
else {
Py_DECREF(ret);
}
Py_DECREF(ret);
}
if (use_gil) {
@ -982,12 +974,8 @@ static void bpy_prop_float_array_get_cb(struct PointerRNA *ptr,
for (i = 0; i < len; i++) {
values[i] = 0.0f;
}
/* PyC_AsArray decrements refcount internally on error */
}
else {
Py_DECREF(ret);
}
Py_DECREF(ret);
}
if (use_gil) {