blender
/
blender
129
397
Fork 571
Code Issues 6.2k Pull Requests 752 Projects 19 Wiki Activity

EEVEE: Fix ill defined blend in cubemap array workaround 

This fixes some firefly issues on corners of the cubemaps where the
blending factors would go above 1 or below 0.
This commit is contained in:
Clément Foucault 2022-10-21 13:11:31 +02:00
parent 4bfb99e4d8
commit 26f181c6b7
Notes: blender-bot 2023-02-14 09:29:42 +01:00 
Referenced by issue #102018, Cycles HIP issues on Debian
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
source/blender/draw/engines/eevee/shaders/cubemap_lib.glsl
View File

@ -96,7 +96,7 @@ vec4 cubemap_seamless(sampler2DArray tex, vec4 cubevec, float lod)
/* Mix all colors to get the corner color. */
vec4 col3 = (col + col1 + col2) / 3.0;
vec2 mix_fac = uv_border * 0.5;
vec2 mix_fac = saturate(uv_border * 0.5);
return mix(mix(col, col2, mix_fac.x), mix(col1, col3, mix_fac.x), mix_fac.y);
}
else if (any(border)) {
@ -108,7 +108,7 @@ vec4 cubemap_seamless(sampler2DArray tex, vec4 cubevec, float lod)
uv = cubemap_face_coord(cubevec.xyz, face);
coord = vec3(uv, cubevec.w * 6.0 + face);
float mix_fac = max(uv_border.x, uv_border.y) * 0.5;
float mix_fac = saturate(max(uv_border.x, uv_border.y) * 0.5);
return mix(col, textureLod(tex, coord, lod), mix_fac);
}
else {