blender
/
blender
126
393
Fork 565
Code Issues 6.2k Pull Requests 750 Projects 19 Wiki Activity

Fix T48668, bevel mistake on presumed reflex angle. 

Note: the angle in bug isn't really reflex - using the vertex normal
for this test isn't always right, but usually is. At any rate,
shouldn't try to put vertex on edge between if a reflex angle.
This commit is contained in:
Howard Trickey 2017-05-23 07:55:14 -04:00
parent 72d67ba4c2
commit 49cc78ef18
Notes: blender-bot 2023-02-14 10:18:56 +01:00 
Referenced by issue #48668, Bevel fails in this case
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
source/blender/bmesh/tools/bmesh_bevel.c
View File

@ -916,8 +916,12 @@ static bool offset_meet_edge(EdgeHalf *e1, EdgeHalf *e2, BMVert *v, float meetc
return false;
}
cross_v3_v3v3(fno, dir1, dir2);
if (dot_v3v3(fno, v->no) < 0.0f)
if (dot_v3v3(fno, v->no) < 0.0f) {
ang = 2.0f * (float)M_PI - ang; /* angle is reflex */
if (r_angle)
*r_angle = ang;
return false;
}
if (r_angle)
*r_angle = ang;