blender
/
blender
129
397
Fork 571
Code Issues 6.2k Pull Requests 750 Projects 19 Wiki Activity

Alembic: replaced BLI_assert() with comment why the assert is wrong 

The comment also hints at what should be fixed, instead.
This commit is contained in:
Sybren A. Stüvel 2018-06-08 15:49:33 +02:00
parent 249a41bc7c
commit 4df45e18dc
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
source/blender/alembic/intern/abc_util.cc
View File

@ -181,11 +181,11 @@ void copy_m44_axis_swap(float dst_mat[4][4], float src_mat[4][4], AbcAxisSwapMod
unit_m3(dst_rot);
unit_m4(dst_scale_mat);
/* We assume there is no sheer component and no homogeneous scaling component. */
BLI_assert(fabs(src_mat[0][3]) < 2 * FLT_EPSILON);
BLI_assert(fabs(src_mat[1][3]) < 2 * FLT_EPSILON);
BLI_assert(fabs(src_mat[2][3]) < 2 * FLT_EPSILON);
BLI_assert(fabs(src_mat[3][3] - 1.0f) < 2 * FLT_EPSILON);
/* TODO(Sybren): This code assumes there is no sheer component and no
* homogeneous scaling component, which is not always true when writing
* non-hierarchical (e.g. flat) objects (e.g. when parent has non-uniform
* scale and the child rotates). This is currently not taken into account
* when axis-swapping. */
/* Extract translation, rotation, and scale form matrix. */
mat4_to_loc_rot_size(src_trans, src_rot, src_scale, src_mat);