blender
/
blender
128
396
Fork 569
Code Issues 6.2k Pull Requests 757 Projects 19 Wiki Activity

Fix T75827, boolean of non-manifold objects leaves stray edges. 

Well, this only fixes the example if one uses the new Exact mode,
but since that is available, seems fair to call this fixed.
Since these were not closed-volume operands, the Exact mode needed
some adjustment to the threshold used for "inside-outside" tests
for the case of deciding if the cutter is inside the other shape
for a Difference.
This commit is contained in:
Howard Trickey 2020-09-05 16:01:39 -04:00
parent 8c4f7e6d04
commit 5faf72bb71
Notes: blender-bot 2023-02-14 08:21:44 +01:00 
Referenced by issue #75827, Boolean operation generates additional edges
Referenced by issue #47030, BMesh booleans (track todo's)
1 changed files with 19 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
source/blender/blenlib/intern/mesh_boolean.cc
View File

@ -2358,18 +2358,26 @@ static double generalized_winding_number(const IMesh &tm,
/**
* Return true if point \a testp is inside the volume implied by the
* faces for which the shape_fn returns the value shape.
* If \a high_confidence is true then we want a higher degree
* of "insideness" than if it is false.
*/
static bool point_is_inside_shape(const IMesh &tm,
std::function<int(int)> shape_fn,
const double3 &testp,
int shape)
int shape,
bool high_confidence)
{
double gwn = generalized_winding_number(tm, shape_fn, testp, shape);
/* Due to floating point error, an outside point should get a value
* of zero for gwn, but may have a very slightly positive value instead.
* It is not important to get this epsilon very small, because practical
* cases of interest will have gwn at least 0.2 if it is not zero. */
return (gwn > 0.01);
if (high_confidence) {
return (gwn > 0.9);
}
else {
return (gwn > 0.01);
}
}
/**
@ -2415,7 +2423,15 @@ static IMesh gwn_boolean(const IMesh &tm,
std::cout << "test point = " << test_point_db << "\n";
}
int other_shape = 1 - shape;
bool inside = point_is_inside_shape(tm, shape_fn, test_point_db, other_shape);
/* The point_is_inside_shape function has to approximate if the other
* shape is not PWN. For most operations, even a hint of being inside
* givs good results, but when shape is the cutter in a Difference
* operation, we want to be pretty sure that the point is inside other_shape.
* E.g., T75827.
*/
bool need_high_confidence = (op == BoolOpType::Difference) && (shape == 1);
bool inside = point_is_inside_shape(
tm, shape_fn, test_point_db, other_shape, need_high_confidence);
if (dbg_level > 0) {
std::cout << "test point is " << (inside ? "inside\n" : "outside\n");
}