blender
/
blender
129
397
Fork 572
Code Issues 6.2k Pull Requests 749 Projects 19 Wiki Activity

Cycles: Fixes for Burley BSSRDF 

There are several fixes in here, which hopefully will make the shader
working correct without too much magic in there.

First of all, this commit brings BURLEY_TRUNCATE down from 30 to 16
which reduces noise a lot. It's still higher than original truncate
from Brecht, but this reduces PDF value at a cutoff distance by an
order of magnitude (now it's 0.008387, previously it was 0.063521
for the albedo of 0.8 and radius 1.0). This should converge to a
proper result faster and don't have artifacts.

This kind of reverts fix for T47356, but after additional thinking
came to conclusion Burley is not being totally smooth, it is about
giving less waxy results which it's kind of doing in the file.

Second of all, this commit fixes burley_eval() to use normalized
diffusion reflectance. This matches the way we calculate CDF and
solves numeric instability close to 0, making PDF profile looking
closer to other SSS profiles:

  https://developer.blender.org/F282355
  https://developer.blender.org/F282356
  https://developer.blender.org/F282357

Reviewers: brecht

Reviewed By: brecht

Differential Revision: https://developer.blender.org/D1792
This commit is contained in:
Sergey Sharybin 2016-02-12 11:42:33 +01:00
parent 83dc288689
commit 69dc0c3192
Notes: blender-bot 2023-02-14 08:14:49 +01:00 
Referenced by issue #47356, Possible errors introduced in the new SSS implementation (in the days after it was committed)
1 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
intern/cycles/kernel/closure/bssrdf.h
View File

@ -181,8 +181,8 @@ ccl_device void bssrdf_cubic_sample(ShaderClosure *sc, float xi, float *r, float
* the mean free length, but still not too big so sampling is still
* effective. Might need some further tweaks.
*/
#define BURLEY_TRUNCATE 30.0f
#define BURLEY_TRUNCATE_CDF 0.999966f // cdf(BURLEY_TRUNCATE)
#define BURLEY_TRUNCATE 16.0f
#define BURLEY_TRUNCATE_CDF 0.9963790093708328f // cdf(BURLEY_TRUNCATE)
ccl_device_inline float bssrdf_burley_fitting(float A)
{
@ -195,7 +195,7 @@ ccl_device_inline float bssrdf_burley_fitting(float A)
*/
ccl_device_inline float bssrdf_burley_compatible_mfp(float r)
{
return 0.5f * M_1_PI_F * r;
return 0.25f * M_1_PI_F * r;
}
ccl_device void bssrdf_burley_setup(ShaderClosure *sc)
@ -215,20 +215,20 @@ ccl_device float bssrdf_burley_eval(ShaderClosure *sc, float r)
const float d = sc->custom1;
const float Rm = BURLEY_TRUNCATE * d;
if (r >= Rm)
if(r >= Rm)
return 0.0f;
/* Clamp to avoid precision issues computing expf(-x)/x */
r = fmaxf(r, 1e-2f * d);
/* Burley refletance profile, equation (3).
*
* Note that surface albedo is already included into sc->weight, no need to
* multiply by this term here.
* NOTES:
* - Surface albedo is already included into sc->weight, no need to
* multiply by this term here.
* - This is normalized diffuse model, so the equation is mutliplied
* by 2*pi, which also matches cdf().
*/
float exp_r_3_d = expf(-r / (3.0f * d));
float exp_r_d = exp_r_3_d * exp_r_3_d * exp_r_3_d;
return (exp_r_d + exp_r_3_d) / (8*M_PI_F*d*r);
return (exp_r_d + exp_r_3_d) / (4.0f*d);
}
ccl_device float bssrdf_burley_pdf(ShaderClosure *sc, float r)