blender
/
blender
128
396
Fork 568
Code Issues 6.2k Pull Requests 749 Projects 19 Wiki Activity

Fix T76730 DRW: Sorting of empty shading groups. 

This is to fix an assert in EEVEE caused by a transparent shading group
that is create but not populated by any drawcall.
This commit is contained in:
Clément Foucault 2020-05-18 16:59:04 +02:00
parent cb8d8335b2
commit 6eb00fb02e
Notes: blender-bot 2023-02-14 05:51:15 +01:00 
Referenced by issue #76730, Eevee assert in shader group sorting when opening file
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
source/blender/draw/intern/draw_manager_data.c
View File

@ -2000,7 +2000,10 @@ void DRW_pass_sort_shgroup_z(DRWPass *pass)
}
}
/* To be sorted a shgroup needs to have at least one draw command. */
BLI_assert(handle != 0);
/* FIXME(fclem) In some case, we can still have empty shading group to sort. However their
* final order is not well defined.
* (see T76730 & D7729). */
// BLI_assert(handle != 0);
DRWObjectMatrix *obmats = DRW_memblock_elem_from_handle(DST.vmempool->obmats, &handle);