blender
/
blender
129
397
Fork 571
Code Issues 6.2k Pull Requests 754 Projects 19 Wiki Activity

makesdna/makesrna: silence output by default 

No need to print status for basic & reliable operations,
build systems can output operations they run if needed,
or debug output changed in the source if developers are debugging.

Nice for ninja, so any printed text hints at a problem to fix.
This commit is contained in:
Campbell Barton 2017-11-28 20:27:40 +11:00
parent 2bf3825711
commit 7c64e33b01
Notes: blender-bot 2023-02-14 06:22:01 +01:00 
Referenced by issue #53683, 2.79a release
Referenced by issue #53410, Playback slow with large static Text Object
2 changed files with 17 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
source/blender/makesdna/intern/makesdna.c
View File

@ -978,7 +978,7 @@ static int make_structDNA(const char *baseDirectory, FILE *file, FILE *file_offs
char str[SDNA_MAX_FILENAME_LENGTH], *cp;
int firststruct;
if (debugSDNA > -1) {
if (debugSDNA > 0) {
fflush(stdout);
printf("Running makesdna at debug level %d\n", debugSDNA);
}
@ -1074,7 +1074,7 @@ static int make_structDNA(const char *baseDirectory, FILE *file, FILE *file_offs
/* file writing */
if (debugSDNA > -1) printf("Writing file ... ");
if (debugSDNA > 0) printf("Writing file ... ");
if (nr_names == 0 || nr_structs == 0) {
/* pass */
@ -1184,7 +1184,7 @@ static int make_structDNA(const char *baseDirectory, FILE *file, FILE *file_offs
MEM_freeN(typelens_64);
MEM_freeN(structs);
if (debugSDNA > -1) printf("done.\n");
if (debugSDNA > 0) printf("done.\n");
return(0);
}

16
source/blender/makesrna/intern/makesrna.c
View File

@ -46,6 +46,14 @@
# endif
#endif
/**
* Variable to control debug output of makesrna.
* debugSRNA:
* - 0 = no output, except errors
* - 1 = detail actions
*/
static int debugSRNA = 0;
/* stub for BLI_abort() */
#ifndef NDEBUG
void BLI_system_backtrace(FILE *fp)
@ -62,7 +70,9 @@ void BLI_system_backtrace(FILE *fp)
static int file_older(const char *file1, const char *file2)
{
struct stat st1, st2;
/* printf("compare: %s %s\n", file1, file2); */
if (debugSRNA > 0) {
printf("compare: %s %s\n", file1, file2);
}
if (stat(file1, &st1)) return 0;
if (stat(file2, &st2)) return 0;
@ -4134,7 +4144,9 @@ int main(int argc, char **argv)
return_status = 1;
}
else {
fprintf(stderr, "Running makesrna\n");
if (debugSRNA > 0) {
fprintf(stderr, "Running makesrna\n");
}
makesrna_path = argv[0];
return_status = rna_preprocess(argv[1]);
}