Fix T82960: Inaccurate selection on collapsed outliner rows

After rB15083d9e1 the outliner tree is not rebuilt after expanding or
collapsing rows. Because the tree is no longer rebuilt the positions
and flags of the elements are not cleared when collapsing a row. This
caused hover highlights and selections on the collapsed child icons to
be incorrect in many cases.

For example, only the direct children of a collapsed element are drawn
inline. If any grandchild elements had been previously icon row flagged
they would continue to be evaluated as icon row elements despite being
hidden. In this case the x coordinates of the child and grandchild would
overlap causing selection to appear erratic.

Now the flags for inline row icons are explicitly cleared, which was
previously only done because the tree was rebuilt on collapsing rows.
This commit is contained in:
Nathan Craddock 2020-12-17 16:28:24 -07:00
parent 7cbcfb7f49
commit 7d25139eaf
Notes: blender-bot 2023-02-13 20:27:16 +01:00
Referenced by issue #83216, Potential candidates for corrective releases
Referenced by issue #82960, Outliner: Selection on collapsed row is inaccurate
1 changed files with 1 additions and 0 deletions

View File

@ -2845,6 +2845,7 @@ static void outliner_draw_iconrow(bContext *C,
LISTBASE_FOREACH (TreeElement *, te, lb) {
TreeStoreElem *tselem = TREESTORE(te);
te->flag &= ~(TE_ICONROW | TE_ICONROW_MERGED);
/* object hierarchy always, further constrained on level */
if (level < 1 || (tselem->type == 0 && te->idcode == ID_OB)) {