blender
/
blender
128
396
Fork 568
Code Issues 6.2k Pull Requests 749 Projects 19 Wiki Activity

Fix T72402: Decimate f-curves fails with co-linear key-frames

This commit is contained in:
Campbell Barton 2019-12-24 12:20:34 +11:00
parent b450ba84d9
commit af2be110c3
Notes: blender-bot 2023-02-14 00:20:15 +01:00 
Referenced by issue #72402, Decimate f-curves breaks curves in multiple segments.
1 changed files with 15 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
extern/curve_fit_nd/intern/curve_fit_cubic.c vendored
View File

@ -611,13 +611,26 @@ static void cubic_from_points_offset_fallback(
}
}
/* The value of 'dists[..] / 0.75' is the length to use when the tangents
* are perpendicular to the direction defined by the two points.
*
* Project tangents onto these perpendicular lengths.
* Note that this can cause divide by zero in the case of co-linear tangents.
* The limits check afterwards accounts for this.
*
* The 'dists[..] + dir_dirs' limit is just a rough approximation.
* While a more exact value could be calculated,
* in this case the error values approach divide by zero (inf)
* so there is no need to be too precise when checking if limits have been exceeded. */
double alpha_l = (dists[0] / 0.75) / fabs(dot_vnvn(tan_l, a[0], dims));
double alpha_r = (dists[1] / 0.75) / fabs(dot_vnvn(tan_r, a[1], dims));
if (!(alpha_l > 0.0)) {
if (!(alpha_l > 0.0) || (alpha_l > dists[0] + dir_dist)) {
alpha_l = dir_dist / 3.0;
}
if (!(alpha_r > 0.0)) {
if (!(alpha_r > 0.0) || (alpha_r > dists[1] + dir_dist)) {
alpha_r = dir_dist / 3.0;
}