blender
/
blender
129
398
Fork 572
Code Issues 6.2k Pull Requests 748 Projects 19 Wiki Activity

Fix/workaround some types of black dots in denoising with bright speculars. 

This is not a real solution and colored dots still remain, just rejecting some
pixels that seem clearly wrong.
This commit is contained in:
Brecht Van Lommel 2019-03-22 14:05:18 +01:00
parent 0b98b7ed57
commit b0c40de5ee
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
intern/cycles/kernel/filter/filter_reconstruction.h
View File

@ -95,14 +95,16 @@ ccl_device_inline void kernel_filter_finalize(int x, int y,
}
/* The weighted average of pixel colors (essentially, the NLM-filtered image).
* In case the solution of the linear model fails due to numerical issues,
* fall back to this value. */
* In case the solution of the linear model fails due to numerical issues or
* returns non-sensical negative values, fall back to this value. */
float3 mean_color = XtWY[0]/XtWX[0];
math_trimatrix_vec3_solve(XtWX, XtWY, (*rank)+1, stride);
float3 final_color = XtWY[0];
if(!isfinite3_safe(final_color)) {
if(!isfinite3_safe(final_color) ||
(final_color.x < -0.01f || final_color.y < -0.01f || final_color.z < -0.01f))
{
final_color = mean_color;
}