blender
/
blender
128
396
Fork 568
Code Issues 6.2k Pull Requests 753 Projects 19 Wiki Activity

Fix T75062: Frame Flashes During 3D Viewport Animation Playback 

This issue became visible after fixing other TAA issues recently.
The sample count of the first frame wasn't reset resulting that the
incorrect resolve took place. This issue was already there beforehand,
it is just much clearer during the recent changes.

Now the `taa_sample will be reset when performing an animation playback
in the 3d viewport.
This commit is contained in:
Jeroen Bakker 2020-03-26 08:18:07 +01:00
parent bae9553848
commit b2f04fce2d
Notes: blender-bot 2023-02-13 23:04:50 +01:00 
Referenced by issue #75062, When Playback animation in Workbench the first frame flashes
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
source/blender/draw/engines/workbench/workbench_effect_antialiasing.c
View File

@ -168,9 +168,9 @@ void workbench_antialiasing_engine_init(WORKBENCH_Data *vedata)
wpd->view = NULL;
/* reset complete drawing when navigating. */
/* reset complete drawing when navigating or during viewport playback. */
if (wpd->taa_sample != 0) {
if (wpd->is_navigating) {
if (wpd->is_navigating || wpd->is_playback) {
wpd->taa_sample = 0;
}
}
@ -424,7 +424,6 @@ void workbench_antialiasing_draw_pass(WORKBENCH_Data *vedata)
const bool last_sample = wpd->taa_sample + 1 == wpd->taa_sample_len;
const bool taa_finished = wpd->taa_sample >= wpd->taa_sample_len;
if (wpd->taa_sample == 0) {
/* In playback mode, we are sure the next redraw will not use the same viewmatrix.
* In this case no need to save the depth buffer. */