blender
/
blender
128
396
Fork 568
Code Issues 6.2k Pull Requests 753 Projects 19 Wiki Activity

Math Lib: avoid temp array for rotate_m4 

No need to have temp array storage, avoid 2x loops.
This commit is contained in:
Campbell Barton 2016-11-25 21:00:32 +11:00
parent e1e49fd1a8
commit bcd0d8584f
Notes: blender-bot 2023-02-14 07:23:27 +01:00 
Referenced by issue #50116, Light threshold broke branched path tracer
1 changed files with 14 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
source/blender/blenlib/intern/math_matrix.c
View File

@ -1634,39 +1634,33 @@ void translate_m4(float mat[4][4], float Tx, float Ty, float Tz)
*/
void rotate_m4(float mat[4][4], const char axis, const float angle)
{
int col;
float temp[4] = {0.0f, 0.0f, 0.0f, 0.0f};
float cosine, sine;
const float angle_cos = cosf(angle);
const float angle_sin = sinf(angle);
assert(axis >= 'X' && axis <= 'Z');
cosine = cosf(angle);
sine = sinf(angle);
switch (axis) {
case 'X':
for (col = 0; col < 4; col++)
temp[col] = cosine * mat[1][col] + sine * mat[2][col];
for (col = 0; col < 4; col++) {
mat[2][col] = -sine * mat[1][col] + cosine * mat[2][col];
mat[1][col] = temp[col];
for (int col = 0; col < 4; col++) {
float temp = angle_cos * mat[1][col] + angle_sin * mat[2][col];
mat[2][col] = -angle_sin * mat[1][col] + angle_cos * mat[2][col];
mat[1][col] = temp;
}
break;
case 'Y':
for (col = 0; col < 4; col++)
temp[col] = cosine * mat[0][col] - sine * mat[2][col];
for (col = 0; col < 4; col++) {
mat[2][col] = sine * mat[0][col] + cosine * mat[2][col];
mat[0][col] = temp[col];
for (int col = 0; col < 4; col++) {
float temp = angle_cos * mat[0][col] - angle_sin * mat[2][col];
mat[2][col] = angle_sin * mat[0][col] + angle_cos * mat[2][col];
mat[0][col] = temp;
}
break;
case 'Z':
for (col = 0; col < 4; col++)
temp[col] = cosine * mat[0][col] + sine * mat[1][col];
for (col = 0; col < 4; col++) {
mat[1][col] = -sine * mat[0][col] + cosine * mat[1][col];
mat[0][col] = temp[col];
for (int col = 0; col < 4; col++) {
float temp = angle_cos * mat[0][col] + angle_sin * mat[1][col];
mat[1][col] = -angle_sin * mat[0][col] + angle_cos * mat[1][col];
mat[0][col] = temp;
}
break;
}