blender
/
blender
129
398
Fork 572
Code Issues 6.2k Pull Requests 745 Projects 19 Wiki Activity

Fix T60408: Loose edge distort vertex on a surface 

Treat those vertices as infinitely sharp. This matches the way
how OpenSubdiv's topology is being created.
This commit is contained in:
Sergey Sharybin 2019-01-24 12:05:32 +01:00
parent b3ba97ccce
commit c4be1f861b
Notes: blender-bot 2023-02-14 05:43:04 +01:00 
Referenced by issue #60408, Extruded vertex from subdivion surface shows edge incorrectly in viewport
1 changed files with 12 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
source/blender/blenkernel/intern/subdiv_mesh.c
View File

@ -1034,6 +1034,7 @@ static void find_edge_neighbors(const SubdivMeshContext *ctx,
const MEdge *coarse_medge = coarse_mesh->medge;
neighbors[0] = NULL;
neighbors[1] = NULL;
int neighbor_counters[2] = {0, 0};
for (int edge_index = 0; edge_index < coarse_mesh->totedge; edge_index++) {
const MEdge *current_edge = &coarse_medge[edge_index];
if (current_edge == edge) {
@ -1041,11 +1042,22 @@ static void find_edge_neighbors(const SubdivMeshContext *ctx,
}
if (ELEM(edge->v1, current_edge->v1, current_edge->v2)) {
neighbors[0] = current_edge;
++neighbor_counters[0];
}
if (ELEM(edge->v2, current_edge->v1, current_edge->v2)) {
neighbors[1] = current_edge;
++neighbor_counters[1];
}
}
/* Vertices which has more than one neighbor are considered infinitely
* sharp. This is also how topology factory treats vertices of a surface
* which are adjacent to a loose edge. */
if (neighbor_counters[0] > 1) {
neighbors[0] = NULL;
}
if (neighbor_counters[1] > 1) {
neighbors[1] = NULL;
}
}
static void points_for_loose_edges_interpolation_get(
@ -1144,7 +1156,6 @@ static void subdiv_mesh_vertex_of_loose_edge(
/* Perform interpolation. */
float weights[4];
key_curve_position_weights(u, weights, KEY_BSPLINE);
/* Interpolate custom data. */
subdiv_mesh_vertex_of_loose_edge_interpolate(
ctx, coarse_edge, u, subdiv_vertex_index);