blender
/
blender
129
397
Fork 571
Code Issues 6.2k Pull Requests 748 Projects 19 Wiki Activity

Pose Mode: pass object to mode enter/exit 

Also add lower level mode exit function
This commit is contained in:
Campbell Barton 2018-04-11 09:20:29 +02:00
parent 32339a56f1
commit c963488b5e
Notes: blender-bot 2023-12-08 16:39:08 +01:00 
Referenced by issue #54568, More than 100Mb of memory allocation per click-selection
4 changed files with 30 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
source/blender/editors/armature/pose_edit.c
View File

@ -81,9 +81,8 @@ Object *ED_pose_object_from_context(bContext *C)
}
/* This function is used to process the necessary updates for */
bool ED_object_posemode_enter_ex(Base *base)
bool ED_object_posemode_enter_ex(Object *ob)
{
Object *ob = base->object;
BLI_assert(!ID_IS_LINKED(ob));
bool ok = false;
@ -100,30 +99,37 @@ bool ED_object_posemode_enter_ex(Base *base)
return ok;
}
bool ED_object_posemode_enter(bContext *C, Base *base)
bool ED_object_posemode_enter(bContext *C, Object *ob)
{
ReportList *reports = CTX_wm_reports(C);
if (ID_IS_LINKED(base->object)) {
if (ID_IS_LINKED(ob)) {
BKE_report(reports, RPT_WARNING, "Cannot pose libdata");
return false;
}
bool ok = ED_object_posemode_enter_ex(base);
bool ok = ED_object_posemode_enter_ex(ob);
if (ok) {
WM_event_add_notifier(C, NC_SCENE | ND_MODE | NS_MODE_POSE, NULL);
}
return ok;
}
void ED_object_posemode_exit(bContext *C, Base *base)
bool ED_object_posemode_exit_ex(Object *ob)
{
if (base) {
Object *ob = base->object;
bool ok = false;
if (ob) {
ob->restore_mode = ob->mode;
ob->mode &= ~OB_MODE_POSE;
ok = true;
}
return ok;
}
bool ED_object_posemode_exit(bContext *C, Object *ob)
{
bool ok = ED_object_posemode_exit_ex(ob);
if (ok) {
WM_event_add_notifier(C, NC_SCENE | ND_MODE | NS_MODE_OBJECT, NULL);
}
return ok;
}
/* if a selected or active bone is protected, throw error (oonly if warn == 1) and return 1 */

7
source/blender/editors/include/ED_armature.h
View File

@ -195,9 +195,10 @@ void ED_armature_ebone_listbase_free(struct ListBase *lb);
void ED_armature_ebone_listbase_copy(struct ListBase *lb_dst, struct ListBase *lb_src);
/* poseobject.c */
void ED_object_posemode_exit(struct bContext *C, struct Base *base);
bool ED_object_posemode_enter_ex(struct Base *base);
bool ED_object_posemode_enter(struct bContext *C, struct Base *base);
bool ED_object_posemode_exit_ex(struct Object *ob);
bool ED_object_posemode_exit(struct bContext *C, struct Object *ob);
bool ED_object_posemode_enter_ex(struct Object *ob);
bool ED_object_posemode_enter(struct bContext *C, struct Object *ob);
void ED_pose_de_selectall(struct Object *ob, int select_mode, const bool ignore_visibility);
void ED_pose_bone_select(struct Object *ob, struct bPoseChannel *pchan, bool select);
void ED_pose_recalculate_paths(struct Scene *scene, struct Object *ob);

4
source/blender/editors/object/object_edit.c
View File

@ -718,10 +718,10 @@ static int posemode_exec(bContext *C, wmOperator *op)
}
if (is_mode_set) {
ED_object_posemode_exit(C, base);
ED_object_posemode_exit(C, ob);
}
else {
ED_object_posemode_enter(C, base);
ED_object_posemode_enter(C, ob);
}
return OPERATOR_FINISHED;

13
source/blender/editors/space_outliner/outliner_select.c
View File

@ -714,13 +714,16 @@ static eOLDrawState tree_element_active_pose(
}
if (set != OL_SETSEL_NONE) {
if (scene->obedit)
if (scene->obedit) {
ED_object_editmode_exit(C, EM_FREEDATA | EM_WAITCURSOR | EM_DO_UNDO);
}
if (ob->mode & OB_MODE_POSE)
ED_object_posemode_exit(C, base);
else
ED_object_posemode_enter(C, base);
if (ob->mode & OB_MODE_POSE) {
ED_object_posemode_exit(C, ob);
}
else {
ED_object_posemode_enter(C, ob);
}
}
else {
if (ob->mode & OB_MODE_POSE) {