blender
/
blender
129
398
Fork 572
Code Issues 6.2k Pull Requests 746 Projects 19 Wiki Activity

Fix T59446: Grease pencil mirror modifier wrong 

The mirror was working different to mesh mirror and the result was not the expected.
This commit is contained in:
Antonio Vazquez 2018-12-16 19:53:40 +01:00
parent fbed69866e
commit ea33b90a1b
Notes: blender-bot 2023-02-14 05:52:32 +01:00 
Referenced by issue #59472, Bezier curve object broken
Referenced by issue #59446, Grease pencil mirror modifier with empty not mirroring over empty object
Referenced by issue #58652, blender 2.8 - hard crash - editing shape keys weirdness with instances
1 changed files with 14 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
source/blender/gpencil_modifiers/intern/MOD_gpencilmirror.c
View File

@ -83,26 +83,28 @@ static void update_position(Object *ob, MirrorGpencilModifierData *mmd, bGPDstro
float clear[3] = { 0.0f, 0.0f, 0.0f };
clear[axis] = 1.0f;
float origin[3];
float ob_origin[3];
float mirror_origin[3];
float pt_origin[3];
copy_v3_v3(origin, ob->loc);
copy_v3_v3(ob_origin, ob->loc);
/* only works with current axis */
mul_v3_v3(origin, clear);
mul_v3_v3(ob_origin, clear);
zero_v3(mirror_origin);
if (mmd->object) {
copy_v3_v3(mirror_origin, mmd->object->loc);
mul_v3_v3(mirror_origin, clear);
sub_v3_v3(origin, mirror_origin);
}
/* clear other axis */
for (i = 0, pt = gps->points; i < gps->totpoints; i++, pt++) {
add_v3_v3(&pt->x, origin);
mul_v3_v3(&pt->x, factor);
add_v3_v3(&pt->x, mirror_origin);
mul_v3_v3v3(mirror_origin, mmd->object->loc, clear);
}
/* clear other axis */
for (i = 0, pt = gps->points; i < gps->totpoints; i++, pt++) {
mul_v3_v3(&pt->x, factor);
if (mmd->object) {
sub_v3_v3v3(pt_origin, ob_origin, mirror_origin);
mul_v3_fl(pt_origin, -2.0f);
add_v3_v3(&pt->x, pt_origin);
}
}
}
/* Generic "generateStrokes" callback */