Page MenuHome

CompositingProject
ActivePublic

Details

Recent Activity

Yesterday

Pratik Borhade (PratikPB2123) added projects to D10995: Fix T84815 : Missing preview image in compositing file output node: VFX & Video, Compositing.
Sat, Apr 17, 5:55 AM · Compositing, VFX & Video
Pratik Borhade (PratikPB2123) added a revision to T84815: Missing preview image in compositing file output node: D10995: Fix T84815 : Missing preview image in compositing file output node.
Sat, Apr 17, 5:55 AM · Good First Issue, VFX & Video, Compositing, BF Blender

Fri, Apr 16

Dean Jones (DeanKingsley) claimed T84815: Missing preview image in compositing file output node.

Hi, just submitted a possible fix T84815 : Missing preview image. I would be interested to know if I could have submitted the diff in a better way.

Fri, Apr 16, 5:04 PM · Good First Issue, VFX & Video, Compositing, BF Blender
Eric Klein (eklein) added a watcher for Compositing: Eric Klein (eklein).
Fri, Apr 16, 3:26 AM

Thu, Apr 15

Manuel Castilla (manzanilla) added a comment to D10861: Compositor: Merge SingleThreadedOperation with WriteBufferOperation..

Can we initializeTileData of all input operations in SingleThreadedOperation::executeRegion and pass a span of input buffers to update_memory_buffer?
Later on the concept of initializeTileData won't exist and buffers may be managed by a BufferManager.
To know the rect initializeTileData should render, SingleThreadOperation may have a virtual method "getInputAreaOfInterest(input_index, output_rect)", if not overriden it returns the output rect by default.
determineDependingAreaOfInterest method may be removed, so operations should override this new one when needed.

Thu, Apr 15, 5:20 PM · Compositing

Wed, Apr 14

Manuel Castilla (manzanilla) updated the diff for D10971: Fix compositor: opencl device queue deleted after creation.
  • Better implement custom move contructor
Wed, Apr 14, 4:00 PM · BF Blender (2.93), Compositing
Sergey Sharybin (sergey) requested changes to D10904: Compositor: Scheduling.
Wed, Apr 14, 11:01 AM · Compositing
Manuel Castilla (manzanilla) updated the diff for D10971: Fix compositor: opencl device queue deleted after creation.
  • Use explicit type
  • Add OpenCLDevice move contructor
Wed, Apr 14, 10:17 AM · BF Blender (2.93), Compositing
Jeroen Bakker (jbakker) added projects to D10971: Fix compositor: opencl device queue deleted after creation: Compositing, BF Blender (2.93).
Wed, Apr 14, 8:23 AM · BF Blender (2.93), Compositing

Tue, Apr 13

Manuel Castilla (manzanilla) accepted D10904: Compositor: Scheduling.

Looks good to me. I've tested both modes and haven't found any issue. Thanks to this patch it should be easy to know when all readers of an execution group have finished and free its buffer.

Tue, Apr 13, 9:19 PM · Compositing
Jeroen Bakker (jbakker) placed T81809: Compositor sometimes fails to composite (Image Editor involved) up for grabs.
Tue, Apr 13, 3:04 PM · EEVEE & Viewport, Compositing, BF Blender
Jeroen Bakker (jbakker) reopened T81809: Compositor sometimes fails to composite (Image Editor involved) as "Confirmed".

Opening it. But not able to reproduce.

Tue, Apr 13, 3:04 PM · EEVEE & Viewport, Compositing, BF Blender
Marcin Twarowski (Tvaroog) added a comment to T81809: Compositor sometimes fails to composite (Image Editor involved).

I just tested with 2.93.0 Alpha, branch: master, commit date: 2021-04-13 07:49, hash: rB30ee57be60b7 and the problem was still there.

Tue, Apr 13, 2:48 PM · EEVEE & Viewport, Compositing, BF Blender
Jeroen Bakker (jbakker) updated the diff for D10904: Compositor: Scheduling.
  • Merge branch 'master' into temp-compositor-scheduling
  • Compostior: Test for break to stop compositing.
  • Tweaked InputToOutput scheduling.
Tue, Apr 13, 10:49 AM · Compositing
Jeroen Bakker (jbakker) closed T81809: Compositor sometimes fails to composite (Image Editor involved) as Resolved.

This issue has been fixed. I assume some of the tweaks in the threading solved this issue.

Tue, Apr 13, 8:14 AM · EEVEE & Viewport, Compositing, BF Blender

Mon, Apr 12

Jeroen Bakker (jbakker) closed T87292: "File Output" node does not saves anything as Resolved.

Issue was related to T87252

Mon, Apr 12, 3:36 PM · Compositing, VFX & Video, BF Blender
Jeroen Bakker (jbakker) closed T50840: No motionblur on cornerpin node as Archived.

This is a feature request according the rules of the bug tracker.
For feature request please use the appropriate channels.

Mon, Apr 12, 3:31 PM · VFX & Video, Compositing, BF Blender
Joao Morgado (MrJomo) added a comment to T74491: Compositor improvement plan.

Looks like some work might be happening on the compositor (exciting!). I started collecting some ideas in a DevTalk thread a while ago, but unfortunately got busy and mostly abandoned it. It might be worth checking it out again.

Mon, Apr 12, 3:30 PM · VFX & Video, Compositing
Jeroen Bakker (jbakker) moved T74491: Compositor improvement plan from Backlog to Designs on the Compositing board.
Mon, Apr 12, 3:20 PM · VFX & Video, Compositing
Jeroen Bakker (jbakker) closed T74680: Incorrect mixing in Glare node as Resolved by committing rB95e010a22eb4: Fix T74680: Incorrect mixing in Glare node.
Mon, Apr 12, 2:42 PM · VFX & Video, Compositing, BF Blender
Jeroen Bakker (jbakker) closed D7138: Fix T74680: Incorrect mixing in Glare node.
Mon, Apr 12, 2:42 PM · Compositing
Jeroen Bakker (jbakker) closed T77023: blender either crashes immediately after rendering when using multiple denoise and file output nodes, or the output of random denoise nodes saved with the file output node are pure black. as Archived.

There is already a mutex guarding multiple calls to OIDN so there is no parallel execution going on. The compositor memory efficiency can be improved and is part of a T81650: New compositor system proposal
I wasn't able to reproduce the pink output or crash.

Mon, Apr 12, 2:29 PM · VFX & Video, Compositing, BF Blender
Jeroen Bakker (jbakker) moved T80562: Relative space from Backlog to Designs on the Compositing board.
Mon, Apr 12, 1:50 PM · VFX & Video, Compositing
Jeroen Bakker (jbakker) moved T87292: "File Output" node does not saves anything from Backlog to In Progress on the Compositing board.
Mon, Apr 12, 1:48 PM · Compositing, VFX & Video, BF Blender
Jeroen Bakker (jbakker) added a comment to T85717: Using viewernode as an image texture causes shader or compositor to fail intermittently.

@Philipp Oeser (lichtwerk) yes this is currently not supported and should be hidden.

Mon, Apr 12, 1:48 PM · Render & Cycles, VFX & Video, Rendering, Compositing, BF Blender
Jeroen Bakker (jbakker) merged T85717: Using viewernode as an image texture causes shader or compositor to fail intermittently into T73182: Exclude 'Render Result' and 'Viewer' image types in the dropdown in certain contexts [Shader Editor, Compositor, UV Editor...].
Mon, Apr 12, 1:47 PM · Nodes, Compositing, BF Blender
Jeroen Bakker (jbakker) merged task T85717: Using viewernode as an image texture causes shader or compositor to fail intermittently into T73182: Exclude 'Render Result' and 'Viewer' image types in the dropdown in certain contexts [Shader Editor, Compositor, UV Editor...].
Mon, Apr 12, 1:47 PM · Render & Cycles, VFX & Video, Rendering, Compositing, BF Blender
Jeroen Bakker (jbakker) moved T49944: Compositor - ID Mask Anti Aliasing not working from Backlog to Easy Tasks on the Compositing board.
Mon, Apr 12, 1:45 PM · Good First Issue, VFX & Video, Compositing, BF Blender
Jeroen Bakker (jbakker) added a project to T49944: Compositor - ID Mask Anti Aliasing not working: Good First Issue.

We currently have the AA node. From workflow point of view masks can be added and AA afterwards.
For more complex setups use Cryptomatte.

Mon, Apr 12, 1:43 PM · Good First Issue, VFX & Video, Compositing, BF Blender
Jeroen Bakker (jbakker) moved T81650: New compositor system proposal from Backlog to Designs on the Compositing board.
Mon, Apr 12, 1:31 PM · VFX & Video, Compositing
Jeroen Bakker (jbakker) moved T84815: Missing preview image in compositing file output node from Backlog to Easy Tasks on the Compositing board.
Mon, Apr 12, 1:30 PM · Good First Issue, VFX & Video, Compositing, BF Blender
Jeroen Bakker (jbakker) moved T87035: Replace `#ifdef COM_Debug` with constexpr function. from Backlog to Easy Tasks on the Compositing board.
Mon, Apr 12, 1:30 PM · Good First Issue, Compositing
Jeroen Bakker (jbakker) added a comment to T84815: Missing preview image in compositing file output node.

Hmm a bit of a one off issue.

Mon, Apr 12, 1:21 PM · Good First Issue, VFX & Video, Compositing, BF Blender
Jeroen Bakker (jbakker) closed T87252: 2.93 file output node broken with more than 4 inputs as Resolved by committing rB75642b4cfd65: Fix T87252: File output node broken with more than 4 inputs..
Mon, Apr 12, 10:14 AM · VFX & Video, Compositing, BF Blender
Philipp Oeser (lichtwerk) merged T87383: For some reasons file output node does not save file, when i want save cryptomattes at level 6 with object, material, asset check into T87252: 2.93 file output node broken with more than 4 inputs.
Mon, Apr 12, 9:43 AM · VFX & Video, Compositing, BF Blender

Fri, Apr 9

Jeroen Bakker (jbakker) added a comment to T87292: "File Output" node does not saves anything.

Ah I switched to EEVEE as I was working on a debug build. But somehow there are 5 input socket and the compositor connects them to 9 source.
Next week will look at all the exceptions that have been added for the file output node and see what is failing and what works.

Fri, Apr 9, 4:47 PM · Compositing, VFX & Video, BF Blender
Philipp Oeser (lichtwerk) added a comment to T87292: "File Output" node does not saves anything.

Seems to be unrelated. The issue is that the first connected socket determines the resolution of the output file. As this socket is not connected to anything it just doesn't save the image. Not sure why the mentioned commit is the cause, it seems to be always the case.

Fri, Apr 9, 4:33 PM · Compositing, VFX & Video, BF Blender
Jeroen Bakker (jbakker) added a revision to T87252: 2.93 file output node broken with more than 4 inputs: D10930: [WIP] Fix for T87252.
Fri, Apr 9, 4:32 PM · VFX & Video, Compositing, BF Blender
Jeroen Bakker (jbakker) added a revision to T87292: "File Output" node does not saves anything: D10930: [WIP] Fix for T87252.
Fri, Apr 9, 4:32 PM · Compositing, VFX & Video, BF Blender
Jeroen Bakker (jbakker) added tasks to D10930: [WIP] Fix for T87252: T87292: "File Output" node does not saves anything, T87252: 2.93 file output node broken with more than 4 inputs.
Fri, Apr 9, 4:31 PM · Compositing
Jeroen Bakker (jbakker) retitled D10930: [WIP] Fix for T87252 from Compositor: Output where debug is stored. to [WIP] Fix for T87252.
Fri, Apr 9, 4:26 PM · Compositing
Jeroen Bakker (jbakker) reopened T87292: "File Output" node does not saves anything as "Confirmed".

Seems to be unrelated. The issue is that the first connected socket determines the resolution of the output file. As this socket is not connected to anything it just doesn't save the image. Not sure why the mentioned commit is the cause, it seems to be always the case.

Fri, Apr 9, 4:18 PM · Compositing, VFX & Video, BF Blender
Jeroen Bakker (jbakker) closed D10846: Compositor: Enable suggest-override warning..
Fri, Apr 9, 12:18 PM · Compositing

Thu, Apr 8

Philipp Oeser (lichtwerk) merged T87292: "File Output" node does not saves anything into T87252: 2.93 file output node broken with more than 4 inputs.
Thu, Apr 8, 6:05 PM · VFX & Video, Compositing, BF Blender
Philipp Oeser (lichtwerk) merged task T87292: "File Output" node does not saves anything into T87252: 2.93 file output node broken with more than 4 inputs.
Thu, Apr 8, 6:05 PM · Compositing, VFX & Video, BF Blender
Philipp Oeser (lichtwerk) added a comment to T87292: "File Output" node does not saves anything.

Assume this is the same as T87252, will merge these reports.

Thu, Apr 8, 6:05 PM · Compositing, VFX & Video, BF Blender
Philipp Oeser (lichtwerk) merged T87307: Compositing, File output writes no files if it has more than 4 Inputs into T87252: 2.93 file output node broken with more than 4 inputs.
Thu, Apr 8, 6:04 PM · VFX & Video, Compositing, BF Blender
Philipp Oeser (lichtwerk) renamed T87252: 2.93 file output node broken with more than 4 inputs from 2.93 file output node broken with more than 4 outputs to 2.93 file output node broken with more than 4 inputs.
Thu, Apr 8, 6:04 PM · VFX & Video, Compositing, BF Blender
Philipp Oeser (lichtwerk) renamed T87252: 2.93 file output node broken with more than 4 inputs from 2.93 file output node broken (with additional Inputs?) to 2.93 file output node broken with more than 4 outputs.
Thu, Apr 8, 6:03 PM · VFX & Video, Compositing, BF Blender
Jeroen Bakker (jbakker) added a comment to T86271: Blender crashing when working in Compositor - for example deleting Cryptomatte nodes.

That is fine. The fix was to not delete the matte Id after loading a file. And always update the Id

Thu, Apr 8, 5:09 PM · VFX & Video, Compositing, BF Blender