Mask editing and use for compositing.
Thu, Feb 9
Sorry, I've been away and haven't had time to update this. I'm attaching a file demonstrating the problem.
Report has not been reacted on for 7 days, closing due to bug tracker policy.
Thu, Feb 2
Thanks for the report, please provide a blend file for testing.
Dec 9 2016
Dec 2 2016
Can confirm the issue, 'Add Square' and then select a mask point, and the id_type of points' parents remains to 0.
Nov 22 2016
Before creating another bug of this kind, here is another:
Sorry, I didn't know that the file wasn't ever uploaded. Here it is: 101-mask-keyframes.blend
Nov 18 2016
This file is created from scratch in 2.78a.
This file is somewhat corrupted: mask parent's ID type is supposed to always be ID_MC (ID type of MovieClip), but in this file the type is simply 0 (which is not a valid ID type even).
Could you check with latest master (i.e. buildbot builds)? IIRC, sergey committed a fix for this sometime in the past few weeks-month.
Nov 17 2016
Aug 11 2016
Cannot confirm this, would bet you somehow disabled Global Undo in UserPreferences, Editing settings…
Aug 2 2016
I can't really reproduce the issue. Please test if latest builds from builder.blender.org still have it and if they do please attach .blend file which demonstrates the issue.
Jul 28 2016
Awesome bug :)
Jul 26 2016
May 23 2016
One week without response.
May 16 2016
Most likely same issue as in T48422, please tray again with latest testbuild, should be fixed.
May 15 2016
Nov 23 2015
One problem remains though: Currently(in master) you are able to adjust the newly created handles manually by keeping your mouse button pressed and moving your cursor. With this patch this cannot be done anymore because it calculates the handles for you.
Nov 13 2015
Version without knife(only improved calculation): mask_ctrl_click.diff
- Replace every t
Nov 10 2015
- Only use improved handle calculation when both neighbors are doubleside-aligned/free
- Fix parenting bug
- conventions: use u instead of t
- cleanup split function
Nov 8 2015
@Marcelo Mutzbauer (1xundoredo), seems reasonable
@Campbell Barton (campbellbarton) What about only using the improved calculation in case both neighbors already are doubleside aligned/free and falling back to old behavior otherwise? If both neighbors are free it could then make the newly inserted point free, although that would not be necessary to achieve the same shape.
Nov 4 2015
- Add accidentally removed line back in
- Clean up mask_spline_split_spline_point
- Check against FLT_EPSILON when preparing for the next recursive call
Parenting turned out to be even more 'problematic'. If both neighbors have the same parent at the same frame, there shouldn't be any problems.(Technically it has to be the initial position where the spline points has been parented, which is the case on the same frame)
If they don't - it just assumes parenting the newly created point is not possible(though parenting the same point track on different frames should be). If that is the case(whether it is because of different track points or because of different frames), it currently places the new point in respect to its neighbors' positions after the parenting(without being parented itself). This is done on every keyframe.
@Marcelo Mutzbauer (1xundoredo): Would you be able to split this patch?
Nov 3 2015
- Yet another parenting fix
- Fix some parenting bugs
@Sean Kennedy (hype) Thank you for the report. Mask points are parented individually. The solution I found was to check whether both neighbor points have the same parent. If they do, the new point is also going to be parented to the same track/plane. If they don't the new point won't be parented at all. Does that look like a good solution?
- Fix stupid #if 1 instead of #if 0 which disabled the better adjustment of ctrl+lmb handles(Can still be removed easily btw, just as I did in the last update ;))
- Change name of select_neighbors to select neighbor_handles
- Get rid of uneccessary assignment of w